gym 1.6.3 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 378f10d0a08b2c15f6363308f7283df7df4ecfe3
-  data.tar.gz: 3e8786dbc86d23826a378d00d73b24e868ab7fc0
+  metadata.gz: 3cb5dfb0c034f1f176aa33c251efe825fc565588
+  data.tar.gz: ad83beb96bae35108114fba5b82ceef5beb20582
 SHA512:
-  metadata.gz: 0fd65c7716687b32d54762e17b9a920d1ba271dd788308584a5a9b2b263e7398654fd50e94e1963f4256525dd3a45205f7faadb0ca9219e227a6138e46d99008
-  data.tar.gz: 4cd197f9fb6535496c5b6e287cb5739615c45112467a211f5d538b3ab8d9ac51b8177ec8b964bafcb84078674ca7a9bf513e7c591af5c542b159f298a90e0fc0
+  metadata.gz: 7b2ef7b42f1ac411b048ab1d31a31fdc224aa81d286bb19dab22c2775815863089010b02d52cc6d602f77de69aa95be1e5147b6a72ab57eb4f6bd60ccbc74549
+  data.tar.gz: 8e9661c7de9d06cbfd85a752085ea01b31df8cad059d51de6b48bee97f5a466e726be94e1812821d032caf1b83f83f2d04ac31a09da6c0d4773e5e2d5c4b969e

data/README.md

@@ -180,7 +180,12 @@ export_options(
 
 For the list of available options run `xcodebuild -help`.
 
-# Automating the whole process
+## Setup code signing
+
+- [More information on how to get started with codesigning](/fastlane/docs/Codesigning)
+- [Docs on how to set up your Xcode project](/fastlane/docs/Codesigning/XcodeProject.md)
+
+## Automating the whole process
 
 `gym` works great together with [fastlane](https://fastlane.tools), which connects all deployment tools into one streamlined workflow.
 

data/lib/assets/GymfileTemplate

@@ -1,5 +1,5 @@
 # For more information about this configuration visit
-# https://github.com/fastlane/gym#gymfile
+# https://github.com/fastlane/fastlane/tree/master/gym#gymfile
 
 # In general, you can use the options available
 # gym --help

data/lib/assets/package_application_patches/PackageApplication_MD5

@@ -1 +1,2 @@
-a434316d561ce5c4392a8447b58c18e7
+a434316d561ce5c4392a8447b58c18e7
+75c29555834c603566a2319c5e4d2838

data/lib/assets/wrap_xcodebuild/xcbuild-safe.sh

@@ -41,6 +41,14 @@ if [[ $? -eq 0 ]]; then
   unset BUNDLE_GEMFILE
 fi
 
+if which rbenv > /dev/null; then
+  echo "rbenv detected, removing env variables"
+  unset RUBYLIB
+  unset RUBYOPT
+  unset GEM_HOME
+  unset GEM_PATH
+fi
+
 # to help troubleshooting
 # env | sort > /tmp/env.wrapper
 # rvm info >> /tmp/env.wrapper

data/lib/gym.rb

@@ -11,6 +11,7 @@ require 'gym/xcode'
 
 require 'fastlane_core'
 require 'terminal-table'
+require 'shellwords'
 
 module Gym
   class << self

data/lib/gym/error_handler.rb

@@ -88,7 +88,7 @@ module Gym
           standard_output = read_standard_output output
           print standard_output if standard_output
           print "There was an error exporting your application"
-          print "Unfortunately the new Xcode export API is unstable and causes problems on some project"
+          print "Unfortunately the new Xcode export API is unstable and causes problems on some projects"
           print "You can temporary use the :use_legacy_build_api option to get the build to work again"
         end
         UI.user_error!("Error packaging up the application")

data/lib/gym/generators/build_command_generator.rb

@@ -57,7 +57,7 @@ module Gym
 
       def suffix
         suffix = []
-        suffix << "CODE_SIGN_IDENTITY='#{Gym.config[:codesigning_identity]}'" if Gym.config[:codesigning_identity]
+        suffix << "CODE_SIGN_IDENTITY=#{Gym.config[:codesigning_identity].shellescape}" if Gym.config[:codesigning_identity]
         suffix
       end
 

data/lib/gym/generators/package_command_generator_legacy.rb

@@ -11,7 +11,9 @@ module Gym
   class PackageCommandGeneratorLegacy
     class << self
       def generate
-        parts = ["/usr/bin/xcrun #{XcodebuildFixes.patch_package_application} -v"]
+        print_legacy_information
+
+        parts = ["/usr/bin/xcrun #{XcodebuildFixes.patch_package_application.shellescape} -v"]
         parts += options
         parts += pipe
 
@@ -30,7 +32,7 @@ module Gym
         end
 
         if Gym.config[:codesigning_identity]
-          options << "--sign '#{Gym.config[:codesigning_identity]}'"
+          options << "--sign #{Gym.config[:codesigning_identity].shellescape}"
         end
 
         options
@@ -77,6 +79,24 @@ module Gym
       def apps_path
         ""
       end
+
+      def print_legacy_information
+        if Gym.config[:include_bitcode]
+          UI.important "Legacy build api is enabled, the `include_bitcode` value will be ignored"
+        end
+
+        if Gym.config[:include_symbols]
+          UI.important "Legacy build api is enabled, the `include_symbols` value will be ignored"
+        end
+
+        if Gym.config[:export_team_id].to_s.length > 0
+          UI.important "Legacy build api is enabled, the `export_team_id` value will be ignored"
+        end
+
+        if Gym.config[:export_method].to_s.length > 0
+          UI.important "Legacy build api is enabled, the `export_method` value will be ignored"
+        end
+      end
     end
   end
 end

data/lib/gym/generators/package_command_generator_xcode7.rb

@@ -10,9 +10,9 @@ module Gym
   class PackageCommandGeneratorXcode7
     class << self
       def generate
-        print_legacy_information unless Helper.fastlane_enabled?
+        print_legacy_information
 
-        parts = ["/usr/bin/xcrun #{XcodebuildFixes.wrap_xcodebuild} -exportArchive"]
+        parts = ["/usr/bin/xcrun #{XcodebuildFixes.wrap_xcodebuild.shellescape} -exportArchive"]
         parts += options
         parts += pipe
 
@@ -161,10 +161,10 @@ module Gym
       end
 
       def print_legacy_information
-        if Gym.config[:provisioning_profile_path]
-          UI.important "You're using Xcode 7, the `provisioning_profile_path` value will be ignored"
-          UI.important "Please follow the Code Signing Guide: https://github.com/fastlane/fastlane/blob/master/fastlane/docs/CodeSigning.md"
-        end
+        return if Gym.config[:provisioning_profile_path].to_s.length == 0
+
+        UI.error "You're using Xcode 7, the `provisioning_profile_path` value will be ignored"
+        UI.error "Please follow the Code Signing Guide: https://codesigning.guide (for match) or https://github.com/fastlane/fastlane/blob/master/fastlane/docs/CodeSigning.md"
       end
     end
   end

data/lib/gym/options.rb

@@ -163,8 +163,9 @@ module Gym
                                      env_name: "GYM_PROVISIONING_PROFILE_PATH",
                                      description: "The path to the provisioning profile (optional)",
                                      optional: true,
+                                     deprecated: 'Use target specific provisioning profiles instead',
                                      verify_block: proc do |value|
-                                       UI.user_error!("Provisioning profile not found at path '#{File.expand_path(value)}'") unless File.exist?(value)
+                                       UI.user_error!("Provisioning profile not found at path '#{File.expand_path(value)}'") unless File.exist?(File.expand_path(value))
                                      end),
         FastlaneCore::ConfigItem.new(key: :destination,
                                      short_option: "-d",
@@ -194,8 +195,7 @@ module Gym
                                      env_name: "SUPPRESS_OUTPUT",
                                      description: "Suppress the output of xcodebuild to stdout. Output is still saved in buildlog_path",
                                      optional: true,
-                                     is_string: false
-                                    )
+                                     is_string: false)
       ]
     end
   end

data/lib/gym/version.rb

@@ -1,4 +1,4 @@
 module Gym
-  VERSION = "1.6.3"
+  VERSION = "1.7.0"
   DESCRIPTION = "Building your iOS apps has never been easier"
 end

data/lib/gym/xcodebuild_fixes/package_application_fix.rb

@@ -11,16 +11,16 @@ module Gym
         return @patched_package_application_path if File.exist?(@patched_package_application_path)
 
         Dir.mktmpdir do |tmpdir|
-          # Check current PackageApplication MD5
+          # Check current set of PackageApplication MD5 hashes
           require 'digest'
 
           path = File.join(Helper.gem_path("gym"), "lib/assets/package_application_patches/PackageApplication_MD5")
-          expected_md5 = File.read(path)
+          expected_md5_hashes = File.read(path).split("\n")
 
           # If that location changes, search it using xcrun --sdk iphoneos -f PackageApplication
           package_application_path = "#{Xcode.xcode_path}/Platforms/iPhoneOS.platform/Developer/usr/bin/PackageApplication"
 
-          UI.crash!("Unable to patch the `PackageApplication` script bundled in Xcode. This is not supported.") unless expected_md5 == Digest::MD5.file(package_application_path).hexdigest
+          UI.crash!("Unable to patch the `PackageApplication` script bundled in Xcode. This is not supported.") unless expected_md5_hashes.include?(Digest::MD5.file(package_application_path).hexdigest)
 
           # Duplicate PackageApplication script to PackageApplication4Gym
           FileUtils.copy_file(package_application_path, @patched_package_application_path)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gym
 version: !ruby/object:Gem::Version
-  version: 1.6.3
+  version: 1.7.0
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-07 00:00:00.000000000 Z
+date: 2016-07-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fastlane_core
@@ -16,7 +16,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.43.1
+        version: 0.43.3
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.43.1
+        version: 0.43.3
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -284,7 +284,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.0
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Building your iOS apps has never been easier