gyft 0.0.4 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8e6eeace4f248958e53b36ea5adcff736fbdedc8
-  data.tar.gz: dc6b3b16b6c9b3cc78c6c9c6958ead8a44178aa7
+  metadata.gz: 1cacc42d597e9d65aaef5cb8fc4b4a1b1bd4d257
+  data.tar.gz: 7d0bfd2bb5bcedcfb091c556eb17d9da29ac0d09
 SHA512:
-  metadata.gz: 543e7cf9d0e3cb507861c3ec4190767c26f0df1a0858448334e7de46fff2dfe3c5579a03ef3cffed148fd453b5c03e5d9ebfc680dfe19db2e80d740ae6dde5ac
-  data.tar.gz: 8111036baa68ba2a81b4420d57a7b2e912490fe4ed79259f516702cfb39801b3e6c5ce950fba7430ac4601354d5c9c67093b1e1c93ef903ece18383af950d670
+  metadata.gz: 2b05032d9ff5336b23772d406e72fb42270acca69212b69398adee074233ce401afe59cf74c9f8b4e4dffe328b9aea0e6b47e17284b289f1b597a53a5fa0c927
+  data.tar.gz: 6922c59dcdeb5780b396937b7b9c37d45746adb7dd575009f92d73abce0f4a63c942df2b913efb4a83e94ccda5245602239bc35dd19f9c6db606c35f9c12a822

data/gyft.gemspec

@@ -15,5 +15,4 @@ Gem::Specification.new do |s|
   s.add_development_dependency('rake')
   s.add_development_dependency('webmock')
   s.add_development_dependency('minitest')
-  s.add_development_dependency('awesome_print')
 end

data/lib/gyft/client.rb

@@ -5,31 +5,31 @@ require 'json'
 module Gyft
   class Client
     class ServerError < StandardError; end
+    class NotFoundError < StandardError; end
+    class BadRequestError < StandardError; end
 
     ENDPOINTS = {
       'production' => 'api.gyft.com',
       'sandbox' => 'apitest.gyft.com'
     }
 
-    attr_accessor :api_key, :api_secret, :environment, :http
+    attr_accessor :api_key, :api_secret, :environment, :http, :reseller
 
     def initialize(options = {})
       @api_key = options.fetch(:api_key) do
-        ENV['GYFT_RESELLER_API_KEY'] ||
-        ArgumentError.new("Missing required argument: api_key")
+        ENV['GYFT_API_KEY'] || raise(KeyError, "Missing required argument: api_key")
       end
 
       @api_secret = options.fetch(:api_secret) do
-        ENV['GYFT_RESELLER_API_SECRET'] ||
-        ArgumentError.new("Missing required argument: api_secret")
+        ENV['GYFT_API_SECRET'] || raise(KeyError, "Missing required argument: api_secret")
       end
 
       @environment = begin
         environment = options.fetch(:environment) do
-          ENV['GYFT_RESELLER_API_ENVIRONMENT'] || 'sandbox'
+          ENV['GYFT_API_ENVIRONMENT'] || 'sandbox'
         end
         unless %w{production sandbox}.include?(environment)
-          raise ArgumentError.new("Invalid argument: environment should be one of 'production' or 'sandbox'")
+          raise(KeyError, "Invalid argument: environment should be one of 'production' or 'sandbox'")
         end
         environment
       end
@@ -47,7 +47,7 @@ module Gyft
     end
 
     def reseller
-      Gyft::Client::Reseller.new(self)
+      @reseller ||= Gyft::Client::Reseller.new(self)
     end
 
     def partner
@@ -94,6 +94,10 @@ module Gyft
       case response
       when Net::HTTPSuccess
         json?(response) ? JSON.parse(response.body) : response.body
+      when Net::HTTPNotFound
+        raise NotFoundError, "Record not found (404)"
+      when Net::HTTPBadRequest
+        raise BadRequestError, "Bad request (400)"
       else
         if json?(response)
           raise ServerError, "HTTP #{response.code}: #{JSON.parse(response.body)}"

data/lib/gyft/client/reseller.rb

@@ -22,14 +22,21 @@ class Gyft::Client::Reseller
     @client.get('/reseller/merchants')['details'].map do |merchant|
       merchant[:client] = @client
       merchant = Gyft::Merchant.new(merchant)
-      merchant.shop_cards = merchant.shop_cards.map do |card|
-        card[:client] = @client
-        Gyft::Card.new(card)
+
+      if merchant.shop_cards
+        merchant.shop_cards = merchant.shop_cards.map do |card|
+          card[:client] = @client
+          Gyft::Card.new(card)
+        end
       end
-      merchant.categories = merchant.categories.map do |category|
-        category[:client] = @client
-        Gyft::Category.new(category)
+
+      if merchant.categories
+        merchant.categories = merchant.categories.map do |category|
+          category[:client] = @client
+          Gyft::Category.new(category)
+        end
       end
+      
       merchant
     end
   end

data/lib/gyft/version.rb

@@ -1,3 +1,3 @@
 module Gyft
-  VERSION = '0.0.4'
+  VERSION = '1.0.0'
 end

data/spec/card_spec.rb

@@ -0,0 +1,21 @@
+require_relative './test_helper'
+
+describe 'Gyft::Card' do
+
+  describe '.purchase' do
+    it "should delegate to the client" do
+      @client = Minitest::Mock.new
+      @card = Gyft::Card.new id: 123, client: @client
+      @partner = Minitest::Mock.new
+
+      @client.expect :partner, @partner
+      @partner.expect :purchase, @partner
+      @partner.expect :gift_card_direct, {}, [{ shop_card_id: 123, to_email: 'foo@bar.com'}]
+
+      @card.purchase(to_email: 'foo@bar.com')
+
+      @client.verify
+      @partner.verify
+    end
+  end
+end

data/spec/client/health_spec.rb

@@ -0,0 +1,24 @@
+require_relative '../test_helper'
+
+describe 'Gyft::Client::Health' do
+
+  describe '.check' do
+    it "should return if succesful" do
+      @client = Minitest::Mock.new
+      @health = Gyft::Client::Health.new @client
+
+      @client.expect :get, nil, ["/health/check"]
+      @health.check.must_equal true
+      @client.verify
+    end
+
+    it "should catch a SocketError" do
+      @client = Gyft::Client.new(api_key: "123", api_secret: "234")
+      @health = Gyft::Client::Health.new @client
+
+      @client.stub :get, ->(path){ raise SocketError.new } do
+        @health.check.must_equal false
+      end
+    end
+  end
+end

data/spec/client/partner_spec.rb

@@ -0,0 +1,44 @@
+require_relative '../test_helper'
+
+describe 'Gyft::Client::Partner' do
+
+  describe '.purchase.gift_card_direct' do
+    before do
+      @client = Minitest::Mock.new
+      @transaction = { id: '123' }
+      @partner = Gyft::Client::Partner.new @client
+      @params = { to_email: 'foo@bar.com', shop_card_id: '234' }
+    end
+
+    it "should return if succesful" do
+      @client.expect :post, @transaction, ["/partner/purchase/gift_card_direct", @params]
+      result = @partner.purchase.gift_card_direct(@params)
+      result.id.must_equal '123'
+      @client.verify
+    end
+
+    it "should error if params are missing" do
+      @params.delete(:to_email)
+      assert_raises KeyError do
+        @partner.purchase.gift_card_direct(@params)
+      end
+    end
+
+    it "should ignore invalid params" do
+      @new_params = @params.dup
+      @new_params[:foo] = 'bar'
+
+      @client.expect :post, @transaction, ["/partner/purchase/gift_card_direct", @params]
+      @partner.purchase.gift_card_direct(@new_params)
+      @client.verify
+    end
+
+    it "should symbolize keys" do
+      @new_params = { 'to_email' => 'foo@bar.com', 'shop_card_id' => '234' }
+
+      @client.expect :post, @transaction, ["/partner/purchase/gift_card_direct", @params]
+      @partner.purchase.gift_card_direct(@new_params)
+      @client.verify
+    end
+  end
+end

data/spec/client/reseller_spec.rb

@@ -0,0 +1,60 @@
+require_relative '../test_helper'
+
+describe 'Gyft::Client::Reseller' do
+  before do
+    @client = Minitest::Mock.new
+    @reseller = Gyft::Client::Reseller.new @client
+  end
+
+  describe '.shop_cards' do
+    it "should return if succesful" do
+      @cards = [{ id: '123' }]
+      @client.expect :get, @cards, ["/reseller/shop_cards"]
+      result = @reseller.shop_cards
+      result.first.id.must_equal '123'
+      @client.verify
+    end
+  end
+
+  describe '.categories' do
+    it "should return if succesful" do
+      @categories = { 'details' => [{ id: '123' }] }
+      @client.expect :get, @categories, ["/reseller/categories"]
+      result = @reseller.categories
+      result.first.id.must_equal '123'
+      @client.verify
+    end
+  end
+
+  describe '.merchants' do
+    it "should return if succesful" do
+      @merchants = { 'details' => [{ id: '123' }] }
+      @client.expect :get, @merchants, ["/reseller/merchants"]
+      result = @reseller.merchants
+      result.first.id.must_equal '123'
+      @client.verify
+    end
+  end
+
+  describe '.account' do
+    it "should return if succesful" do
+      @account = { id: '123' }
+      @client.expect :get, @account, ["/reseller/account"]
+      result = @reseller.account
+      result.id.must_equal @account[:id]
+      @client.verify
+    end
+  end
+
+  describe '.transaction' do
+    it "should return a Gyft::Client::Transactions object" do
+      @reseller.transaction.must_be_instance_of Gyft::Client::Transactions
+    end
+  end
+
+  describe '.transactions' do
+    it "should return a Gyft::Client::Transactions object" do
+      @reseller.transactions.must_be_instance_of Gyft::Client::Transactions
+    end
+  end
+end

data/spec/client/transactions_spec.rb

@@ -0,0 +1,54 @@
+require_relative '../test_helper'
+
+describe 'Gyft::Client::Transactions' do
+  before do
+    @client = Minitest::Mock.new
+    @transaction = { id: '123' }
+    @transactions = Gyft::Client::Transactions.new @client
+  end
+
+  describe '.find' do
+    it "should return if succesful" do
+      @client.expect :get, @transaction, ["/reseller/transaction/123"]
+      result = @transactions.find(123)
+      result.id.must_equal '123'
+      @client.verify
+    end
+  end
+
+  describe '.all' do
+    it "should return if succesful" do
+      @client.expect :get, [@transaction], ["/reseller/transactions"]
+      result = @transactions.all
+      result.first.id.must_equal '123'
+      @client.verify
+    end
+  end
+
+  describe '.first' do
+    it "should return if succesful" do
+      @client.expect :get, [@transaction], ["/reseller/transactions/first/10"]
+      result = @transactions.first(10)
+      result.first.id.must_equal '123'
+      @client.verify
+    end
+  end
+
+  describe '.last' do
+    it "should return if succesful" do
+      @client.expect :get, [@transaction], ["/reseller/transactions/last/10"]
+      result = @transactions.last(10)
+      result.first.id.must_equal '123'
+      @client.verify
+    end
+  end
+
+  describe '.refund' do
+    it "should return if succesful" do
+      @client.expect :post, @transaction, ["/reseller/transaction/refund", {id: 123}]
+      result = @transactions.refund(123)
+      result.id.must_equal '123'
+      @client.verify
+    end
+  end
+end

data/spec/client_spec.rb

@@ -0,0 +1,112 @@
+require_relative './test_helper'
+
+describe 'Gyft::Client' do
+  before do
+    @client = Gyft::Client.new(api_key: '123', api_secret: '234')
+  end
+
+  describe '.initialize' do
+    it "should return successful with the right params" do
+      client = Gyft::Client.new(api_key: '123', api_secret: '234')
+      client.must_be_instance_of Gyft::Client
+      client.api_key.must_equal '123'
+      client.api_secret.must_equal '234'
+      client.environment.must_equal 'sandbox'
+    end
+
+    it "should be able to accept another environment" do
+      client = Gyft::Client.new(api_key: '123', api_secret: '234', environment: 'production')
+      client.environment.must_equal 'production'
+    end
+
+    it "should return successful with the ENV variables set" do
+      ENV['GYFT_API_KEY'] = '123'
+      ENV['GYFT_API_SECRET'] = '234'
+      ENV['GYFT_API_ENVIRONMENT'] = 'production'
+
+      client = Gyft::Client.new
+      client.must_be_instance_of Gyft::Client
+      client.api_key.must_equal '123'
+      client.api_secret.must_equal '234'
+      client.environment.must_equal 'production'
+
+      ENV.delete('GYFT_API_KEY')
+      ENV.delete('GYFT_API_SECRET')
+      ENV.delete('GYFT_API_ENVIRONMENT')
+    end
+
+    it "should raise without the right params" do
+      assert_raises KeyError do
+        Gyft::Client.new
+      end
+    end
+  end
+
+  describe '.cards' do
+    it "should delegate to Gyft::Reseller" do
+      @reseller = Minitest::Mock.new
+      @client.reseller = @reseller
+      @reseller.expect :shop_cards, nil
+      @client.cards
+      @reseller.verify
+    end
+  end
+
+  describe '.health' do
+    it "should return a Gyft::Client::Health object" do
+      @client.health.must_be_instance_of Gyft::Client::Health
+    end
+  end
+
+  describe '.reseller' do
+    it "should return a Gyft::Client::Reseller object" do
+      @client.reseller.must_be_instance_of Gyft::Client::Reseller
+    end
+  end
+
+  describe '.partner' do
+    it "should return a Gyft::Client::Partner object" do
+      @client.partner.must_be_instance_of Gyft::Client::Partner
+    end
+  end
+
+  describe '.get' do
+    it "should return the json on success" do
+      stub_request(:get, /apitest.gyft.com\/mashery\/v1\/reseller\/categories/).
+        to_return(:status => 200, :body => '{"status":0,"details":[{"id":4,"name":"Babies & Children"}]}', :headers => { 'Content-Type' =>  'application/json'})
+
+      result = @client.get('/reseller/categories')
+      result['details'].first['id'].must_equal 4
+    end
+
+    it "should raise on 404" do
+      stub_request(:get, /apitest.gyft.com\/mashery\/v1\/reseller\/categories/).
+        to_return(:status => 404)
+
+      assert_raises Gyft::Client::NotFoundError do
+        @client.get('/reseller/categories')
+      end
+    end
+  end
+
+  describe '.post' do
+    it "should return the json on success" do
+      body = '{"id":"1234","status":0,"gf_reseller_id":"asdasd","gf_reseller_transaction_id":123,"email":"foo@bar.com","gf_order_id":123,"gf_order_detail_id":123,"gf_gyfted_card_id":123,"invalidated":false}'
+      stub_request(:post, /apitest.gyft.com\/mashery\/v1\/reseller\/transactions\/refund/).
+        to_return(:status => 200, :body => body, :headers => { 'Content-Type' =>  'application/json'})
+
+      result = @client.post('/reseller/transactions/refund', id: '123')
+      result['id'].must_equal '1234'
+    end
+
+    it "should handle a bad request" do
+      stub_request(:post, /apitest.gyft.com\/mashery\/v1\/reseller\/transactions\/refund/).
+        to_return(:status => 400)
+
+        assert_raises Gyft::Client::BadRequestError do
+          @client.post('/reseller/transactions/refund', id: '123')
+        end
+    end
+  end
+
+end

data/spec/test_helper.rb

@@ -0,0 +1,4 @@
+require 'minitest/autorun'
+require 'minitest/pride'
+require 'webmock/minitest'
+require 'gyft'

data/spec/transaction_spec.rb

@@ -0,0 +1,43 @@
+require_relative './test_helper'
+
+describe 'Gyft::Transaction' do
+
+  describe '.reload' do
+    it "should delegate to the client" do
+      @client = Minitest::Mock.new
+      @transaction = Gyft::Transaction.new id: 123, client: @client
+      @reseller = Minitest::Mock.new
+      @transactions = Minitest::Mock.new
+
+      @client.expect :reseller, @reseller
+      @reseller.expect :transactions, @transactions
+      @transactions.expect :find, {}, [123]
+
+      @transaction.reload
+
+      @client.verify
+      @reseller.verify
+      @transactions.verify
+    end
+  end
+
+  describe '.refund' do
+    it "should delegate to the client" do
+      @client = Minitest::Mock.new
+      @transaction = Gyft::Transaction.new id: 123, client: @client
+      @reseller = Minitest::Mock.new
+      @transactions = Minitest::Mock.new
+
+      @client.expect :reseller, @reseller
+      @reseller.expect :transactions, @transactions
+      @transactions.expect :refund, {}, [123]
+
+      @transaction.refund
+
+      @client.verify
+      @reseller.verify
+      @transactions.verify
+    end
+  end
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gyft
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 1.0.0
 platform: ruby
 authors:
 - Cristiano Betta
@@ -52,20 +52,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: awesome_print
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 description: Wrapper for the Gyft API
 email: cbetta@gmail.com
 executables: []
@@ -88,7 +74,14 @@ files:
 - lib/gyft/refund.rb
 - lib/gyft/transaction.rb
 - lib/gyft/version.rb
-- spec/gyft_spec.rb
+- spec/card_spec.rb
+- spec/client/health_spec.rb
+- spec/client/partner_spec.rb
+- spec/client/reseller_spec.rb
+- spec/client/transactions_spec.rb
+- spec/client_spec.rb
+- spec/test_helper.rb
+- spec/transaction_spec.rb
 homepage: https://github.com/cbetta/gyft
 licenses:
 - MIT

data/spec/gyft_spec.rb

@@ -1,18 +0,0 @@
-require 'minitest/autorun'
-require 'webmock/minitest'
-require 'gyft'
-
-describe 'Gyft::Reseller' do
-
-  before do
-    @client = Gyft::Client.new(api_key: '123', api_secret: '234')
-  end
-
-  describe '.health.check' do
-    it 'should return the result' do
-      stub_request(:get, /apitest.gyft.com\/mashery/)
-        .to_return(status: 200, body: "", headers: {})
-      @client.health.check.must_equal(true)
-    end
-  end
-end