gvl_metrics_middleware 0.2.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e3ed6765b65e47dc4b7b194c206994881750a0029d07ab40125c4300b93bcba2
-  data.tar.gz: 66ce9746ef0ec48e258f34c5bf34c79325addc2393d29b19cc142c697d64edff
+  metadata.gz: 81e9afea6ad5c3271fb91da6b0f69efcd3e1f49153b7e5a278483701295ebbac
+  data.tar.gz: 22363d1d03ee82e7a5e6475226fdf73414d9b643728dd0da6c4b7f05b86c6b29
 SHA512:
-  metadata.gz: f091d8530abd00c5aef08300d33ee3e50323d6e62cfb3a117fa478817af00d81a6a30cf33c98eba87a37731d01afda3a82751ea81f3bafaa37aba96af3891a88
-  data.tar.gz: f92832fddb6530a4ea8699c609b36f0fd283918740c2938a22dfe16e5a67059c21cf78b96e01b24b823fb64a76d193105a6174083d381c365713e670f5225125
+  metadata.gz: 4ba04171e7a5a1ae4eb7da1f9cbb32302d79e07679d05edc12f9d6dcc100bce0f514002368e94440f9b6cd00c313372d35b22accfda0905dae16083a29e26341
+  data.tar.gz: cdcf224fafb3879e806e8a033c5622431baf77c14fda3b76baef184f4e8cf60862ce41838527b31ebc831124349d6b4995da1248114d8af483e8a19027688fef

data/Appraisals

@@ -5,7 +5,6 @@ appraise "rails_edge" do
     gem "rails"
     gem "railties"
     gem "activesupport"
-    gem "activemodel"
   end
 end
 
@@ -13,19 +12,22 @@ appraise "rails_80" do
   gem "rails", "~> 8.0.0"
   gem "railties", "~> 8.0.0"
   gem "activesupport", "~> 8.0.0"
-  gem "activemodel", "~> 8.0.0"
+end
+
+appraise "rails_81" do
+  gem "rails", "~> 8.1.0"
+  gem "railties", "~> 8.1.0"
+  gem "activesupport", "~> 8.1.0"
 end
 
 appraise "rails_72" do
   gem "rails", "~> 7.2.0"
   gem "railties", "~> 7.2.0"
   gem "activesupport", "~> 7.2.0"
-  gem "activemodel", "~> 7.2.0"
 end
 
 appraise "rails_71" do
   gem "rails", "~> 7.1.0"
   gem "railties", "~> 7.1.0"
   gem "activesupport", "~> 7.1.0"
-  gem "activemodel", "~> 7.1.0"
 end

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 ## [Unreleased]
 
+## [0.2.1] - 2025-11-14
+
+- Fixed errors when middleware stack may have been modified ([#18](https://github.com/speedshop/gvl_metrics_middleware/pull/18))
+
 ## [0.2.0] - 2025-10-30
 
 - Add sampling support ([#7](https://github.com/speedshop/gvl_metrics_middleware/pull/7)). Set `config.sampling_rate = 0.1` to sample 10% of requests/jobs (defaults to 1%).

data/README.md

@@ -15,7 +15,7 @@ gem 'gvl_metrics_middleware', git: "https://github.com/speedshop/gvl_metrics_mid
 
 ## Usage
 
-The `gvl_metrics_middleware` automatically inserts the nessecary middleware into your application’s stack. To get
+The `gvl_metrics_middleware` automatically inserts the necessary middleware into your application’s stack. To get
 started, configure a callback to handle the GVL metrics. Place the following configuration in your
 application’s `config/initializers`directory:
 
@@ -112,7 +112,7 @@ where both the control and experiment groups ran identical code, and the differe
 consistent with those reported in [Shopify's `gvltools`](https://github.com/Shopify/gvltools?tab=readme-ov-file#usage),
 where the overhead was measured at 1-5% in a production environment.
 
-As stated in [the README of `gvltools`](https://github.com/Shopify/gvltools?tab=readme-ov-file#usage)`, the exact
+As stated in [the README of `gvltools`](https://github.com/Shopify/gvltools?tab=readme-ov-file#usage), the exact
 overhead is not yet known. However, unless you observe an immediate, significant jump in response times after
 deployment, the overhead is negligible and should not impact application performance. This makes the middleware a
 reliable choice for tracking GVL metrics in production environments.

data/gemfiles/rails_71.gemfile

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 # This file was generated by Appraisal
 
 source "https://rubygems.org"
@@ -7,9 +5,9 @@ source "https://rubygems.org"
 gem "minitest", "~> 5.16"
 gem "rake", "~> 13.0"
 gem "rubocop", require: false
+gem "rack-attack", "~> 6.8"
 gem "rails", "~> 7.1.0"
 gem "railties", "~> 7.1.0"
 gem "activesupport", "~> 7.1.0"
-gem "rackup"
 
 gemspec path: "../"

data/gemfiles/rails_72.gemfile

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 # This file was generated by Appraisal
 
 source "https://rubygems.org"
@@ -7,9 +5,9 @@ source "https://rubygems.org"
 gem "minitest", "~> 5.16"
 gem "rake", "~> 13.0"
 gem "rubocop", require: false
+gem "rack-attack", "~> 6.8"
 gem "rails", "~> 7.2.0"
 gem "railties", "~> 7.2.0"
 gem "activesupport", "~> 7.2.0"
-gem "rackup"
 
 gemspec path: "../"

data/gemfiles/rails_80.gemfile

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 # This file was generated by Appraisal
 
 source "https://rubygems.org"
@@ -7,9 +5,9 @@ source "https://rubygems.org"
 gem "minitest", "~> 5.16"
 gem "rake", "~> 13.0"
 gem "rubocop", require: false
+gem "rack-attack", "~> 6.8"
 gem "rails", "~> 8.0.0"
 gem "railties", "~> 8.0.0"
 gem "activesupport", "~> 8.0.0"
-gem "rackup"
 
 gemspec path: "../"

data/gemfiles/rails_81.gemfile

@@ -0,0 +1,13 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "minitest", "~> 5.16"
+gem "rake", "~> 13.0"
+gem "rubocop", require: false
+gem "rack-attack", "~> 6.8"
+gem "rails", "~> 8.1.0"
+gem "railties", "~> 8.1.0"
+gem "activesupport", "~> 8.1.0"
+
+gemspec path: "../"

data/gemfiles/rails_edge.gemfile

@@ -1,5 +1,3 @@
-# frozen_string_literal: true
-
 # This file was generated by Appraisal
 
 source "https://rubygems.org"
@@ -13,6 +11,6 @@ end
 gem "minitest", "~> 5.16"
 gem "rake", "~> 13.0"
 gem "rubocop", require: false
-gem "rackup"
+gem "rack-attack", "~> 6.8"
 
 gemspec path: "../"

data/lib/gvl_metrics_middleware/railtie.rb

@@ -8,23 +8,20 @@ module GvlMetricsMiddleware
     config.gvl_metrics_middleware.enabled = !Rails.env.test?
     config.gvl_metrics_middleware.safe_guard = Rails.env.production?
 
-    initializer "gvl_metrics_middleware", after: :load_config_initializers do |app|
-      if app.config.gvl_metrics_middleware.enabled && app.config.gvl_metrics_middleware.safe_guard
-        GvlMetricsMiddleware.on_report_failure.nil? && GvlMetricsMiddleware.on_report_failure do |source, exception|
-          Rails.logger.error("GVL Metrics Middleware failed to report metrics from #{source}: #{exception.class} (#{exception.message})")
-        end
-
-        GvlMetricsMiddleware.safe_guard = app.config.gvl_metrics_middleware.safe_guard
-      end
+    initializer "gvl_metrics_middleware.rack" do |app|
+      app.config.middleware.insert(0, GvlMetricsMiddleware::Rack)
     end
 
-    initializer "gvl_metrics_middleware.rack", after: :load_config_initializers do |app|
-      app.config.middleware.insert(0, GvlMetricsMiddleware::Rack) if app.config.gvl_metrics_middleware.enabled
+    config.after_initialize do |app|
+      GvlMetricsMiddleware.enabled = app.config.gvl_metrics_middleware.enabled
+      setup_safe_guard(app.config)
+      configure_sidekiq_middleware(app.config)
     end
 
-    initializer "gvl_metrics_middleware.sidekiq", after: :load_config_initializers do |app|
-      if defined?(::Sidekiq) && app.config.gvl_metrics_middleware.enabled
+    def self.configure_sidekiq_middleware(app_config)
+      if defined?(::Sidekiq) && app_config.gvl_metrics_middleware.enabled
         require "gvl_metrics_middleware/sidekiq"
+
         ::Sidekiq.configure_server do |config|
           config.server_middleware do |chain|
             chain.prepend(GvlMetricsMiddleware::Sidekiq)
@@ -32,5 +29,15 @@ module GvlMetricsMiddleware
         end
       end
     end
+
+    def self.setup_safe_guard(app_config)
+      if app_config.gvl_metrics_middleware.enabled && app_config.gvl_metrics_middleware.safe_guard
+        GvlMetricsMiddleware.on_report_failure.nil? && GvlMetricsMiddleware.on_report_failure do |source, exception|
+          Rails.logger.error("GVL Metrics Middleware failed to report metrics from #{source}: #{exception.class} (#{exception.message})")
+        end
+
+        GvlMetricsMiddleware.safe_guard = app_config.gvl_metrics_middleware.safe_guard
+      end
+    end
   end
 end

data/lib/gvl_metrics_middleware/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module GvlMetricsMiddleware
-  VERSION = "0.2.0"
+  VERSION = "0.2.1"
 end

data/lib/gvl_metrics_middleware.rb

@@ -25,6 +25,14 @@ module GvlMetricsMiddleware
     end
   end
 
+  @@enabled = true
+
+  def self.enabled? = @@enabled
+
+  def self.enabled=(value)
+    @@enabled = value
+  end
+
   @@on_report_failure = nil
 
   def self.on_report_failure(&block)
@@ -62,6 +70,6 @@ module GvlMetricsMiddleware
     return true if @@sampling_rate == 1.0
     return false if @@sampling_rate == 0.0
 
-    rand < @@sampling_rate
+    enabled? && (rand < @@sampling_rate)
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gvl_metrics_middleware
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Nate Berkopec
@@ -84,6 +84,7 @@ files:
 - gemfiles/rails_71.gemfile
 - gemfiles/rails_72.gemfile
 - gemfiles/rails_80.gemfile
+- gemfiles/rails_81.gemfile
 - gemfiles/rails_edge.gemfile
 - gvl-metrics.png
 - lib/gvl_metrics_middleware.rb