gvive 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2eaf74e4921bc1ab21759c460a8655c350df6e07
-  data.tar.gz: '0954b56a1456ca6452ff48933d45758a15ec803d'
+  metadata.gz: 0f42745844ffddfcd7269bd08365ee80518ca179
+  data.tar.gz: '044974c569d35df4b488b5939da0ffae3ac965dc'
 SHA512:
-  metadata.gz: 94186cf9843777f5cf64659ae294b9b39ba7d29e81b7d2cdb6e904c29042436344d3998011f9b6afec6483bd646d739c9f00fd77cfb0e5632b2d293f512d32ed
-  data.tar.gz: c514974adf452accf88b8412c08f7dc2c59a0d85e3b5535856bae876c23c7f5164246c20cc4b7e7cf779955db665ac1027eee6a1b405d124bdd4e58e55fb0b9a
+  metadata.gz: 9c91a649208b21b9bcf9161e304dd8c3de2c02fe49cdd59607c6256357c28ae6457dd57220ed3fcb333ba33259b67566f198d5a9339b088f618d9f8a180cd134
+  data.tar.gz: 0a1f34f154619ec91fc8b87c23c5d307e67e76e8c94864a45404c8db419033338476e75cf00caae1456b394dbb856e9a9f33c71c2833fb368c99e4bf51a18ed1

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    gvive (0.1.0)
+    gvive (1.1.0)
       http (~> 2.0)
 
 GEM

data/README.md

@@ -50,12 +50,12 @@ You are required to provide the Voter ID number
 ```ruby
 voter = GVIVE::Identity::Voter.new('6580676543')
 if voter.valid?
-   p voter.data.Fullname
-   p voter.data.PollingStation
-   p voter.data.ResidentialAddress
+   p voter.data.fullname
+   p voter.data.polling_station
+   p voter.data.residential_address
   # ...
  else
-   p voter.data.Message
+   p voter.data.message
  end
 ```
 
@@ -65,13 +65,13 @@ You are required to provide the Passport ID number
 ```ruby
 passport = GVIVE::Identity::Passport.new('G00827283')
 if passport.valid?
-   p passport.data.FirstName
-   p passport.data.LastName
-   p passport.data.Gender
-   p passport.data.ExpiryDate
+   p passport.data.first_name
+   p passport.data.last_name
+   p passport.data.gender
+   p passport.data.expiry_date
    # ...
  else
-   p passport.data.Message
+   p passport.data.message
  end
 ```
 
@@ -81,16 +81,26 @@ You are required to provide the Certificate of Competence Number & the full name
 ```ruby
 driver = GVIVE::Identity::Driver.new('COO92930','Alfred Rowe')
 if driver.valid?
-   p driver.data.FirstName
-   p driver.data.LastName
-   p driver.data.Gender
-   p driver.data.ExpiryDate
+   p driver.data.first_name
+   p driver.data.last_name
+   p driver.data.class_of_licence
+   p driver.data.date_of_issue
    # ...
  else
-   p driver.data.Message
+   p driver.data.message
  end
 ```
 
+## Testing
+In order to protect valid identity information, all valid IDs have been moved to environment variables. You will need to set them up before tests can pass for valid ID specs.
+
+```sh
+export GVIVE_VALID_VID=VOTER_ID_NUMBER
+export GVIVE_VALID_PID=PASSPORT_ID_NUMBER
+export GVIVE_VALID_DCOC=DRIVER_CERTIFICATE_OF_COMPETENCE_NUMBER
+export GVIVE_VALID_DNAME=⁠⁠⁠⁠⁠"Full name as printed exactly on ID card"
+```
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. You can also run `bin/console` for an interactive prompt that will allow you to experiment.

data/lib/gvive/identity/driver.rb

@@ -1,5 +1,3 @@
-require 'cgi'
-
 module GVIVE
   module Identity
     class Driver < GVIVE::Identities

data/lib/gvive/response.rb

@@ -15,7 +15,26 @@ module GVIVE
     # Convert response data to plain Ruby Objects
     # @return [OpenStruct]
     def to_o
-      @cache = JSON.parse @http_response.body.to_s, object_class: OpenStruct
+      old_hash = JSON.parse @http_response.body.to_s
+      new_hash = {}
+      old_hash.each do |k,v|
+        new_hash["#{snakecase(k)}"] = v
+      end
+      @cache = OpenStruct.new(new_hash)
+    end
+
+    # Shamelessly copied from the internet with 1% modifications :)
+    # http://www.rubydoc.info/github/rubyworks/facets/String%3Asnakecase
+    # Convert all CamelCased strings to snake_cased
+    # @param [String] str
+    # @return [String]
+    def snakecase(str)
+      str.to_s.gsub(/([A-Z]+)([A-Z][a-z])/,'\1_\2').
+      gsub(/([a-z\d])([A-Z])/,'\1_\2').
+      tr('-', '_').
+      gsub(/\s/, '_').
+      gsub(/__+/, '_').
+      downcase
     end
 
     # GVIVE returned valid response
@@ -23,7 +42,7 @@ module GVIVE
     # Check also for GVIVE ResponseCode Key in the response body 200 for data found
     # @return [Boolean]
     def success?
-      @http_response.code == 200 && to_o.ResponseCode == "200"
+      @http_response.code == 200 && to_o.response_code == "200"
     end
   end
 end

data/lib/gvive/version.rb

@@ -1,3 +1,3 @@
 module GVIVE
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gvive
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Alfred Rowe
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-09-29 00:00:00.000000000 Z
+date: 2017-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler