gutentag 2.5.3 → 2.5.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9b86cbc2c649e92b40be12e9be738e3b57f57cb10241103e02d2aa5ea82a0d0a
-  data.tar.gz: 916b5eabf6121b235ca9136ac2eaf0113bde665f532bd21afe5b728825718fee
+  metadata.gz: 7af5fa8abd650550bd231819b8b4f043a17a15f0afba13dc443bf1b42ddd7a26
+  data.tar.gz: 7e22c0cc2a8c0de4840264b1e9cceb62c4504fc8df5d0e636a4894aa298152b5
 SHA512:
-  metadata.gz: 3e3dcd7dcae2889b2ab496966bbb5b57c332f46546cbc7dd8f3e557f710c5ae89cfebe833a25bc6efb73c18fb74b858422943072407b328f59251543a000da4e
-  data.tar.gz: e7c60af1366e1afbc647162cbd72618be7884c9dc3bf8f580a8b6ddfa61684c7c1546f2fd9f85f0aadceaa2ac7b1dd22b70332b1061c162c2b3695d1fea111ac
+  metadata.gz: 44ebaff249f6bba8798d98944177e3eac9569dc7731a3814add6e10fa1b2c5db1f491175e00bda53a25d84d6a96bdd622a5a812adac032017234c54864072002
+  data.tar.gz: fd440589741ffe77dfbde8649095c2bb5fae9a656d5b0cfb110390a8e156d49840cbead9a0e1e19d01a19a527a2d2e85dbd60e31a807fe25c6e2f746e5b59c55

data/.github/workflows/ci.yml

@@ -0,0 +1,90 @@
+name: CI
+
+on: [push, pull_request]
+
+jobs:
+  test:
+    runs-on: ubuntu-18.04
+
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: [ '2.4', '2.5', '2.6', '2.7', '3.0' ]
+        bundler: [ '1.17.3', '2.1.4' ]
+        database: [ 'mysql', 'postgresql', 'sqlite' ]
+        exclude:
+          - ruby: '2.4'
+            bundler: '2.1.4'
+          - ruby: '2.5'
+            bundler: '2.1.4'
+          - ruby: '2.6'
+            bundler: '2.1.4'
+          - ruby: '2.7'
+            bundler: '1.17.3'
+          - ruby: '3.0'
+            bundler: '1.17.3'
+
+    services:
+      postgres:
+        image: postgres:10
+        env:
+          POSTGRES_USER: root
+          POSTGRES_PASSWORD: gutentag
+          POSTGRES_DB: test
+        ports: ['5432:5432']
+        # needed because the postgres container does not provide a healthcheck
+        options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5
+
+      mysql:
+        image: mysql:5.7
+        env:
+          MYSQL_ROOT_PASSWORD: gutentag
+          MYSQL_DATABASE: test
+        ports: ['3306:3306']
+        options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3
+
+    steps:
+      - name: Check out code
+        uses: actions/checkout@v2
+      - name: Set up ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler: ${{ matrix.bundler }}
+          bundler-cache: true
+
+      - name: Set up Bundler
+        run: |
+          export BUNDLER_VERSION=${{ matrix.bundler }}
+          export BUNDLE_PATH=$PWD/vendor/bundle
+
+          gem update --system
+
+          bundle _${{ matrix.bundler }}_ config set path $PWD/$BUNDLE_PATH
+          bundle _${{ matrix.bundler }}_ install --jobs=4 --retry=3
+          bundle _${{ matrix.bundler }}_ update
+      - name: Set up Appraisal
+        run: bundle exec appraisal update
+      - name: Test
+        env:
+          CI: "true"
+          DATABASE: ${{ matrix.database }}
+          DB_USERNAME: root
+          DB_PASSWORD: gutentag
+          DB_HOST: 127.0.0.1
+        run: bundle exec appraisal rspec
+
+  rubocop:
+    runs-on: ubuntu-18.04
+
+    steps:
+      - name: Check out code
+        uses: actions/checkout@v2
+      - name: Set up ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 2.7
+          bundler: 2.1.4
+          bundler-cache: true
+      - name: Rubocop
+        run: bundle exec rubocop

data/.rubocop.yml

@@ -7,6 +7,10 @@ AllCops:
   TargetRubyVersion: 2.3
   Exclude:
     - gemfiles/*.gemfile
+    - vendor/**/*
+
+Bundler/DuplicatedGem:
+  Enabled: false
 
 Metrics/MethodLength:
   Exclude:

data/Appraisals

@@ -22,22 +22,29 @@ end if RUBY_VERSION.to_f < 2.7
 appraise "rails_5_0" do
   gem "rails",  "~> 5.0.3"
   gem "mysql2", "~> 0.4.0", :platform => :ruby
-end if RUBY_VERSION.to_f >= 2.2
+end if RUBY_VERSION.to_f >= 2.2 && RUBY_VERSION.to_f <= 2.7
 
 appraise "rails_5_1" do
   gem "rails",  "~> 5.1.1"
   gem "mysql2", "~> 0.4.0", :platform => :ruby
-end if RUBY_VERSION.to_f >= 2.2
+end if RUBY_VERSION.to_f >= 2.2 && RUBY_VERSION.to_f <= 2.7
 
 appraise "rails_5_2" do
   gem "rails",  "~> 5.2.0"
   gem "pg",     "~> 1.0",   :platform => :ruby
   gem "mysql2", "~> 0.5.0", :platform => :ruby
-end if RUBY_VERSION.to_f >= 2.2
+end if RUBY_VERSION.to_f >= 2.2 && RUBY_VERSION.to_f <= 2.7
 
 appraise "rails_6_0" do
   gem "rails",   "~> 6.0.0"
   gem "pg",      "~> 1.0",   :platform => :ruby
   gem "mysql2",  "~> 0.5.0", :platform => :ruby
-  gem "sqlite3", "~> 1.4", :platform => :ruby
+  gem "sqlite3", "~> 1.4",   :platform => :ruby
+end if RUBY_VERSION.to_f >= 2.5 && RUBY_PLATFORM != "java"
+
+appraise "rails_6_1" do
+  gem "rails",   "~> 6.1.0"
+  gem "pg",      "~> 1.0",   :platform => :ruby
+  gem "mysql2",  "~> 0.5.0", :platform => :ruby
+  gem "sqlite3", "~> 1.4",   :platform => :ruby
 end if RUBY_VERSION.to_f >= 2.5 && RUBY_PLATFORM != "java"

data/CHANGELOG.md

@@ -2,11 +2,17 @@
 
 All notable changes to this project (at least, from v0.5.0 onwards) will be documented in this file.
 
+## 2.5.4 - 2021-02-21
+
+### Fixed
+
+* Don't apply the tag length validation when `ActiveRecord::ConnectionNotEstablished` exceptions are raised. ([John Duff](https://github.com/jduff) in [#77](https://github.com/pat/gutentag/pull/77)).
+
 ## 2.5.3 - 2020-06-28
 
 ### Fixed
 
-* Use `saved_change_to_tag_names?` instead of `tag_names_previously_changed?` for Rails 5.1+ ([Morten Trolle](https://github.com/mtrolle) in [70](https://github.com/pat/gutentag/pull/70)).
+* Use `saved_change_to_tag_names?` instead of `tag_names_previously_changed?` for Rails 5.1+ ([Morten Trolle](https://github.com/mtrolle) in [#70](https://github.com/pat/gutentag/pull/70)).
 * `Gutentag::Tag.names_for_scope` now handles empty scopes ([Mike Gunderloy](https://github.com/ffmike) in [#73](https://github.com/pat/gutentag/pull/73)).
 
 ## 2.5.2 - 2019-07-08

data/Gemfile

@@ -8,7 +8,12 @@ gem "test-unit", :platform => :ruby_22
 
 gem "mysql2",  "~> 0.3",    :platform => :ruby
 gem "pg",      "~> 0.18",   :platform => :ruby
-gem "sqlite3", "~> 1.3.13", :platform => :ruby
+
+if RUBY_VERSION.to_f < 3.0
+  gem "sqlite3", "~> 1.3.13"
+else
+  gem "sqlite3", "~> 1.4"
+end
 
 gem "activerecord-jdbcmysql-adapter",      ">= 1.3.23", :platform => :jruby
 gem "activerecord-jdbcpostgresql-adapter", ">= 1.3.23", :platform => :jruby

data/gutentag.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name        = "gutentag"
-  s.version     = "2.5.3"
+  s.version     = "2.5.4"
   s.authors     = ["Pat Allan"]
   s.email       = ["pat@freelancing-gods.com"]
   s.homepage    = "https://github.com/pat/gutentag"
@@ -16,7 +16,7 @@ Gem::Specification.new do |s|
 
   s.add_runtime_dependency     "activerecord", ">= 3.2.0"
 
-  s.add_development_dependency "appraisal",           "~> 2.1.0"
+  s.add_development_dependency "appraisal",           "~> 2.3"
   s.add_development_dependency "bundler",             ">= 1.17"
   s.add_development_dependency "combustion",          "~> 1.1"
   s.add_development_dependency "database_cleaner",    "~> 1.6"

data/lib/gutentag/tag_validations.rb

@@ -13,6 +13,7 @@ class Gutentag::TagValidations
     if ActiveRecord::VERSION::STRING.to_f > 4.0
       classes << ActiveRecord::NoDatabaseError
     end
+    classes << ActiveRecord::ConnectionNotEstablished
     classes << Mysql2::Error     if defined?(::Mysql2)
     classes << PG::ConnectionBad if defined?(::PG)
     classes

data/spec/internal/config/database.yml

@@ -2,11 +2,26 @@
 test:
   adapter: mysql2
   database: gutentag
-  username: root
+  username: <%= ENV.fetch("DB_USERNAME", "root") %>
+  <% if ENV["DB_HOST"] %>
+  host: <%= ENV["DB_HOST"] %>
+  <% end %>
+  <% if ENV["DB_PASSWORD"] %>
+  password: <%= ENV["DB_PASSWORD"] %>
+  <% end %>
 <% elsif ENV["DATABASE"] == "postgres" %>
 test:
   adapter: postgresql
   database: gutentag
+  <% if ENV["DB_HOST"] %>
+  host: <%= ENV["DB_HOST"] %>
+  <% end %>
+  <% if ENV["DB_USERNAME"] %>
+  username: <%= ENV["DB_USERNAME"] %>
+  <% end %>
+  <% if ENV["DB_PASSWORD"] %>
+  password: <%= ENV["DB_PASSWORD"] %>
+  <% end %>
 <% else %>
 test:
   adapter: sqlite3

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gutentag
 version: !ruby/object:Gem::Version
-  version: 2.5.3
+  version: 2.5.4
 platform: ruby
 authors:
 - Pat Allan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-28 00:00:00.000000000 Z
+date: 2021-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: '2.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -143,9 +143,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rubocop.yml"
-- ".travis.yml"
 - Appraisals
 - CHANGELOG.md
 - Gemfile

data/.travis.yml

@@ -1,23 +0,0 @@
-language: ruby
-dist: xenial
-script: bundle exec appraisal rake
-rvm:
-  - 2.3.8
-  - 2.4.10
-  - 2.5.8
-  - 2.6.6
-  - 2.7.1
-  # - jruby-9.2.8.0
-before_install:
-  - gem install bundler --version 1.17.3
-install:
-  - bundle _1.17.3_ install --jobs=3 --retry=3
-before_script:
-  - bundle exec appraisal install
-env:
-  - DATABASE=postgres
-  - DATABASE=mysql
-  - DATABASE=sqlite
-services:
-- mysql
-- postgresql