gutentag 2.4.1 → 2.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 53b60a0cb99836a7c475d6fee7b431f99e38c16976f914e3591e86530c1d5b7b
-  data.tar.gz: 564c325549cf3f51ceb24a5986a06d5ad66b81f1a07b948a1875b4e1d8ebead5
+SHA1:
+  metadata.gz: fe6d98b81a4c392bb7591418821697ceb622e80e
+  data.tar.gz: 5299b1efed9975a5bb902d704617c41dc0a1dd38
 SHA512:
-  metadata.gz: dcb6dba995fc07e770dbd605d667501dba90ed153c6c40ff825e53276890a2a7fb2e5d4f13cef3573a094d0b25fb1645baa956aeccdf3e1bfad8e6b0f8ade58e
-  data.tar.gz: df7591b2ed083abb732c447ecf1b916d540edc168b4542bca99fe41e03e8135f2cee6745b2a43d2e68cc9466da411e578db4bac40264123d3cf88ee5da84b502
+  metadata.gz: 1ae92f80e7bd6b60bd7623a976b910ba4a9a43e97aac6b2dab3b0f2d72ee76bce9d1eaddc6a70c2bbbe4500c36cfa9ea2f055635f4e6a0b0182dd6842b43af83
+  data.tar.gz: 2a07b209873183a7ed92d47bd2c6cecf153af767d14c2fe6e664272c6ee22032134ce4a0b194d5a0837206716cd5f99388b1c5a325c60d7c5c4bdd79aa9d0396

data/.rubocop.yml

@@ -2,13 +2,10 @@ inherit_from:
   - https://gist.githubusercontent.com/pat/ba3b8ffb1901bfe5439b460943b6b019/raw/.rubocop.yml
 
 AllCops:
-  TargetRubyVersion: 2.2
+  TargetRubyVersion: 2.3
   Exclude:
     - gemfiles/*.gemfile
 
-Layout/AlignHash:
-  EnforcedHashRocketStyle: table
-
 Metrics/MethodLength:
   Exclude:
     - db/migrate/1_gutentag_tables.rb
@@ -21,6 +18,3 @@ Style/MultilineIfModifier:
 Style/MultilineTernaryOperator:
   Exclude:
     - db/migrate/*.rb
-
-Style/SafeNavigation:
-  Enabled: false

data/.travis.yml

@@ -2,7 +2,6 @@ language: ruby
 dist: xenial
 script: bundle exec appraisal rake
 rvm:
-  - 2.2.10
   - 2.3.8
   - 2.4.5
   - 2.5.3

data/Appraisals

@@ -1,10 +1,5 @@
 # frozen_string_literal: true
 
-appraise "rails_3_2" do
-  gem "rails",   "~> 3.2.22.5"
-  gem "mysql2",  "~> 0.3.10", :platform => :ruby
-end if RUBY_VERSION.to_f <= 2.2
-
 appraise "rails_4_0" do
   gem "rails",   "~> 4.0.13"
   gem "mysql2",  "~> 0.3.10", :platform => :ruby

data/CHANGELOG.md

@@ -2,6 +2,18 @@
 
 All notable changes to this project (at least, from v0.5.0 onwards) will be documented in this file.
 
+## 2.5.0 - 2019-03-15
+
+**Pleease note this release ends official support of Rails 3.2 and Ruby (MRI) 2.2.** The code currently still works on Ruby 2.2, and all features except for the new `Gutentag::Tag.names_for_scope` method work in Rails 3.2, but they're no longer tested against, and cannot be guaranteed to work in future releases.
+
+### Added
+
+* Added the `Gutentag::Tag.names_for_scope(scope)` method, which accepts an ActiveRecord model or a relation, and returns all tag names associated to that model/relation.
+
+### Changed
+
+* Removing support for MRI 2.2 and Rails 3.2.
+
 ## 2.4.1 - 2019-02-22
 
 ### Changed

data/README.md

@@ -72,15 +72,17 @@ Article.tagged_with(:ids => [tag_a.id, tag_b.id], :match => :all)
 
 These are the versions the test suite runs against. It's possible it may work on older versions of Ruby, but it definitely won't work on older versions of Rails.
 
-* Ruby: MRI v2.2-v2.6, JRuby v9.2.5
-* Rails/ActiveRecord: v3.2-v6.0
+* Ruby: MRI v2.3-v2.6, JRuby v9.2.5
+* Rails/ActiveRecord: v4.0-v6.0
+
+If you're using MRI v2.2 and/or ActiveRecord v3.2, the last version of Gutentag that fully supported those versions is v2.4.1.
 
 ### Installing
 
 Get it into your Gemfile - and don't forget the version constraint!
 
 ```Ruby
-gem 'gutentag', '~> 2.4'
+gem 'gutentag', '~> 2.5'
 ```
 
 Next: your tags get persisted to your database, so let's import and run the migrations to get the tables set up:

data/app/models/gutentag/tag.rb

@@ -19,6 +19,17 @@ class Gutentag::Tag < ActiveRecord::Base
     find_by_name(name) || create(:name => name)
   end
 
+  def self.names_for_scope(scope)
+    join_conditions = {:taggable_type => scope.name}
+    if scope.current_scope.present?
+      join_conditions[:taggable_id] = scope.select(:id)
+    end
+
+    joins(:taggings).where(
+      Gutentag::Tagging.table_name => join_conditions
+    ).distinct.pluck(:name)
+  end
+
   def name=(value)
     super(Gutentag.normaliser.call(value))
   end

data/gutentag.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name        = "gutentag"
-  s.version     = "2.4.1"
+  s.version     = "2.5.0"
   s.authors     = ["Pat Allan"]
   s.email       = ["pat@freelancing-gods.com"]
   s.homepage    = "https://github.com/pat/gutentag"

data/lib/gutentag/active_record/instance_methods_3_2.rb

@@ -16,7 +16,7 @@ module Gutentag::ActiveRecord::InstanceMethods
   def tag_names=(names)
     names = Gutentag::TagNames.call(names)
 
-    Gutentag.dirtier.call self, names if Gutentag.dirtier
+    Gutentag.dirtier.call self, names if Gutentag.dirtier.present?
 
     @tag_names = names
   end

data/spec/acceptance/tag_names_for_scope_spec.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+RSpec.describe "Tag names for scopes" do
+  it "returns tag names for a given model" do
+    Article.create :tag_names => %w[ koala wombat ]
+    Article.create :tag_names => %w[ cassowary ]
+
+    expect(Gutentag::Tag.names_for_scope(Article)).
+      to match_array(%w[ koala wombat cassowary ])
+  end
+
+  it "returns tag names for a given scope" do
+    Article.create :title => "mammals", :tag_names => %w[ koala wombat ]
+    Article.create :title => "birds",   :tag_names => %w[ cassowary ]
+
+    expect(Gutentag::Tag.names_for_scope(Article.where(:title => "mammals"))).
+      to match_array(%w[ koala wombat ])
+  end
+
+  it "does not duplicate tag names for a given model/scope" do
+    Article.create :tag_names => %w[ koala wombat ]
+    Article.create :tag_names => %w[ cassowary ]
+    Article.create :tag_names => %w[ cassowary wombat ]
+
+    expect(Gutentag::Tag.names_for_scope(Article)).
+      to match_array(%w[ koala wombat cassowary ])
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gutentag
 version: !ruby/object:Gem::Version
-  version: 2.4.1
+  version: 2.5.0
 platform: ruby
 authors:
 - Pat Allan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-02-22 00:00:00.000000000 Z
+date: 2019-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -163,6 +163,7 @@ files:
 - lib/gutentag/tagged_with/query.rb
 - spec/acceptance/dirty_state_spec.rb
 - spec/acceptance/removing_unused_spec.rb
+- spec/acceptance/tag_names_for_scope_spec.rb
 - spec/acceptance/tag_names_spec.rb
 - spec/acceptance/tags_spec.rb
 - spec/gutentag/active_record_spec.rb
@@ -196,7 +197,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.4.5.5
 signing_key: 
 specification_version: 4
 summary: Good Tags