gutentag 0.5.1 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f6d5be313a5546f19c11c2c5a74b0164665c795e
-  data.tar.gz: e9dee9503ecbae393676a9d5d897e79b12876236
+  metadata.gz: 5caab7c06cc22c8d471dff482d8a0e8697bd9fea
+  data.tar.gz: 8402bccf294c70bd31d12e4bf31eda66e4b347db
 SHA512:
-  metadata.gz: 5d353d61f4c35f34c56c4545cac40eef7a6a187da84515bcc99c883de01892a01823f746cedf5e7a1f8b26878023fddef5bb4ae09d48c8e262a761968a4324ca
-  data.tar.gz: d22d8a4f863229adeda019d80919f63fe55adf653e0be3cd813190e529474e9d7b86f247909506debead2ad69a5b940d81fc3954fd3752896563d7b4a13be6ff
+  metadata.gz: 6e6370b2e38a4c3d97f5d48e43057cf1890f22cbd059f9ffd7f36a4781c7e9863bb32bbdef3e5c76cf3d5f7c8f4ec5432fc70671080567d95f04018e78c7a3b0
+  data.tar.gz: ff1200c35f2076cfdf3182e7b6d65a67707436c806782f9df6bfe363291c75942d634cc6da1599cb14d974dda3c313ab2a98d8f1cec944499c9c4de83b655f0c

data/.gitignore

@@ -1,3 +1,3 @@
-Gemfile.lock
+*.lock
 pkg/*
 spec/internal/db/*.sqlite

data/.travis.yml

@@ -1,5 +1,7 @@
 language: ruby
-script: bundle exec rspec spec
+script: bundle exec appraisal rspec
 rvm:
-  - 1.9.3
   - 2.0.0
+  - 2.2.0
+before_script:
+  - bundle exec appraisal install

data/Appraisals

@@ -0,0 +1,15 @@
+appraise 'rails_3_2' do
+  gem 'rails',  '~> 3.2.21'
+end
+
+appraise 'rails_4_0' do
+  gem 'rails', '~> 4.0.12'
+end
+
+appraise 'rails_4_1' do
+  gem 'rails', '~> 4.1.8'
+end
+
+appraise 'rails_4_2' do
+  gem 'rails', '~> 4.2.0'
+end

data/README.md

@@ -12,7 +12,7 @@ This was built partly as a proof-of-concept, and partly to see how a tagging gem
 
 Get it into your Gemfile - and don't forget the version constraint!
 
-    gem 'gutentag', '~> 0.5.1'
+    gem 'gutentag', '~> 0.6.0'
 
 Next: your tags get persisted to your database, so let's import and run the migrations to get the tables set up:
 
@@ -21,6 +21,12 @@ Next: your tags get persisted to your database, so let's import and run the migr
 
 ## Upgrading
 
+### 0.6.0
+
+Rails 4.2 is supported as of Gutentag 0.6.0 - but please note that due to internal changes in ActiveRecord, changes to tag_names will no longer be tracked by your model's dirty state. This feature will continue to work in Rails 3.2 through to 4.1 though.
+
+### 0.5.0
+
 Between 0.4.0 and 0.5.0, Gutentag switched table names from `tags` and `taggings` to `gutentag_tags` and `gutentag_taggings`. This has been done to avoid conflicting with the more generic table names that may exist in Rails apps already.
 
 If you were using Gutentag 0.4.0 (or older) and now want to upgrade, you'll need to create a migration manually that renames these tables:
@@ -53,4 +59,4 @@ Changes to tag_names are not persisted immediately - you must save your taggable
 
 ## Licence
 
-Copyright (c) 2013, Gutentag is developed and maintained by Pat Allan, and is released under the open MIT Licence.
+Copyright (c) 2013-2015, Gutentag is developed and maintained by Pat Allan, and is released under the open MIT Licence.

data/db/migrate/1_gutentag_tables.rb

@@ -4,7 +4,7 @@ class GutentagTables < ActiveRecord::Migration
       t.integer :tag_id,        :null => false
       t.integer :taggable_id,   :null => false
       t.string  :taggable_type, :null => false
-      t.timestamps
+      t.timestamps :null => false
     end
 
     add_index :gutentag_taggings, :tag_id
@@ -14,7 +14,7 @@ class GutentagTables < ActiveRecord::Migration
 
     create_table :gutentag_tags do |t|
       t.string :name, :null => false
-      t.timestamps
+      t.timestamps :null => false
     end
 
     add_index :gutentag_tags, :name, :unique => true

data/gemfiles/rails_3_2.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 3.2.21"
+
+gemspec :path => "../"

data/gemfiles/rails_4_0.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 4.0.12"
+
+gemspec :path => "../"

data/gemfiles/rails_4_1.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 4.1.8"
+
+gemspec :path => "../"

data/gemfiles/rails_4_2.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 4.2.0"
+
+gemspec :path => "../"

data/gutentag.gemspec

@@ -1,7 +1,7 @@
 # -*- encoding: utf-8 -*-
 Gem::Specification.new do |s|
   s.name        = 'gutentag'
-  s.version     = '0.5.1'
+  s.version     = '0.6.0'
   s.authors     = ['Pat Allan']
   s.email       = ['pat@freelancing-gods.com']
   s.homepage    = 'https://github.com/pat/gutentag'
@@ -14,7 +14,8 @@ Gem::Specification.new do |s|
   s.require_paths = ['lib']
 
   s.add_runtime_dependency     'activerecord', '>= 3.2.0'
+  s.add_runtime_dependency     'appraisal',    '~> 1.0.2'
   s.add_development_dependency 'combustion',   '0.5.1'
-  s.add_development_dependency 'rspec-rails',  '~> 2.13'
+  s.add_development_dependency 'rspec-rails',  '~> 3.1'
   s.add_development_dependency 'sqlite3',      '~> 1.3.7'
 end

data/lib/gutentag.rb

@@ -1,4 +1,14 @@
+require 'active_record/version'
+
 module Gutentag
+  def self.dirtier
+    @dirtier
+  end
+
+  def self.dirtier=(dirtier)
+    @dirtier = dirtier
+  end
+
   def self.normaliser
     @normaliser ||= Gutentag::TagName
   end
@@ -13,3 +23,9 @@ require 'gutentag/dirty'
 require 'gutentag/engine'
 require 'gutentag/persistence'
 require 'gutentag/tag_name'
+
+if ActiveRecord::VERSION::MAJOR == 3
+  Gutentag.dirtier = Gutentag::Dirty
+elsif ActiveRecord::VERSION::MAJOR == 4 && ActiveRecord::VERSION::MINOR < 2
+  Gutentag.dirtier = Gutentag::Dirty
+end

data/lib/gutentag/active_record.rb

@@ -19,11 +19,11 @@ module Gutentag::ActiveRecord
   end
 
   def tag_names
-    @tag_names ||= tags.collect(&:name)
+    @tag_names ||= tags.pluck(:name)
   end
 
   def tag_names=(names)
-    Gutentag::Dirty.call self, names
+    Gutentag.dirtier.call self, names if Gutentag.dirtier
 
     @tag_names = names
   end

data/spec/acceptance/tag_names_spec.rb

@@ -26,7 +26,7 @@ describe "Managing tags via names" do
 
     expect(article.changed_attributes.stringify_keys).
       to eq('tag_names' => ['melbourne'])
-  end
+  end if Gutentag.dirtier
 
   it "does not make model dirty when changing through tag_names" do
     article.tag_names << 'melbourne'

data/spec/internal/db/schema.rb

@@ -1,6 +1,6 @@
 ActiveRecord::Schema.define do
   create_table :articles, :force => true do |t|
-    t.string  :title
-    t.timestamps
+    t.string :title
+    t.timestamps :null => false
   end
 end

data/spec/models/gutentag/tag_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Gutentag::Tag do
+describe Gutentag::Tag, :type => :model do
   describe '.find_by_name' do
     it "returns a tag with the same name" do
       existing = Gutentag::Tag.create! :name => 'pancakes'

data/spec/models/gutentag/tagging_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Gutentag::Tagging do
+describe Gutentag::Tagging, :type => :model do
   describe '#valid?' do
     let(:tag)      { Gutentag::Tag.create! :name => 'pancakes' }
     let(:taggable) { Article.create! }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gutentag
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.6.0
 platform: ruby
 authors:
 - Pat Allan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-29 00:00:00.000000000 Z
+date: 2015-01-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -24,6 +24,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.0
+- !ruby/object:Gem::Dependency
+  name: appraisal
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.0.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.0.2
 - !ruby/object:Gem::Dependency
   name: combustion
   requirement: !ruby/object:Gem::Requirement
@@ -44,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.13'
+        version: '3.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.13'
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -75,6 +89,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".travis.yml"
+- Appraisals
 - Gemfile
 - LICENCE
 - README.md
@@ -84,6 +99,10 @@ files:
 - db/migrate/1_gutentag_tables.rb
 - db/migrate/2_gutentag_cache_counter.rb
 - db/migrate/3_no_null_counters.rb
+- gemfiles/rails_3_2.gemfile
+- gemfiles/rails_4_0.gemfile
+- gemfiles/rails_4_1.gemfile
+- gemfiles/rails_4_2.gemfile
 - gutentag.gemspec
 - lib/gutentag.rb
 - lib/gutentag/active_record.rb
@@ -121,7 +140,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.3.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Good Tags