guideline 0.0.2 → 0.0.3

data/lib/guideline/checkers/hard_tab_indent_checker.rb

@@ -0,0 +1,15 @@
+module Guideline
+  class HardTabIndentChecker < Checker
+    def check(path)
+      path.each_line.with_index do |line, index|
+        if line =~ /^ *\t/
+          add_error(
+            :message => "Use space indent instead of hard tab indent",
+            :path    => path,
+            :line    => index + 1
+          )
+        end
+      end
+    end
+  end
+end

data/lib/guideline/version.rb

@@ -1,3 +1,3 @@
 module Guideline
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/lib/guideline.rb

@@ -1,6 +1,7 @@
 require "guideline/version"
 require "guideline/visitor"
 require "guideline/error"
-require "guideline/checker"
-require "guideline/checker/long_line_checker"
-require "guideline/checker/long_method_checker"
+require "guideline/checkers/checker"
+require "guideline/checkers/long_line_checker"
+require "guideline/checkers/long_method_checker"
+require "guideline/checkers/hard_tab_indent_checker"

data/spec/guideline/checkers/hard_tab_indent_checker_spec.rb

@@ -0,0 +1,45 @@
+require "spec_helper"
+
+module Guideline
+  describe HardTabIndentChecker do
+    describe "#check" do
+      let(:checker) do
+        described_class.new
+      end
+
+      let(:path) do
+        mock(:each_line => content.each_line)
+      end
+
+      context "when there is hard tab indent" do
+        let(:content) do
+          <<-EOF
+            def foo
+            \t1
+            end
+          EOF
+        end
+
+        specify "checker detects error" do
+          checker.check(path)
+          checker.should have_error
+        end
+      end
+
+      context "when there is no too long line" do
+        let(:content) do
+          <<-EOF
+            def foo
+              1
+            end
+          EOF
+        end
+
+        specify "checker does not detect error" do
+          checker.check(path)
+          checker.should_not have_error
+        end
+      end
+    end
+  end
+end

data/spec/guideline/checkers/long_line_checker_spec.rb

@@ -0,0 +1,45 @@
+require "spec_helper"
+
+module Guideline
+  describe LongLineChecker do
+    describe "#check" do
+      let(:checker) do
+        described_class.new(:max => 50)
+      end
+
+      let(:path) do
+        mock(:each_line => content.each_line)
+      end
+
+      context "when there is too line" do
+        let(:content) do
+          <<-EOF
+            def foo
+              too looooooooooooooooooooooooooooooooooooooooooooooooooooong line
+            end
+          EOF
+        end
+
+        specify "checker detects error" do
+          checker.check(path)
+          checker.should have_error
+        end
+      end
+
+      context "when there is no too long line" do
+        let(:content) do
+          <<-EOF
+            def foo
+              not long line
+            end
+          EOF
+        end
+
+        specify "checker does not detect error" do
+          checker.check(path)
+          checker.should_not have_error
+        end
+      end
+    end
+  end
+end

data/spec/guideline/checkers/long_method_checker_spec.rb

@@ -0,0 +1,46 @@
+require "spec_helper"
+
+module Guideline
+  describe LongMethodChecker do
+    describe "#check" do
+      let(:checker) do
+        described_class.new(:max => 1)
+      end
+
+      let(:path) do
+        mock(:read => content)
+      end
+
+      context "when there is too long method" do
+        let(:content) do
+          <<-EOF
+            def foo
+              1
+              2
+            end
+          EOF
+        end
+
+        specify "checker detects error" do
+          checker.check(path)
+          checker.should have_error
+        end
+      end
+
+      context "when there is no too long method" do
+        let(:content) do
+          <<-EOF
+            def foo
+              1
+            end
+          EOF
+        end
+
+        specify "checker does not detect error" do
+          checker.check(path)
+          checker.should_not have_error
+        end
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: guideline
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -91,14 +91,17 @@ files:
 - examples/long_method_checker.rb
 - guideline.gemspec
 - lib/guideline.rb
-- lib/guideline/checker.rb
-- lib/guideline/checker/long_line_checker.rb
-- lib/guideline/checker/long_method_checker.rb
+- lib/guideline/checkers/checker.rb
+- lib/guideline/checkers/hard_tab_indent_checker.rb
+- lib/guideline/checkers/long_line_checker.rb
+- lib/guideline/checkers/long_method_checker.rb
 - lib/guideline/error.rb
 - lib/guideline/version.rb
 - lib/guideline/visitor.rb
-- spec/guideline/checker/long_line_checker_spec.rb
-- spec/guideline/checker_spec.rb
+- spec/guideline/checkers/checker_spec.rb
+- spec/guideline/checkers/hard_tab_indent_checker_spec.rb
+- spec/guideline/checkers/long_line_checker_spec.rb
+- spec/guideline/checkers/long_method_checker_spec.rb
 - spec/guideline/visitor_spec.rb
 - spec/guideline_spec.rb
 - spec/spec_helper.rb
@@ -127,8 +130,10 @@ signing_key:
 specification_version: 3
 summary: The guideline of your code
 test_files:
-- spec/guideline/checker/long_line_checker_spec.rb
-- spec/guideline/checker_spec.rb
+- spec/guideline/checkers/checker_spec.rb
+- spec/guideline/checkers/hard_tab_indent_checker_spec.rb
+- spec/guideline/checkers/long_line_checker_spec.rb
+- spec/guideline/checkers/long_method_checker_spec.rb
 - spec/guideline/visitor_spec.rb
 - spec/guideline_spec.rb
 - spec/spec_helper.rb

data/spec/guideline/checker/long_line_checker_spec.rb

@@ -1,28 +0,0 @@
-require "spec_helper"
-
-module Guideline
-  describe LongLineChecker do
-    describe "#check" do
-      subject do
-        checker.check(path)
-      end
-
-      let(:checker) do
-        described_class.new(:max => 1)
-      end
-
-      let(:path) do
-        Pathname.new(__FILE__)
-      end
-
-      it do
-        should be_a Array
-      end
-
-      it do
-        subject
-        checker.should have_error
-      end
-    end
-  end
-end