guevara 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c0ba03d076780de6b75d3ad0fb3a95936a56596d
-  data.tar.gz: e7512da4cb5436b863fe87e41f73a35bb9b9581b
+  metadata.gz: f58362850aca1d07cc5f908b70c4ce191bb980e3
+  data.tar.gz: 09f73431c56f52808db6216c6a91b44318916139
 SHA512:
-  metadata.gz: f80fbd6d4f56d080d024e8ecd7131f9e782d2c231ef388755006fbadd977f9db869a09c9034604e2fd56539df5553a6dee916c2f3279a003ec1430fdecac86fe
-  data.tar.gz: 8901eadeb421a1bbd6bde04f78ebc16580c4181a4631812885b52cb5abacde7e9334686197354eabb13773655651a203d9e73c431b9b6ed6d7b1a65c202cde8c
+  metadata.gz: f9cf60939fd3f0ee3a4fd53945137011b434b1eb564f2af54967957d6639dac13ec4d916ff0cb0fd20ce90ed65c9217fb65b9d6c471d16988970f10a027e9327
+  data.tar.gz: 8762e796e63f6c1716b41ca44e4630fccee4fdff91e95e0a500e224549dfa285a4b18f31830a28e64fb9912c597fbfb124f1b37f00214376b5770783ea50074e

data/lib/guevara/batch.rb

@@ -9,8 +9,8 @@ module Guevara
 
     attr_reader :transactions, :attributes
 
-    def initialize(transactions, attributes)
-      @transactions = transactions
+    def initialize(attributes)
+      @transactions = attributes.delete(:transactions)
       @attributes   = attributes
     end
 
@@ -27,8 +27,7 @@ module Guevara
     end
 
     def batch_header
-      header_attributes = { effective_date: effective_date }.merge(attributes)
-      BatchHeader.new header_attributes
+      BatchHeader.new attributes
     end
 
     def batch_control
@@ -56,10 +55,6 @@ module Guevara
         modulo(1_000_000_000_000)
     end
 
-    def effective_date
-      transactions.first[:effective_date]
-    end
-
     def entry transaction, index
       entry_attributes = transaction.merge(number: index + 1,
                                            origin_id: attributes[:origin_id])

data/lib/guevara/file_header.rb

@@ -16,8 +16,8 @@ module Guevara
     def fields
       ["1",
        "%<priority_code>02d",
-       "%<destination_id>010d",
-       "%<origin_id>010d",
+       " %<destination_id>09d",
+       " %<origin_id>09d",
        "%<created_at>10.10s",
        "%<id>1.1s",
        "094", # record size is fixed

data/lib/guevara/nacha.rb

@@ -14,9 +14,8 @@ module Guevara
 
     def batches= batches
       @batches = batches.each_with_index.map do |batch_attributes, index|
-        transactions = batch_attributes.delete(:transactions)
         batch_attributes[:number] = index + 1
-        Batch.new(transactions, batch_attributes)
+        Batch.new(batch_attributes)
       end
     end
 
@@ -42,7 +41,7 @@ module Guevara
       entry_count = total { |b| b.batch_control.attributes[:entry_count] }
       block_count = entry_count + batches.size * 2 + 2
       FileControl.new(
-        batch_count:  batches.size,
+        batch_count:  batches.count,
         block_count:  block_count,
         entry_count:  entry_count,
         entry_hash:   total { |b| b.batch_control.attributes[:entry_hash] },

data/lib/guevara/version.rb

@@ -1,3 +1,3 @@
 module Guevara
-  VERSION = "0.0.1"
+  VERSION = "0.1.0"
 end

data/test/helper.rb

@@ -6,10 +6,7 @@ def sample_transaction
     id:               'FD00AFA8A0F7',
     type:             'debit',
     amount:           1600,
-    effective_date:   '2014-09-21',
     name:             'marge baker',
-    first_name:       'marge',
-    last_name:        'baker',
     additional_info:  'wellsville|KS|66092|101 2nd st|',
     telephone:        '5858232966',
     account_type:     'checking',
@@ -18,6 +15,35 @@ def sample_transaction
   }
 end
 
+def lines(nacha)
+  nacha.to_s.lines.to_a
+end
+
+def sample_batch
+  {
+    service_class:  '200',
+    company_name:   'rubylit',
+    company_id:     'Ruby123',
+    company_date:   '2014-09-18',
+    origin_id:      '12345678',
+    effective_date: '2014-09-21',
+    transactions:   [ sample_transaction ]
+  }
+end
+
+def sample_nacha
+  {
+    priority_code:    01,
+    destination_id:   '12345678',
+    origin_id:        '12345678',
+    created_at:       '2014-11-28T13:30',
+    id:               'A',
+    destination_name: 'Rubylit',
+    origin_name:      'Zest',
+    batches:          [ sample_batch ]
+  }
+end
+
 def debugger_equal value, other
   flunk <<DEBUG unless value == other
 Output is not as Expected

data/test/test_batch_generation.rb

@@ -2,13 +2,7 @@ require_relative 'helper.rb'
 require_relative '../lib/guevara/batch'
 
 setup do
-  Guevara::Batch.new [ sample_transaction ],
-    service_class:  '200',
-    company_name:   'rubylit',
-    company_id:     'Ruby123',
-    company_date:   '2014-09-18',
-    origin_id:      '12345678',
-    number:         1
+  Guevara::Batch.new sample_batch.merge(:number => 1)
 end
 
 test 'generates the batch' do |batch|

data/test/test_file_generation.rb

@@ -1,43 +1,9 @@
 require_relative 'helper.rb'
 require 'guevara'
 
-test 'generates the batch' do |batch|
-
-  transaction = {
-    id:               'FD00AFA8A0F7',
-    type:             'debit',
-    amount:           1600,
-    name:             'marge baker',
-    additional_info:  'wellsville|KS|66092|101 2nd st|',
-    telephone:        '5858232966',
-    account_type:     'checking',
-    routing_number:   103100195,
-    account_number:   '3ACCOUNT234'
-  }
-
-  batch = {
-    service_class:  '200',
-    company_name:   'rubylit',
-    company_id:     'Ruby123',
-    company_date:   '2014-09-18',
-    origin_id:      '12345678',
-    effective_date: '2014-09-21',
-    transactions:   [ transaction ]
-  }
-
-  nacha = Guevara::Nacha.new(
-    priority_code:    01,
-    destination_id:   '12345678',
-    origin_id:        '12345678',
-    created_at:       '2014-11-28T13:30',
-    id:               'A',
-    destination_name: 'Rubylit',
-    origin_name:      'Zest',
-    batches:          [ batch ]
-  )
-
+test 'generates nacha sample file' do |batch|
   expected = <<NACHA
-101001234567800123456781411281330A094101                Rubylit                   Zest       0
+101 012345678 0123456781411281330A094101                Rubylit                   Zest       0
 5200rubylit                                Ruby123PPD          140918140921   1123456780000001
 6271031001953ACCOUNT234      0000001600FD00AFA8A0F7   marge baker             1123456780000001
 705wellsville|KS|66092|101 2nd st|                                                 00010000001
@@ -45,8 +11,26 @@ test 'generates the batch' do |batch|
 9000001000006000000020010310019000000001600000000000000                                       
 NACHA
 
+  nacha = Guevara::Nacha.new sample_nacha
+
   nacha.to_s.lines.to_a.each_with_index do |line, index|
     debugger_equal line, expected.lines.to_a[index]
   end
+end
+
+test 'file control row gets the number of batches' do
+  nacha_attributes = sample_nacha.merge(:batches => [sample_batch, sample_batch])
+  nacha = Guevara::Nacha.new nacha_attributes
+
+  assert_equal lines(nacha).last[1,6].to_i, 2
+end
+
+test 'all the batches are added to the file' do
+  batches = 5.times.map do
+    sample_batch
+  end
+  nacha_attributes = sample_nacha.merge(:batches => batches)
 
+  nacha = Guevara::Nacha.new nacha_attributes
+  assert lines(nacha).size > 10
 end

data/test/test_file_header.rb

@@ -15,7 +15,6 @@ end
 
 test 'generates a full file' do |header|
   debugger_equal header.to_s, <<NACHA
-101001234567800123456781411281330A094101                Rubylit                   Zest       0
+101 012345678 0123456781411281330A094101                Rubylit                   Zest       0
 NACHA
 end
-

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: guevara
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Gaston Ramos