guard-rubocop 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b0043258943e6ce7804f19377ee96f8cb4fbe231
-  data.tar.gz: 63e9ca25fb5011528c2e86df4b1a98eccfda5e4a
+  metadata.gz: 7ee264c2bba19588cd6ec3f4c4cce81a1138d74c
+  data.tar.gz: 9b615077842cffb9ac97de41fa79f3904fa42a5e
 SHA512:
-  metadata.gz: 292b240599d027edd2125021b55212ae4f0291eaa7d897a4489d2cf8d338c8bb372480a344cc2e468e2f09a2ff941530921a1db8d9e6b66c681c2c30abe3f121
-  data.tar.gz: 052a46d2a3f6e4a2ba5abb368e0ff6cc91d3cad56bdb21d9e8de14f57a26106420833544c7fd204e7b943143f44c0ea4a242c30e38dfe1005506531be1b9af89
+  metadata.gz: 0f501120bc69f42e6be7edae56133788ec314560d31f275f7c41e00be536a61235078a13ee2ab8c016bfe641149a90393e77b75f535add608f6092e4cc3295c9
+  data.tar.gz: dec761efcec40969296561f2606ec5e81e3fc2e48807bda3cdda3eac31668cab7cc5082588914851bc2dc78c444567717cfd554a1d075ba346ac9179a70dbbef

data/Gemfile

@@ -2,12 +2,8 @@ source 'https://rubygems.org'
 
 gemspec
 
-# Travis CI
 group :test do
   gem 'coveralls'
-end
-
-# Jenkins
-group :ci do
   gem 'simplecov-rcov', '~> 0.2'
+  gem 'ci_reporter',    '~> 1.8'
 end

data/README.md

@@ -1,5 +1,4 @@
-# Guard::Rubocop [![Build Status](https://travis-ci.org/yujinakayama/guard-rubocop.png?branch=master)](https://travis-ci.org/yujinakayama/guard-rubocop) [![Coverage Status](https://coveralls.io/repos/yujinakayama/guard-rubocop/badge.png?branch=master)](https://coveralls.io/r/yujinakayama/guard-rubocop) [![Dependency Status](https://gemnasium.com/yujinakayama/guard-rubocop.png)](https://gemnasium.com/yujinakayama/guard-rubocop) [![Code Climate](https://codeclimate.com/github/yujinakayama/guard-rubocop.png)](https://codeclimate.com/github/yujinakayama/guard-rubocop)
-
+# Guard::Rubocop [![Gem Version](https://badge.fury.io/rb/guard-rubocop.png)](http://badge.fury.io/rb/guard-rubocop) [![Dependency Status](https://gemnasium.com/yujinakayama/guard-rubocop.png)](https://gemnasium.com/yujinakayama/guard-rubocop) [![Build Status](https://travis-ci.org/yujinakayama/guard-rubocop.png?branch=master)](https://travis-ci.org/yujinakayama/guard-rubocop) [![Coverage Status](https://coveralls.io/repos/yujinakayama/guard-rubocop/badge.png?branch=master)](https://coveralls.io/r/yujinakayama/guard-rubocop) [![Code Climate](https://codeclimate.com/github/yujinakayama/guard-rubocop.png)](https://codeclimate.com/github/yujinakayama/guard-rubocop)
 
 Guard::Rubocop allows you to automatically check Ruby code style with [RuboCop](https://github.com/bbatsov/rubocop) when files are modified.
 

data/Rakefile

@@ -1 +1,18 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new(:spec)
+
+namespace :ci do
+  task :spec do
+    ENV['CI'] = 'true'
+
+    ENV['CI_REPORTS'] = 'spec/reports'
+    require 'ci/reporter/rake/rspec'
+    Rake::Task['ci:setup:rspec'].invoke
+
+    Rake::Task['spec'].invoke
+  end
+end
+
+task :default => :spec

data/lib/guard/rubocop.rb

@@ -6,9 +6,7 @@ require 'guard/notifier'
 
 module Guard
   class Rubocop < Guard
-    # rubocop:disable SymbolSnakeCase
-    autoload :Runner, 'guard/rubocop/runner'
-    # rubocop:enable SymbolSnakeCase
+    autoload :Runner, 'guard/rubocop/runner' # rubocop:disable SymbolSnakeCase
 
     attr_reader :options, :failed_paths
 
@@ -40,8 +38,7 @@ module Guard
 
     def run_on_changes(paths)
       paths += @failed_paths if @options[:keep_failed]
-      paths.map! { |path| File.expand_path(path) }
-      paths.uniq!
+      paths = clean_paths(paths)
 
       UI.info "Checking Ruby code styles: #{paths.join(' ')}"
 

data/lib/guard/rubocop/runner.rb

@@ -40,20 +40,10 @@ module Guard
 
         process.start
 
-        ios = [stdout_reader]
         output = ''
 
         loop do
-          available_ios, = IO.select(ios, nil, nil, MINIMUM_POLL_INTERVAL)
-
-          if available_ios
-            available_ios.each do |io|
-              chunk = io.read_available_nonblock
-              $stdout.write chunk
-              output << chunk
-            end
-          end
-
+          output << capture_and_print_output(stdout_reader)
           break if process.exited?
         end
 
@@ -62,7 +52,7 @@ module Guard
 
       def notify
         image = passed ? :success : :failed
-        Notifier.notify(summary, title: 'Rubocop results', image: image)
+        Notifier.notify(summary, title: 'RuboCop results', image: image)
       end
 
       def summary
@@ -75,6 +65,16 @@ module Guard
         output.scan(/^== (.+) ==$/).flatten
       end
 
+      private
+
+      def capture_and_print_output(output)
+        available_ios, = IO.select([output], nil, nil, MINIMUM_POLL_INTERVAL)
+        return '' unless available_ios
+        chunk = available_ios.first.read_available_nonblock
+        $stdout.write chunk
+        chunk
+      end
+
       class IO < ::IO
         READ_CHUNK_SIZE = 10000
 

data/lib/guard/rubocop/version.rb

@@ -7,7 +7,7 @@ module Guard
     # http://semver.org/
     MAJOR = 0
     MINOR = 0
-    PATCH = 1
+    PATCH = 2
     VERSION = [MAJOR, MINOR, PATCH].join('.')
   end
 end

data/spec/guard/rubocop/runner_spec.rb

@@ -128,7 +128,7 @@ describe Guard::Rubocop::Runner, :silence_output do
     end
   end
 
-  shared_context 'stubbed output', stubbed_output: true do
+  shared_context 'stubbed output', :stubbed_output do
     before do
       runner.stub(:output) do
 <<OUTPUT
@@ -143,7 +143,7 @@ OUTPUT
     end
   end
 
-  describe '#notify', stubbed_output: true do
+  describe '#notify', :stubbed_output do
     it 'notifies summary' do
       Guard::Notifier.should_receive(:notify) do |message, options|
         message.should == '7 files inspected, 2 offences detected'
@@ -151,9 +151,9 @@ OUTPUT
       runner.notify
     end
 
-    it 'notifies with title "Rubocop results"' do
+    it 'notifies with title "RuboCop results"' do
       Guard::Notifier.should_receive(:notify) do |message, options|
-        options[:title].should == 'Rubocop results'
+        options[:title].should == 'RuboCop results'
       end
       runner.notify
     end
@@ -185,7 +185,7 @@ OUTPUT
     end
   end
 
-  describe '#summary', stubbed_output: true do
+  describe '#summary', :stubbed_output do
     subject { super().summary }
 
     it 'returns summary line of output' do
@@ -193,7 +193,7 @@ OUTPUT
     end
   end
 
-  describe '#failed_paths', stubbed_output: true do
+  describe '#failed_paths', :stubbed_output do
     subject { super().failed_paths }
 
     it 'returns failed file paths as array' do

data/spec/guard/rubocop_spec.rb

@@ -2,193 +2,191 @@
 
 require 'spec_helper.rb'
 
-module Guard
-  describe Rubocop, :silence_output do
-    subject(:guard) { Rubocop.new(watchers, options) }
-    let(:watchers) { [] }
-    let(:options) { {} }
-
-    let(:runner) { Rubocop::Runner.any_instance }
-
-    describe '#options' do
-      subject { super().options }
-
-      context 'by default' do
-        let(:options) { {} }
-        its([:all_on_start]) { should be_true }
-        its([:keep_failed])  { should be_true }
-        its([:notification]) { should == :failed }
-      end
-    end
+describe Guard::Rubocop, :silence_output do
+  subject(:guard) { Guard::Rubocop.new(watchers, options) }
+  let(:watchers) { [] }
+  let(:options) { {} }
 
-    describe '#start' do
-      context 'when :all_on_start option is enabled' do
-        let(:options) { { all_on_start: true } }
-
-        it 'runs all' do
-          guard.should_receive(:run_all)
-          guard.start
-        end
-      end
+  let(:runner) { Guard::Rubocop::Runner.any_instance }
 
-      context 'when :all_on_start option is disabled' do
-        let(:options) { { all_on_start: false } }
+  describe '#options' do
+    subject { super().options }
 
-        it 'does nothing' do
-          guard.should_not_receive(:run_all)
-          guard.start
-        end
-      end
+    context 'by default' do
+      let(:options) { {} }
+      its([:all_on_start]) { should be_true }
+      its([:keep_failed])  { should be_true }
+      its([:notification]) { should == :failed }
     end
+  end
 
-    shared_examples 'processes after running', :processes_after_running do
-      context 'when passed' do
-        it 'throws nothing' do
-          runner.stub(:run).and_return(true)
-          expect { subject }.not_to throw_symbol
-        end
+  describe '#start' do
+    context 'when :all_on_start option is enabled' do
+      let(:options) { { all_on_start: true } }
 
-        it 'clears failed paths' do
-          runner.stub(:run).and_return(true)
-          runner.stub(:failed_paths).and_return([])
-          subject
-          guard.failed_paths.should be_empty
-        end
+      it 'runs all' do
+        guard.should_receive(:run_all)
+        guard.start
       end
+    end
 
-      context 'when failed' do
-        it 'throws symbol :task_has_failed' do
-          runner.stub(:run).and_return(false)
-          expect { subject }.to throw_symbol(:task_has_failed)
-        end
+    context 'when :all_on_start option is disabled' do
+      let(:options) { { all_on_start: false } }
 
-        it 'keeps failed paths' do
-          guard.stub(:throw)
-          failed_paths = [
-            'some_failed_file.rb',
-            'dir/another_failed_file.rb'
-          ]
-          runner.stub(:run).and_return(false)
-          runner.stub(:failed_paths).and_return(failed_paths)
-          subject
-          guard.failed_paths.should == failed_paths
-        end
+      it 'does nothing' do
+        guard.should_not_receive(:run_all)
+        guard.start
       end
     end
+  end
 
-    describe '#run_all', :processes_after_running do
-      subject { super().run_all }
-
-      before do
+  shared_examples 'processes after running', :processes_after_running do
+    context 'when passed' do
+      it 'throws nothing' do
         runner.stub(:run).and_return(true)
+        expect { subject }.not_to throw_symbol
       end
 
-      it 'inspects all files with rubocop' do
-        runner.should_receive(:run).with(no_args)
-        guard.run_all
+      it 'clears failed paths' do
+        runner.stub(:run).and_return(true)
+        runner.stub(:failed_paths).and_return([])
+        subject
+        guard.failed_paths.should be_empty
       end
     end
 
-    describe '#run_on_changes', :processes_after_running do
-      subject { super().run_on_changes(changed_paths) }
-      let(:changed_paths) { ['some.rb', 'dir/another.rb', 'dir/../some.rb'] }
-
-      before do
-        runner.stub(:run).and_return(true)
+    context 'when failed' do
+      it 'throws symbol :task_has_failed' do
+        runner.stub(:run).and_return(false)
+        expect { subject }.to throw_symbol(:task_has_failed)
       end
 
-      it 'inspects changed files with rubocop' do
-        runner.should_receive(:run)
-        guard.run_on_changes(changed_paths)
+      it 'keeps failed paths' do
+        guard.stub(:throw)
+        failed_paths = [
+          'some_failed_file.rb',
+          'dir/another_failed_file.rb'
+        ]
+        runner.stub(:run).and_return(false)
+        runner.stub(:failed_paths).and_return(failed_paths)
+        subject
+        guard.failed_paths.should == failed_paths
       end
+    end
+  end
 
-      it 'passes cleaned paths to rubocop' do
-        runner.should_receive(:run) do |paths|
-          paths.should == [
-            File.expand_path('some.rb'),
-            File.expand_path('dir/another.rb')
-          ]
-        end
-        guard.run_on_changes(changed_paths)
-      end
+  describe '#run_all', :processes_after_running do
+    subject { super().run_all }
 
-      let(:failed_path) { File.expand_path('failed_file_last_time.rb') }
+    before do
+      runner.stub(:run).and_return(true)
+    end
 
-      context 'when :keep_failed option is enabled' do
-        let(:options) { { keep_failed: true } }
+    it 'inspects all files with rubocop' do
+      runner.should_receive(:run).with(no_args)
+      guard.run_all
+    end
+  end
 
-        it 'also inspects paths which are failed last time' do
-          guard.failed_paths << failed_path
-          runner.should_receive(:run) do |paths|
-            paths.should include failed_path
-          end
-          guard.run_on_changes(changed_paths)
-        end
-      end
+  describe '#run_on_changes', :processes_after_running do
+    subject { super().run_on_changes(changed_paths) }
+    let(:changed_paths) { ['some.rb', 'dir/another.rb', 'dir/../some.rb'] }
 
-      context 'when :keep_failed option is disabled' do
-        let(:options) { { keep_failed: false } }
-        let(:changed_paths) do
-          [
-            File.expand_path('some.rb'),
-            File.expand_path('dir/another.rb')
-          ]
-        end
+    before do
+      runner.stub(:run).and_return(true)
+    end
 
-        it 'inspects just changed paths' do
-          guard.failed_paths << failed_path
-          runner.should_receive(:run) do |paths|
-            paths.should == changed_paths
-          end
-          guard.run_on_changes(changed_paths)
-        end
-      end
+    it 'inspects changed files with rubocop' do
+      runner.should_receive(:run)
+      guard.run_on_changes(changed_paths)
     end
 
-    describe '#reload' do
-      it 'clears failed paths' do
-        guard.failed_paths << 'failed.rb'
-        guard.reload
-        guard.failed_paths.should be_empty
+    it 'passes cleaned paths to rubocop' do
+      runner.should_receive(:run) do |paths|
+        paths.should == [
+          File.expand_path('some.rb'),
+          File.expand_path('dir/another.rb')
+        ]
       end
+      guard.run_on_changes(changed_paths)
     end
 
-    describe '#clean_paths' do
-      it 'converts to absolute paths' do
-        paths = [
-          'lib/guard/rubocop.rb',
-          'spec/spec_helper.rb'
-        ]
-        guard.clean_paths(paths).should == [
-          File.expand_path('lib/guard/rubocop.rb'),
-          File.expand_path('spec/spec_helper.rb')
-        ]
+    let(:failed_path) { File.expand_path('failed_file_last_time.rb') }
+
+    context 'when :keep_failed option is enabled' do
+      let(:options) { { keep_failed: true } }
+
+      it 'also inspects paths which are failed last time' do
+        guard.failed_paths << failed_path
+        runner.should_receive(:run) do |paths|
+          paths.should include failed_path
+        end
+        guard.run_on_changes(changed_paths)
       end
+    end
 
-      it 'removes to duplicated paths' do
-        paths = [
-          'lib/guard/rubocop.rb',
-          'spec/spec_helper.rb',
-          'lib/guard/../guard/rubocop.rb'
-        ]
-        guard.clean_paths(paths).should == [
-          File.expand_path('lib/guard/rubocop.rb'),
-          File.expand_path('spec/spec_helper.rb')
+    context 'when :keep_failed option is disabled' do
+      let(:options) { { keep_failed: false } }
+      let(:changed_paths) do
+        [
+          File.expand_path('some.rb'),
+          File.expand_path('dir/another.rb')
         ]
       end
 
-      it 'removes paths which are included in another path' do
-        paths = [
-          'lib/guard/rubocop.rb',
-          'spec/spec_helper.rb',
-          'spec'
-        ]
-        guard.clean_paths(paths).should == [
-          File.expand_path('lib/guard/rubocop.rb'),
-          File.expand_path('spec')
-        ]
+      it 'inspects just changed paths' do
+        guard.failed_paths << failed_path
+        runner.should_receive(:run) do |paths|
+          paths.should == changed_paths
+        end
+        guard.run_on_changes(changed_paths)
       end
     end
+  end
+
+  describe '#reload' do
+    it 'clears failed paths' do
+      guard.failed_paths << 'failed.rb'
+      guard.reload
+      guard.failed_paths.should be_empty
+    end
+  end
+
+  describe '#clean_paths' do
+    it 'converts to absolute paths' do
+      paths = [
+        'lib/guard/rubocop.rb',
+        'spec/spec_helper.rb'
+      ]
+      guard.clean_paths(paths).should == [
+        File.expand_path('lib/guard/rubocop.rb'),
+        File.expand_path('spec/spec_helper.rb')
+      ]
+    end
 
+    it 'removes duplicated paths' do
+      paths = [
+        'lib/guard/rubocop.rb',
+        'spec/spec_helper.rb',
+        'lib/guard/../guard/rubocop.rb'
+      ]
+      guard.clean_paths(paths).should == [
+        File.expand_path('lib/guard/rubocop.rb'),
+        File.expand_path('spec/spec_helper.rb')
+      ]
+    end
+
+    it 'removes paths which are included in another path' do
+      paths = [
+        'lib/guard/rubocop.rb',
+        'spec/spec_helper.rb',
+        'spec'
+      ]
+      guard.clean_paths(paths).should == [
+        File.expand_path('lib/guard/rubocop.rb'),
+        File.expand_path('spec')
+      ]
+    end
   end
+
 end

data/spec/spec_helper.rb

@@ -1,27 +1,7 @@
 # coding: utf-8
 
-class NoExpectationExecutedError < StandardError
-end
-
 RSpec.configure do |config|
   config.treat_symbols_as_metadata_keys_with_true_values = true
-
-  # Original snippet by sorah
-  # https://gist.github.com/sorah/4315150
-  config.after do
-    result = self.example.metadata[:execution_result]
-
-    has_mock_expectations = !RSpec::Mocks.space.instance_eval do
-      receivers
-    end.empty?
-
-    next if result[:exception]
-    next if result[:pending_message]
-    next if RSpec::Matchers.last_should
-    next if has_mock_expectations
-
-    fail NoExpectationExecutedError
-  end
 end
 
 Dir[File.join(File.dirname(__FILE__), 'support', '*')].each do |path|
@@ -33,7 +13,7 @@ SimpleCov.coverage_dir(File.join('spec', 'coverage'))
 
 if ENV['TRAVIS']
   require 'coveralls'
-  Coveralls.wear!
+  SimpleCov.formatter = Coveralls::SimpleCov::Formatter
 elsif ENV['CI']
   require 'simplecov-rcov'
   SimpleCov.formatter = SimpleCov::Formatter::RcovFormatter

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: guard-rubocop
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Yuji Nakayama
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-20 00:00:00.000000000 Z
+date: 2013-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: guard
@@ -166,7 +166,6 @@ files:
 - README.md
 - Rakefile
 - guard-rubocop.gemspec
-- lib/guard/.rubocop.yml
 - lib/guard/rubocop.rb
 - lib/guard/rubocop/runner.rb
 - lib/guard/rubocop/templates/Guardfile
@@ -175,7 +174,6 @@ files:
 - spec/guard/rubocop/runner_spec.rb
 - spec/guard/rubocop_spec.rb
 - spec/spec_helper.rb
-- spec/support/.rubocop.yml
 - spec/support/capture_helper.rb
 - spec/support/silence_output.rb
 homepage: https://github.com/yujinakayama/guard-rubocop
@@ -207,6 +205,6 @@ test_files:
 - spec/guard/rubocop/runner_spec.rb
 - spec/guard/rubocop_spec.rb
 - spec/spec_helper.rb
-- spec/support/.rubocop.yml
 - spec/support/capture_helper.rb
 - spec/support/silence_output.rb
+has_rdoc: 

data/lib/guard/.rubocop.yml

@@ -1,4 +0,0 @@
-# A workaround for `autoload :Runner` in rubocop.rb
-# until comment based switch will be released
-SymbolSnakeCase:
-  Enabled: false

data/spec/support/.rubocop.yml

@@ -1,2 +0,0 @@
-Syntax:
-  Enabled: false