guard-rspec 4.6.0 → 4.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: da3d682ea54facc503739cd4d094710f204117da
-  data.tar.gz: 7222b1f22d4650eeb50b510e6ddd0b653d72c145
+  metadata.gz: d6f8f0ec11addb557bcea8e0b4e67b2f53bc9fc0
+  data.tar.gz: 72f89cda0c8952689eac3466d5450e458d3ecbde
 SHA512:
-  metadata.gz: 069b0a96a591b25139fff82402d4a48dff213ac9b4412ed570aad6ac92bae197808217786552b1b91785f91c0bb16e33c21bda3f7dacdfa33cd52439e3f3855f
-  data.tar.gz: d6d147aca928c4c5bc7c68f7b2cf40ee0eeeb8ff72ef63a5d1bb544b23ce401d6615f6ac039b51dfbd30840fc3c07c78f2eb54f818ae99e66f2f4fa5ebcec5ac
+  metadata.gz: f87137e2042acd5bd024d0d094c020411dc55c9b68c7edec9b87c8fb7f5238445af78f65e0041653137d6e6187e1f1d74b4eb13066b687129258a1d18dc5c934
+  data.tar.gz: 9d6b60cdb428ac5f33a0a8ebdc12d33f053bfb2184c6c56200d18cc48137aab79e28ce3fddf5ed2913efaca45c00249fa80e4f942c9a45569b8f5bec34ac1de3

data/README.md

@@ -109,6 +109,33 @@ guard :rspec, cmd: 'rspec -f html -o ./tmp/spec_results.html', launchy: './tmp/s
 end
 ```
 
+### Integration with Zeus
+
+First, know that Guard::Zeus also generates a Guardfile template with RSpec commands - if you prefer Guard::RSpec, you may want to keep Guard::Zeus, but without the RSpec running commands (so you can manage the Guard::Zeus server instead of running it manually).
+
+Second, since Guard::RSpec 4.6.x, the output file name is passed using environment variables - but Zeus doesn't pass these when rerunning tests, so you get this error: #334
+
+The workaround is to create a custom Zeus plan:
+
+1. `zeus init`
+2. edit `custom_plan.rb` to contain the following:
+
+```ruby
+require 'zeus/rails'
+
+class CustomPlan < Zeus::Rails
+  def test(*args)
+    ENV['GUARD_RSPEC_RESULTS_FILE'] = 'tmp/guard_rspec_results.txt' # Guard::RSpec::Runner::TEMPORARY_FILE_PATH
+    super
+  end
+end
+
+Zeus.plan = CustomPlan.new
+```
+
+And that's it. (I'd like things to work without this, but I don't know how.)
+
+
 ### Using parallel_tests
 
 parallel_tests has a `-o` option for passing RSpec options, and here's a trick to make it work with Guard::RSpec:

data/lib/guard/rspec/runner.rb

@@ -1,3 +1,5 @@
+require "guard/rspec_defaults"
+
 require "guard/rspec/inspectors/factory"
 require "guard/rspec/command"
 require "guard/rspec/notifier"
@@ -80,7 +82,7 @@ module Guard
       end
 
       def _results_file(results_file, chdir)
-        results_file ||= TEMPORARY_FILE_PATH
+        results_file ||= RSpecDefaults::TEMPORARY_FILE_PATH
         return results_file unless Pathname(results_file).relative?
         chdir ? File.join(chdir, results_file) : results_file
       end

data/lib/guard/rspec/version.rb

@@ -1,5 +1,5 @@
 module Guard
   module RSpecVersion
-    VERSION = "4.6.0"
+    VERSION = "4.6.1"
   end
 end

data/lib/guard/rspec_defaults.rb

@@ -0,0 +1,5 @@
+module Guard
+  class RSpecDefaults
+    TEMPORARY_FILE_PATH = "tmp/rspec_guard_result"
+  end
+end

data/lib/guard/rspec_formatter.rb

@@ -7,8 +7,16 @@ require "fileutils"
 require "rspec"
 require "rspec/core/formatters/base_formatter"
 
+require "guard/rspec_defaults"
+
 module Guard
   class RSpecFormatter < ::RSpec::Core::Formatters::BaseFormatter
+    WIKI_ENV_WARN_URL =
+      "https://github.com/guard/guard-rspec/wiki/Warning:-no-environment"
+
+    NO_ENV_WARNING_MSG = "no environment passed - see #{WIKI_ENV_WARN_URL}"
+    NO_RESULTS_VALUE_MSG = ":results_file value unknown (using defaults)"
+
     def self.rspec_3?
       ::RSpec::Core::Version::STRING.split(".").first == "3"
     end
@@ -110,7 +118,12 @@ module Guard
 
     def _results_file
       path = ENV["GUARD_RSPEC_RESULTS_FILE"]
-      fail "Fatal: No output file given for Guard::RSpec formatter!" unless path
+      if path.nil?
+        STDERR.puts "Guard::RSpec: Warning: #{NO_ENV_WARNING_MSG}\n" \
+          "Guard::RSpec: Warning: #{NO_RESULTS_VALUE_MSG}"
+        path = RSpecDefaults::TEMPORARY_FILE_PATH
+      end
+
       File.expand_path(path)
     end
   end

data/spec/lib/guard/rspec_formatter_spec.rb

@@ -86,6 +86,35 @@ RSpec.describe Guard::RSpecFormatter do
           end.to raise_error(TypeError, "foo")
         end
       end
+
+      context "when no env is passed" do
+        let(:file) { File.join(Dir.pwd, "tmp/rspec_guard_result") }
+
+        before do
+          ENV["GUARD_RSPEC_RESULTS_FILE"] = nil
+
+          allow(FileUtils).to receive(:mkdir_p).
+            with(File.dirname(file)) {}
+
+          allow(File).to receive(:open).
+            with(file, "w") do |_, _, &block|
+            block.call writer
+          end
+        end
+
+        it "warns" do
+          expect(STDERR).to receive(:puts).with(/no environment/)
+          formatter.dump_summary(*example_dump_summary_args)
+        end
+
+        it "uses default file" do
+          expect(File).to receive(:open).
+            with(file, "w") do |_, _, &block|
+            block.call writer
+          end
+          formatter.dump_summary(*example_dump_summary_args)
+        end
+      end
     end
 
     context "with failures" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: guard-rspec
 version: !ruby/object:Gem::Version
-  version: 4.6.0
+  version: 4.6.1
 platform: ruby
 authors:
 - Thibaud Guillaume-Gentil
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-26 00:00:00.000000000 Z
+date: 2015-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: guard
@@ -144,6 +144,7 @@ files:
 - lib/guard/rspec/runner.rb
 - lib/guard/rspec/templates/Guardfile
 - lib/guard/rspec/version.rb
+- lib/guard/rspec_defaults.rb
 - lib/guard/rspec_formatter.rb
 - spec/lib/guard/rspec/command_spec.rb
 - spec/lib/guard/rspec/deprecator_spec.rb
@@ -181,7 +182,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.7
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Guard gem for RSpec