guard-rspec 4.2.4 → 4.2.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 68ca1733c0e0f32c09688a1bc91d098a383c0dfc
-  data.tar.gz: 683059e58e8673b87957cc8d81a971916e617b0b
+  metadata.gz: a598c45db4e4390bae3972fa52d33fac7c89198d
+  data.tar.gz: f83033f5b8b6fb4c93014a0b49513b03f9680f8d
 SHA512:
-  metadata.gz: e2b2ccf857787b9a517d8ecc25c80f608c70b374aaa488f16b143945185450c828bc77c0ca9c2ffa5c98988979a5aa9c98f7f5bd00156f26dbeceb7d88f918e5
-  data.tar.gz: 2a388ad2d0d7679fbd4eb2ccbe2748d43eb7d617167d54ccafc65483c854df51f5e38c6a5f7496a9aca2e946a29c7a84aae3008f3095943d38dfd84a6169b255
+  metadata.gz: 16367f9c055934e7d9a22ada928d566b26755110e03064b41f4093789b0ed2a1fb3c21e265efd39c8c3f78de1df65dbabfc9720f1584baf32acaa5e66ff6b016
+  data.tar.gz: dbe619c50ec3df366100f9fea1f0c513d859e93a8e7564e9bcddd4b54a2b301347885b72713e7603ec7cbe104d1d64573c507776728555d9ed34075735a26beb

data/lib/guard/rspec/formatter.rb

@@ -4,7 +4,7 @@ require 'rspec/core/formatters/base_formatter'
 module Guard
   class RSpec
     class Formatter < ::RSpec::Core::Formatters::BaseFormatter
-      TEMPORARY_FILE_PATH = './tmp/rspec_guard_result'
+      TEMPORARY_FILE_PATH = File.expand_path('./tmp/rspec_guard_result')
 
       # rspec issue https://github.com/rspec/rspec-core/issues/793
       def self.extract_spec_location(metadata)
@@ -47,7 +47,7 @@ module Guard
       private
 
       def write(&block)
-        FileUtils.mkdir_p('tmp')
+        FileUtils.mkdir_p(File.dirname(TEMPORARY_FILE_PATH))
         File.open(TEMPORARY_FILE_PATH, 'w', &block)
       end
 

data/lib/guard/rspec/version.rb

@@ -1,5 +1,5 @@
 module Guard
   module RSpecVersion
-    VERSION = '4.2.4'
+    VERSION = '4.2.5'
   end
 end

data/spec/lib/guard/rspec/formatter_spec.rb

@@ -1,32 +1,48 @@
 require 'spec_helper.rb'
-
 require 'guard/rspec/formatter'
 
 describe Guard::RSpec::Formatter do
-  let(:writer){
-    StringIO.new
-  }
-  let(:formatter) {
-    Guard::RSpec::Formatter.new(StringIO.new).tap{|formatter|
-      formatter.stub(:write) do |&block|
-        block.call writer
-      end
-    }
-  }
+  describe '::TEMPORARY_FILE_PATH' do
+    it 'is absolute path' do
+      require 'pathname'
+      temporary_file_path = described_class.const_get(:TEMPORARY_FILE_PATH)
+      expect(Pathname.new(temporary_file_path).absolute?).to be_true
+    end
+  end
 
   describe '#dump_summary' do
-
-    let(:result){
+    let(:writer) {
+      StringIO.new
+    }
+    let(:formatter) {
+      Guard::RSpec::Formatter.new(StringIO.new).tap do |formatter|
+        formatter.stub(:write) do |&block|
+          block.call writer
+        end
+      end
+    }
+    let(:result) {
       writer.rewind
       writer.read
     }
 
+    context 'without stubbed IO' do
+      let(:formatter) {
+        Guard::RSpec::Formatter.new(StringIO.new)
+      }
+
+      it 'creates temporary file and and writes to it' do
+        temporary_file_path = described_class.const_get(:TEMPORARY_FILE_PATH)
+        expect(FileUtils).to receive(:mkdir_p).with(File.dirname(temporary_file_path)) {}
+        expect(File).to receive(:open).with(temporary_file_path, 'w') { |filename, mode, &block| block.call writer }
+        formatter.dump_summary(123, 1, 2, 3)
+      end
+    end
 
     context 'with failures' do
-      let(:spec_filename){
+      let(:spec_filename) {
         'failed_location_spec.rb'
       }
-
       let(:failed_example) { double(
         execution_result: { status: 'failed' },
         metadata: { location: spec_filename }
@@ -46,27 +62,32 @@ describe Guard::RSpec::Formatter do
 
     end
 
-    it "should find the spec file for shared examples" do
-      metadata = {:location => './spec/support/breadcrumbs.rb:75',
-                  :example_group => {:location => './spec/requests/breadcrumbs_spec.rb:218'}
-                 }
+    it 'should find the spec file for shared examples' do
+      metadata = {
+        location: './spec/support/breadcrumbs.rb:75',
+        example_group: { location: './spec/requests/breadcrumbs_spec.rb:218' }
+      }
 
       expect(described_class.extract_spec_location(metadata)).to start_with './spec/requests/breadcrumbs_spec.rb'
     end
 
-    it "should return only the spec file without line number for shared examples" do
-      metadata = {:location => './spec/support/breadcrumbs.rb:75',
-                  :example_group => {:location => './spec/requests/breadcrumbs_spec.rb:218'}
+    # Skip location because of rspec issue https://github.com/rspec/rspec-core/issues/1243
+    it 'should return only the spec file without line number for shared examples' do
+      metadata = {
+        location: './spec/support/breadcrumbs.rb:75',
+        example_group: { location: './spec/requests/breadcrumbs_spec.rb:218' }
       }
 
       expect(described_class.extract_spec_location(metadata)).to eq './spec/requests/breadcrumbs_spec.rb'
     end
 
-    it "should return location of the root spec when a shared examples has no location" do
-      metadata = {:location => './spec/support/breadcrumbs.rb:75',
-                  :example_group => {}
+    it 'should return location of the root spec when a shared examples has no location' do
+      metadata = {
+        location: './spec/support/breadcrumbs.rb:75',
+        example_group: {}
       }
 
+      expect(Guard::UI).to receive(:warning).with("no spec file found for #{metadata[:location]}") {}
       expect(described_class.extract_spec_location(metadata)).to eq metadata[:location]
     end
 
@@ -84,5 +105,4 @@ describe Guard::RSpec::Formatter do
       end
     end
   end
-
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: guard-rspec
 version: !ruby/object:Gem::Version
-  version: 4.2.4
+  version: 4.2.5
 platform: ruby
 authors:
 - Thibaud Guillaume-Gentil
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-09 00:00:00.000000000 Z
+date: 2014-01-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: guard