guard-reek 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3e14145294d2397904b31818eca863d6c8d0fc29
-  data.tar.gz: 83f8324385d5faf09c04205d38dcc281eb6564dc
+  metadata.gz: 2b2f9c07536b9de785e7d0e455756820f4d49cfa
+  data.tar.gz: 7e5006fbdef4fe4e1c66ac86fd7d0d369f0e1520
 SHA512:
-  metadata.gz: ed13bded7c1a6889fff97b47abf83b68afed9ba5e2acf795ea13759be9233bd17dfdb8943285a211c4a6eb9e308aeeba72c37a790bdca10e75a60ba677f32e06
-  data.tar.gz: f8ccbff9580d94599e85d772b6bd46762dcc82b869fda20243c2a9f12b1922d5ce4f448f3d9cdbb81cca49f11a1be5008267459e752a768de7f19ef93d3a25fe
+  metadata.gz: b2a585c094df8e9e40b353c5945a86d821f75ee5c8b080d98080b2088b82e969d523ca83fcfb09eb00c4c8e2ea7042a314a3b9ccfc2fca0e64dc76b4ced83ec2
+  data.tar.gz: ef18dd28416c02bd8f2cde852b60fac8e9c413e3d803f021185d027312da3d74af729a8debe1cf4556cad0dcd615f13764b6de34f3fa203d8fd5e4f2915ae002

data/.travis.yml

@@ -1,10 +1,14 @@
 language: ruby
+addons:
+  apt:
+    packages:
+      - haveged
 rvm:
-  - 2.1.9
-  - 2.2.5
-  - 2.3.1
+  - 2.1.10
+  - 2.2.7
+  - 2.3.4
   - jruby-9.0.5.0
-  - jruby-9.1.5.0
+  - jruby-9.1.12.0
 env:
   global:
     - RUBY_ENV=test

data/CHANGELOG.md

@@ -0,0 +1,5 @@
+# Change log
+
+## 1.2.0
+* `all` defaults to `*`
+* option to set `all` 

data/Guardfile

@@ -4,7 +4,7 @@ guard :rspec, cmd: 'bundle exec rspec', all_on_start: true do
   watch('spec/spec_helper.rb')  { "spec" }
 end
 
-guard :reek, cli: '--single-line' do
+guard :reek, cli: ['--single-line', '--empty-headings'] do
   watch('config.reek')
   watch(/^lib\/.*\.rb$/)
 end

data/README.md

@@ -54,6 +54,9 @@ end
 ```
 all_on_start: true     # Check all files at Guard startup.
                        #   default: true
+all: 'app lib spec'    # What to run when running all
+                       # An array or string is acceptable.
+                       #   default: *
 cli: '--single-line'   # Pass arbitrary reek CLI arguments.
                        # An array or string is acceptable.
                        #   default: nil

data/lib/guard/reek/runner.rb

@@ -9,41 +9,55 @@ module Guard
 
       def initialize(options)
         @cli = options[:cli]
+        @all = options[:all] || '*'
         @notifier = options[:notifier] || Notifier
         @ui = options[:ui] || UI
       end
 
-      def run(paths = [])
-        paths = [] if paths.include?('.reek')
-        ui_message(paths)
-
-        command = reek_cmd.concat(paths)
-        @result = Kernel.system(*command)
-
-        notify_about_result
-      end
-
-      private
+      # this class decides which files are run against reek
+      class Paths
+        def initialize(paths, all)
+          @all = all
+          @paths = paths
+          @paths = [] if @paths.include?('.reek')
+        end
 
-      def reek_cmd
-        ['reek', @cli].compact
-      end
+        def to_s
+          @paths.empty? ? 'all' : @paths.to_s
+        end
 
-      def ui_message(paths)
-        if paths.empty?
-          ui.info('Guard::Reek running on all')
-        else
-          ui.info("Guard::Reek is running on #{paths}")
+        def to_ary
+          if @paths.empty?
+            Array(@all)
+          else
+            @paths
+          end
         end
       end
 
-      def notify_about_result
+      def run(paths = [])
+        result = run_reek_cmd(paths)
+
         if result
           notifier.notify('Reek Results', title: 'Passed', image: :success)
         else
           notifier.notify('Reek Results', title: 'Failed', image: :failed)
         end
       end
+
+      private
+
+      def run_reek_cmd(paths)
+        runner_paths = Paths.new(paths, @all)
+        ui.info("Guard::Reek is running on #{runner_paths}")
+
+        command = reek_cmd.concat(runner_paths)
+        Kernel.system(command.join(' '))
+      end
+
+      def reek_cmd
+        ['reek', @cli].compact
+      end
     end
   end
 end

data/lib/guard/reek/version.rb

@@ -6,7 +6,7 @@ module Guard
   module ReekVersion
     # http://semver.org/
     MAJOR = 1
-    MINOR = 1
+    MINOR = 2
     PATCH = 0
 
     def self.to_s

data/spec/guard/reek/runner_spec.rb

@@ -12,23 +12,35 @@ describe Guard::Reek::Runner do
   end
 
   it 'executes reek' do
-    expect(Kernel).to receive(:system).with('reek')
+    expect(Kernel).to receive(:system).with('reek *')
     subject.run
   end
 
   it 'executes reek with file' do
-    expect(Kernel).to receive(:system).with('reek', 'test.rb')
+    expect(Kernel).to receive(:system).with('reek test.rb')
     subject.run(['test.rb'])
   end
 
   it 'executes reek when .reek updated' do
-    expect(Kernel).to receive(:system).with('reek')
+    expect(Kernel).to receive(:system).with('reek *')
     subject.run(['.reek'])
   end
 
   it 'executes reek with cli options' do
     options[:cli] = '-s'
-    expect(Kernel).to receive(:system).with('reek', '-s')
+    expect(Kernel).to receive(:system).with('reek -s *')
+    subject.run
+  end
+
+  it 'executes reek with all options as string' do
+    options[:all] = 'app'
+    expect(Kernel).to receive(:system).with('reek app')
+    subject.run
+  end
+
+  it 'executes reek with all options as array' do
+    options[:all] = %w[app lib]
+    expect(Kernel).to receive(:system).with('reek app lib')
     subject.run
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: guard-reek
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Grant Petersen-Speelman
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-23 00:00:00.000000000 Z
+date: 2017-06-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: reek
@@ -148,6 +148,7 @@ files:
 - .gitignore
 - .rspec
 - .travis.yml
+- CHANGELOG.md
 - Gemfile
 - Guardfile
 - LICENSE.txt