guard-preek 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f0ab530a436bfeed1df22b41a0b2488997008542
-  data.tar.gz: cc3ec50ace5e0461f5620c53393b3216ecfa05f2
+  metadata.gz: 1bc8f29cf814a1eed75c9c8caac776ddf52740af
+  data.tar.gz: a38f19c09e73c0c951fe57024c0e37757947c74d
 SHA512:
-  metadata.gz: eba871e32c5901b9572f16342509bc5557587132e4859825bd8d5a0f2c9bb4befa1667d99639613e1493d8576b4a8a754b26713a5dcc6b7c3a26a05209da38fd
-  data.tar.gz: ff681b1144717d152726e0a3855459fe4b473812e60075cf77a4971704b6cc57e891b606e8c406c12a76add9355f7cb7c30f8dd96c269de4934c9dba2640090c
+  metadata.gz: 7ecfd778f5907098c181d11b40f2bb345dbc1b316119889bb5010e35f0631b7693f1e8d3d1db3377e3e45fa2a99ff67998b97aab61ca6ba5aad24fec96d88b47
+  data.tar.gz: 86fd27e82939b99bd358c2abd8cd49410201ddecdf5b91c734a36ce09c079fe7afc682ef9cc90156ec37335f6e09235ac280ee7ce932900e9590640fcdc2910f

data/Guardfile

@@ -1,24 +1,5 @@
-# A sample Guardfile
-# More info at https://github.com/guard/guard#readme
-
 guard :rspec do
   watch(%r{^spec/.+_spec\.rb$})
   watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
   watch('spec/spec_helper.rb')  { "spec" }
-
-  # Rails example
-  watch(%r{^app/(.+)\.rb$})                           { |m| "spec/#{m[1]}_spec.rb" }
-  watch(%r{^app/(.*)(\.erb|\.haml)$})                 { |m| "spec/#{m[1]}#{m[2]}_spec.rb" }
-  watch(%r{^app/controllers/(.+)_(controller)\.rb$})  { |m| ["spec/routing/#{m[1]}_routing_spec.rb", "spec/#{m[2]}s/#{m[1]}_#{m[2]}_spec.rb", "spec/acceptance/#{m[1]}_spec.rb"] }
-  watch(%r{^spec/support/(.+)\.rb$})                  { "spec" }
-  watch('config/routes.rb')                           { "spec/routing" }
-  watch('app/controllers/application_controller.rb')  { "spec/controllers" }
-
-  # Capybara features specs
-  watch(%r{^app/views/(.+)/.*\.(erb|haml)$})          { |m| "spec/features/#{m[1]}_spec.rb" }
-
-  # Turnip features and steps
-  watch(%r{^spec/acceptance/(.+)\.feature$})
-  watch(%r{^spec/acceptance/steps/(.+)_steps\.rb$})   { |m| Dir[File.join("**/#{m[1]}.feature")][0] || 'spec/acceptance' }
 end
-

data/README.md

@@ -10,7 +10,7 @@ Do your refactoring with [Guard](https://github.com/guard/guard) and [Preek](htt
 ## Installation
 
     $ gem install guard-preek
-    
+
 or
 
     # Add to Gemfile
@@ -21,12 +21,12 @@ or install it yourself
     $ git clone git@github.com:joenas/guard-preek.git
     $ cd guard-preek
     $ rake install
-    
+
 
 ## Usage
 
-To generate template: 
- 
+To generate template:
+
     $ guard init preek
 
 ### Examples
@@ -40,6 +40,7 @@ end
 
 ``` ruby
 run_all_dir: 'lib'           # Enter in guard will run Preek on 'lib'
+report: :verbose             # Use Preek::VerboseReport, default is QuietReport
 ```
 
 ## Contributing

data/guard-preek.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ["lib"]
 
   spec.add_dependency "guard", '~> 1.6'
-  spec.add_dependency "preek", "~> 1.0"
+  spec.add_dependency "preek", "~> 1.3.1"
 
   spec.add_development_dependency "bundler", "~> 1.3"
   spec.add_development_dependency "rake"

data/lib/guard/preek/runner.rb

@@ -3,18 +3,27 @@ require 'preek'
 module Guard
   class Preek
     class Runner
-      def initialize(files)
+      def initialize(files, report_type)
         @files = Array(files)
+        @report_type = report_type
       end
 
       def perform
-        ::Preek::Smell(@files, excludes)
+        ::Preek::Examiner.new(@files, excludes, reporter: reporter).perform
       end
 
     private
       def excludes
         %w(IrresponsibleModule)
       end
+
+      def reporter
+        if @report_type == :verbose
+          ::Preek::VerboseReport
+        else
+          ::Preek::QuietReport
+        end
+      end
     end
   end
 end

data/lib/guard/preek/templates/Guardfile

@@ -2,6 +2,6 @@
 # More info at https://github.com/guard/guard#readme
 
 guard :preek, run_all_dir: 'lib' do
-	watch(/lib\/(.*).rb/)
+	watch(/^lib\/(.*).rb/)
 end
 

data/lib/guard/preek/version.rb

@@ -1,5 +1,5 @@
 module Guard
   class PreekVersion
-    VERSION = "0.0.4"
+    VERSION = "0.0.5"
   end
 end

data/lib/guard/preek.rb

@@ -7,14 +7,14 @@ module Guard
     autoload :Runner, 'guard/preek/runner'
 
     def run_on_changes(paths)
-      Runner.new(paths).perform
+      Runner.new(paths, options[:report]).perform
     end
 
     def run_all
       dir = options[:run_all_dir]
       raise_dir_missing unless dir
       UI.info %(Running Preek on '#{dir}'. Wait for it...!)
-      Runner.new(dir).perform
+      Runner.new(dir, options[:report]).perform
     end
 
   private

data/spec/guard/integration_spec.rb

@@ -10,20 +10,48 @@ describe Guard::Preek do
     Given(:paths){ ["spec/test_files/#{file}.rb"] }
     When(:output) { capture(:stdout) { guard.run_on_changes(paths) } }
 
-    context 'with a smell' do
-      Given(:file) {'nil_check'}
-      Then { output.should match(/NilCheck/) }
-    end
+    context 'with no options' do
+      context 'with a smell' do
+        Given(:file) {'nil_check'}
+        Then { output.should match(/NilCheck/) }
+        Then { output.should include(paths[0])}
+      end
+
+      context 'with Irresponsible' do
+        Given(:file) {'irresponsible'}
+        Then { output.should match(/No smells detected/) }
+        Then { output.should_not include(paths[0])}
+      end
 
-    context 'with Irresponsible' do
-      Given(:file) {'irresponsible'}
-      Then { output.should match(/No smells detected/) }
+      context 'without smell' do
+        Given(:file) {'non_smelly'}
+        Then { output.should match(/No smells detected/) }
+        Then { output.should_not include(paths[0])}
+      end
     end
 
-    context 'without smell' do
-      Given(:file) {'non_smelly'}
-      Then { output.should match(/No smells detected/) }
+    context 'with option "report: :verbose"' do
+      Given(:options){ {report: :verbose} }
+
+      context 'with a smell' do
+        Given(:file) {'nil_check'}
+        Then { output.should match(/NilCheck/) }
+        Then { output.should include(paths[0])}
+      end
+
+      context 'with Irresponsible' do
+        Given(:file) {'irresponsible'}
+        Then { output.should match(/No smells detected/) }
+        Then { output.should include(paths[0])}
+      end
+
+      context 'without smell' do
+        Given(:file) {'non_smelly'}
+        Then { output.should match(/No smells detected/) }
+        Then { output.should include(paths[0])}
+      end
     end
+
   end
 
   context '#run_all' do

data/spec/guard/preek_spec.rb

@@ -4,26 +4,46 @@ describe Guard::Preek do
 
   Given(:guard){ Guard::Preek.new([], options) }
   Given(:options){ Hash.new }
+  Given(:paths){ ['some_file.rb'] }
+  Given(:runner){ double('runner', perform: true) }
+
 
   context '#run_on_changes' do
-    Given(:paths){ ['some_file.rb'] }
-    Given(:runner){ double('runner', perform: true) }
-    Given{ Guard::Preek::Runner.should_receive(:new).with(paths).and_return(runner) }
-    Given{ runner.should_receive(:perform) }
     When{ guard.run_on_changes(paths) }
-    Then{ 'its great' }
+
+    context 'with no options' do
+      Given{ Guard::Preek::Runner.should_receive(:new).with(paths, options[:report]).and_return(runner) }
+      Given{ runner.should_receive(:perform) }
+      Then{ 'its great' }
+    end
+
+    context 'with "report: :verbose" option' do
+      Given(:options){ {report: :verbose} }
+      Given(:runner){ double('runner', perform: true) }
+      Given{ Guard::Preek::Runner.should_receive(:new).with(paths, options[:report]).and_return(runner) }
+      Given{ runner.should_receive(:perform) }
+      Then{ 'its great' }
+    end
   end
 
   context '#run_all' do
     context 'with "run_all_dir" option' do
       Given(:options){ {run_all_dir: 'lib'} }
       Given(:runner){ double('runner', perform: true) }
-      Given{ Guard::Preek::Runner.should_receive(:new).with(options[:run_all_dir]).and_return(runner) }
+      Given{ Guard::Preek::Runner.should_receive(:new).with(options[:run_all_dir], options[:report]).and_return(runner) }
       Given{ runner.should_receive(:perform) }
       When{ guard.run_all }
       Then{ 'also great' }
     end
 
+    context 'with "report: verbose" option' do
+      Given(:options){ {report: :verbose, run_all_dir: 'lib'} }
+      Given(:runner){ double('runner', perform: true) }
+      Given{ Guard::Preek::Runner.should_receive(:new).with(options[:run_all_dir], options[:report]).and_return(runner) }
+      Given{ runner.should_receive(:perform) }
+      When{ guard.run_all }
+      Then{ 'its great' }
+    end
 
     context 'with no options' do
       Then{

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: guard-preek
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Jon Neverland
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-25 00:00:00.000000000 Z
+date: 2013-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: guard
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.3.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 1.3.1
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -185,7 +185,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.2
+rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: Simple refactoring Guard, pretty prints Reek smells