guard-mocha-node 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ae8b7b547d5bc0fddacd89dbabb3a40dbc2b160b
-  data.tar.gz: 8997479c237892833a1953cee52ce0738b96ed87
+  metadata.gz: ef3935e2938c11f5fdcd34aa6fd3692fdc46d9ba
+  data.tar.gz: c2fe24f694f378c05cd3531e0031471882e8cd34
 SHA512:
-  metadata.gz: 055b68bea222173bf83028fbc186d0af90bd8589fa4e67de27a82997ae2fde4205ca936e149d722b87f0df9b71ee2888c62d8ad522af89be9f87d1c32049e7ed
-  data.tar.gz: f951c9910b9561bcffb64823a335d2181cdb325ba454e225dec087ca88d6179c201bc0d9caa549552a7a637f686fbe8cac8cced98800dd903e06361ae5019159
+  metadata.gz: b9867a0c2be875a7c97ef1835de2ab14bdb2e5645f3b6eb268c8e3dff3137a0a9b2402d03e0ee762d8d1eb123874af4d55911b575cd6a9501cfdf59d68a78f95
+  data.tar.gz: 4c8c3fb0c17fdde975d241c8eb37fa119dd502833aca3817c047f3837b766bc6349fe9d3020290e67c192591c7eda8a0b08961ac0a7012d7bce187f45eb30159

data/lib/guard/mocha_node/runner.rb

@@ -1,4 +1,3 @@
-require 'open3'
 require 'guard/ui'
 
 module Guard
@@ -18,13 +17,13 @@ module Guard
 
       def self.print_message
         message = @options[:message]
-	is_all_specs = @paths.sort == @options[:paths_for_all_specs].sort
+        is_all_specs = @paths.sort == @options[:paths_for_all_specs].sort
         message ||= is_all_specs ? "Running all specs" : "Running: #{@paths.join(' ')}"
         ::Guard::UI.info(message, :reset => true)
       end
 
       def self.execute_mocha_node_command
-        ::Open3.popen3(*mocha_node_command)
+        Kernel.system(*mocha_node_command)
       end
 
       def self.mocha_node_command
@@ -36,34 +35,34 @@ module Guard
 
       def self.command_line_options
         options = []
-	compilers = []
+        compilers = []
 
         if @options[:coffeescript]
           compilers << "coffee:coffee-script"
         end
 
-	if @options[:livescript]
+        if @options[:livescript]
           compilers << "ls:LiveScript"
         end
 
-	if not compilers.empty?
-	  options << "--compilers"
-	  options << compilers.join(",")
-	end
+        if not compilers.empty?
+          options << "--compilers"
+          options << compilers.join(",")
+        end
 
         if @options[:recursive]
           options << "--recursive"
         end
 
-	if @options[:require]
-	  r = @options[:require]
-	  r = [r] if not r.instance_of? Array
+        if @options[:require]
+          r = @options[:require]
+          r = [r] if not r.instance_of? Array
 
-	  r.each { |e|
-	    options << "-r"
-	    options << e
-	  }
-	end
+          r.each { |e|
+            options << "-r"
+            options << e
+          }
+        end
 
         if @options[:color]
           options << "-c"
@@ -81,8 +80,8 @@ module Guard
           options << @options[:reporter]
         end
 
-	# puts "---- printing the options"
-	# puts options
+        # puts "---- printing the options"
+        # puts options
         options
       end
     end

data/lib/guard/mocha_node/spec_state.rb

@@ -1,14 +1,6 @@
 module Guard
   class MochaNode
     class SpecState
-      STDIN  = 0
-      STDOUT = 1
-      STDERR = 2
-      THREAD = 3
-
-      SUCCESS_CODE = 0
-      ERROR_CODE   = 1
-
       attr_accessor :failing_paths
 
       def initialize
@@ -17,17 +9,7 @@ module Guard
 
       def update(run_paths = [], options = {})
         @run_paths = run_paths
-        @io = Runner.run(@run_paths, options)
-        @stdout     = @io[STDOUT]
-        @stderr     = @io[STDERR]
-        # stream stdout immediately
-        until @stdout.eof?
-          line = @stdout.gets
-          print line if !line.strip.empty?
-        end
-        @stderr.each { |line| print line }
-        @exitstatus = @io[THREAD].value rescue ERROR_CODE
-        close_io
+        @exitok = Runner.run(@run_paths, options)
         update_passed_and_fixed
         update_failing_paths
         passing?
@@ -49,13 +31,9 @@ module Guard
 
       private
 
-      def close_io
-        @io[STDIN..STDERR].each { |s| s.close }
-      end
-
       def update_passed_and_fixed
         previously_failed = !passing?
-        @passed = @exitstatus == SUCCESS_CODE
+        @passed = @exitok
         @fixed  = @passed && previously_failed
       end
 

data/lib/guard/mocha_node/version.rb

@@ -1,5 +1,5 @@
 module Guard
   module MochaNodeVersion
-    VERSION = "0.0.5"
+    VERSION = "0.0.6"
   end
 end

data/spec/lib/runner_spec.rb

@@ -4,7 +4,7 @@ describe Guard::MochaNode::Runner do
   let(:runner) { Guard::MochaNode::Runner }
 
   before do
-    Open3.stub(:popen3 => "response")
+    Kernel.stub(:system => "response")
   end
 
   describe ".run" do
@@ -19,118 +19,118 @@ describe Guard::MochaNode::Runner do
       let(:some_paths) { %w(/foo/bar /zip/zap) }
 
       it "executes mocha node" do
-        Open3.should_receive(:popen3) do |*args|
-	  args[0].should eq "__EXECUTABLE__"
-	end
+        Kernel.should_receive(:system) do |*args|
+          args[0].should eq "__EXECUTABLE__"
+        end
         runner.run(some_paths, options.merge({ :mocha_bin => "__EXECUTABLE__"}))
       end
 
       it "passes the paths to the executable" do
-        Open3.should_receive(:popen3) do |*args|
-	  last_args = args[(some_paths.length * -1)..(-1)]
-	  last_args.should eql some_paths
-	end
+        Kernel.should_receive(:system) do |*args|
+          last_args = args[(some_paths.length * -1)..(-1)]
+          last_args.should eql some_paths
+        end
         runner.run(some_paths, options)
       end
 
       context "and coffeescript option is true" do
         it "passes the --compilers coffee:coffee-script option to mocha node" do
-          Open3.should_receive(:popen3) do |*args|
-	    index_compilers = args.find_index "--compilers"
-	    index_compilers.should_not be nil
-	    args[index_compilers +1].should eql "coffee:coffee-script"
-	  end
-	  runner.run(some_paths, options.merge({ :coffeescript => true}))
+          Kernel.should_receive(:system) do |*args|
+            index_compilers = args.find_index "--compilers"
+            index_compilers.should_not be nil
+            args[index_compilers +1].should eql "coffee:coffee-script"
+          end
+          runner.run(some_paths, options.merge({ :coffeescript => true}))
         end
       end
 
       context "and coffeescript option is false" do
         it "does not pass the --compilers coffee:coffee-script option to mocha node" do
-          Open3.should_receive(:popen3) do |*args|
-	    index_compilers = args.find_index "--compilers"
-	    if index_compilers != nil
-	      args[index_compilers +1].should_not match /coffee:coffee-script/
-	    end
-	  end
+          Kernel.should_receive(:system) do |*args|
+            index_compilers = args.find_index "--compilers"
+            if index_compilers != nil
+              args[index_compilers +1].should_not match /coffee:coffee-script/
+            end
+          end
           runner.run(some_paths, options.merge({ :coffeescript => false}))
         end
       end
 
       context "and livescript option is true" do
         it "passes the --compilers ls:LiveScript option to mocha node" do
-          Open3.should_receive(:popen3) do |*args|
-	    index_compilers = args.find_index "--compilers"
-	    index_compilers.should_not be nil
-	    args[index_compilers +1].should eql "ls:LiveScript"
-	  end
-	  runner.run(some_paths, options.merge({ :livescript => true}))
+          Kernel.should_receive(:system) do |*args|
+            index_compilers = args.find_index "--compilers"
+            index_compilers.should_not be nil
+            args[index_compilers +1].should eql "ls:LiveScript"
+          end
+          runner.run(some_paths, options.merge({ :livescript => true}))
         end
       end
 
       context "and livescript option is false" do
         it "does not pass the --compilers ls:LiveScript option to mocha node" do
-          Open3.should_receive(:popen3) do |*args|
-	    index_compilers = args.find_index "--compilers"
-	    if index_compilers != nil
-	      args[index_compilers +1].should_not match /ls:LiveScript/
-	    end
-	  end
+          Kernel.should_receive(:system) do |*args|
+            index_compilers = args.find_index "--compilers"
+            if index_compilers != nil
+              args[index_compilers +1].should_not match /ls:LiveScript/
+            end
+          end
           runner.run(some_paths, options.merge({ :livescript => false}))
         end
       end
 
       context "and both coffeescript and livescript  option are true" do
         it "passes the --compilers coffee:coffee-script,ls:LiveScript option to mocha node" do
-          Open3.should_receive(:popen3) do |*args|
-	    index_compilers = args.find_index "--compilers"
-	    index_compilers.should_not be nil
-	    args[index_compilers +1].should eql "coffee:coffee-script,ls:LiveScript"
-	  end
-	  runner.run(some_paths, options.merge({ :livescript => true, :coffeescript => true }))
+          Kernel.should_receive(:system) do |*args|
+            index_compilers = args.find_index "--compilers"
+            index_compilers.should_not be nil
+            args[index_compilers +1].should eql "coffee:coffee-script,ls:LiveScript"
+          end
+          runner.run(some_paths, options.merge({ :livescript => true, :coffeescript => true }))
         end
       end
 
       context "and color option is true" do
         it "passes the -c option to mocha node" do
-          Open3.should_receive(:popen3) do |*args|
-	    args.should include "-c"
-	  end
+          Kernel.should_receive(:system) do |*args|
+            args.should include "-c"
+          end
           runner.run(some_paths, options.merge({ :color => true}))
         end
       end
 
       context "and color option is false" do
         it "passes the -C option to mocha node" do
-          Open3.should_receive(:popen3) do |*args|
-	    args.should include "-C"
-	  end
+          Kernel.should_receive(:system) do |*args|
+            args.should include "-C"
+          end
           runner.run(some_paths, options.merge({ :color => false}))
         end
       end
 
       context "and globals option is set" do
         it "passes the --globals option to mocha node" do
-          Open3.should_receive(:popen3) do |*args|
-	    args.should include("--globals", "Foo")
+          Kernel.should_receive(:system) do |*args|
+            args.should include("--globals", "Foo")
             # ensure ordering
             args[args.index("--globals") + 1].should eql("Foo")
-	  end
+          end
           runner.run(some_paths, options.merge({ :globals => ['Foo']}))
         end
       end
 
       context "and globals option is empty" do
         it "does not pass the --globals option to mocha node" do
-          Open3.should_receive(:popen3) do |*args|
-	    args.should_not include "--globals"
-	  end
+          Kernel.should_receive(:system) do |*args|
+            args.should_not include "--globals"
+          end
           runner.run(some_paths, options.merge({ :globals => []}))
         end
       end
 
       context "and reporter option is set" do
         it "passes the --reporter option to mocha node" do
-          Open3.should_receive(:popen3) do |*args|
+          Kernel.should_receive(:system) do |*args|
             args.should include("--reporter", "Foo")
             # ensure ordering
             args[args.index("--reporter") + 1].should eql("Foo")
@@ -141,7 +141,7 @@ describe Guard::MochaNode::Runner do
 
       context "and reporter option is not set" do
         it "does not pass the --reporter option to mocha node" do
-          Open3.should_receive(:popen3) do |*args|
+          Kernel.should_receive(:system) do |*args|
             args.should_not include "--reporter"
           end
           runner.run(some_paths, options)
@@ -150,57 +150,57 @@ describe Guard::MochaNode::Runner do
 
       context "and recursive option is true" do
         it "passes the --recursive option to mocha node" do
-          Open3.should_receive(:popen3) do |*args|
-	    args.should include "--recursive"
-	  end
+          Kernel.should_receive(:system) do |*args|
+            args.should include "--recursive"
+          end
           runner.run(some_paths, options.merge({ :recursive => true}))
         end
       end
 
       context "and recursive option is false" do
         it "does not pass the --recursive option to mocha node" do
-          Open3.should_receive(:popen3) do |*args|
-	    args.should_not include "--recursive"
-	  end
+          Kernel.should_receive(:system) do |*args|
+            args.should_not include "--recursive"
+          end
           runner.run(some_paths, options.merge({ :recursive => false}))
         end
       end
 
       context "and require option is 'should'" do
         it "passes the '-r should' option to mocha node" do
-          Open3.should_receive(:popen3) do |*args|
-	    require_index = args.find_index '-r'
-	    require_index.should_not eq nil
-	    args[require_index+1].should eql "should"
-	  end
+          Kernel.should_receive(:system) do |*args|
+            require_index = args.find_index '-r'
+            require_index.should_not eq nil
+            args[require_index+1].should eql "should"
+          end
           runner.run(some_paths, options.merge({ :require => 'should'}))
         end
       end
 
       context "and require option is ['should', 'chai']" do
         it "passes the '-r should -r chai' option to mocha node" do
-          Open3.should_receive(:popen3) do |*args|
-	    args.each_with_index.
-	      reject{ |e,i| e != '-r' }.
-	      map{ |e,i| args[i+1] }.should eql ["should", "chai"]
+          Kernel.should_receive(:system) do |*args|
+            args.each_with_index.
+              reject{ |e,i| e != '-r' }.
+              map{ |e,i| args[i+1] }.should eql ["should", "chai"]
 
-	  end
+          end
           runner.run(some_paths, options.merge({ :require => ['should', 'chai'] }))
         end
       end
 
       context "and require option is nil" do
         it "does not pass the -r option to mocha node" do
-          Open3.should_receive(:popen3) do |*args|
-	    args.should_not include "-r"
-	  end
+          Kernel.should_receive(:system) do |*args|
+            args.should_not include "-r"
+          end
           runner.run(some_paths, options.merge({ :require => nil}))
         end
       end
 
       it "returns IO object" do
         io_obj = double("io obj")
-        Open3.stub(:popen3 => io_obj)
+        Kernel.stub(:system => io_obj)
         runner.run(some_paths, options).should eql io_obj
       end
 

data/spec/lib/spec_state_spec.rb

@@ -19,32 +19,20 @@ describe Guard::MochaNode::SpecState do
   end
 
   describe "#update" do
-    let(:io) { [
-                double("stdin",  :close => true),
-                double("stdout", :close => true, :lines => [], :eof? => true),
-                double("stderr", :close => true, :each => []),
-                double("thread", :value => 0)
-               ] }
     let(:some_paths)   { %w(some paths) }
     let(:some_options) { double("some options") }
 
     before do
-      runner.stub(:run => io)
+      runner.stub(:run => true)
     end
 
     it "runs the runner with the paths and options" do
-      runner.should_receive(:run).with(some_paths, some_options).and_return(io)
+      runner.should_receive(:run).with(some_paths, some_options).and_return(true)
       state.update(some_paths, some_options)
     end
 
-    it "closes stdin, stdout, and stderr of the subprocess" do
-      io[0..2].each { |i| i.should_receive(:close) }
-      state.update
-    end
-
     context "when the runner process exit value is zero" do
       before do
-        io[3].stub(:value => 0)
         state.update
       end
 
@@ -94,7 +82,7 @@ describe Guard::MochaNode::SpecState do
 
     context "when the runner process exit value is not zero" do
       before do
-        io[3].stub(:value => 1)
+        runner.stub(:run => false)
         state.update(some_paths, some_options)
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: guard-mocha-node
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - dave@kapoq.com
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-13 00:00:00.000000000 Z
+date: 2013-08-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: guard