guard-jasmine-headless-webkit 0.0.5 → 0.1.0

data/Gemfile

@@ -2,8 +2,9 @@ source "http://rubygems.org"
 
 # Specify your gem's dependencies in guard-jasmine-headless-webkit.gemspec
 gemspec
-gem 'guard'
+gem 'guard', :git => 'https://github.com/guard/guard.git'
 gem 'rspec'
 gem 'mocha'
 gem 'rake', '0.8.7'
 gem 'growl'
+gem 'fakefs', :require => nil

data/README.md

@@ -15,9 +15,9 @@ home folder's `.jasmine-headless-webkit` file.
 ## `guard` options
 
 * `:all_on_start => false` to not run everything when starting, just like `guard-rspec`.
-* `:run_before => "<command to run>` to run a command before running specs. If the command fails, the test run stops. Useful for running Jammit before running your specs to compile templates:
-
-  `guard 'jasmine-headliness-webkit', :run_before => 'jammit -f 2>/dev/null' do`
+* `:run_before => "<command to run>` to run a command before running specs. If the command fails, the test run stops.
+* `:jammit => true` to run `jammit -f 2>/dev/null` before the tests for the current file change are run.
+* `:valid_extensions => %w{` to run `jammit -f 2>/dev/null` before the tests for the current file change are run.
 
 ## What's the deal with `newest_js_file`?
 

data/Rakefile

@@ -6,3 +6,32 @@ task :push_everywhere do
   system %{git push origin master}
   system %{git push guard master}
 end
+
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new(:spec)
+
+namespace :spec do
+  desc "Run on three Rubies"
+  task :platforms do
+    current = %x{rvm-prompt v}
+    
+    fail = false
+    %w{1.8.7 1.9.2 ree}.each do |version|
+      puts "Switching to #{version}"
+      Bundler.with_clean_env do
+        system %{bash -c 'source ~/.rvm/scripts/rvm && rvm #{version} && bundle exec rake spec'}
+      end
+      if $?.exitstatus != 0
+        fail = true
+        break
+      end
+    end
+
+    system %{rvm #{current}}
+
+    exit (fail ? 1 : 0)
+  end
+end
+
+task :default => 'spec:platforms'

data/lib/guard/jasmine-headless-webkit.rb

@@ -4,11 +4,14 @@ require 'guard/jasmine-headless-webkit/runner'
 
 module Guard
   class JasmineHeadlessWebkit < Guard
+    DEFAULT_EXTENSIONS = %w{js coffee}
+
     def initialize(watchers = [], options = {})
       super
       @options = {
         :all_on_start => true,
-        :run_before => false
+        :run_before => false,
+        :valid_extensions => DEFAULT_EXTENSIONS
       }.merge(options)
     end
 
@@ -18,25 +21,54 @@ module Guard
     end
 
     def run_all
-      JasmineHeadlessWebkitRunner.run if run_before
+      JasmineHeadlessWebkitRunner.run if run_before and run_jammit
+      @ran_jammit = false
     end
 
     def run_on_change(paths)
-      if run_before
-        run_all if JasmineHeadlessWebkitRunner.run(paths) == 0
+      paths = filter_paths(paths)
+      @ran_jammit = false
+      if run_before and run_jammit
+        @ran_jammit = true
+        do_run_all = true
+        if !paths.empty?
+          do_run_all = (JasmineHeadlessWebkitRunner.run(paths) == 0)
+        end
+        run_all if do_run_all
       end
     end
 
     private
+    def filter_paths(paths)
+      paths.find_all { |path| File.extname(path)[valid_extensions] }
+    end
+
+    def valid_extensions
+      %r{\.(#{@options[:valid_extensions].join('|')})$}
+    end
+
     def run_before
       if @options[:run_before]
-        UI.info "Guard::JasmineHeadlessWebkit running #{@options[:run_before]} first..."
-        system @options[:run_before]
-        $?.exitstatus == 0
+        run_program(@options[:run_before])
+      else
+        true
+      end
+    end
+
+    def run_jammit
+      if @options[:jammit] && !@ran_jammit
+        run_program("Jammit", %{jammit -f 2>/dev/null})
       else
         true
       end
     end
+
+    def run_program(name, command = nil)
+      command ||= name
+      UI.info "Guard::JasmineHeadlessWebkit running #{name}..."
+      system command
+      $?.exitstatus == 0
+    end
   end
 
   class Dsl

data/lib/guard/jasmine-headless-webkit/runner.rb

@@ -9,15 +9,25 @@ module Guard
 
         system %{jasmine-headless-webkit --report #{file.path} -c #{paths.join(" ")}}
 
-        total, fails, any_console, secs = File.read(file.path).strip.split('/')
+        notify(file.path)
+      end
+
+      def notify(file)
+        if (data = File.read(file).strip).empty?
+          Notifier.notify('Spec runner interrupted!', :title => 'Jasmine results', :image => :failed)
+        else
+          total, fails, any_console, secs = File.read(file).strip.split('/')
 
-        Notifier.notify(message(total, fails, secs, any_console == "T"), :title => 'Jasmine results', :image => image(any_console == "T", fails))
-        fails.to_i
+          Notifier.notify(message(total, fails, secs, any_console == "T"), :title => 'Jasmine results', :image => image(any_console == "T", fails))
+          fails.to_i
+        end
       end
 
       private
       def message(total, fails, secs, any_console)
-        "#{total} tests, #{fails} failures, #{secs} secs#{any_console ? ', console.log used' : ''}."
+        total_word = (total.to_i == 1) ? "test" : "tests"
+
+        "#{total} #{total_word}, #{fails} failures, #{secs} secs#{any_console ? ', console.log used' : ''}."
       end
 
       def image(any_console, fails)

data/lib/guard/jasmine-headless-webkit/templates/Guardfile

@@ -7,9 +7,9 @@ spec_location = "spec/javascripts/%s_spec"
 # spec_location = "spec/javascripts/%sSpec"
 
 guard 'jasmine-headless-webkit' do
-  watch(%r{^app/views/.*\.jst})
-  watch(%r{^public/javascripts/(.*)\.js}) { |m| newest_js_file(spec_location % m[1]) }
-  watch(%r{^app/assets/javascripts/(.*)\.(js|coffee)}) { |m| newest_js_file(spec_location % m[1]) }
+  watch(%r{^app/views/.*\.jst$})
+  watch(%r{^public/javascripts/(.*)\.js$}) { |m| newest_js_file(spec_location % m[1]) }
+  watch(%r{^app/assets/javascripts/(.*)\.(js|coffee)$}) { |m| newest_js_file(spec_location % m[1]) }
   watch(%r{^spec/javascripts/(.*)_spec\..*}) { |m| newest_js_file(spec_location % m[1]) }
 end
 

data/lib/guard/jasmine-headless-webkit/version.rb

@@ -1,5 +1,5 @@
 module Guard
   module JasmineHeadlessWebkitVersion
-    VERSION = "0.0.5"
+    VERSION = "0.1.0"
   end
 end

data/spec/lib/guard/jasmine-headless-webkit/runner_spec.rb

@@ -0,0 +1,35 @@
+require 'spec_helper'
+require 'guard/jasmine-headless-webkit/runner'
+require 'fakefs/spec_helpers'
+
+describe Guard::JasmineHeadlessWebkitRunner do
+  describe '.notify' do
+    include FakeFS::SpecHelpers
+
+    let(:file) { 'temp.txt' }
+
+    before do
+      File.open(file, 'w') { |fh| fh.print data }
+    end
+
+    context 'system run not interrupted' do
+      let(:data) { '1/0/F/5' }
+
+      it 'should notify with the right information' do
+        Guard::Notifier.expects(:notify).with("1 test, 0 failures, 5 secs.", { :title => 'Jasmine results', :image => :success })
+
+        Guard::JasmineHeadlessWebkitRunner.notify(file)
+      end
+    end
+
+    context 'system run interrupted' do
+      let(:data) { '' }
+
+      it 'should notify failure' do
+        Guard::Notifier.expects(:notify).with("Spec runner interrupted!", { :title => 'Jasmine results', :image => :failed })
+
+        Guard::JasmineHeadlessWebkitRunner.notify(file)
+      end
+    end
+  end
+end

data/spec/lib/guard/jasmine-headless-webkit_spec.rb

@@ -32,7 +32,7 @@ describe Guard::JasmineHeadlessWebkit do
         Guard::JasmineHeadlessWebkitRunner.expects(:run).returns(1)
         guard.expects(:run_all).never
 
-        guard.run_on_change(%w{test})
+        guard.run_on_change(%w{test.js})
       end
     end
 
@@ -41,7 +41,25 @@ describe Guard::JasmineHeadlessWebkit do
         Guard::JasmineHeadlessWebkitRunner.expects(:run).returns(0)
         guard.expects(:run_all).once
 
-        guard.run_on_change(%w{test})
+        guard.run_on_change(%w{test.js})
+      end
+    end
+
+    context 'no files given, just run all' do
+      it 'should run all but not run once' do
+        Guard::JasmineHeadlessWebkitRunner.expects(:run).never
+        guard.expects(:run_all).once
+
+        guard.run_on_change([])
+      end
+    end
+
+    context "Files I don't care about given, ignore" do
+      it 'should run all but not run once' do
+        Guard::JasmineHeadlessWebkitRunner.expects(:run).never
+        guard.expects(:run_all).once
+
+        guard.run_on_change(%w{test.jst})
       end
     end
   end
@@ -50,6 +68,7 @@ describe Guard::JasmineHeadlessWebkit do
     context 'with failing command' do
       before do
         Guard::JasmineHeadlessWebkitRunner.expects(:run).never
+        Guard::UI.expects(:info).with(regexp_matches(/false/))
       end
 
       let(:options) { { :run_before => 'false' } }
@@ -62,6 +81,7 @@ describe Guard::JasmineHeadlessWebkit do
     context 'with succeeding command' do
       before do
         Guard::JasmineHeadlessWebkitRunner.expects(:run).once
+        Guard::UI.expects(:info).with(regexp_matches(/true/))
       end
 
       let(:options) { { :run_before => 'true' } }
@@ -71,4 +91,32 @@ describe Guard::JasmineHeadlessWebkit do
       end
     end
   end
+
+  describe 'run jammit first' do
+    context 'run on run_all if called first' do
+      before do
+        guard.expects(:run_program).once.returns(true)
+        Guard::JasmineHeadlessWebkitRunner.expects(:run).once
+      end
+
+      let(:options) { { :jammit => true } }
+
+      it "should run jammit first" do
+        guard.run_all
+      end
+    end
+
+    context 'only run once if run_on_change is successful' do
+      before do
+        guard.expects(:run_program).once.returns(true)
+        Guard::JasmineHeadlessWebkitRunner.expects(:run).twice.returns(0)
+      end
+
+      let(:options) { { :jammit => true } }
+
+      it "should run jammit only once" do
+        guard.run_on_change(%w{path.js})
+      end
+    end
+  end
 end

metadata

@@ -2,7 +2,7 @@
 name: guard-jasmine-headless-webkit
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.5
+  version: 0.1.0
 platform: ruby
 authors: 
 - John Bintz
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-05-29 00:00:00 -04:00
+date: 2011-06-07 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -55,6 +55,7 @@ files:
 - lib/guard/jasmine-headless-webkit/runner.rb
 - lib/guard/jasmine-headless-webkit/templates/Guardfile
 - lib/guard/jasmine-headless-webkit/version.rb
+- spec/lib/guard/jasmine-headless-webkit/runner_spec.rb
 - spec/lib/guard/jasmine-headless-webkit_spec.rb
 - spec/spec_helper.rb
 has_rdoc: true
@@ -71,7 +72,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 642568591730735796
+      hash: -738405479392593179
       segments: 
       - 0
       version: "0"
@@ -80,7 +81,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      hash: 642568591730735796
+      hash: -738405479392593179
       segments: 
       - 0
       version: "0"
@@ -92,5 +93,6 @@ signing_key:
 specification_version: 3
 summary: Run jasmine-headless-webkit using guard
 test_files: 
+- spec/lib/guard/jasmine-headless-webkit/runner_spec.rb
 - spec/lib/guard/jasmine-headless-webkit_spec.rb
 - spec/spec_helper.rb