gruff 0.27.1 → 0.28.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 295e6f1b645cfad9f63a1cc0759f4ee57d84663c5d2317cfe2c5aba41e3bd6bc
-  data.tar.gz: f3fc8b6c4a914c7a276aa0df08a90facf2be398ba0ac321d4c812ea4d7706f15
+  metadata.gz: 26b395dec8d012e9a7cee4013081d689b7decd86aeda0dc1ffd8fc66c6e71db6
+  data.tar.gz: 6cc57c03116dff4ba0a0c6e8adb0f36d247431bba05e292bb6d422a8b9d1b1c5
 SHA512:
-  metadata.gz: c6763d1b4995818e9340c56a63fc5af6aa79c844b4d6518d61310095eed759ae4099dcf7538e88ec3ca0fc7ab4a32b1321b7425e692253e461b4076cb54af77c
-  data.tar.gz: e87a0bf90f66eb77035f330df3f12d56d7d9bb393c1fe4fdf3a0745437e90e08752baa58a1170727b59a287c560d4dc03d18dc0db505d6987a5d7637dc15b5d6
+  metadata.gz: 7b155ccb54f177475c81c1176401fd95147152300e48da0c96951d8767bf8b861cbc7a4f2e27da32e727cb64e1f9fe31b5fa7a8bee49d2747e0a3e883a72a636
+  data.tar.gz: c2ec8dd6104836dfa234a8300c0e1ba40e212b2faac3c77ec504fd9db7d01408a75bbe486a487a3744965c54487c114961f5c58f79ca66c8e974b3dd4b135d05

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Change Log
 
+## 0.28.0
+
+- Fix Gruff::Line to prevent unknown lines drawing (#664)
+
 ## 0.27.1
 
 - RBS: Fix wrong type declarations (#662)

data/lib/gruff/line.rb

@@ -229,13 +229,10 @@ private
 
     stroke_width  = @line_width || clip_value_if_greater_than(@columns / (store.norm_data.first.y_points.size * 4.0), 5.0)
     circle_radius = @dot_radius || clip_value_if_greater_than(@columns / (store.norm_data.first.y_points.size * 2.5), 5.0)
+    prev_x = prev_y = nil
 
     store.norm_data.each do |data_row|
-      poly_points_group = [[]]
-
       data_row.coordinates.each_with_index do |(x_data, y_data), index|
-        poly_points = poly_points_group.last
-
         new_x = begin
           if x_data.nil?
             # use the old method: equally spaced points along the x-axis
@@ -249,24 +246,24 @@ private
         unless y_data
           # we can't draw a line for a null data point, we can still label the axis though.
           # Split the polygonal line into separate groups of points for polyline.
-          poly_points_group << []
+          prev_x = prev_y = nil
           next
         end
 
         new_y = @graph_top + (@graph_height - (y_data * @graph_height))
 
-        poly_points << new_x
-        poly_points << new_y
-
         if contains_one_point_only?(data_row) || !@hide_dots
           Gruff::Renderer::Dot.new(renderer, @dot_style, color: data_row.color, width: stroke_width).render(new_x, new_y, circle_radius)
         end
-      end
-
-      unless @hide_lines
-        poly_points_group.each do |poly_points|
-          Gruff::Renderer::Polyline.new(renderer, color: data_row.color, width: stroke_width).render(poly_points) unless poly_points.empty?
+        if !@hide_lines && prev_x && prev_y
+          # Renderer::Polyline may cause unknown lines to be drawn with complex graphs.
+          # Probably it is related to ImageMagick behavior.
+          # To avoid this problem, we use the Renderer::Line instead.
+          Gruff::Renderer::Line.new(renderer, color: data_row.color, width: stroke_width)
+                               .render(prev_x, prev_y, new_x, new_y)
         end
+        prev_x = new_x
+        prev_y = new_y
       end
     end
   end

data/lib/gruff/version.rb

@@ -3,5 +3,5 @@
 # rbs_inline: enabled
 
 module Gruff
-  VERSION = '0.27.1'
+  VERSION = '0.28.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gruff
 version: !ruby/object:Gem::Version
-  version: 0.27.1
+  version: 0.28.0
 platform: ruby
 authors:
 - Geoffrey Grosenbach
@@ -191,7 +191,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.7
+rubygems_version: 3.7.0
 specification_version: 4
 summary: Beautiful graphs for one or multiple datasets.
 test_files: []