gruf-queue 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cc1f1ae6ceeae244f3240289293550ac50d4817c146bdd0ae08c0ba4aac3d6b9
-  data.tar.gz: 510388ca36e935b14f7d727acc5f74a46969018b87cce11bfedf6a0a5723ba1b
+  metadata.gz: 0c95bbcdd543d4648972f17a59e97f8c3113964fd0f3a38da423a17f6a98913e
+  data.tar.gz: 7079457c7e33fc6a272f8974998a5db14d743e234197625bd5b71c28332273d0
 SHA512:
-  metadata.gz: 456159e1ad576446eb160c81a5fd285a8892c005cafc89c3607fcf8371da9e65e98481f14d44760f798cba36abda25e55c80199779e5e68339b6836faf5a32b3
-  data.tar.gz: 2c4e4d90a9667a860de5fb243d0d1c8d4fa8cae4499307c5f65f9e2b0dc7827973662ea24b03c1d1b000807a880645c272b93a52c8b4cd373c01e96c765028a7
+  metadata.gz: 55862eaad56dfe99040d110c419581b58bd12a418d2729ef73788332ab9ddaac6b39638f19de2a104550c696bd0a92e61dbc531bfbae664d4725b681322f3b7f
+  data.tar.gz: 64de88a3ec9c97d34bf32c76fae59cd4b3b9340b5a13a0435ed6e1b6ab9e3dde7ba34f0f0d18e297c065c32e6108ec6581abe826d3f6c2c0a80f917aa1ed2f60

data/CHANGELOG.md

@@ -5,6 +5,35 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.1.5]
+
+### Changed
+- **BREAKING**: Complete rewrite of pool enhancement architecture
+- Eliminated AlwaysReadyQueue and all worker queue management complexity
+- Simplified to direct job scheduling with `@jobs << [blk, args]`
+- Custom `schedule`, `start`, and `loop_execute_jobs` methods
+- Workers now simply loop and pop jobs from single @jobs queue
+
+### Added
+- Custom job execution loop with proper error handling
+- Thread-safe job scheduling with stop_mutex synchronization
+- Graceful shutdown support integrated into job processing loop
+
+### Removed
+- AlwaysReadyQueue class and all null object pattern code
+- Complex worker state tracking and ready_workers queue management
+- Unnecessary abstractions and indirection layers
+
+### Fixed
+- Eliminated all worker queue complexity and potential race conditions
+- Much more predictable and maintainable job processing
+- Simplified shutdown process with clear control flow
+
+### Improved
+- Dramatically simplified codebase with single job queue approach
+- Better performance through reduced complexity
+- Easier to understand and debug job processing flow
+
 ## [0.1.4]
 
 ### Changed

data/README.md

@@ -8,8 +8,9 @@ Simple GRPC::Pool enhancement that replaces worker-based capacity checking with
 
 ## What it does
 
-- Replaces `GRPC::Pool` worker queue management with a simple job count check
-- Uses `jobs_waiting < threshold` instead of tracking actual worker availability
+- Simplifies `GRPC::Pool` by removing complex worker queue management
+- Direct job scheduling to `@jobs` queue with idle thread processing
+- Uses `jobs_waiting < threshold` for capacity management
 - Configurable threshold via `GRUF_MAX_WAITING_REQUESTS` (default: 60)
 - Supports graceful shutdown
 

data/lib/gruf/queue/pool_enhancements.rb

@@ -2,30 +2,58 @@
 
 module Gruf
   module Queue
-    # Null object implementation for worker queue management.
-    # Provides clean interface without complex worker state tracking.
-    class AlwaysReadyQueue
-      def empty? = false
-
-      def <<(*) = self
-
-      def push(*) = self
-
-      def pop = ::Queue.new
-
-      def size = 1
-    end
-
     # Enhanced GRPC::Pool with job count based capacity management
     module PoolEnhancements
       DEFAULT_MAX_WAITING_REQUESTS = 60
 
       def initialize(...)
         super
-        @ready_workers = AlwaysReadyQueue.new
         @max_waiting_requests = ENV.fetch('GRUF_MAX_WAITING_REQUESTS', DEFAULT_MAX_WAITING_REQUESTS).to_i
       end
 
+      def schedule(*args, &blk)
+        return if blk.nil?
+
+        @stop_mutex.synchronize do
+          if @stopped
+            GRPC.logger.warn('did not schedule job, already stopped')
+            return
+          end
+
+          @jobs << [blk, args]
+        end
+      end
+
+      def start
+        @stop_mutex.synchronize do
+          raise 'already stopped' if @stopped
+        end
+        until @workers.size == @size.to_i
+          next_thread = Thread.new do
+            catch(:exit) do # allows { throw :exit } to kill a thread
+              loop_execute_jobs
+            end
+            remove_current_thread
+          end
+          @workers << next_thread
+        end
+      end
+
+      def loop_execute_jobs
+        loop do
+          begin
+            blk, args = @jobs.pop
+            blk.call(*args)
+          rescue StandardError, GRPC::Core::CallError => e
+            GRPC.logger.warn('Error in worker thread')
+            GRPC.logger.warn(e)
+          end
+          @stop_mutex.synchronize do
+            return if @stopped
+          end
+        end
+      end
+
       def ready_for_work?
         return false if @stopped
 

data/lib/gruf/queue/version.rb

@@ -2,6 +2,6 @@
 
 module Gruf
   module Queue
-    VERSION = '0.1.4'
+    VERSION = '0.1.5'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: gruf-queue
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Ether Moon