grpc-rest 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '097d1a366f7eb41bd6a4b1e68f8cacfa84e74013aaed85d3348a8be300503f64'
-  data.tar.gz: ef6e2ca8a7f43577a51d0fb9b85ad2ed6576f8591b33520732c6a62dd976daf2
+  metadata.gz: 5e28479dab1a6c6ed45aaf5a04c293a2e672b4c33e7b55a50df0863aaa8a0b4b
+  data.tar.gz: b813da5fc1c9e3629bbb06e4ca9a8d3b518c4219eff5d5b326eec7f0eac83e3b
 SHA512:
-  metadata.gz: 6a181f74f58f23e2c89b73e24833197e365a167cdea63b55a31635d06349062becc15f9b1ead3572801514587be288fa5aca02f180b8c519a505350ea8e475f5
-  data.tar.gz: fd0c20102f445578d5c21a5a984e95323fbdc9a5d102c8e9d8ccadd17a9b9196896e0a6e6c55ac3fd1c98f6e3b3b6b4669e4ec5573970d1dbf1c1663b9fab46d
+  metadata.gz: 92606239e1d5233e80844311cf26672e58548883af6801e474e3e5cd4c052a050234cd5624024be7f9e29c2b040d5983681c3c9897cb3a7158fd1290f8ed5328
+  data.tar.gz: 50d61f9784a195d55b5566eafc4bc59b25a6fca6bb4e37eb1197b3cb30408020fa91dbf8478a729bc122f262a4d720105a09796d26dedf6c944840de50281283

data/CHANGELOG

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## UNRELEASED
 
+# 0.5.1 - 2025-08-27
+
+- Fix: Better error message for invalid time values.
+
 # 0.5.0 - 2025-08-25
 
 - ***MAJOR CHANGE***: `grpc-rest` now no longer requires any code generation. All functionality is dynamic and loads on startup.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    grpc-rest (0.5.0)
+    grpc-rest (0.5.1)
       google-protobuf (>= 4.30.2)
       grpc
       rails (>= 6.0)

data/lib/grpc_rest/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module GrpcRest
-  VERSION = '0.5.0'
+  VERSION = '0.5.1'
 end

data/lib/grpc_rest.rb

@@ -90,7 +90,12 @@ module GrpcRest
       when 'google.protobuf.Timestamp'
         return Google::Protobuf::Timestamp.from_time(Time.at(val)) if val.is_a?(Numeric)
 
-        Google::Protobuf::Timestamp.from_time(Time.new(val))
+        begin
+          parsed_time = Time.new(val)
+          Google::Protobuf::Timestamp.from_time(parsed_time)
+        rescue ArgumentError => e
+          raise ArgumentError, "Could not parse time value '#{val}': #{e.message}"
+        end
 
       when 'google.protobuf.Value'
         Google::Protobuf::Value.from_ruby(val)

data/spec/grpc_rest_spec.rb

@@ -51,6 +51,22 @@ RSpec.describe 'generated controller', type: :request do
                                            'fullResponse' => %({"testId":"abc","foobar":"xyz","secondRecord":{"subId":"id1","anotherId":"id2"},"timestampField":"2024-04-03T01:02:03Z"})
                                          })
     end
+
+    it 'should return a good error for invalid times' do
+      params = {
+        sub_id: 'id1',
+        another_id: 'id2'
+      }
+
+      post '/test2?test_id=abc&foobar=xyz&timestamp_field=2024-04-03+01:02', params: params, as: :json
+      puts response.body
+      expect(response).not_to be_successful
+      expect(response.parsed_body).
+        to match(hash_including({
+                                  'code' => 3,
+                                  'message' => "InvalidArgument: Could not parse time value '2024-04-03 01:02': missing sec part: 01:02"
+                                }))
+    end
   end
 
   describe 'using sub-record splat' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: grpc-rest
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Daniel Orner