growlyflash 0.6.2 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1208a3344005b31a6d2b1fe928883911448da22b
-  data.tar.gz: 58b15437fc48493ca61a54b1f33adf06699c52e7
+  metadata.gz: 0b15ba027b5bb449f0ab3a2d18a0a8273d73867e
+  data.tar.gz: 5acfd64725e4a5faa2614800696d0b2d818f841f
 SHA512:
-  metadata.gz: 2b667f1531dae94780bf1107d10d07805ea85f91a88f937bba93d68a39bd0a7cebed9fd117c7c7b023de3a5f08b300443cac4ecfcf150ddf1ffac32c16d136c2
-  data.tar.gz: b1736bdcb589afd61ff536ad4ef3c9caa74da130175930a62e4249ea98e5ea174f2040e9a3fa42adf28acb54be50815352974acb83768e9f08401912679d8229
+  metadata.gz: f0554c4b4fdca37baa13ec0fa115884c39ceaef8dd72fce7631070c7d1aab35fb8cc3bc71fdb6ad5c3db2500841748684152a8b60cc9d04d1be4bbcf0880eb41
+  data.tar.gz: a647b4016db94cbeff98a44ec18b91af0b5800b8bfe430fdd0459726403c992e47bd9e612ad36d0c34e0d332b924a0d7b34c24e80e3e6c41a8ddab37c82defc4

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,13 @@
+# Contributor Code of Conduct
+
+As contributors and maintainers of this project, we pledge to respect all people who contribute through reporting issues, posting feature requests, updating documentation, submitting pull requests or patches, and other activities.
+
+We are committed to making participation in this project a harassment-free experience for everyone, regardless of level of experience, gender, gender identity and expression, sexual orientation, disability, personal appearance, body size, race, ethnicity, age, or religion.
+
+Examples of unacceptable behavior by participants include the use of sexual language or imagery, derogatory comments or personal attacks, trolling, public or private harassment, insults, or other unprofessional conduct.
+
+Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct. Project maintainers who do not follow the Code of Conduct may be removed from the project team.
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by opening an issue or contacting one or more of the project maintainers.
+
+This Code of Conduct is adapted from the [Contributor Covenant](http://contributor-covenant.org), version 1.0.0, available at [http://contributor-covenant.org/version/1/0/0/](http://contributor-covenant.org/version/1/0/0/)

data/Gemfile

@@ -4,7 +4,6 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'rails', '>= 3.2.0', '<= 5.0.0'
-gem 'rake', require: false
 
 group :test do
   gem 'minitest'

data/LICENSE.txt

@@ -0,0 +1,21 @@
+The MIT License (MIT)
+
+Copyright (c) 2015 Tõnis Simo
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.

data/README.md

@@ -15,7 +15,7 @@ Warning! Current version breaks integration from older releases, so, if you want
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'growlyflash', '~> 0.5.0'
+gem 'growlyflash', '~> 0.6.0'
 ```
 
 Require one of the following Growlyflash javascripts depending on your Bootstrap version in `app/assets/javascripts/application.js`:
@@ -34,7 +34,7 @@ Import Growlyflash style in `app/assets/stylesheets/application.css.scss` after
 @import "growlyflash";
 ```
 
-To use text flash messages as growl notifications with XHR request, add `use_growlyflash` to your controllers (usually `application_controller.rb`). This is a shorthand for `append_after_filter :flash_to_header, if: :is_xhr_request?` and takes callback parameters like `only`, `except`, `if` or `unless`:
+To use text flash messages as growl notifications with XHR request, add `use_growlyflash` to your controllers (usually `application_controller.rb`). This is a shorthand for `append_after_filter :flash_to_header, if: "request.xhr?"` and takes callback parameters like `only`, `except`, `if` or `unless`:
 
 ```ruby
 use_growlyflash # except: %i[actions without growlyflash]
@@ -76,23 +76,17 @@ $growlyflash-zindex:  9999 !default;
 @import "growlyflash";
 ```
 
-Insert the following if you want to close alert boxes by clicking on themselves. 
+Insert the following if you want to close alert boxes by clicking on themselves.
 Also it doesn't steel focus from toggled elements like dropdowns and works fine with touch devices, so I advise to use it:
 
 ```coffee
 jQuery ->
-  $(document).on 'click.alert.data-api', '[data-dismiss="alert"]', (e) ->
+  $(document).on "touchstart.alert click.alert", ".growlyflash", (e) ->
     e.stopPropagation()
-    off
-  
-  $(document).on 'touchstart click', ".bootstrap-growl", (e) ->
-    e.stopPropagation()
-    $('[data-dismiss="alert"]', @).click()
+    ($ @).alert 'close'
     off
 ```
 
-Also
-
 ## Contributing
 
 1. Fork it

data/growlyflash.gemspec

@@ -2,23 +2,25 @@
 
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+require "growlyflash/version"
 
 Gem::Specification.new do |spec|
   spec.name          = 'growlyflash'
-  spec.version       = '0.6.2'
+  spec.version       = Growlyflash::VERSION
   spec.authors       = ['Tõnis Simo']
   spec.email         = ['anton.estum@gmail.com']
+  spec.summary       = %q{Growl-styled flash messages for Ruby on Rails with Bootstrap.}
+  spec.description   = %q{Growl-styled flash messages for Ruby on Rails with Bootstrap. For XHR requests flash messages are transfering in 'X-Messages' headers, otherwise they are storing in js variables.}
   spec.homepage      = 'https://github.com/estum/growlyflash'
-  spec.summary       = %q{Tiny gem which provides growl-styled flash messages for Ruby on Rails with Bootstrap.}
-  spec.description   = %q{Tiny gem which provides growl-styled flash messages for Ruby on Rails with Bootstrap. For XHR requests flash messages are transfering in 'X-Messages' headers, otherwise they are storing in js variables.}
-  spec.license       = 'MIT'
-  
-  spec.files         = `git ls-files`.split($/)
-  spec.require_paths = %w[app lib]
-  spec.test_files     = Dir['test/**/*']
-  
+  spec.license       = "MIT"
+
+  spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
+  spec.require_paths = ["lib"]
+
   spec.required_ruby_version = ">= 1.9.3"
-  
+
   spec.add_dependency 'railties', '>= 3.2', '< 5.0'
   spec.add_dependency 'coffee-rails', '>= 3.2.1'
+  spec.add_development_dependency "bundler"
+  spec.add_development_dependency "rake"
 end

data/lib/growlyflash.rb

@@ -1,2 +1,6 @@
+require 'growlyflash/version'
 require 'growlyflash/controller_additions'
-require 'growlyflash/engine' if defined?(Rails)
+require 'growlyflash/engine' if defined?(Rails)
+
+module Growlyflash
+end

data/lib/growlyflash/controller_additions.rb

@@ -1,44 +1,45 @@
-require 'active_support/concern'
-
 module Growlyflash
   module ControllerAdditions
-    extend ActiveSupport::Concern
-    
-    included do
-      helper_method :growlyflash_static_notices, :growlyhash
+    def self.included(base)
+      base.module_eval do
+        extend ClassMethods
+        helper_method :growlyflash_static_notices, :growlyhash
+      end
     end
-    
+
     module ClassMethods
       private
+
       def use_growlyflash(options = {})
-        append_after_filter :flash_to_headers, options.reverse_merge(if: :is_xhr_request?)
+        append_after_filter :flash_to_headers, options.reverse_merge(if: "request.xhr?")
       end
-      
+
       def skip_growlyflash(options = {})
         skip_after_filter :flash_to_headers, options
       end
     end
-    
-    private
-    def is_xhr_request?
-      request.xhr?
-    end
-    
+
+    protected
+
+    # Dumps available messages to headers and discards them to prevent appear
+    # it again after refreshing a page
     def flash_to_headers
       response.headers['X-Message'] = URI.escape(growlyhash(true).to_json)
-      
-      # discard flash to prevent it appear again after refreshing page
-      growlyhash.each_key {|k| flash.discard(k) }
+      growlyhash.each_key { |k| flash.discard(k) }
     end
-    
+
+    # View helper method which renders flash messages to js variable if they
+    # weren't dumped to headers with XHR request
     def growlyflash_static_notices(js_var = 'window.flashes')
-      return nil unless flash.any?
-      view_context.javascript_tag "#{js_var} = #{growlyhash.to_json.html_safe};", defer: 'defer'
+      return if flash.empty?
+      script = "#{js_var} = #{growlyhash.to_json.html_safe};".freeze
+      view_context.javascript_tag(script, defer: 'defer')
     end
-    
+
+    # Hash with available growl flash messages which contains a string object.
     def growlyhash(force = false)
       @growlyhash = nil if force
-      @growlyhash ||= flash.to_hash.select {|k, v| v.is_a? String }
+      @growlyhash ||= flash.to_hash.select { |k, v| v.is_a? String }
     end
   end
 end

data/lib/growlyflash/engine.rb

@@ -1,3 +1,5 @@
+require 'rails/engine'
+
 module Growlyflash
   class Engine < ::Rails::Engine
     ActiveSupport.on_load :action_controller do

data/lib/growlyflash/version.rb

@@ -0,0 +1,3 @@
+module Growlyflash
+  VERSION = "0.7.0"
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: growlyflash
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.7.0
 platform: ruby
 authors:
 - Tõnis Simo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-07 00:00:00.000000000 Z
+date: 2015-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -44,9 +44,37 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.1
-description: Tiny gem which provides growl-styled flash messages for Ruby on Rails
-  with Bootstrap. For XHR requests flash messages are transfering in 'X-Messages'
-  headers, otherwise they are storing in js variables.
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description: Growl-styled flash messages for Ruby on Rails with Bootstrap. For XHR
+  requests flash messages are transfering in 'X-Messages' headers, otherwise they
+  are storing in js variables.
 email:
 - anton.estum@gmail.com
 executables: []
@@ -54,7 +82,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- CODE_OF_CONDUCT.md
 - Gemfile
+- LICENSE.txt
 - README.md
 - Rakefile
 - app/assets/javascripts/growlyflash.bs2.js.coffee
@@ -66,8 +96,7 @@ files:
 - lib/growlyflash.rb
 - lib/growlyflash/controller_additions.rb
 - lib/growlyflash/engine.rb
-- test/integration/action_controller/growlyflash_test.rb
-- test/test_helper.rb
+- lib/growlyflash/version.rb
 homepage: https://github.com/estum/growlyflash
 licenses:
 - MIT
@@ -75,7 +104,6 @@ metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
-- app
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
@@ -89,11 +117,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.3
+rubygems_version: 2.4.7
 signing_key: 
 specification_version: 4
-summary: Tiny gem which provides growl-styled flash messages for Ruby on Rails with
-  Bootstrap.
-test_files:
-- test/integration/action_controller/growlyflash_test.rb
-- test/test_helper.rb
+summary: Growl-styled flash messages for Ruby on Rails with Bootstrap.
+test_files: []

data/test/integration/action_controller/growlyflash_test.rb

@@ -1,40 +0,0 @@
-require 'test_helper'
-
-module ActionController
-  module Growlyflash
-    class IntegrationTest < ActionController::TestCase
-      class MyController < ActionController::Base
-        use_growlyflash
-        skip_growlyflash only: [:xhr_skip_growlyflash]
-        
-        def xhr_use_growlyflash
-          flash.notice = "Growlyflash!"
-          flash[:timedout] = true
-          render json: '{}'
-        end
-        
-        def xhr_skip_growlyflash
-          flash.notice = "Growlyflash!"
-          render json: '{}'
-        end
-      end
-      
-      tests MyController
-      
-      def test_xhr_use_growlyflash
-        xhr :get, :xhr_use_growlyflash
-        
-        assert_response 200
-        refute_nil @response.headers['X-Message']
-        assert_equal '{"notice":"Growlyflash!"}', URI.decode_www_form_component(@response.headers['X-Message'])
-      end
-      
-      def test_xhr_skip_growlyflash
-        xhr :get, :xhr_skip_growlyflash
-        
-        assert_response 200
-        assert_nil @response.headers['X-Message']
-      end
-    end
-  end
-end

data/test/test_helper.rb

@@ -1,26 +0,0 @@
-require 'bundler/setup'
-require 'minitest/autorun'
-require 'growlyflash'
-require 'action_controller'
-
-# Ensure backward compatibility with Minitest 4
-Minitest::Test = MiniTest::Unit::TestCase unless defined?(Minitest::Test)
-
-require "minitest/reporters"
-Minitest::Reporters.use! Minitest::Reporters::DefaultReporter.new(:color => true)
-
-module TestHelper
-  Routes = ActionDispatch::Routing::RouteSet.new
-  Routes.draw do
-    get ':controller(/:action(/:id))'
-    get ':controller(/:action)'
-  end
-  
-  ActionController::Base.send :include, Routes.url_helpers
-end
-
-ActionController::TestCase.class_eval do
-  def setup
-    @routes = TestHelper::Routes
-  end
-end