grover 1.2.6 → 1.2.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 52cfb87c3efabd49ef2e83562f918ca7c8f5e0d51721ae52ca35ad9281b2b378
-  data.tar.gz: 6ecadfce0b7efb45a693df41f0065a0136ed315555b65c0580ace664b4f380c1
+  metadata.gz: 7db2892eede2403ccadf9ba0f08437a0baa981891cfa15b352a9a93540fa210e
+  data.tar.gz: 7d1e39781fb526c53f3445545ee810d275cea55c1216b08b1b3f8135027c0d58
 SHA512:
-  metadata.gz: f41aa2df2e2580e1102830315b0845a00cbe4184d2aee839e1161e11fcc22fa794209293ca50c5bb7c543404b79ae71251b7fb3131ae0e1350e8aa72374f0d77
-  data.tar.gz: e7df3f9cca33bf7dd1f18010dbfd01f85f8ac616601f337372ff968e5178a6f54a9429717dcd9a93bb01bcea79446d481374522112b373b96a06b731d243625c
+  metadata.gz: d54d14998ffe44d160b5b4586dc7a41a09f80a63a362b0745916052fc06d126b273c358992fc4a5273e6d7c2c668d18120cad4392409905de56ffa54e0850648
+  data.tar.gz: 58c59d86aceb48f4968bcc1c0ad6bd44b8e7602450e24304da1d61249b6e529ae9614e6c9d15c1fdad1e49f8575cd6a6c282a634af24000532573a68e03f8ca1

data/lib/grover/dev_tools_parser.rb

@@ -0,0 +1,52 @@
+# frozen_string_literal: true
+
+class Grover
+  #
+  # DevToolsParser helper class for simplifying the debug output
+  #
+  class DevToolsParser
+    class << self
+      def parse(raw_devtools_output) # rubocop:disable Metrics/MethodLength
+        lines = raw_devtools_output.strip.split("\n")
+        simplified_output = []
+
+        while lines.any?
+          if starts_with_array_pattern? lines
+            simplified_output.push extract_array_pattern!(lines)
+          elsif starts_with_hash_pattern? lines
+            simplified_output.push extract_hash_pattern!(lines)
+          else
+            simplified_output.push lines.shift
+          end
+        end
+
+        simplified_output
+      end
+
+      private
+
+      def starts_with_array_pattern?(lines)
+        lines.length >= 3 && lines[0].end_with?(' [') && lines[1].start_with?("  '") && lines[2] == ']'
+      end
+
+      def extract_array_pattern!(lines)
+        "#{lines.shift}#{lines.shift[1..]} #{lines.shift}"
+      end
+
+      def starts_with_hash_pattern?(lines)
+        return false unless lines.length >= 3 && lines[0].end_with?(' {')
+
+        last_hash_line = lines[1..].index { |line| !line.match?(/\A  .*,\z/) }
+        return false if last_hash_line.nil?
+
+        lines[last_hash_line + 1].match?(/\A  .*[^,]\z/) && lines[last_hash_line + 2] == '}'
+      end
+
+      def extract_hash_pattern!(lines)
+        result = lines.shift
+        result += lines.shift[1..] while lines[0] != '}'
+        result + " #{lines.shift}"
+      end
+    end
+  end
+end

data/lib/grover/errors.rb

@@ -6,11 +6,18 @@ class Grover
   #
   # Heavily based on the Schmooze library https://github.com/Shopify/schmooze
   #
-  Error = Class.new(StandardError)
-  DependencyError = Class.new(Error)
+  class Error < StandardError
+  end
+
+  class DependencyError < Error
+  end
+
   module JavaScript # rubocop:disable Style/Documentation
-    Error = Class.new(::Grover::Error)
-    UnknownError = Class.new(Error)
+    class Error < ::Grover::Error
+    end
+
+    class UnknownError < Error
+    end
 
     ErrorWithDetails = Class.new(Error) do
       def initialize(name, error_details)
@@ -20,12 +27,17 @@ class Grover
 
       attr_reader :error_details
     end
-    RequestFailedError = Class.new(ErrorWithDetails)
-    PageRenderError = Class.new(ErrorWithDetails)
+    class RequestFailedError < ErrorWithDetails
+    end
+
+    class PageRenderError < ErrorWithDetails
+    end
 
     def self.const_missing(name)
       const_set name, Class.new(Error)
     end
   end
-  UnsafeConfigurationError = Class.new(Error)
+
+  class UnsafeConfigurationError < Error
+  end
 end

data/lib/grover/processor.rb

@@ -26,6 +26,8 @@ class Grover
       cleanup_process if stdin
     end
 
+    attr_reader :debug_output
+
     private
 
     attr_reader :app_root, :stdin, :stdout, :stderr, :wait_thr
@@ -83,6 +85,8 @@ class Grover
       input = stdout.gets
       raise Errno::EPIPE, "Can't read from worker" if input.nil?
 
+      capture_debug_output if node_debug_enabled?
+
       status, message, error_class, errors = JSON.parse(input)
 
       if status == 'ok'
@@ -98,6 +102,18 @@ class Grover
       raise Grover::Error, "Worker process failed:\n#{stderr.read}"
     end
 
+    def capture_debug_output
+      error_output = ''
+      begin
+        loop { error_output += stderr.read_nonblock(4096).force_encoding('UTF-8') }
+      rescue IO::WaitReadable
+        nil
+      end
+      @debug_output = Grover::DevToolsParser.parse(error_output)
+    end
+
+    def node_debug_enabled? = Grover.configuration.node_env_vars.keys.include?('DEBUG')
+
     def cleanup_process
       stdin.close
       stdout.close

data/lib/grover/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Grover
-  VERSION = '1.2.6'
+  VERSION = '1.2.7'
 end

data/lib/grover.rb

@@ -10,6 +10,7 @@ require 'grover/html_preprocessor'
 require 'grover/middleware'
 require 'grover/configuration'
 require 'grover/options_builder'
+require 'grover/dev_tools_parser'
 require 'grover/processor'
 
 require 'nokogiri'
@@ -48,6 +49,7 @@ class Grover
   # @return [String] The resulting PDF data
   #
   def to_pdf(path = nil)
+    @processor = nil # Flush out the processor from any previous use
     processor.convert :pdf, @uri, normalized_options(path: path)
   end
 
@@ -57,6 +59,7 @@ class Grover
   # @return [String] The resulting HTML string
   #
   def to_html
+    @processor = nil # Flush out the processor from any previous use
     processor.convert :content, @uri, normalized_options(path: nil)
   end
 
@@ -68,6 +71,7 @@ class Grover
   # @return [String] The resulting image data
   #
   def screenshot(path: nil, format: nil)
+    @processor = nil # Flush out the processor from any previous use
     options = normalized_options(path: path)
     options['type'] = format if %w[png jpeg].include? format
     processor.convert :screenshot, @uri, options
@@ -111,6 +115,15 @@ class Grover
     back_cover_path.is_a?(::String) && back_cover_path.start_with?('/')
   end
 
+  #
+  # Returns the debug output from the conversion process.
+  #
+  # @return [Array<String>, nil] An array of DevTools log output, or `nil` if DEBUG env var is not enabled
+  #
+  def debug_output
+    processor.debug_output
+  end
+
   #
   # Instance inspection
   #
@@ -141,7 +154,7 @@ class Grover
   end
 
   def processor
-    Processor.new(root_path)
+    @processor ||= Processor.new(root_path)
   end
 
   def normalized_options(path:)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: grover
 version: !ruby/object:Gem::Version
-  version: 1.2.6
+  version: 1.2.7
 platform: ruby
 authors:
 - Andrew Bromwich
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-01-14 00:00:00.000000000 Z
+date: 2026-02-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -36,6 +36,7 @@ files:
 - lib/active_support_ext/object/duplicable.rb
 - lib/grover.rb
 - lib/grover/configuration.rb
+- lib/grover/dev_tools_parser.rb
 - lib/grover/errors.rb
 - lib/grover/html_preprocessor.rb
 - lib/grover/js/processor.cjs