grover 0.6.2 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 1062c1738a1216a3c8fb5907b1abcb5abee7ef4e
-  data.tar.gz: 7a6aea69f2eaa43d30f0c126f0baea36c3b70470
+SHA256:
+  metadata.gz: 0dd2633e1565fccf5aba8c538c7ebbb0d0479f7145b1785031a9029195f20811
+  data.tar.gz: ee046e2a56a34fdb63fb6714c1a0ef6ab3ad1e5273b69d3ffcc59e55449636fc
 SHA512:
-  metadata.gz: 3824873485392bc39b03509cd88f296555aaea0984eaff8158be31bee78fc282d790d86cb988bf05eac1035a866d0306131fd31dd4d67fdca0157e3e241e3721
-  data.tar.gz: 7f2ce9086e1206c2464232f80893b7098272737cb74398299514b6c8ed2f817e4485706965f73f858ac0f5e13c10b58653d84b1d574042b76225da0a954d08bd
+  metadata.gz: 785dcbf00a08efa14ec417f9064844e3bc9ef43dc9968aee31b201af40f1d8a231639bcc0fbd38f991ffa9ed4d202a28f8e48d3d06dde59fd87d06f7b54f3518
+  data.tar.gz: 1c3ebd039422218cc318d91006fd1229449a602bbc6addcddc1a1626224bf193a2811ad80f06b8521cc639d801284c985f3fd4f20d4e6839b39c98d3346f3316

data/lib/grover.rb

@@ -21,15 +21,24 @@ class Grover
     dependencies puppeteer: 'puppeteer'
 
     def self.launch_params
-      ENV['CI'] == 'true' ? "{args: ['--no-sandbox', '--disable-setuid-sandbox']}" : ''
+      ENV['CI'] == 'true' ? "{args: ['--no-sandbox', '--disable-setuid-sandbox']}" : '{}'
     end
 
-    method :convert_pdf, <<-FUNCTION
+    method :convert_pdf, Utils.strip_heredoc(<<-FUNCTION)
       async (url_or_html, options) => {
         let browser;
         try {
+          let launchParams = #{launch_params};
+
+          // Configure puppeteer debugging options
+          const debug = options.debug; delete options.debug;
+          if (debug != undefined) {
+            if (debug.headless != undefined) { launchParams.headless = debug.headless; }
+            if (debug.devtools != undefined) { launchParams.devtools = debug.devtools; }
+          }
+
           // Launch the browser and create a page
-          browser = await puppeteer.launch(#{launch_params});
+          browser = await puppeteer.launch(launchParams);
           const page = await browser.newPage();
 
           // Set caching flag (if provided)
@@ -69,8 +78,10 @@ class Grover
             await page.emulateMedia(emulateMedia);
           }
 
-          // Return the converted PDF
-          return await page.pdf(options);
+          // If we're not running puppeteer in headless mode, return the converted PDF
+          if (debug == undefined || debug.headless == undefined || debug.headless) {
+            return await page.pdf(options);
+          }
         } finally {
           if (browser) {
             await browser.close();
@@ -113,6 +124,8 @@ class Grover
     normalized_options = Utils.normalize_object @options
     normalized_options['path'] = path if path.is_a? ::String
     result = processor.convert_pdf @url, normalized_options
+    return unless result
+
     result['data'].pack('c*')
   end
 

data/lib/grover/middleware.rb

@@ -31,7 +31,7 @@ class Grover
 
     private
 
-    PDF_REGEX = /\.pdf$/i
+    PDF_REGEX = /\.pdf$/i.freeze
 
     def rendering_pdf?
       @render_pdf

data/lib/grover/version.rb

@@ -1,3 +1,3 @@
 class Grover
-  VERSION = '0.6.2'.freeze
+  VERSION = '0.7.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: grover
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.7.1
 platform: ruby
 authors:
 - Andrew Bromwich
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-20 00:00:00.000000000 Z
+date: 2019-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: combine_pdf
@@ -52,20 +52,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.2'
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: pdf-reader
   requirement: !ruby/object:Gem::Requirement
@@ -199,7 +185,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14.1
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A Ruby gem to transform HTML into PDFs wrapper the NodeJS Google Puppeteer