groonga-command 1.1.7 → 1.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 14ad301da5a00c4717492c28e9ac0ca55e35072e
-  data.tar.gz: 52f11a9b2aad40ae6ad12c2458788acaf2aa1310
+  metadata.gz: d0c9670224dc3568111c60739250563fe465a10b
+  data.tar.gz: 7897c976034a57a216e8a9282093f491f10a7583
 SHA512:
-  metadata.gz: f90f2162bb13eb5088246bf0859f439813c91fd92892d7de26c7c2fb83deb28b535c811869d7882dca08d9c38975936e1ca2bdc215f21e573ae2662634517e2c
-  data.tar.gz: abb484c5a5bc9851a92e60babbf247250b7574d92f380c1b384ef52265633960e9d63e0b870b73ba59e4962bc26787e0e26464f730c1107478dc574404564306
+  metadata.gz: ae6987f30293dbdd548e8757fd18ce1e1156105acbcad9fc35930a0ea6d8201a3c94813880c90e683d655aeb3ab39f7de3d1150d9ee2808eb7755072c9966ad2
+  data.tar.gz: 1eeaf1457cdf569d1e02c54afca500465de66f880785b4822d054323c19f501565cf61c6766240502f5831f9f782180e171f912821ff1cb3f3779aa12ca7509c

data/doc/text/news.md

@@ -1,5 +1,20 @@
 # News
 
+## 1.1.8: 2016-03-21
+
+### Improvements
+
+  * {Groonga::Command::Shutdown}: Added.
+  * {Groonga::Command::TableRemove#name}: Added.
+  * {Groonga::Command::TableRemove#dependent?}: Added.
+  * {Groonga::Command::Base#request_id}: Added.
+  * {Groonga::Command.all}: Added.
+  * {Groonga::Command.find}: Supported `Symbol` as command name.
+  * {Groonga::Command#command_name}: Added. Because
+    {Groonga::Command#name} may be overwritten by subclasses. For
+    example, {Groonga::TableRemove#name} overwrites it.
+  * {Groonga::Command#name}: Made deprecated.
+
 ## 1.1.7: 2016-03-07
 
 ### Improvements

data/lib/groonga/command/base.rb

@@ -1,6 +1,4 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2012-2014  Kouhei Sutou <kou@clear-code.com>
+# Copyright (C) 2012-2016  Kouhei Sutou <kou@clear-code.com>
 #
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
@@ -23,12 +21,26 @@ module Groonga
   module Command
     class << self
       @@registered_commands = {}
+      def all
+        @@registered_commands
+      end
+
       def register(name, klass)
-        @@registered_commands[name] = klass
+        @@registered_commands[normalize_name(name)] = klass
       end
 
       def find(name)
-        @@registered_commands[name] || Base
+        @@registered_commands[normalize_name(name)] || Base
+      end
+
+      private
+      def normalize_name(name)
+        case name
+        when String
+          name.to_sym
+        else
+          name
+        end
       end
     end
 
@@ -39,16 +51,28 @@ module Groonga
         end
       end
 
-      attr_reader :name, :arguments
+      attr_reader :command_name, :arguments
       attr_accessor :original_format, :original_source, :path_prefix
-      def initialize(name, pair_arguments, ordered_arguments=[])
-        @name = name
+      def initialize(command_name, pair_arguments, ordered_arguments=[])
+        @command_name = command_name
         @arguments = construct_arguments(pair_arguments, ordered_arguments)
         @original_format = nil
         @original_source = nil
         @path_prefix = "/d/"
       end
 
+      # @deprecated since 1.1.8. Use {#command_name} instead.
+      def name
+        command_name
+      end
+
+      # @return [String] The command name.
+      #
+      # @since 1.1.8
+      def command_name
+        @command_name
+      end
+
       def [](name)
         @arguments[normalize_name(name)]
       end
@@ -80,6 +104,13 @@ module Groonga
         (self[:output_type] || :json).to_sym
       end
 
+      # @return [String, nil] `request_id` parameter value.
+      #
+      # @since 1.1.8
+      def request_id
+        self[:request_id]
+      end
+
       def to_uri_format
         Format::URI.new(@path_prefix, @name, normalized_arguments).path
       end

data/lib/groonga/command/shutdown.rb

@@ -0,0 +1,43 @@
+# Copyright (C) 2016  Kouhei Sutou <kou@clear-code.com>
+#
+# This library is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Lesser General Public
+# License as published by the Free Software Foundation; either
+# version 2.1 of the License, or (at your option) any later version.
+#
+# This library is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public
+# License along with this library; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+
+require "groonga/command/base"
+
+module Groonga
+  module Command
+    # A command class that represents `shutdown` command.
+    #
+    # @since 1.1.8
+    class Shutdown < Base
+      Command.register("shutdown", self)
+
+      class << self
+        def parameter_names
+          [
+            :mode,
+          ]
+        end
+      end
+
+      # @return [String] `mode` parameter value.
+      #
+      # @since 1.1.8
+      def mode
+        self[:mode]
+      end
+    end
+  end
+end

data/lib/groonga/command/table-remove.rb

@@ -1,6 +1,4 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2012  Kouhei Sutou <kou@clear-code.com>
+# Copyright (C) 2012-2016  Kouhei Sutou <kou@clear-code.com>
 #
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
@@ -27,9 +25,24 @@ module Groonga
         def parameter_names
           [
             :name,
+            :dependent,
           ]
         end
       end
+
+      # @return [String] `name` parameter value.
+      #
+      # @since 1.1.8
+      def name
+        self[:name]
+      end
+
+      # @return [Boolean] `dependent` parameter value.
+      #
+      # @since 1.1.8
+      def dependent?
+        self[:dependent] != "no"
+      end
     end
   end
 end

data/lib/groonga/command/version.rb

@@ -16,6 +16,6 @@
 
 module Groonga
   module Command
-    VERSION = "1.1.7"
+    VERSION = "1.1.8"
   end
 end

data/lib/groonga/command.rb

@@ -53,6 +53,7 @@ require "groonga/command/request-cancel"
 require "groonga/command/ruby-eval"
 require "groonga/command/ruby-load"
 require "groonga/command/select"
+require "groonga/command/shutdown"
 require "groonga/command/status"
 require "groonga/command/suggest"
 require "groonga/command/table-create"

data/test/command/test-shutdown.rb

@@ -0,0 +1,46 @@
+# Copyright (C) 2016  Kouhei Sutou <kou@clear-code.com>
+#
+# This library is free software; you can redistribute it and/or
+# modify it under the terms of the GNU Lesser General Public
+# License as published by the Free Software Foundation; either
+# version 2.1 of the License, or (at your option) any later version.
+#
+# This library is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+# Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public
+# License along with this library; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301  USA
+
+class ShutdownCommandTest < Test::Unit::TestCase
+  private
+  def shutdown_command(pair_arguments={}, ordered_arguments=[])
+    Groonga::Command::Shutdown.new("shutdown",
+                                   pair_arguments,
+                                   ordered_arguments)
+  end
+
+  class ConstructorTest < self
+    def test_ordered_arguments
+      mode = "immediate"
+
+      command = shutdown_command({},
+                                 [
+                                   mode,
+                                 ])
+      assert_equal({
+                     :mode => mode,
+                   },
+                   command.arguments)
+    end
+  end
+
+  class ModeTest < self
+    def test_reader
+      command = shutdown_command(:mode => "immediate")
+      assert_equal("immediate", command.mode)
+    end
+  end
+end

data/test/command/test-table-remove.rb

@@ -1,6 +1,4 @@
-# -*- coding: utf-8 -*-
-#
-# Copyright (C) 2012-2013  Kouhei Sutou <kou@clear-code.com>
+# Copyright (C) 2012-2016  Kouhei Sutou <kou@clear-code.com>
 #
 # This library is free software; you can redistribute it and/or
 # modify it under the terms of the GNU Lesser General Public
@@ -27,12 +25,39 @@ class TableRemoveCommandTest < Test::Unit::TestCase
   class ConstructorTest < self
     def test_ordered_arguments
       name = "Users"
+      dependent = "yes"
 
-      command = table_remove_command({}, [name])
+      command = table_remove_command({}, [name, dependent])
       assert_equal({
                      :name => name,
+                     :dependent => dependent,
                    },
                    command.arguments)
     end
   end
+
+  class NameTest < self
+    def test_reader
+      command = table_remove_command(:name => "Users")
+      assert_equal("Users", command.name)
+    end
+  end
+
+  class DependentTest < self
+    class ReaderTest < self
+      def test_default
+        command = table_remove_command
+        assert do
+          command.dependent?
+        end
+      end
+
+      def test_no
+        command = table_remove_command(:dependent => "no")
+        assert do
+          not command.dependent?
+        end
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: groonga-command
 version: !ruby/object:Gem::Version
-  version: 1.1.7
+  version: 1.1.8
 platform: ruby
 authors:
 - Kouhei Sutou
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-06 00:00:00.000000000 Z
+date: 2016-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -174,6 +174,7 @@ files:
 - lib/groonga/command/ruby-eval.rb
 - lib/groonga/command/ruby-load.rb
 - lib/groonga/command/select.rb
+- lib/groonga/command/shutdown.rb
 - lib/groonga/command/status.rb
 - lib/groonga/command/suggest.rb
 - lib/groonga/command/table-create.rb
@@ -220,6 +221,7 @@ files:
 - test/command/test-ruby-eval.rb
 - test/command/test-ruby-load.rb
 - test/command/test-select.rb
+- test/command/test-shutdown.rb
 - test/command/test-status.rb
 - test/command/test-suggest.rb
 - test/command/test-table-create.rb
@@ -258,51 +260,52 @@ specification_version: 4
 summary: Groonga-command is a library that represents [Groonga](http://groonga.org/)'s
   command. You can write a program that handle Groonga's command by using groonga-command.
 test_files:
-- test/run-test.rb
-- test/command/test-object-exist.rb
-- test/command/test-register.rb
-- test/command/test-suggest.rb
-- test/command/test-log-level.rb
-- test/command/test-ruby-load.rb
-- test/command/test-object-inspect.rb
-- test/command/test-tokenize.rb
-- test/command/test-table-list.rb
-- test/command/test-column-copy.rb
+- test/groonga-command-test-utils.rb
+- test/command/test-config-delete.rb
+- test/command/test-object-remove.rb
+- test/command/test-table-tokenize.rb
+- test/command/test-reindex.rb
+- test/command/test-plugin-unregister.rb
 - test/command/test-io-flush.rb
+- test/command/test-base.rb
+- test/command/test-logical-count.rb
+- test/command/test-table-rename.rb
+- test/command/test-column-rename.rb
 - test/command/test-dump.rb
-- test/command/test-table-tokenize.rb
-- test/command/test-object-remove.rb
-- test/command/test-thread-limit.rb
-- test/command/test-logical-range-filter.rb
+- test/command/test-normalize.rb
+- test/command/test-config-get.rb
+- test/command/test-register.rb
+- test/command/test-shutdown.rb
+- test/command/test-delete.rb
+- test/command/test-column-copy.rb
+- test/command/test-tokenize.rb
+- test/command/test-log-put.rb
 - test/command/test-load.rb
-- test/command/test-config-delete.rb
 - test/command/test-column-list.rb
-- test/command/test-plugin-unregister.rb
-- test/command/format/test-command.rb
 - test/command/test-plugin-register.rb
-- test/command/test-reindex.rb
+- test/command/test-request-cancel.rb
+- test/command/test-column-create.rb
+- test/command/test-config-set.rb
+- test/command/test-logical-range-filter.rb
+- test/command/test-object-inspect.rb
+- test/command/format/test-command.rb
+- test/command/test-logical-select.rb
+- test/command/test-get.rb
+- test/command/test-thread-limit.rb
+- test/command/test-table-list.rb
+- test/command/test-object-exist.rb
+- test/command/test-log-level.rb
+- test/command/test-range-filter.rb
 - test/command/test-status.rb
-- test/command/test-config-get.rb
+- test/command/test-logical-shard-list.rb
+- test/command/test-suggest.rb
 - test/command/test-select.rb
 - test/command/test-column-remove.rb
-- test/command/test-table-rename.rb
 - test/command/test-ruby-eval.rb
-- test/command/test-range-filter.rb
-- test/command/test-column-rename.rb
-- test/command/test-request-cancel.rb
-- test/command/test-log-put.rb
-- test/command/test-get.rb
 - test/command/test-table-create.rb
-- test/command/test-logical-select.rb
-- test/command/test-config-set.rb
-- test/command/test-base.rb
-- test/command/test-normalize.rb
-- test/command/test-logical-count.rb
-- test/command/test-logical-shard-list.rb
-- test/command/test-column-create.rb
-- test/command/test-delete.rb
-- test/command/test-truncate.rb
 - test/command/test-table-remove.rb
+- test/command/test-ruby-load.rb
+- test/command/test-truncate.rb
 - test/command/test-logical-table-remove.rb
-- test/groonga-command-test-utils.rb
+- test/run-test.rb
 has_rdoc: