grim 0.2.3 → 0.2.4

data/lib/grim.rb

@@ -27,6 +27,10 @@ module Grim
   class PathMissing < Grim::Exception
   end
 
+  # Exception that is raised if Grim::Page#save can't process the page
+  class UnprocessablePage < Grim::Exception
+  end
+
   # Creates and returns a new instance of Grim::Pdf
   #
   # path - a path string or object

data/lib/grim/page.rb

@@ -36,12 +36,12 @@ module Grim
       density = options.fetch(:density, Grim::DENSITY)
       quality = options.fetch(:quality, Grim::QUALITY)
 
-      SafeShell.execute("convert", "-resize", width, "-antialias", "-render",
+      output = SafeShell.execute("convert", "-resize", width, "-antialias", "-render",
                         "-quality", quality, "-colorspace", "RGB",
                         "-interlace", "none", "-density", density,
                         "#{@pdf.path}[#{@index}]", path)
 
-      File.exists?(path)
+      $? == 0 || raise(UnprocessablePage, output)
     end
 
     # Extracts the text from the selected page.

data/lib/grim/version.rb

@@ -1,4 +1,4 @@
 # encoding: UTF-8
 module Grim
-  VERSION = "0.2.3" unless defined?(::Grim::VERSION)
+  VERSION = "0.2.4" unless defined?(::Grim::VERSION)
 end

data/spec/lib/grim/page_spec.rb

@@ -86,6 +86,15 @@ describe Grim::Page do
     end
   end
 
+  describe "#save with an unprocessable PDF" do
+    let(:path) { tmp_path("unprocessable.jpg") }
+    let(:pdf)  { Grim::Pdf.new(fixture_path("unprocessable.pdf")) }
+
+    it "should raise an error" do
+      lambda { pdf[0].save(path) }.should raise_error(Grim::UnprocessablePage, /missing an image filename/)
+    end
+  end
+
   describe "#text" do
     it "should return the text from the selected page" do
       pdf = Grim::Pdf.new(fixture_path("smoker.pdf"))

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: grim
 version: !ruby/object:Gem::Version 
-  hash: 17
+  hash: 31
   prerelease: 
   segments: 
   - 0
   - 2
-  - 3
-  version: 0.2.3
+  - 4
+  version: 0.2.4
 platform: ruby
 authors: 
 - Jonathan Hoyt
@@ -15,10 +15,12 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-09-12 00:00:00 Z
+date: 2011-09-27 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  version_requirements: &id001 !ruby/object:Gem::Requirement 
+  name: safe_shell
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
@@ -29,10 +31,8 @@ dependencies:
         - 0
         - 0
         version: 1.0.0
-  prerelease: false
   type: :runtime
-  requirement: *id001
-  name: safe_shell
+  version_requirements: *id001
 description: Grim is a simple gem for extracting a page from a pdf and converting it to an image as well as extract the text from the page as a string. It basically gives you an easy to use api to ghostscript, imagemagick, and pdftotext specific to this use case.
 email: 
 - jonmagic@gmail.com
@@ -55,6 +55,7 @@ files:
 - lib/grim/version.rb
 - lib/pdf_info.ps
 - spec/fixtures/smoker.pdf
+- spec/fixtures/unprocessable.pdf
 - spec/lib/grim/page_spec.rb
 - spec/lib/grim/pdf_spec.rb
 - spec/lib/grim_spec.rb
@@ -94,6 +95,7 @@ specification_version: 3
 summary: Extract slides and text from a PDF.
 test_files: 
 - spec/fixtures/smoker.pdf
+- spec/fixtures/unprocessable.pdf
 - spec/lib/grim/page_spec.rb
 - spec/lib/grim/pdf_spec.rb
 - spec/lib/grim_spec.rb