gridium 1.1.35 → 1.1.36

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bc44fb52f1320ccaf47d6d2ba4632e29b2f642e0
-  data.tar.gz: ce69715beb35d69201f86c9266309afcf536ab42
+  metadata.gz: dc394adb83e2168340ced467ae4f27984776bc91
+  data.tar.gz: 131259a3fb64cbec4df0c59443199f27d15f7aad
 SHA512:
-  metadata.gz: 6bf31c51af9cf634972368b93d4aceb9423f238b6102015651d2ec96252f69eb932680e99327070ee65ecc165c226cca53c1dfa24d63538b1e471503ffc5c91e
-  data.tar.gz: 10c88c36c9c2a03a49604d0f4fc1d79a81e458bd21d798481b8c9d94167d6959e476e422411c7bf5d01f0efcc4209b912bbda6b9841b951a408adbb4645f187d
+  metadata.gz: d4bce2e0436804761bc3e6339da75fd0ea37177c4996ffe065cae100b1210d8ac2bed1eb3501256d4768e71bcb72c5e9927e29e258cffc1590f977d35847b572
+  data.tar.gz: 4dfc11fade041d3309a9ef17c846a380e54fd61b6b8537a775c9c63bf27835576917e44396b44a89497a82e93c91e2f3a3f9198251087e439dcfeda524749824

data/lib/element.rb

@@ -94,14 +94,22 @@ class Element
     element.attribute(name)
   end
 
-  # Requires element to have an ID value, to successfully use `document.getElementById`
+  # Requires element to have an unique css
+  # @param [String] name - attribute name
+  # @param [String] value - attribute value to set
   def set_attribute(name, value)
-    id = self.attribute('id')
-    if id.nil? || id.empty?
-      Log.warn("[GRIDIUM::Element] #{self} does not have an 'id'. Consider adding one.")
+    Log.debug("[GRIDIUM::Element] setting element attribute '#{name}' to '#{value}'")
+
+    if self.by == :css
+      ElementExtensions.set_attribute(self.locator, name, value)
     else
-      Log.debug("[GRIDIUM::Element] setting element attribute '#{name}' to '#{value}'")
-      ElementExtensions.set_attribute(id, name, value)
+      # see if the element has an id to work with
+      id = self.attribute('id')
+      if id.nil? || id.empty?
+        Log.warn("[GRIDIUM::Element] #{self} does not have an 'id'. Consider adding one.")
+      else
+        ElementExtensions.set_attribute("[id=#{id}", name, value)
+      end
     end
   end
 

data/lib/element_extensions.rb

@@ -59,12 +59,12 @@ class Gridium::ElementExtensions
 
     #
     # Use Javascript to set element attribute value from :id
-    # @param [String] id
-    # @param [String] Attribute
-    # @param [String] value
+    # @param [String] selector  - css selector for find element by
+    # @param [String] attribute - element attribute to set
+    # @param [String] value     - element value to set
     #
-    def set_attribute(id, attr, val)
-      Driver.execute_script_driver("document.getElementById('#{id}').setAttribute('#{attr}', '#{val}')");
+    def set_attribute(selector, attr, val)
+      Driver.execute_script_driver("document.querySelectorAll('#{selector}')[0].setAttribute('#{attr}', '#{val}')")
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: gridium
 version: !ruby/object:Gem::Version
-  version: 1.1.35
+  version: 1.1.36
 platform: ruby
 authors:
 - Seth Urban
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-09-22 00:00:00.000000000 Z
+date: 2017-09-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler