grell 1.6.6 → 1.6.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 98ea3ab2a0070ed58b888f4776894e391a6d59fa
-  data.tar.gz: 478b4fe3cd8326d52543ba38961ac4318434ee44
+  metadata.gz: 416346b7f2b8e8fe95ce0269599227929be4360f
+  data.tar.gz: 98b06e25d9d87e926a263d28023a2e0f5a22c24e
 SHA512:
-  metadata.gz: dc7b0b0bf90b51ee8d7c881e5eec6ce3a8d7d3058eac99ed5f1f4ed8cfb55f34b41c6f2bacbd9fc836e889eb67af0555996211b7411754e006951a48dcd9dccf
-  data.tar.gz: de50bdceca2dd0177fe20bcc9127018723859bb727b827cf464553d4cd5e598436dbb53fdafcead8184faeb0e9d2b2f3c0c6cd24c809c777277fcc7bc0264d07
+  metadata.gz: c435a95ee0d6a6116999e7d916db607ae16eab5f6cdad379d04fdc6e7160b1ff5420460b6c06c87bd39f1ee27a4451e22f10c565ea756690b1833afb093a8c4d
+  data.tar.gz: 65766dbde21e449906daaf5661d2a74064f05b286033461461196db11345df31bb7a7ca130e6d9b29e6384019fc32d6ea2b27fbe87215f9fb18111e5f475c0f9

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 1.6.7
+  * Increment '@times_visited' first to avoid infinite retries when rescuing errors
+
 # 1.6.6
   * Updated phantomjs_logger not to open '/dev/null'
 

data/lib/grell/page.rb

@@ -33,11 +33,12 @@ module Grell
       end
       @result_page = VisitedPage.new(@rawpage)
       @timestamp = Time.now
-      @times_visited += 1
     rescue Capybara::Poltergeist::BrowserError, Capybara::Poltergeist::DeadClient,
            Capybara::Poltergeist::JavascriptError, Capybara::Poltergeist::StatusFailError,
            Capybara::Poltergeist::TimeoutError, Errno::ECONNRESET, URI::InvalidURIError => e
       unavailable_page(404, e)
+    ensure
+      @times_visited += 1
     end
 
     # Number of times we have retried the current page

data/lib/grell/version.rb

@@ -1,3 +1,3 @@
 module Grell
-  VERSION = "1.6.6".freeze
+  VERSION = "1.6.7".freeze
 end

data/spec/lib/page_spec.rb

@@ -102,6 +102,7 @@ RSpec.describe Grell::Page do
       expect(page).to be_visited
       expect(page.timestamp).to eq(now)
       expect(page.error?).to eq(true)
+      expect(page.instance_variable_get(:@times_visited)).to eq(1)
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: grell
 version: !ruby/object:Gem::Version
-  version: 1.6.6
+  version: 1.6.7
 platform: ruby
 authors:
 - Jordi Polo Carres
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-11 00:00:00.000000000 Z
+date: 2016-06-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara