grell 1.6.9 → 1.6.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2a7136c81652b0260ee867e65380e69e5d3a2264
-  data.tar.gz: f95af6c4e4a99aa1216f8842c8829af521f7b1d9
+  metadata.gz: 866f1b7117624455b79791bacba549710eb7dc2b
+  data.tar.gz: 4a3646c053bb7b4884fa8b82ebb24809d2d37f97
 SHA512:
-  metadata.gz: 5b6c238c9894254531f5448dd5435603009b01c0c1fef015b748f3a91a662fa81fd0c7bbe882b95d88e8cbe91beee342222877f889931d5ed186cf0e2d03ef4e
-  data.tar.gz: 76a390dc30e53275ded279b27a8bd6ebabe4d9cefb0cc7367563467cd86fd37e6bb20440810d237137f400d72af6dd289602603ff6f70dce8f3bd6906f6d24e2
+  metadata.gz: dfb07e7c0a6a7fb2fe53a40a3da248a24ba683972c696ab7064481448cb4067403dc7350d34cbba21ff4f240fb09b3571adbb36b38bfecd28aeee1ea1551638e
+  data.tar.gz: 7f91a206fd4cb264d73b05468dce66d858637c6d675b92088b800a85b67599201f957f879d618a0f4fc7a538de79c3211f82ffc3d73b063fec760da09209578a

data/.travis.yml

@@ -6,3 +6,9 @@ rvm:
   - 2.2.4
   - 2.3.0
 script: bundle exec rspec
+
+before_install:
+  - mkdir travis-phantomjs
+  - wget https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-2.1.1-linux-x86_64.tar.bz2 -O $PWD/travis-phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2
+  - tar -xvf $PWD/travis-phantomjs/phantomjs-2.1.1-linux-x86_64.tar.bz2 -C $PWD/travis-phantomjs
+  - export PATH=$PWD/travis-phantomjs/phantomjs-2.1.1-linux-x86_64/bin:$PATH

data/CHANGELOG.md

@@ -1,5 +1,9 @@
+# 1.6.10
+  * Avoid following JS href links, add missing dependencies to fix Travis build
+
 # 1.6.9
   * Avoid following links when disabled by CSS (1.6.8 worked only for Javascript)
+
 # 1.6.8
   * Avoid following disabled links
 

data/README.md

@@ -23,7 +23,7 @@ Or install it yourself as:
 
 Grell uses PhantomJS, you will need to download and install it in your
 system. Check for instructions in http://phantomjs.org/
-Grell has been tested with PhantomJS v1.9.x
+Grell has been tested with PhantomJS v2.1.x
 
 ## Usage
 

data/grell.gemspec

@@ -24,12 +24,14 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'capybara', '~> 2.7'
   spec.add_dependency 'poltergeist', '~> 1.10'
 
-  spec.add_development_dependency "bundler", "~> 1.6"
-  spec.add_development_dependency "byebug", "~> 4.0"
-  spec.add_development_dependency "kender", '~> 0.2'
-  spec.add_development_dependency "rake", '~> 10.0'
-  spec.add_development_dependency "webmock", '~> 1.18'
+  spec.add_development_dependency 'bundler', '~> 1.6'
+  spec.add_development_dependency 'byebug', '~> 4.0'
+  spec.add_development_dependency 'kender', '~> 0.2'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'webmock', '~> 1.18'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'puffing-billy', '~> 0.5'
   spec.add_development_dependency 'timecop', '~> 0.8'
+  spec.add_development_dependency 'capybara-webkit', '~> 1.11.1'
+  spec.add_development_dependency 'selenium-webdriver', '~> 2.53.4'
 end

data/lib/grell/page.rb

@@ -206,7 +206,7 @@ module Grell
       private
       def all_links
         links =  @rawpage.all_anchors.map { |anchor| Link.new(anchor) }
-        body_enabled_links = links.reject { |link| link.inside_header? || link.disabled? }
+        body_enabled_links = links.reject { |link| link.inside_header? || link.disabled? || link.js_href? }
         body_enabled_links.map { |link| link.to_url(host) }.uniq.compact
 
       rescue Capybara::Poltergeist::ObsoleteNode
@@ -232,6 +232,11 @@ module Grell
           @anchor.disabled? || !!@anchor.native.attributes['disabled']
         end
 
+        # Does the href use javascript?
+        def js_href?
+          href.start_with?('javascript:')
+        end
+
         # Some links may use data-href + javascript to do interesting things
         def href
           @anchor['href'] || @anchor['data-href']

data/lib/grell/version.rb

@@ -1,3 +1,3 @@
 module Grell
-  VERSION = "1.6.9".freeze
+  VERSION = "1.6.10".freeze
 end

data/spec/spec_helper.rb

@@ -2,7 +2,7 @@ require 'grell'
 require 'byebug'
 require 'timecop'
 require 'webmock/rspec'
-require 'billy/rspec'
+require 'billy/capybara/rspec'
 require 'rack'
 require 'rack/server'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: grell
 version: !ruby/object:Gem::Version
-  version: 1.6.9
+  version: 1.6.10
 platform: ruby
 authors:
 - Jordi Polo Carres
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-13 00:00:00.000000000 Z
+date: 2016-07-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -150,6 +150,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.8'
+- !ruby/object:Gem::Dependency
+  name: capybara-webkit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.11.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.11.1
+- !ruby/object:Gem::Dependency
+  name: selenium-webdriver
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.53.4
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.53.4
 description: Ruby web crawler using PhantomJS
 email:
 - jcarres@mdsol.com