green_syslogger 0.2.0 → 0.2.1

data/Manifest

@@ -1,6 +1,13 @@
 Manifest
 README.md
 Rakefile
-green_syslogger.gemspec
+experimental_test/benchmarks.txt
+experimental_test/green_syslogger_benchmarks_test.rb
+experimental_test/green_syslogger_mutithread_test.rb
+experimental_test/ruby_prof_buffered_logger.txt
+experimental_test/ruby_prof_green_syslogger.txt
+experimental_test/ruby_prof_syslog_logger.txt
+experimental_test/testing_singleton_methods_with_variable.rb
 lib/green_syslogger.rb
 test/green_syslogger_test.rb
+test/test_helper.rb

data/README.md

@@ -22,10 +22,12 @@ Custom Rails Logger
     logger = GreenSyslogger.new
     logger.debug( 'debug message' )
 
-To install it configure it on the <RAILS_ENVIRONMENT>.rb:
-    config.logger = GreenSyslogger.new(<default tag>, <facility>, <level>)
+To configure it on the <RAILS_ENVIRONMENT>.rb:
+
+    config.logger = GreenSyslogger.new([<default tag>], [<facility>], [<level>])
 
 By default
+
     GreenSyslogger.new('rails', 'local2', :debug)
 
 Example for Rails configuration:
@@ -40,9 +42,9 @@ To use it:
     logger.debug("my debug message")
     logger.error("my error message")
 
-To user another tag:
+To use another tag:
 
-    logger.custom("my custom message", <tag>, <level>)
+    logger.custom("my custom message", [<tag>], [<level>])
 
 By default:
 
@@ -54,12 +56,18 @@ In the `GreenSyslogger.custom` there are two reopen connections just to be allow
 
 There is not `GreenSyslogger.silencer`. Maybe is a good idea to implemented.
 
+Benchmarking to compare with other logger libraries and to see with is the cost of the `reopen` calls.
+
 ## Change log
 
 ### v 0.2.0
 
 * Compatible with `config.logger.auto_flushing = false` so every log of a simple request will be written on an atomic way
 
+### v 0.2.1
+
+* Avoiding Thread blocking
+* Optimization
 
 ## Credits
 

data/Rakefile

@@ -2,7 +2,7 @@ require 'rubygems'
 require 'rake'  
 require 'echoe'  
   
-Echoe.new('green_syslogger', '0.2.0') do |p|  
+Echoe.new('green_syslogger', '0.2.1') do |p|  
   p.description     = "Syslogger that makes your life greener"  
   p.url             = "https://github.com/SponsorPay/GreenSyslogger"  
   p.author          = "Fernando Guillen <http://fernandoguillen.info> & Juan Jose Vidal <@j2vidal>"

data/experimental_test/benchmarks.txt

@@ -0,0 +1,40 @@
+# normal
+green_syslogger_buffered:  2.640000   0.890000   3.530000 (  3.668854)
+
+# with copy_buffer
+green_syslogger_buffered:  2.620000   0.890000   3.510000 (  3.607195)
+
+# regex comprobation before .gsub!
+green_syslogger_buffered:  2.530000   0.890000   3.420000 (  3.460330)
+
+# with the DATE_FORMAT constant
+green_syslogger_buffered:  2.150000   0.870000   3.020000 (  3.766759)
+(slower!)
+
+# without the 'auto_flush' method call
+green_syslogger_buffered:  2.130000   0.860000   2.990000 (  3.796795)
+(no changes!!)
+
+# MAX_BUFFER=5
+green_syslogger_buffered:  2.220000   0.870000   3.090000 (  3.590922)
+(faster!)
+
+# MAX_BUFFER=1
+green_syslogger_buffered:  2.560000   0.910000   3.470000 (  4.080794)
+(slower!)
+
+# more strings to Constants
+green_syslogger_buffered:  2.140000   0.860000   3.000000 (  3.641767)
+(faster!)
+
+# without .strftime
+green_syslogger_buffered:  2.190000   0.860000   3.050000 (  3.683527)
+(no changes!)
+
+# without print Time
+green_syslogger_buffered:  1.850000   0.880000   2.730000 (  3.428737)
+(faster!)
+
+# without the message = #message
+green_syslogger_buffered:  1.780000   0.890000   2.670000 (  3.470216)
+(no changes!)

data/experimental_test/green_syslogger_benchmarks_test.rb

@@ -0,0 +1,61 @@
+require "#{File.dirname(__FILE__)}/../test/test_helper"
+
+class GreenSysloggerBenchmarksTest < Test::Unit::TestCase
+  # def test_all_loggers
+  #   logger = Logger.new( "/tmp/log.txt" )
+  #   syslog_logger = SyslogLogger.new
+  #   buffered_logger = ActiveSupport::BufferedLogger.new( "/tmp/log2.txt" )
+  #   buffered_logger.auto_flushing = false
+  #       
+  #   n = 50000
+  # 
+  #   Benchmark.bm(7) do |x|
+  #     x.report("logger:")          { n.times do   ; logger.debug('message'); end }
+  #     x.report("syslog_logger:")   { n.times do   ; syslog_logger.debug('message'); end }
+  #     x.report("buffered_logger:") { n.times do   ; buffered_logger.debug('message'); end }
+  #   end
+  #   
+  #   SyslogLogger::SYSLOG.close
+  #   
+  #   green_syslogger = GreenSyslogger.new
+  #   Benchmark.bm(7) do |x|
+  #     x.report("gren_syslogger:")  { n.times do   ; green_syslogger.debug('message'); end }
+  #   end
+  #   
+  #   green_syslogger.auto_flushing = false
+  #   Benchmark.bm(7) do |x|
+  #     x.report("green_syslogger_buffered:")  { n.times do   ; green_syslogger.debug('message'); end }
+  #   end
+  #   
+  #   Benchmark.bm(7) do |x|
+  #     x.report("gren_syslogger_custom:")  { n.times do   ; green_syslogger.custom('message'); end }
+  #   end
+  #   
+  #   green_syslogger.close
+  # end
+  
+  def test_only_green_syslogger
+    n = 50000
+    green_syslogger = GreenSyslogger.new
+    green_syslogger.auto_flushing = false
+    
+    Benchmark.bm(7) do |x|
+      x.report("green_syslogger_buffered:")  { n.times do   ; green_syslogger.debug('message'); end }
+    end
+    
+    green_syslogger.close
+  end
+  
+  # def test_only_bufffered_syslogger
+  #   n = 50000
+  #   logger = BufferedSyslogger.new
+  #   logger.level = Logger::DEBUG
+  #   
+  #   Benchmark.bm(7) do |x|
+  #     x.report("buffered_syslogger:")  { n.times do   ; logger.debug('message');  end }
+  #   end
+  #   
+  #   logger.close
+  # end
+
+end

data/experimental_test/green_syslogger_mutithread_test.rb

@@ -0,0 +1,74 @@
+require "#{File.dirname(__FILE__)}/../test/test_helper"
+
+class GreenSysloggerMultithreadTest < Test::Unit::TestCase
+  def test_multithread
+    flushing_times = 5
+    flusing_at = 5
+    
+    t1 = 
+      Thread.new do
+        green_syslogger = GreenSyslogger.new
+        green_syslogger.auto_flushing = false
+      
+        (1..flushing_times).each do |n|
+          (1..flusing_at).each do |nn|
+            green_syslogger.debug("thread 1 #{n}-#{nn}")
+          end
+          green_syslogger.flush
+          sleep(0.5)
+        end
+      end
+  
+    t2 =
+      Thread.new do
+        green_syslogger = GreenSyslogger.new
+        green_syslogger.auto_flushing = false
+        (1..flushing_times).each do |n|
+          (1..flusing_at).each do |nn|
+            green_syslogger.debug("thread 2 #{n}-#{nn}")
+          end
+          green_syslogger.flush
+          sleep(1)
+        end
+      end
+    
+    while( t1.alive? || t2.alive? ) do
+      sleep(1)
+    end
+  end
+  
+  # def test_multithread_syslog_logger
+  #   flushing_times = 10
+  #   flusing_at = 10
+  #   
+  #   Thread.new do
+  #     puts "init thread 1---"
+  #     green_syslogger = SyslogLogger.new
+  #     
+  #     (1..flushing_times).each do |n|
+  #       (1..flusing_at).each do |nn|
+  #         green_syslogger.debug("thread 1 #{n}-#{nn}")
+  #       end
+  #       # green_syslogger.flush
+  #       puts "flushed thread 1"
+  #       sleep(1)
+  #     end
+  #   end
+  #   
+  #   Thread.new do
+  #     green_syslogger = SyslogLogger.new
+  #     (1..flushing_times).each do |n|
+  #       (1..flusing_at).each do |nn|
+  #         puts "XXX: thread 2 debug"
+  #         green_syslogger.debug("thread 2 #{n}-#{nn}")
+  #       end
+  #       puts "flushing thread 2"
+  #       # green_syslogger.flush
+  #       puts "flushed thread 2"
+  #       sleep(1)
+  #     end
+  #   end
+  #   
+  #   sleep(100)
+  # end
+end

data/experimental_test/ruby_prof_buffered_logger.txt

@@ -0,0 +1,56 @@
+$ ruby-prof green_syslogger_benchmarks.rb 
+             user     system      total        real
+buffered_logger:  1.420000   1.640000   3.060000 (  3.073966)
+Thread ID: 2148237740
+Total: 3.096940
+
+ %self     total     self     wait    child    calls  name
+ 29.93      2.75     0.93     0.00     1.83    50000  ActiveSupport::BufferedLogger#add
+ 13.99      0.86     0.43     0.00     0.43   100100  ActiveSupport::BufferedLogger#buffer
+ 10.02      1.12     0.31     0.00     0.81    50000  ActiveSupport::BufferedLogger#auto_flush
+  7.00      0.32     0.22     0.00     0.10   100218  Hash#[]
+  5.76      2.93     0.18     0.00     2.75    50000  ActiveSupport::BufferedLogger#debug
+  4.19      3.06     0.13     0.00     2.93        1  Integer#times
+  3.62      0.28     0.11     0.00     0.17       84  Array#each
+  3.40      0.11     0.11     0.00     0.00   100150  <Class::Thread>#current
+  3.34      0.10     0.10     0.00     0.00   100200  Kernel#hash
+  3.29      0.16     0.10     0.00     0.06    50000  StringIO#<<
+  1.85      0.06     0.06     0.00     0.00    50012  Fixnum#>
+  1.83      0.06     0.06     0.00     0.00    50001  Array#<<
+  1.81      0.06     0.06     0.00     0.00    50000  StringIO#write
+  1.80      0.06     0.06     0.00     0.00    50047  String#to_s
+  1.80      0.06     0.06     0.00     0.00    50000  String#[]
+  1.76      0.05     0.05     0.00     0.00    50024  Array#size
+  1.75      0.05     0.05     0.00     0.00    50032  Fixnum#==
+  1.66      0.05     0.05     0.00     0.00    50000  Fixnum#>=
+  0.31      0.01     0.01     0.00     0.01       18  Kernel#gem_original_require
+  0.15      0.00     0.00     0.00     0.00       33  <Class::Dir>#[]
+  0.13      0.01     0.00     0.00     0.00       44  Array#select
+  0.06      0.00     0.00     0.00     0.00       53  IO#write
+  0.06      0.00     0.00     0.00     0.00     1572  String#=~
+  0.04      0.27     0.00     0.00     0.27       52  Mutex#synchronize
+  0.02      3.07     0.00     0.00     3.07        1  <Class::GreenSysloggerBenchmarks>#do
+  0.02      0.01     0.00     0.00     0.01       33  Gem::GemPathSearcher#matching_files
+  0.02      0.00     0.00     0.00     0.00       94  String#gsub!
+  0.02      0.00     0.00     0.00     0.00       29  ActiveSupport::Inflector#underscore
+  0.02      0.00     0.00     0.00     0.00       30  ActiveSupport::Autoload#autoload
+  0.01      0.00     0.00     0.00     0.00       12  Integer#upto
+  0.01      0.01     0.00     0.00     0.01        6  <Module::Gem>#activate
+  0.01      0.00     0.00     0.00     0.00       82  Class#new
+  0.01      0.00     0.00     0.00     0.00      250  Kernel#instance_variables
+  0.01      0.00     0.00     0.00     0.00       10  Module#class_eval
+  0.01      0.00     0.00     0.00     0.00      223  Module#method_added
+  0.01      0.00     0.00     0.00     0.00      258  Array#include?
+  0.01      0.00     0.00     0.00     0.00       50  ActiveSupport::BufferedLogger#clear_buffer
+  0.01      0.00     0.00     0.00     0.00       12  Gem::Version#<=>
+  0.01      3.10     0.00     0.00     3.10        1  Kernel#load
+  0.01      0.01     0.00     0.00     0.01        6  Gem::SourceIndex#search
+  0.01      0.00     0.00     0.00     0.00       96  Hash#[]=
+  0.01      0.00     0.00     0.00     0.00        6  Kernel#eval
+  0.01      0.00     0.00     0.00     0.00       50  StringIO#initialize
+  0.01      0.27     0.00     0.00     0.27       50  ActiveSupport::BufferedLogger#flush
+  0.01      0.00     0.00     0.00     0.00       76  Gem::Version#segments
+  0.01      0.00     0.00     0.00     0.00        8  Gem::Dependency#initialize
+  0.01      0.00     0.00     0.00     0.00       50  Hash#delete
+  0.01      0.00     0.00     0.00     0.00      140  Module#===
+  0.00      0.01     0.00     0.00     0.01       33  Gem::Ge

data/experimental_test/ruby_prof_green_syslogger.txt

@@ -0,0 +1,79 @@
+$ ruby-prof green_syslogger_benchmarks.rb 
+             user     system      total        real
+gren_syslogger_buffered:  4.180000   3.630000   7.810000 (  7.928079)
+Thread ID: 2148237740
+Total: 7.846172
+
+ %self     total     self     wait    child    calls  name
+ 27.15      2.13     2.13     0.00     0.00    50000  <Module::<#Syslog: opened=true, ident="rails", options=1, facility=144, mask=255>>#debug
+ 15.62      4.19     1.23     0.00     2.96      131  Array#each
+ 10.75      7.43     0.84     0.00     6.58    50000  GreenSyslogger#add
+  5.46      0.85     0.43     0.00     0.43   100100  GreenSyslogger#buffer
+  4.91      0.49     0.39     0.00     0.10   250214  Hash#[]
+  4.87      0.38     0.38     0.00     0.00   350046  Array#[]
+  4.81      0.65     0.38     0.00     0.27    50000  GreenSyslogger#level?
+  4.22      5.04     0.33     0.00     4.71    50000  GreenSyslogger#auto_flush
+  3.54      0.28     0.28     0.00     0.00    50000  Time#strftime
+  3.34      7.69     0.26     0.00     7.43    50000  GreenSyslogger#debug
+  2.06      0.30     0.16     0.00     0.14    50002  <Class::Time>#now
+  1.84      2.27     0.14     0.00     2.13    50000  Kernel#send
+  1.55      7.81     0.12     0.00     7.69        1  Integer#times
+  1.40      0.11     0.11     0.00     0.00    50094  String#gsub!
+  1.35      0.11     0.11     0.00     0.00   100200  <Class::Thread>#current
+  1.33      0.10     0.10     0.00     0.00   100000  Fixnum#>=
+  1.32      0.10     0.10     0.00     0.00   100300  Kernel#hash
+  1.05      0.08     0.08     0.00     0.00    50002  <Class::Time>#allocate
+  0.77      0.06     0.06     0.00     0.00    50092  String#==
+  0.75      0.06     0.06     0.00     0.00    50002  Time#initialize
+  0.73      0.06     0.06     0.00     0.00    50001  Array#<<
+  0.69      0.05     0.05     0.00     0.00    50024  Array#size
+  0.13      0.01     0.01     0.00     0.01       16  Kernel#gem_original_require
+  0.08      0.01     0.01     0.00     0.00       33  <Class::Dir>#[]
+  0.05      0.01     0.00     0.00     0.00       44  Array#select
+  0.02      0.00     0.00     0.00     0.00     1572  String#=~
+  0.01      4.17     0.00     0.00     4.17      102  Mutex#synchronize
+  0.01      4.18     0.00     0.00     4.18      100  GreenSyslogger#flush
+  0.01      0.00     0.00     0.00     0.00      100  GreenSyslogger#clear_buffer
+  0.01      0.01     0.00     0.00     0.01       33  Gem::GemPathSearcher#matching_files
+  0.01      0.00     0.00     0.00     0.00       29  ActiveSupport::Inflector#underscore
+  0.01      0.00     0.00     0.00     0.00       30  ActiveSupport::Autoload#autoload
+  0.01      7.85     0.00     0.00     7.85        1  Kernel#load
+  0.01      0.00     0.00     0.00     0.00      146  Hash#[]=
+  0.01      0.00     0.00     0.00     0.00      100  Hash#delete
+  0.01      0.00     0.00     0.00     0.00       12  Integer#upto
+  0.01      0.01     0.00     0.00     0.01        6  <Module::Gem>#activate
+  0.00      0.00     0.00     0.00     0.00      250  Kernel#instance_variables
+  0.00      0.00     0.00     0.00     0.00      258  Array#include?
+  0.00      0.00     0.00     0.00     0.00       12  Gem::Version#<=>
+  0.00      0.00     0.00     0.00     0.00      192  Module#method_added
+  0.00      0.01     0.00     0.00     0.01        6  Gem::SourceIndex#search
+  0.00      0.00     0.00     0.00     0.00      107  Hash#default
+  0.00      0.00     0.00     0.00     0.00        6  Kernel#eval
+  0.00      0.00     0.00     0.00     0.00       76  Gem::Version#segments
+  0.00      0.00     0.00     0.00     0.00        8  Gem::Dependency#initialize
+  0.00      0.00     0.00     0.00     0.00        6  Hash#values
+  0.00      0.00     0.00     0.00     0.00      140  Module#===
+  0.00      0.03     0.00     0.00     0.03       14  Kernel#require
+  0.00      0.01     0.00     0.00     0.01       33  Gem::GemPathSearcher#matching_file?
+  0.00      0.00     0.00     0.00     0.00       27  Class#new
+  0.00      0.00     0.00     0.00     0.00       12  Module#define_method
+  0.00      0.00     0.00     0.00     0.00       35  Kernel#dup
+  0.00      0.00     0.00     0.00     0.00       53  <Class::File>#join
+  0.00      0.00     0.00     0.00     0.00        7  Module#attr_accessor
+  0.00      0.00     0.00     0.00     0.00        3  Hash#each_key
+  0.00      0.00     0.00     0.00     0.00       11  Array#map
+  0.00      0.00     0.00     0.00     0.00       10  Gem::Specification#full_gem_path
+  0.00      0.00     0.00     0.00     0.00        6  <Class::SyslogLogger>#make_methods
+  0.00      0.00     0.00     0.00     0.00        6  Gem::Requirement#initialize
+  0.00      0.00     0.00     0.00     0.00       66  Symbol#to_s
+  0.00      0.00     0.00     0.00     0.00        1  <Module::<#Syslog: opened=true, ident="rails", options=1, facility=144, mask=255>>#open
+  0.00      0.00     0.00     0.00     0.00       10  Gem::Specification#full_name
+  0.00      0.00     0.00     0.00     0.00        5  Array#index
+  0.00      0.00     0.00     0.00     0.00       13  Module#attr_reader
+  0.00      0.00     0.00     0.00     0.00       33  <Module::Gem>#suffix_pattern
+  0.00      0.00     0.00     0.00     0.00        6  Gem::Version#initialize
+  0.00      0.00     0.00     0.00     0.00       10  Gem::Specification#installation_path
+  0.00      0.00     0.00     0.00     0.00        6  <Class::Gem::Requirement>#parse
+  0.00      0.00     0.00     0.00     0.00        1  ActiveSupport::Autoload#eager_autoload
+  0.00      0.00     0.00     0.00     0.00       10  <Class::File>#directory?
+  0.00      0.00     0.00     0.00     0.00       51  Arr

data/experimental_test/ruby_prof_syslog_logger.txt

@@ -0,0 +1,63 @@
+$ ruby-prof green_syslogger_benchmarks.rb 
+             user     system      total        real
+syslog_logger:  2.230000   1.850000   4.080000 (  4.161498)
+Thread ID: 2148237740
+Total: 4.119740
+
+ %self     total     self     wait    child    calls  name
+ 51.96      2.14     2.14     0.00     0.00    50000  <Module::<#Syslog: opened=true, ident="rails", options=3, facility=8, mask=255>>#debug
+ 15.05      1.18     0.62     0.00     0.56    50000  SyslogLogger#clean
+ 12.78      3.90     0.53     0.00     3.37    50000  SyslogLogger#debug
+  4.47      4.08     0.18     0.00     3.90        1  Integer#times
+  4.31      0.29     0.18     0.00     0.11    50035  Kernel#dup
+  3.42      0.14     0.14     0.00     0.00   100094  String#gsub!
+  1.58      0.07     0.07     0.00     0.00    50006  String#strip!
+  1.42      0.06     0.06     0.00     0.00    50030  String#initialize_copy
+  1.41      0.06     0.06     0.00     0.00    50047  String#to_s
+  1.37      0.06     0.06     0.00     0.00    50030  <Class::String>#allocate
+  1.37      0.06     0.06     0.00     0.00    50000  Fixnum#<
+  0.26      0.01     0.01     0.00     0.01       18  Kernel#gem_original_require
+  0.12      0.00     0.00     0.00     0.00       33  <Class::Dir>#[]
+  0.10      0.01     0.00     0.00     0.00       44  Array#select
+  0.04      0.00     0.00     0.00     0.00     1572  String#=~
+  0.03      0.02     0.00     0.00     0.01       34  Array#each
+  0.02      4.09     0.00     0.00     4.09        1  <Class::GreenSysloggerBenchmarks>#do
+  0.01      0.01     0.00     0.00     0.01       33  Gem::GemPathSearcher#matching_files
+  0.01      0.00     0.00     0.00     0.00       10  Module#class_eval
+  0.01      0.00     0.00     0.00     0.00       29  ActiveSupport::Inflector#underscore
+  0.01      0.00     0.00     0.00     0.00       30  ActiveSupport::Autoload#autoload
+  0.01      0.00     0.00     0.00     0.00       12  Integer#upto
+  0.01      0.01     0.00     0.00     0.01        6  <Module::Gem>#activate
+  0.01      0.00     0.00     0.00     0.00      250  Kernel#instance_variables
+  0.01      0.00     0.00     0.00     0.00      223  Module#method_added
+  0.01      0.00     0.00     0.00     0.00      258  Array#include?
+  0.01      0.00     0.00     0.00     0.00       12  Gem::Version#<=>
+  0.01      4.12     0.00     0.00     4.12        1  Kernel#load
+  0.01      0.01     0.00     0.00     0.01        6  Gem::SourceIndex#search
+  0.01      0.00     0.00     0.00     0.00        6  Kernel#eval
+  0.00      0.00     0.00     0.00     0.00       76  Gem::Version#segments
+  0.00      0.00     0.00     0.00     0.00       32  Class#new
+  0.00      0.00     0.00     0.00     0.00        8  Gem::Dependency#initialize
+  0.00      0.00     0.00     0.00     0.00      140  Module#===
+  0.00      0.00     0.00     0.00     0.00       14  Module#attr_reader
+  0.00      0.00     0.00     0.00     0.00      118  Hash#[]
+  0.00      0.03     0.00     0.00     0.03       16  Kernel#require
+  0.00      0.01     0.00     0.00     0.01       33  Gem::GemPathSearcher#matching_file?
+  0.00      0.00     0.00     0.00     0.00        6  Hash#values
+  0.00      0.00     0.00     0.00     0.00       12  Module#define_method
+  0.00      0.00     0.00     0.00     0.00       53  <Class::File>#join
+  0.00      0.00     0.00     0.00     0.00        8  Module#attr_accessor
+  0.00      0.00     0.00     0.00     0.00       78  Symbol#to_s
+  0.00      0.00     0.00     0.00     0.00        3  Hash#each_key
+  0.00      0.00     0.00     0.00     0.00       92  String#==
+  0.00      0.00     0.00     0.00     0.00       11  Array#map
+  0.00      0.00     0.00     0.00     0.00        6  Gem::Requirement#initialize
+  0.00      0.00     0.00     0.00     0.00       10  Gem::Specification#full_gem_path
+  0.00      0.00     0.00     0.00     0.00        6  <Class::SyslogLogger>#make_methods
+  0.00      0.00     0.00     0.00     0.00        1  <Module::<#Syslog: opened=true, ident="rails", options=3, facility=8, mask=255>>#open
+  0.00      0.00     0.00     0.00     0.00       10  Gem::Specification#full_name
+  0.00      0.00     0.00     0.00     0.00       10  Gem::Specification#installation_path
+  0.00      0.00     0.00     0.00     0.00       33  <Module::Gem>#suffix_pattern
+  0.00      0.00     0.00     0.00     0.00        5  Array#index
+  0.00      0.00     0.00     0.00     0.00        6  Gem::Version#initialize
+  0.00      0.00     0.00     0.00     0.00        6  <Class

data/experimental_test/testing_singleton_methods_with_variable.rb

@@ -0,0 +1,33 @@
+class TestingSingletonMethodsWithVariable
+  METHODS = %w(a b c d)
+
+  def initialize(favorite_method)
+    class << self
+      METHODS.each do |method_name|
+        if( favorite_method == method_name )
+          define_method method_name do
+            puts "#{method_name} its my favorite method"
+          end
+        else
+          define_method method_name do
+            puts "#{method_name} its not my favorite method"
+          end
+        end
+      end
+    end
+  end
+end
+
+t = TestingSingletonMethodsWithVariable.new('b')
+t.a
+t.b
+t.c
+t.d
+
+
+# $ ruby test/testing_singleton_methods_with_variable.rb 
+# test/testing_singleton_methods_with_variable.rb:7:in `initialize': undefined local variable or method `favorite_method' for #<Class:#<TestingSingletonMethodsWithVariable:0x1001a77b8>> (NameError)
+#   from test/testing_singleton_methods_with_variable.rb:6:in `each'
+#   from test/testing_singleton_methods_with_variable.rb:6:in `initialize'
+#   from test/testing_singleton_methods_with_variable.rb:21:in `new'
+#   from test/testing_singleton_methods_with_variable.rb:21

data/green_syslogger.gemspec

@@ -2,22 +2,22 @@
 
 Gem::Specification.new do |s|
   s.name = %q{green_syslogger}
-  s.version = "0.2.0"
+  s.version = "0.2.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
   s.authors = ["Fernando Guillen <http://fernandoguillen.info> & Juan Jose Vidal <@j2vidal>"]
-  s.date = %q{2010-11-12}
+  s.date = %q{2010-11-17}
   s.description = %q{Syslogger that makes your life greener}
   s.email = %q{fguillen.mail@gmail.com}
   s.extra_rdoc_files = ["README.md", "lib/green_syslogger.rb"]
-  s.files = ["Manifest", "README.md", "Rakefile", "green_syslogger.gemspec", "lib/green_syslogger.rb", "test/green_syslogger_test.rb"]
+  s.files = ["Manifest", "README.md", "Rakefile", "experimental_test/benchmarks.txt", "experimental_test/green_syslogger_benchmarks_test.rb", "experimental_test/green_syslogger_mutithread_test.rb", "experimental_test/ruby_prof_buffered_logger.txt", "experimental_test/ruby_prof_green_syslogger.txt", "experimental_test/ruby_prof_syslog_logger.txt", "experimental_test/testing_singleton_methods_with_variable.rb", "lib/green_syslogger.rb", "test/green_syslogger_test.rb", "test/test_helper.rb", "green_syslogger.gemspec"]
   s.homepage = %q{https://github.com/SponsorPay/GreenSyslogger}
   s.rdoc_options = ["--line-numbers", "--inline-source", "--title", "Green_syslogger", "--main", "README.md"]
   s.require_paths = ["lib"]
   s.rubyforge_project = %q{green_syslogger}
   s.rubygems_version = %q{1.3.7}
   s.summary = %q{Syslogger that makes your life greener}
-  s.test_files = ["test/green_syslogger_test.rb"]
+  s.test_files = ["test/green_syslogger_test.rb", "test/test_helper.rb"]
 
   if s.respond_to? :specification_version then
     current_version = Gem::Specification::CURRENT_SPECIFICATION_VERSION

data/lib/green_syslogger.rb

@@ -9,31 +9,37 @@ require 'syslog'
 # * Posibility to use custom 'tag' only in a concrete point so you can configure Syslog to filter this concrete message to another file
 # * Compatible with `config.logger.auto_flushing = false` so every log of a simple request will be written on an atomic way
 #
-# To install it configure it on the <RAILS_ENVIRONMENT>.rb:
-#    config.logger = GreenSyslogger.new(<default tag>, <facility>, <level>)
-#
+#     require 'green_syslogger'
+#     logger = GreenSyslogger.new
+#     logger.debug( 'debug message' )
+# 
+# To configure it on the <RAILS_ENVIRONMENT>.rb:
+# 
+#     config.logger = GreenSyslogger.new([<default tag>], [<facility>], [<level>])
+# 
 # By default
+# 
 #     GreenSyslogger.new('rails', 'local2', :debug)
-#
+# 
 # Example for Rails configuration:
-#
-#    config.log_level = :info
-#    config.logger = GreenSyslogger.new('myapp', 'local1', config.log_level)
-#    config.colorize_logging = false
-#    config.logger.auto_flushing = false
-#
+# 
+#     config.log_level = :info
+#     config.logger = GreenSyslogger.new('myapp', 'local1', config.log_level)
+#     config.colorize_logging = false
+#     config.logger.auto_flushing = false
+# 
 # To use it: 
-#
-#    logger.debug("my debug message")
-#    logger.error("my error message")
-#
-# To user another tag:
-#
-#    logger.custom("my custom message", <tag>, <level>)
-#
+# 
+#     logger.debug("my debug message")
+#     logger.error("my error message")
+# 
+# To use another tag:
+# 
+#     logger.custom("my custom message", [<tag>], [<level>])
+# 
 # By default:
-#
-#    logger.custom("my custom message", 'custom', :info)
+# 
+#     logger.custom("my custom message", 'custom', :info)
 #
 class GreenSyslogger
   attr_accessor :level
@@ -49,6 +55,14 @@ class GreenSyslogger
   }
   
   DEFAULT_MAX_BUFFER_SIZE = 500
+  DATE_FORMAT = '%Y-%m-%d %H:%M:%S'
+  SEPARATOR = '---'
+  RAILS_REQUEST_INIT = "\n\nStarted"
+  RAILS_REQUEST_INIT_CLEANED = "Started"
+  RAILS_REQUEST_INIT_REGEX = /\n\nStarted/
+  
+  @@syslog = nil
+  @@guard = nil
   
   def initialize(tag = 'rails', facility = 'local2', level = :debug)
     @tag = tag
@@ -56,12 +70,19 @@ class GreenSyslogger
     @level = level
     @max_buffer_size = 1
     @buffer = {}
-    @guard = Mutex.new
-    @syslog = Syslog.open(@tag, Syslog::LOG_PID, Syslog.const_get("LOG_#{@facility.upcase}"))
+    
+    if( !@@guard )
+      @@guard = Mutex.new
+    end
+    
+    if( !@@syslog || !@@syslog.opened? )
+      @@syslog = Syslog.open(@tag, Syslog::LOG_PID, Syslog.const_get("LOG_#{@facility.upcase}"))
+    end
   end
   
   def close
-    @syslog.close
+    flush
+    @@syslog.close
   end
 
   # This method is a kind of a back door, using it you can 
@@ -70,12 +91,12 @@ class GreenSyslogger
   # level default to 'info'
   # tag default 'ids-custom'
   def custom(message, tag = 'custom', level = :info)
-    add(tag, level, message)
+    add(tag, level, message)  if(level?(level))
   end
   
   LEVELS_MAP.each_key do |level|
     define_method level do |message|
-      add(@tag, level, message)
+      add(@tag, level, message)  if(level?(level))
     end
     
     define_method "#{level}?" do
@@ -94,26 +115,24 @@ class GreenSyslogger
   end
   
   def flush
-    @guard.synchronize do
-      buffer.each do |buff|
-        date = buff[0]
-        tag = buff[1]
-        level = buff[2]
-        message = buff[3]
-        
-        message = "[#{date.strftime('%Y-%m-%d %H:%M:%S')}] #{message}"
+    @@guard.synchronize do
+      unless buffer.empty?
+        copy_buffer = buffer
+        copy_buffer.each do |date, tag, level, message|
+          message = "[#{date.strftime(DATE_FORMAT)}] #{message}"
         
-        if(tag == @tag)
-          @syslog.send(LEVELS_MAP[level][0], message)
-        else
-          @syslog = Syslog.reopen(tag, Syslog::LOG_PID, Syslog.const_get("LOG_#{@facility.upcase}"))
-          @syslog.send(LEVELS_MAP[level][0], message)
-          @syslog = Syslog.reopen(@tag, Syslog::LOG_PID, Syslog.const_get("LOG_#{@facility.upcase}"))
+          if(tag == @tag)
+            @@syslog.send(LEVELS_MAP[level][0], message)
+          else
+            @@syslog = Syslog.reopen(tag, Syslog::LOG_PID, Syslog.const_get("LOG_#{@facility.upcase}"))
+            @@syslog.send(LEVELS_MAP[level][0], message)
+            @@syslog = Syslog.reopen(@tag, Syslog::LOG_PID, Syslog.const_get("LOG_#{@facility.upcase}"))
+          end
         end
       end
+      
+      @buffer.delete(Thread.current)  # clear buffer
     end
-    
-    clear_buffer
   end
   
   
@@ -123,29 +142,24 @@ class GreenSyslogger
       LEVELS_MAP[level][1] >= LEVELS_MAP[@level][1]
     end
     
-    def add(tag, level, message)
-      if(level?(level))
-        # The init of the request
-        if( message.gsub!("\n\nStarted", 'Started') )
-          add(tag, level, '---')
-        end
-        
-        buffer << [Time.now, tag, level, message]
-        auto_flush
+    def add(tag, level, message)      
+      # The init of the Rails request
+      if( message.gsub!(RAILS_REQUEST_INIT, RAILS_REQUEST_INIT_CLEANED) )
+        buffer << [Time.now, tag, level, SEPARATOR]
       end
+
+      buffer << [Time.now, tag, level, message]
+
+      auto_flush  
     end
-    
+
     def auto_flush
       self.flush  if buffer.size >= @max_buffer_size
     end
-
+    
     def buffer
       @buffer[Thread.current] ||= []
     end
-
-    def clear_buffer
-      @buffer.delete(Thread.current)
-    end
     
     # This is really only for debbugging
     def log_to_file(message)

data/test/green_syslogger_test.rb

@@ -1,9 +1,4 @@
-require 'rubygems'
-require 'test/unit'
-require 'mocha'
-require 'delorean'
-require File.expand_path(File.dirname(__FILE__) + '/../lib/green_syslogger')
-
+require "#{File.dirname(__FILE__)}/test_helper"
 
 class GreenSysloggerTest < Test::Unit::TestCase
   
@@ -17,7 +12,8 @@ class GreenSysloggerTest < Test::Unit::TestCase
   end
 
   def test_initialize_by_default
-    Syslog.expects(:open).with('rails', Syslog::LOG_PID, Syslog::LOG_LOCAL2).returns( @logger.instance_eval('@syslog') )
+    GreenSyslogger.class_eval('@@syslog').expects(:opened?).returns(false)
+    Syslog.expects(:open).with('rails', Syslog::LOG_PID, Syslog::LOG_LOCAL2).returns( GreenSyslogger.class_eval('@@syslog') )
     @logger = GreenSyslogger.new
     
     assert_equal('rails', @logger.instance_eval("@tag"))
@@ -27,7 +23,8 @@ class GreenSysloggerTest < Test::Unit::TestCase
   end
   
   def test_initialize_with_params
-    Syslog.expects(:open).with('my tag', Syslog::LOG_PID, Syslog::LOG_LOCAL3).returns( @logger.instance_eval('@syslog') )
+    GreenSyslogger.class_eval('@@syslog').expects(:opened?).returns(false)
+    Syslog.expects(:open).with('my tag', Syslog::LOG_PID, Syslog::LOG_LOCAL3).returns( GreenSyslogger.class_eval('@@syslog') )
     @logger = GreenSyslogger.new('my tag', 'local3', :info)
     
     assert_equal('my tag', @logger.instance_eval("@tag"))
@@ -97,22 +94,31 @@ class GreenSysloggerTest < Test::Unit::TestCase
   end
   
   def test_flush
-    @syslog = @logger.instance_eval('@syslog')
-    Syslog.expects(:reopen).returns(@syslog).times(2)
-    @syslog.expects(:debug).times(2)
-    @syslog.expects(:info).times(2)
+    syslog = GreenSyslogger.class_eval('@@syslog')
+    
+    order = sequence("order")
+    
+    syslog.expects(:debug).with('[2010-10-10 10:10:10] wadus debug').in_sequence(order)
+    syslog.expects(:info).with('[2010-10-10 10:10:10] wadus info').in_sequence(order)
+    Syslog.expects(:reopen).with('new tag', Syslog::LOG_PID, Syslog::LOG_LOCAL2).returns(syslog).in_sequence(order)
+    syslog.expects(:info).with('[2010-10-10 10:10:10] wadus custom tag info').in_sequence(order)
+    Syslog.expects(:reopen).with('rails', Syslog::LOG_PID, Syslog::LOG_LOCAL2).returns(syslog).in_sequence(order)  
+    syslog.expects(:debug).with('[2010-10-10 10:10:10] wadus debug again').in_sequence(order)
     
     @logger.auto_flushing = false
-    @logger.debug('wadus debug')
-    @logger.info('wadus info')
-    @logger.custom('wadus custom tag info', 'new tag', :info)
-    @logger.debug('wadus info again')
 
+    Delorean.time_travel_to('2010-10-10 10:10:10') do
+      @logger.debug('wadus debug')
+      @logger.info('wadus info')
+      @logger.custom('wadus custom tag info', 'new tag', :info)
+      @logger.debug('wadus debug again')
+    end
+    
     @logger.flush
   end
   
   def test_especial_case_init_of_request
-    @logger.expects(:auto_flush).twice
+    @logger.instance_eval('buffer').expects(:<<).twice
     @logger.info("\n\nStarted")
   end
 end

data/test/test_helper.rb

@@ -0,0 +1,12 @@
+require 'rubygems'
+require 'test/unit'
+require 'mocha'
+require 'delorean'
+require 'logger'
+require 'syslog_logger'
+require 'active_support'
+require 'fileutils'
+require 'benchmark'
+require 'stringio'
+require 'buffered_syslogger'
+require File.expand_path(File.dirname(__FILE__) + '/../lib/green_syslogger')

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: green_syslogger
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 21
   prerelease: false
   segments: 
   - 0
   - 2
-  - 0
-  version: 0.2.0
+  - 1
+  version: 0.2.1
 platform: ruby
 authors: 
 - Fernando Guillen <http://fernandoguillen.info> & Juan Jose Vidal <@j2vidal>
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-11-12 00:00:00 +01:00
+date: 2010-11-17 00:00:00 +01:00
 default_executable: 
 dependencies: []
 
@@ -32,9 +32,17 @@ files:
 - Manifest
 - README.md
 - Rakefile
-- green_syslogger.gemspec
+- experimental_test/benchmarks.txt
+- experimental_test/green_syslogger_benchmarks_test.rb
+- experimental_test/green_syslogger_mutithread_test.rb
+- experimental_test/ruby_prof_buffered_logger.txt
+- experimental_test/ruby_prof_green_syslogger.txt
+- experimental_test/ruby_prof_syslog_logger.txt
+- experimental_test/testing_singleton_methods_with_variable.rb
 - lib/green_syslogger.rb
 - test/green_syslogger_test.rb
+- test/test_helper.rb
+- green_syslogger.gemspec
 has_rdoc: true
 homepage: https://github.com/SponsorPay/GreenSyslogger
 licenses: []
@@ -77,3 +85,4 @@ specification_version: 3
 summary: Syslogger that makes your life greener
 test_files: 
 - test/green_syslogger_test.rb
+- test/test_helper.rb