greatest_updated_at 0.0.1 → 0.1.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: b4972e75f678551d7572c46d2679fb160dbfa395
+  data.tar.gz: 17d201b2f70d4123fbfee160637ab560c3651043
+SHA512:
+  metadata.gz: 4c1184bab68f4ec25cddd1218de294e3158bdda49693cd49f1419c4edd527f0bc2b34790b0a0cc2b7f4c65aa3f0729eb28cead7d28244b7bf389180ad8c09f5f
+  data.tar.gz: 82b418b5ac5272b5006ecdd5b7309caf03c6bffab8001bc34a1201c571518bfdc4b817f835adc67b88a68db69ce872236fd7f63be8a5a79435da41ae3c493d72

data/lib/greatest_updated_at/calculations.rb

@@ -3,24 +3,52 @@ module GreatestUpdatedAt
     # a dumb method for getting the most recently updated date from the named tables.
     # Note that if the tables are not selected in your query as named you will receive an error.
     def greatest_updated_at_from_tables(table_names)
-      max_calcs = Array(table_names).collect{|name|
-        "MAX(#{connection.quote_table_name(name.to_s.pluralize)}.#{connection.quote_column_name("updated_at")})"
-      }
+      self.pluck(greatest_select_val(table_names)).first
+    end
+    
+    # Make an attempt to get the most recently updated record out of all the
+    # included (aka preloaded) records
+    def greatest_updated_at
+      # Force everything included to be in the query via LEFT OUTER JOIN
+      relation = self.eager_load(self.includes_values)
       
-      if max_calcs.length == 1
-        pluck_val = max_calcs.first
-      else
-        pluck_val = "GREATEST(#{max_calcs.join(",")})"
+      # Using this to get a list of tables included via join statements, we don't want to calculate based on those
+      alias_tracker = ActiveRecord::Associations::AliasTracker.create(relation.klass.connection, relation.joins_values)
+      join_tables = alias_tracker.aliases.keys
+      
+      if relation.eager_loading?
+        relation.send(:find_with_associations) { |rel| relation = rel };nil
       end
+      relation.select_values = ['1'] #placeholder while we generate the initial arel
+      arel = relation.arel
+
+      # collect the list of table names we want to get the max updated at from
+      join_nodes = arel.join_sources.reject{ |join| join.kind_of?(Arel::Nodes::StringJoin) }
+      table_names = join_nodes.collect{ |join|  join.left.name } 
+      
+      # remove the join tables and make sure the root table is present 
+      table_names = (table_names - join_tables) | [relation.klass.table_name]
       
-      self.pluck(pluck_val).first
+      # Clear the arel projection, it used to be a placeholder
+      arel.projections = []
+      
+      arel.project greatest_select_val(table_names)
 
+      relation.klass.connection.select_value(arel, 'SQL', arel.bind_values + relation.bind_values)
+      
     end
     
-    # Make an attempt to get the most recently updated record out of all the
-    # included (aka preloaded) records
-    def greatest_updated_at
-      greatest_updated_at_from_tables(self.includes_values.collect{|relation| Array(relation)}.flatten << self.table_name)
+    protected
+    def greatest_select_val(table_names)
+      max_calcs = Array(table_names).collect{|name|
+        "MAX(#{connection.quote_table_name(name.to_s)}.#{connection.quote_column_name("updated_at")})"
+      }
+      
+      if max_calcs.length == 1
+        max_calcs.first
+      else
+        "GREATEST(#{max_calcs.join(", ")})"
+      end
     end
     
   end

metadata

@@ -1,70 +1,68 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: greatest_updated_at
-version: !ruby/object:Gem::Version 
-  hash: 29
-  prerelease: 
-  segments: 
-  - 0
-  - 0
-  - 1
-  version: 0.0.1
+version: !ruby/object:Gem::Version
+  version: 0.1.0
 platform: ruby
-authors: 
+authors:
 - James Prior
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2015-02-19 00:00:00 -05:00
-default_executable: 
-dependencies: []
-
-description: An AR extension to get the most recent updated_at from an active record relation and it's included records
-email: 
+date: 2015-02-19 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: activerecord
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '3.2'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '3.2'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '5'
+description: An AR extension to get the most recent updated_at from an active record
+  relation and it's included records
+email:
 - j.prior@asee.org
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
-- lib/greatest_updated_at/calculations.rb
-- lib/greatest_updated_at.rb
+files:
 - LICENSE
-has_rdoc: true
+- lib/greatest_updated_at.rb
+- lib/greatest_updated_at/calculations.rb
 homepage: https://github.com/asee/greatest_updated_at
-licenses: []
-
+licenses:
+- GPL v2
+metadata: {}
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  none: false
-  requirements: 
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
   - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 1.6.2
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Find the greatest updated_at from all included records in an AR scope
 test_files: []
-