graphql_rails 0.5.2 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d31436f40d036cd543c69a2b59e442d2498eb6349d61c4454dc9376e0caf4de0
-  data.tar.gz: 9b5041b648314fbff349e614e9b1f6be43f94bff32490f8de0dc4a23bb28c6a7
+  metadata.gz: cfcbe2a73989218dd084672e7402c553db62d23825096ba28f8a8af615c8ec63
+  data.tar.gz: dee48916b9b0ee8c4205c4c69b62dd7a2608fd66c58e720792349f53be9508e9
 SHA512:
-  metadata.gz: 72d4881a3aa604c19f38f53e4b77fdea562e7b804d8cec6a125789da32b6b215c298f5dcd1a747680a72c2e65571d0f30ab7b47597758fbb632bf21731f9bf70
-  data.tar.gz: 0a7ec0c5d6bf383c89b82109a4c120137e470f7e187ab8a3ab791840706abd6b0a49933b1bcead76437603fff546fc66ebd024fad8067bea6558d60499c587b0
+  metadata.gz: cd658ca5e90d844b191ef11bbc87f5bd2f1e69cdcc07d4ce56726e3b9c23bc5c7c5056745c69d1fe95a322d67dcea131c9b8c6c14a566ee199b7d835cec508bc
+  data.tar.gz: c6637e6f95b4b48e671f5d3a0303bb33a8327cbfec4b93da41f64e7331728578f02ca33240a37b4bc8b7c371965acbd353d9263f36f7bbc9d94062d4b3dc62fc

data/CHANGELOG.md

@@ -9,6 +9,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 * Added/Changed/Deprecated/Removed/Fixed/Security: YOUR CHANGE HERE
 
+## 0.6.0 (2019-04-29)
+
+* Breaking change: controller params are always underscored [@povilasjurcys](https://github.com/povilasjurcys).
+* Breaking change: cursor in paginated responses has plain index value by default [@povilasjurcys](https://github.com/povilasjurcys).
+* Fixed: do not crash when testing paginated actions [@povilasjurcys](https://github.com/povilasjurcys).
+
 ## 0.5.2 (2019-04-24)
 
 * Fixed: do not crash when using Connection types in non Ruby on Rails project [@povilasjurcys](https://github.com/povilasjurcys).

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    graphql_rails (0.5.2)
+    graphql_rails (0.6.0)
       activesupport (>= 4)
       graphql (~> 1)
 

data/lib/graphql_rails/controller.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'active_support/hash_with_indifferent_access'
+require 'active_support/core_ext/hash'
 require 'graphql_rails/controller/configuration'
 require 'graphql_rails/controller/request'
 require 'graphql_rails/controller/format_results'
@@ -68,7 +69,7 @@ module GraphqlRails
     end
 
     def params
-      @params = HashWithIndifferentAccess.new(graphql_request.params)
+      @params ||= graphql_request.params.deep_transform_keys { |key| key.to_s.underscore }.with_indifferent_access
     end
 
     private

data/lib/graphql_rails/controller/configuration.rb

@@ -9,6 +9,8 @@ module GraphqlRails
   class Controller
     # stores all graphql_rails contoller specific config
     class Configuration
+      attr_reader :action_by_name
+
       def initialize
         @hooks = {
           before: {},

data/lib/graphql_rails/router/plain_cursor_encoder.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module GraphqlRails
+  class Router
+    # simplest possible cursor encoder which returns element index
+    module PlainCursorEncoder
+      def self.encode(plain, _nonce)
+        plain
+      end
+
+      def self.decode(plain, _nonce)
+        plain
+      end
+    end
+  end
+end

data/lib/graphql_rails/router/schema_builder.rb

@@ -4,6 +4,8 @@ module GraphqlRails
   class Router
     # builds GraphQL::Schema based on previously defined grahiti data
     class SchemaBuilder
+      require_relative './plain_cursor_encoder'
+
       attr_reader :queries, :mutations, :raw_actions
 
       def initialize(queries:, mutations:, raw_actions:)
@@ -18,6 +20,7 @@ module GraphqlRails
         raw = raw_actions
 
         GraphQL::Schema.define do
+          cursor_encoder(Router::PlainCursorEncoder)
           raw.each { |action| send(action[:name], *action[:args], &action[:block]) }
 
           query(query_type)

data/lib/graphql_rails/rspec_controller_helpers.rb

@@ -55,28 +55,38 @@ module GraphqlRails
     class FakeContext
       extend Forwardable
 
+      attr_reader :schema
+
       def_delegators :@provided_values, :[], :[]=, :to_h, :key?, :fetch
 
-      def initialize(values:)
+      def initialize(values:, schema:)
         @errors = []
         @provided_values = values
+        @schema = schema
       end
 
       def add_error(error)
         @errors << error
       end
+    end
+
+    class SingleControllerSchemaBuilder
+      attr_reader :controller
 
-      def schema
-        FakeSchema.new
+      def initialize(controller)
+        @controller = controller
       end
-    end
 
-    # instance which has similar behavior as
-    class FakeSchema
-      def initialize; end
+      def call
+        config = controller.controller_configuration
+        action_by_name = config.action_by_name
+        controller_path = controller.name.underscore.sub(/_controller\Z/, '')
 
-      def cursor_encoder
-        GraphQL::Schema::Base64Encoder
+        Router.draw do
+          action_by_name.keys.each do |action_name|
+            query("#{action_name}_test", to: "#{controller_path}##{action_name}")
+          end
+        end
       end
     end
 
@@ -88,7 +98,8 @@ module GraphqlRails
     end
 
     def query(query_name, params: {}, context: {})
-      context_object = FakeContext.new(values: context)
+      schema_builder = SingleControllerSchemaBuilder.new(described_class)
+      context_object = FakeContext.new(values: context, schema: schema_builder.call)
       request = Request.new(params, context_object)
       described_class.new(request).call(query_name)
 

data/lib/graphql_rails/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module GraphqlRails
-  VERSION = '0.5.2'
+  VERSION = '0.6.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql_rails
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.6.0
 platform: ruby
 authors:
 - Povilas Jurčys
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-04-25 00:00:00.000000000 Z
+date: 2019-04-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: graphql
@@ -168,6 +168,7 @@ files:
 - lib/graphql_rails/model/input_attribute.rb
 - lib/graphql_rails/router.rb
 - lib/graphql_rails/router/mutation_route.rb
+- lib/graphql_rails/router/plain_cursor_encoder.rb
 - lib/graphql_rails/router/query_route.rb
 - lib/graphql_rails/router/resource_routes_builder.rb
 - lib/graphql_rails/router/route.rb