graphql_client 0.3.3 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7e4afa9a8d44f51f59d674a378869ed6ba86c250
-  data.tar.gz: 3538662487a766eca54ffe3fb5f73b0543785852
+  metadata.gz: ef03a205ab7279feb064cf18c8155e51bcec815d
+  data.tar.gz: 37dd8c3bf4cff061652a9695aece60c98cc8d30b
 SHA512:
-  metadata.gz: 13d946560d0627dfbb0bea51badf3906f9ef39d935d8ccd3f3e8e01bfc3f64a1a59cd891bbfee52eed6417d7d7bdcdb461b4e087e87ec92291392d5f74dfe976
-  data.tar.gz: 18d6a2125bc01d98ed2ea172b64da931ab83e27547e2aa8436edba7b3a77f87a42ecfda43b39d32cf63b8aa33341dd16c09394e16b0d48e5ecada3c18c0754e7
+  metadata.gz: 4b39ab7a0b9a8f66fe8f784404e58c65421e73366027acb8672a75af1a13ccf579ad1d580aeb574d2472d0889ca970d375a85a2a0a7a79cac73387bf55d3cf86
+  data.tar.gz: '093ddc0a6dd2e375ff7beb410dc46dbf6b47d48f24329558276d468ebd179f31dc4da3c93da381b22108708bd9ece30620c6a59161cda15a1818324c8f79538a'

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.4.0
+
+- Added a `raw_query_with_extensions` method to the client which returns both `data` and `extensions` keys as response objects.
+
 ## 0.3.3
 
 This is the initial public release of the GraphQL Ruby client.

data/README.md

@@ -94,3 +94,17 @@ response = client.raw_query('
 
 puts response.shop.name
 ```
+
+### Extensions
+
+The GraphQL specification allows for an [`extensions` key](http://facebook.github.io/graphql/October2016/#sec-Response-Format) in the response. To access this data use the `raw_query_with_extensions` method instead. It will return a tuple of response objects, one for the `data` key and one for the `extensions` key.
+
+```ruby
+data, extensions = client.raw_query_with_extensions('
+  query {
+    shop {
+       name
+      }
+    }
+')
+```

data/graphql_ruby_client.gemspec

@@ -12,7 +12,7 @@ Gem::Specification.new do |s|
   s.summary = ''
   s.test_files = `git ls-files -- {test}/*`.split("\n")
   s.version = GraphQL::Client::VERSION
-  s.executables << 'graphql-client'
+  s.executables = 'graphql-client'
 
   s.add_runtime_dependency 'graphql_schema', '~> 0.1.5'
 

data/lib/graphql_client/base.rb

@@ -33,8 +33,12 @@ module GraphQL
       end
 
       def raw_query(query_string, operation_name: nil, variables: {})
+        raw_query_with_extensions(query_string, operation_name: operation_name, variables: variables)[0]
+      end
+
+      def raw_query_with_extensions(query_string, operation_name: nil, variables: {})
         response = adapter.request(query_string, operation_name: operation_name, variables: variables)
-        ResponseObject.new(response.data)
+        [ResponseObject.new(response.data), ResponseObject.new(response.extensions)]
       end
 
       private

data/lib/graphql_client/response.rb

@@ -14,7 +14,7 @@ module GraphQL
         @body = response
         @data = data
         @errors = errors.to_a
-        @extensions = extensions.to_a
+        @extensions = extensions
       end
     end
   end

data/lib/graphql_client/version.rb

@@ -2,6 +2,6 @@
 
 module GraphQL
   module Client
-    VERSION = '0.3.3'
+    VERSION = '0.4.1'
   end
 end

data/test/graphql_client/http_client_test.rb

@@ -47,6 +47,43 @@ module GraphQL
 
         adapter.verify
       end
+
+      def test_raw_query_with_extensions_calls_adapter_request_with_query_string
+        config = Config.new(url: 'http://example.com')
+
+        adapter = Minitest::Mock.new
+        adapter.expect(:request, Response.new('{}'), ['query { shop }', operation_name: nil, variables: {}])
+
+        client = Base.new(schema_fixture('schema.json'), config: config, adapter: adapter)
+        client.raw_query_with_extensions('query { shop }')
+
+        adapter.verify
+      end
+
+      def test_raw_query_with_extensions_returns_response_objects_for_data_and_extensions
+        config = Config.new(url: 'http://example.com')
+
+        response = Minitest::Mock.new
+        response.expect(:data, { 'name' => 'shop' })
+        response.expect(:extensions, { 'foo' => 'bar' })
+
+        client = Base.new(schema_fixture('schema.json'), config: config, adapter: AdapterStub.new(response))
+        data, extensions = client.raw_query_with_extensions('query { shop }')
+
+        assert_equal 'shop', data.name
+        assert_equal 'bar', extensions.foo
+        response.verify
+      end
+    end
+
+    class AdapterStub
+      def initialize(request)
+        @request = request
+      end
+
+      def request(*)
+        @request
+      end
     end
   end
 end

data/test/graphql_client/response_object_test.rb

@@ -3,6 +3,12 @@ require 'test_helper'
 module GraphQL
   module Client
     class ResponseObjectTest < Minitest::Test
+      def test_builds_response_objects_from_nil
+        result = ResponseObject.new(nil)
+
+        assert_equal({}, result.data)
+      end
+
       def test_builds_response_objects_from_hashes
         result = ResponseObject.new(
           'myshop' => {

data/test/graphql_client/response_test.rb

@@ -34,21 +34,19 @@ module GraphQL
       def test_initialize_sets_extensions
         body = {
           data: { id: 1 },
-          extensions: [
-            { foo: 'bar' }
-          ]
+          extensions: { foo: 'bar' }
         }
 
         response = Response.new(body.to_json)
 
-        assert_equal [{ 'foo' => 'bar' }], response.extensions
+        assert_equal({ 'foo' => 'bar' }, response.extensions)
       end
 
-      def test_initialize_sets_extensions_default
+      def test_initialize_with_no_extensions_sets_it_to_nil
         body = { data: { id: 1 } }
         response = Response.new(body.to_json)
 
-        assert_equal [], response.extensions
+        assert_nil response.extensions
       end
 
       def test_initialize_raises_error_if_response_contains_errors_without_data

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql_client
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.4.1
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-07 00:00:00.000000000 Z
+date: 2018-03-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: graphql_schema
@@ -175,7 +175,6 @@ files:
 - lib/graphql_client/schema_patches.rb
 - lib/graphql_client/version.rb
 - shipit.rubygems.yml
-- shipit.yml
 - test/graphql_client/adapters/http_adapter_test.rb
 - test/graphql_client/config_test.rb
 - test/graphql_client/graph_connection_test.rb
@@ -220,7 +219,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: ''

data/shipit.yml

@@ -1,4 +0,0 @@
-deploy:
-  override:
-    - bundle exec rake build
-    - bundle exec package_cloud push shopify/gems pkg/*.gem