graphql-schema_comparator 0.3.2 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bae47fd797c861e89911fafe37a7483acf01945e
-  data.tar.gz: 3a3ef6822c996be20aae3d0e3785ae8fa75549e1
+  metadata.gz: e193c10ab21868ab4bf6fd6f3159b4d3e4a67525
+  data.tar.gz: 9603fd58643f3a1dabecb23ff543a646657b1f3a
 SHA512:
-  metadata.gz: 6449c7c8044ebe1c5d586e9a6a99e308ab3b24bd8cee27996da25ff4b3c2793462d4865d8b9de491adec6e58ca2b2492fdc6bb273549831a4f0b9b4764516061
-  data.tar.gz: c3bc07672039aa72c0cb8de702ffa29357c3dd2778ae356cead4f02e242d83fd88f8bd2b9902bd831f8be7cfef8828f2130f1b1c6b9047b6ad84587098f976bc
+  metadata.gz: bced670ccc797b2222231e60d930d167e1856d820722c0c4946c45fe2d84c96fcdd50f9e91089a83a82adc9f9dee212aa6636c810a48e57745ece7b7a1d48c50
+  data.tar.gz: ea0916f65eb4de48038077dff40add62c7fa9d5581293d1618c4b045086545b465e13aecfb0c0390f1147496d47bcee7c5ef10c09ec0c5f5cf2f4503bb04bbb8

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 0.4.0 (Nov 27 2017)
+
+## Breaking Changes
+
+  - Argument and InputValue type changes are considered non
+    breaking if type goes from Null => Non-Null
+
 ## 0.3.2 (Nov 14 2017)
 
 ### New Features

data/lib/graphql/schema_comparator/changes.rb

@@ -1,6 +1,21 @@
 module GraphQL
   module SchemaComparator
     module Changes
+      module SafeTypeChange
+        def safe_change?(old_type, new_type)
+          if !old_type.kind.wraps? && !new_type.kind.wraps?
+            old_type == new_type
+          elsif old_type.kind.list? && new_type.kind.list?
+            safe_change?(old_type.of_type, new_type.of_type)
+          elsif old_type.kind.non_null?
+            of_type = new_type.kind.non_null? ? new_type.of_type : new_type
+            safe_change?(old_type.of_type, of_type)
+          else
+            false
+          end
+        end
+      end
+
       class AbstractChange
         def message
           raise NotImplementedError
@@ -793,13 +808,15 @@ module GraphQL
       end
 
       class InputFieldTypeChanged < AbstractChange
+        include SafeTypeChange
+
         attr_reader :input_type, :old_input_field, :new_input_field
 
         def initialize(input_type, old_input_field, new_input_field)
           @input_type = input_type
           @old_input_field = old_input_field
           @new_input_field = new_input_field
-          @breaking = true
+          @breaking = !safe_change?(old_input_field.type, new_input_field.type)
         end
 
         def message
@@ -812,6 +829,8 @@ module GraphQL
       end
 
       class FieldArgumentTypeChanged < AbstractChange
+        include SafeTypeChange
+
         attr_reader :type, :field, :old_argument, :new_argument
 
         def initialize(type, field, old_argument, new_argument)
@@ -819,7 +838,7 @@ module GraphQL
           @field = field
           @old_argument = old_argument
           @new_argument = new_argument
-          @breaking = true
+          @breaking = !safe_change?(old_argument.type, new_argument.type)
         end
 
         def message

data/lib/graphql/schema_comparator/version.rb

@@ -1,5 +1,5 @@
 module GraphQL
   module SchemaComparator
-    VERSION = "0.3.2"
+    VERSION = "0.4.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql-schema_comparator
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.4.0
 platform: ruby
 authors:
 - Marc-Andre Giroux
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-14 00:00:00.000000000 Z
+date: 2017-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: graphql