graphql-schema_comparator 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 16377eaa74c85158d06801b8224c09d863de9e36
-  data.tar.gz: 9f1cf164f223b30cc7acd3620aa46e843ed04ea9
+  metadata.gz: 510c4140ffe9cca7a012282eabc3570cae2bf084
+  data.tar.gz: 2b1236ab94f83ed213f73afc9dcb941a5ac7e097
 SHA512:
-  metadata.gz: 72e276a27111484f51ee9bdf9a6b17a5420438c8db32601cdacda917677e0e3e1f0a4f9858e8a3e2a5dc00e3b6310b9587ffa248e2cd33ad79b364ee7d959043
-  data.tar.gz: be997a8f471e654a341d7a72d95e2940ec9f7eb2811dd73e73b4f657b67af4a6e628bf37ff411ff3a82ba059717bc058c28750326c2587098eac97d11ae7c7aa
+  metadata.gz: 2734f4d3159c8b0e0851aacd92e94f016d8aeebdffa4ec33a8473436bb8347dfcf72e8b4c0d821243426f267092efcf2bf1571d83f7f04a3ac598e377da65801
+  data.tar.gz: b00933509012e0c900b6ced4e40c48a09c4ff06278ba9cd5a6a3109d70f6f5d879737f448171da4c9ce0e4c23e2383c7f6b94bd4bc06a0f7d077c166dc931582

data/.travis.yml

@@ -0,0 +1,10 @@
+---
+language: ruby
+sudo: false
+cache: bundler
+before_install:
+  - gem update --system --no-doc
+  - gem install bundler
+rvm:
+- 2.3.4
+- 2.4.1

data/CHANGELOG.md

@@ -0,0 +1,12 @@
+# Changelog
+
+## 0.2.0 (Aug 18 2017)
+
+### New features
+
+- Add `#non_breaking_changes` to get a list of non breaking changes from a comparison result. (#4)
+- CLI now Prints results sorted and grouped by breaking / non-breaking (#3)
+
+### Bug fixes
+
+- Fix message for `EnumValueRemoved` (#5)

data/README.md

@@ -1,5 +1,7 @@
 # GraphQL::SchemaComparator
 
+[![Build Status](https://travis-ci.org/xuorig/graphql-schema_comparator.svg?branch=master)](https://travis-ci.org/xuorig/graphql-schema_comparator)
+
 `GraphQL::SchemaComparator` is a GraphQL Schema comparator. What does that mean? `GraphQL::SchemaComparator` takes
 two GraphQL schemas and outputs a list of changes that happened between the two versions. This is useful for many things:
 
@@ -58,6 +60,7 @@ access information on the changes between the two schemas.
  - `result.breaking?` returns true if any breaking changes were found between the two schemas
  - `result.identical?` returns true if the two schemas were identical
  - `result.breaking_changes` returns the list of breaking changes found between schemas.
+ - `result.non_breaking_changes` returns the list of non-breaking changes found between schemas.
 - `result.changes` returns the full list of change objects.
 
 ### Change Objects

data/graphql-schema_comparator.gemspec

@@ -26,6 +26,6 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.14"
   spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "minitest"
-  spec.add_development_dependency "pry-byebug"
+  spec.add_development_dependency "minitest", "~> 5.10"
+  spec.add_development_dependency "pry-byebug", "~> 3.4"
 end

data/lib/graphql/schema_comparator/changes.rb

@@ -46,14 +46,14 @@ module GraphQL
       class EnumValueRemoved
         attr_reader :enum_value, :enum_type, :breaking
 
-        def initialize(enum_value, enum_type)
+        def initialize(enum_type, enum_value)
           @enum_value = enum_value
           @enum_type = enum_type
           @breaking = true
         end
 
         def message
-          "Enum Value #{enum_value.name} was removed from Enum #{enum_type.name}"
+          "Enum value `#{enum_value.name}` was removed from enum `#{enum_type.name}`"
         end
       end
 
@@ -197,7 +197,7 @@ module GraphQL
         end
 
         def message
-          "Enum value #{enum_value.name} was added on enum type #{enum_type.name}"
+          "Enum value `#{enum_value.name}` was added to enum `#{enum_type.name}`"
         end
       end
 
@@ -499,6 +499,7 @@ module GraphQL
         def initialize(input_object_type, field)
           @input_object_type = input_object_type
           @field = field
+          @breaking = field.type.kind.non_null? ? true : false
         end
 
         def message
@@ -513,7 +514,8 @@ module GraphQL
           @type = type
           @field = field
           @argument = argument
-          @breaking = false
+          # TODO: should at least have a warning that it may still be breaking
+          @breaking = argument.type.kind.non_null? ? true : false
         end
 
         def message
@@ -584,7 +586,7 @@ module GraphQL
         def initialize(old_schema, new_schema)
           @old_schema = old_schema
           @new_schema = new_schema
-          @breaking = false
+          @breaking = true
         end
 
         def message
@@ -596,7 +598,7 @@ module GraphQL
         def initialize(old_schema, new_schema)
           @old_schema = old_schema
           @new_schema = new_schema
-          @breaking = false
+          @breaking = true
         end
 
         def message

data/lib/graphql/schema_comparator/result.rb

@@ -1,22 +1,19 @@
 module GraphQL
   module SchemaComparator
     class Result
-      attr_reader :changes
+      attr_reader :changes, :breaking_changes, :non_breaking_changes
 
       def initialize(changes)
-        @changes = changes
+        @changes = changes.sort_by { |c| [c.breaking ? 1 : 2, c.message] }
+        @breaking_changes, @non_breaking_changes = @changes.partition(&:breaking)
       end
 
       def identical?
         @changes.empty?
       end
 
-      def breaking_changes
-        @changes.select { |c| c.breaking }
-      end
-
       def breaking?
-        @changes.any? { |c| c.breaking }
+        breaking_changes.any?
       end
     end
   end

data/lib/graphql/schema_comparator/version.rb

@@ -1,5 +1,5 @@
 module GraphQL
   module SchemaComparator
-    VERSION = "0.1.0"
+    VERSION = "0.2.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql-schema_comparator
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Marc-Andre Giroux
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-23 00:00:00.000000000 Z
+date: 2017-08-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: graphql
@@ -70,30 +70,30 @@ dependencies:
   name: minitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.10'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.4'
 description: GraphQL::SchemaComparator compares two GraphQL schemas given their IDL
   and returns a list of changes.
 email:
@@ -104,6 +104,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".travis.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
@@ -147,7 +149,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: Compare GraphQL schemas and get the changes that happened.