graphql-remote_loader 1.0.4 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b71151aac9fed6da47c53df2db83f4aa32178436
-  data.tar.gz: f556f9d29f9080efa8b326a7a21c443c090f2605
+  metadata.gz: d72d37be4701ca0a4dd4bad71e989241b8557f01
+  data.tar.gz: 0e4c7d0613383cd441d2dc887cc7c5647296a780
 SHA512:
-  metadata.gz: dbf5636dc0e6ab2976d763d4d66b30007b892acb608bc8846dc3731eebb87cd3932265843c2fad6470b0ba06ab9925fc42513b8f5a68ffb01b524693d41de320
-  data.tar.gz: d322e05826e6b70013d6ea692d1c05d47f645bd55cbef6e829e7678deff6eed87dc494320cbab5694d7a702a754c43ab03a8f580e35b67ddb9019b47b10038e9
+  metadata.gz: 53941e0b529fcf5c9f89809de804faf1f52e162c3fa8cccbb2f2c6a0b1f44c8d713a4bf291055504ae75c2fa001f926aa6e15a5bed1acfa949e4ec2d2f3553b1
+  data.tar.gz: 017da570ea18310a6b3eb4801ffa24ff1e22d087cca6daf2b4d1370813c419443b809dfbdc6337b6f9c0690742b540bb2e0e89b1f3342cf32d12406684f9354e

data/.travis.yml

@@ -1,2 +1,5 @@
 language: ruby
+# Work around an issue where bundler isn't installed correctly on Ruby 2.5.
+# We should remove this once Travis uses Ruby 2.6 by default.
+rvm: 2.6
 script: bundle exec rspec

data/Gemfile.lock

@@ -1,8 +1,8 @@
 PATH
   remote: .
   specs:
-    graphql-remote_loader (1.0.3)
-      graphql (~> 1.6)
+    graphql-remote_loader (1.0.5)
+      graphql (~> 1.9)
       graphql-batch (~> 0.3)
 
 GEM
@@ -11,9 +11,9 @@ GEM
     byebug (10.0.2)
     coderay (1.1.2)
     diff-lcs (1.3)
-    graphql (1.8.11)
-    graphql-batch (0.3.10)
-      graphql (>= 0.8, < 2)
+    graphql (1.9.12)
+    graphql-batch (0.4.1)
+      graphql (>= 1.3, < 2)
       promise.rb (~> 0.7.2)
     method_source (0.9.1)
     promise.rb (0.7.4)
@@ -42,11 +42,11 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  bundler (~> 1.14)
+  bundler (~> 2.0)
   graphql-remote_loader!
   pry-byebug (~> 3.4)
   rake (~> 10.0)
   rspec (~> 3.6)
 
 BUNDLED WITH
-   1.15.4
+   2.0.2

data/README.md

@@ -6,18 +6,6 @@ Performant, batched GraphQL queries from within the resolvers of a [`graphql-rub
 
 ## Snippet
 
-For default error handling(null if errors) and no post-processing:
-
-```ruby
-field :login, String, null: true, description: "The currently authenticated GitHub user's login."
-
-def login
-  GitHubLoader.load_value("viewer", "login")
-end
-```
-
-If you need error handling, post-processing, or complex queries:
-
 ```ruby
 field :login, String, null: false, description: "The currently authenticated GitHub user's login."
 
@@ -32,12 +20,8 @@ def login
 end
 ```
 
-## Full example
-
-To see a working example of how `graphql-remote_loader` works, see the [complete, working example application](https://github.com/d12/graphql-remote_loader_example).
-
 ## Description
-`graphql-remote_loader` allows for querying GraphQL APIs from within resolvers of a [`graphql-ruby`](https://github.com/rmosolgo/graphql-ruby) API.
+`graphql-remote_loader` allows for querying GraphQL APIs from within resolvers of a [`graphql-ruby`](https://github.com/rmosolgo/graphql-ruby) API. 
 
 This can be used to create GraphQL APIs that depend on data from other GraphQL APIs, either remote or local.
 
@@ -45,6 +29,10 @@ A promise-based resolution strategy from Shopify's [`graphql-batch`](https://git
 
 You can think of it as a lightweight version of schema-stitching.
 
+## Performance
+
+Each `Loader#load` invocation does not send a GraphQL query to the remote. The Gem uses graphql-batch to collect all GraphQL queries together, then combines them and sends a single query to the upstream. The gem splits the response JSON up so that each promise is only resolved with data that it asked for.
+
 ## How to use
 First, you'll need to install the gem. Either do `gem install graphql-remote_loader` or add this to your Gemfile:
 
@@ -52,9 +40,9 @@ First, you'll need to install the gem. Either do `gem install graphql-remote_loa
 gem "graphql-remote_loader"
 ```
 
-The gem provides a base loader `GraphQL::RemoteLoader::Loader` which does most of the heavy lifting. In order to remain client-agnostic, there's an unimplemented no-op that queries the external GraphQL API.
+The gem provides a base loader `GraphQL::RemoteLoader::Loader` which does most of the heavy lifting. In order to remain client-agnostic, there's an unimplemented no-op that takes a query string and queries the remote GraphQL API.
 
-To use, create a new class that inherits from `GraphQL::RemoteLoader::Loader` and define `def query(query_string)`. The method takes a query String as input. The expected output is a response `Hash`, or some object that responds to `#to_h`.
+To use, create a new class that inherits from `GraphQL::RemoteLoader::Loader` and define `def query(query_string)`. The method takes a query String as input. The expected output is a response `Hash`, or an object that responds to `#to_h`.
 
 Example:
 
@@ -75,6 +63,10 @@ This example uses [`graphql-client`](https://github.com/github/graphql-client).
 
 With your loader setup, you can begin using `#load` or `#load_value` in your `graphql-ruby` resolvers.
 
+## Full example
+
+To see a working example of how `graphql-remote_loader` works, see the [complete, working example application](https://github.com/d12/graphql-remote_loader_example).
+
 ## Running tests
 
 ```

data/graphql-remote_loader.gemspec

@@ -21,10 +21,10 @@ Gem::Specification.new do |spec|
   # spec.executables   = [""]
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "graphql", "~> 1.6"
+  spec.add_dependency "graphql", "~> 1.9"
   spec.add_dependency "graphql-batch", "~> 0.3"
 
-  spec.add_development_dependency "bundler", "~> 1.14"
+  spec.add_development_dependency "bundler", "~> 2.0"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.6"
   spec.add_development_dependency "pry-byebug", "~> 3.4"

data/lib/graphql/remote_loader/query_merger.rb

@@ -45,7 +45,9 @@ module GraphQL
             if matching_fragment_definition
               merge_query_recursive(a_definition, matching_fragment_definition)
             else
-              b_query.definitions << a_definition
+              # graphql-ruby Nodes aren't meant to be mutated, but I'd rather slightly abuse graphql-ruby vs
+              # maintain my own Ruby data and parsing library implementing the GraphQL spec.
+              b_query.instance_variable_set(:@definitions, [b_query.definitions, a_definition].flatten)
             end
           end
         end
@@ -79,7 +81,7 @@ module GraphQL
               matching_field.instance_variable_set(:@prime, new_prime)
               merge_query_recursive(a_query_selection, matching_field) unless exempt_node_types.any? { |type| matching_field.is_a?(type) }
             else
-              b_query.selections << a_query_selection
+              b_query.instance_variable_set(:@selections, [b_query.selections, a_query_selection].flatten)
             end
           end
         end
@@ -112,11 +114,11 @@ module GraphQL
             unless exempt_node_types.any? { |type| selection.is_a? type }
               prime_factor = selection.instance_variable_get(:@prime)
 
-              selection.alias = if selection.alias
+              selection.instance_variable_set(:@alias, if selection.alias
                 "p#{prime_factor}#{selection.alias}"
               else
                 "p#{prime_factor}#{selection.name}"
-              end
+              end)
             end
 
             # Some nodes don't have selections (e.g. fragment spreads)

data/lib/graphql/remote_loader/version.rb

@@ -1,5 +1,5 @@
 module GraphQL
   module RemoteLoader
-    VERSION = "1.0.4"
+    VERSION = "1.0.5"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql-remote_loader
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
 platform: ruby
 authors:
 - Nathaniel Woodthorpe
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-18 00:00:00.000000000 Z
+date: 2019-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: graphql
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '1.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '1.9'
 - !ruby/object:Gem::Dependency
   name: graphql-batch
   requirement: !ruby/object:Gem::Requirement
@@ -44,14 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.14'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.14'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -133,7 +133,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Performant remote GraphQL queries from within a Ruby GraphQL API.