graphql-relay 0.4.3 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1038ccd66be579e1ade39b942de12fd993cbdc26
-  data.tar.gz: 278b0a2e1dbbe0ddb15669e6fcfb0e4206bbab0f
+  metadata.gz: 3ef33be1f3e6ae5251b8ad8248e208b1d884bc80
+  data.tar.gz: 01b0b8d1d1e0ca687f1580b7b2d2e7f45303468f
 SHA512:
-  metadata.gz: e8bf419f8e9c9c55d93a2c1efe15e3e66e81772ef04fe537046205d5d42f1c84bda9c690b3075625f6d80947d2b6fcce9df7032d98507219a70426af26db85ed
-  data.tar.gz: ee7c7e669c03577c0924838f6a985b0639ee9008a5e0fbdfaa24eec75f3913e713b41eeb362802cf42eb2f32b2fd1ac851e74efdb6a2da9c59f2d5ea9ad97dd7
+  metadata.gz: cafa3a911d77401ba5bc525d1ccac55b388bfe861f12209c70d1bb47c62e08a423dee71512c0d6b860ed6260275a2d74a2f8dc91d94c397f676ce56d8528385f
+  data.tar.gz: 99234b626e2f8122d8bf304041bde214e4f8d5930176a255cd121f1b7fbd895e058d0d71a98e400ed2efe535ea41c8d3e2aa8dcfed5ef1428dd54a3eec986854

data/README.md

@@ -72,8 +72,10 @@ Examples:
 
 ## Todo
 
-- Show how to replace default connection implementations with custom ones
 - Show how to wrap a simple field in a connection field with `ConnectionField.create`
+- Add a `max_page_size` config for connections?
+- Refactor some RelationConnection issues:
+  - fix [unbounded count in page info](https://github.com/rmosolgo/graphql-relay-ruby/blob/88b3d94f75a6dd4c8b2604743108db31f66f8dcc/lib/graphql/relay/base_connection.rb#L79-L86), [details](https://github.com/rmosolgo/graphql-relay-ruby/issues/1)
 
 ## More Resources
 

data/lib/graphql/relay/relation_connection.rb

@@ -35,14 +35,14 @@ module GraphQL
           if after
             _o, order_value = slice_from_cursor(after)
             direction_marker = order_direction == :asc ? ">" : "<"
-            where_condition = create_order_condition(order_name, order_value, direction_marker)
+            where_condition = create_order_condition(table_name, order_name, order_value, direction_marker)
             items = items.where(where_condition)
           end
 
           if before
             _o, order_value = slice_from_cursor(before)
             direction_marker = order_direction == :asc ? "<" : ">"
-            where_condition = create_order_condition(order_name, order_value, direction_marker)
+            where_condition = create_order_condition(table_name, order_name, order_value, direction_marker)
             items = items.where(where_condition)
           end
 
@@ -64,10 +64,15 @@ module GraphQL
       def order_direction
         @order_direction ||= order.start_with?("-") ? :desc : :asc
       end
+      
+      def table_name
+        @table_name ||= object.table.table_name
+      end
 
-      def create_order_condition(column, value, direction_marker)
+      def create_order_condition(table, column, value, direction_marker)
+        table_name = ActiveRecord::Base.connection.quote_table_name(table)
         name = ActiveRecord::Base.connection.quote_column_name(column)
-        ["#{name} #{direction_marker} ?", value]
+        ["#{table_name}.#{name} #{direction_marker} ?", value]
       end
     end
 

data/lib/graphql/relay/version.rb

@@ -1,5 +1,5 @@
 module GraphQL
   module Relay
-    VERSION = '0.4.3'
+    VERSION = '0.4.4'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql-relay
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.4
 platform: ruby
 authors:
 - Robert Mosolgo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-26 00:00:00.000000000 Z
+date: 2015-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: graphql