graphql-metrics 3.0.1 → 3.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cf09941ca4f9ed80c7d1080c6c121fa1cb1ac66ed55735dcb74cec0bbbe3a8a2
-  data.tar.gz: 18a8b3feafc4bb5be6c065cf05b91da34fee5c826e77d67ad14ea48a23630459
+  metadata.gz: 692719d6eddd28987c05a5cf767da34dc2a12a6a697e4525dadb4a4ac655cd3b
+  data.tar.gz: 7b06a5ca5ceae870c2dccd75f4b621a12361da07bb7d7269d1171ee9ba177800
 SHA512:
-  metadata.gz: 4e11ef76ccd1d038fab97151f40418e5386b5d2d80b45ca1238f5c0ebf60b6a593980bde4efe4fc60c63b3c590bc7da803e8fcb04ce1c9906fa0cf6edecb0e74
-  data.tar.gz: 32684bc8c1e3fac2e73b4efad7969bb84c38fc34a89510e450e0b423b5ec66104a8cd0fea016b91a47e26299a01df0b09da82597a4fd5dd763d64de4677c04f7
+  metadata.gz: 0751a811a26282763ccf624dc12fd55cdfdcda5998c4e955c359aabc4fcc6ad8ed63ff4c66d6ef271054e4541e7930791643f81f76e177ab749b592db07faef8
+  data.tar.gz: 54dbdc3529bdb9ace551421653067cc893cab818e0cdc17dc6703046f534901b989e7082bc285d39adb31bf30c334b3c8d0e894b647920a457232b0739ca5be9

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+3.0.2
+-----
+
+- [#21](https://github.com/Shopify/graphql-metrics/pull/21) Optimize empty document check
+
 3.0.1
 -----
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    graphql-metrics (3.0.1)
+    graphql-metrics (3.0.2)
       concurrent-ruby (~> 1.1.0)
       graphql (>= 1.9.5, < 1.10.0)
 

data/README.md

@@ -172,9 +172,10 @@ class Schema < GraphQL::Schema
   use GraphQL::Execution::Interpreter # Required.
   use GraphQL::Analysis::AST # Required.
 
-  instrument :query, GraphQL::Metrics::Instrumentation.new
   query_analyzer SimpleAnalyzer
-  tracer GraphQL::Metrics::Tracer.new
+  
+  instrument :query, GraphQL::Metrics::Instrumentation.new # Both of these are required if either is used.
+  tracer GraphQL::Metrics::Tracer.new                      # <-- Note!
 
   use GraphQL::Batch # Optional, but highly recommended. See https://github.com/Shopify/graphql-batch/.
 end

data/lib/graphql/metrics/instrumentation.rb

@@ -47,7 +47,9 @@ module GraphQL
       private
 
       def query_present_and_valid?(query)
-        query.valid? && query.document.to_query_string.present?
+        # Check for selected_operation as well for graphql 1.9 compatibility
+        # which did not reject "empty" documents in its parser.
+        query.valid? && !query.selected_operation.nil?
       end
     end
   end

data/lib/graphql/metrics/version.rb

@@ -2,6 +2,6 @@
 
 module GraphQL
   module Metrics
-    VERSION = "3.0.1"
+    VERSION = "3.0.2"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql-metrics
 version: !ruby/object:Gem::Version
-  version: 3.0.1
+  version: 3.0.2
 platform: ruby
 authors:
 - Christopher Butcher
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-03-16 00:00:00.000000000 Z
+date: 2020-03-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby