graphql-extras 0.3.2 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eb6a2324dfea95555ab147de0f4d79601603e21ca7dde008939795b12d40064c
-  data.tar.gz: ef735334a0b5be7ac0286c45886aa60d507482b73a95c0af89a2d1b5dfae27cc
+  metadata.gz: 1ad1e3740a8a7ef06a6dad31a459153a121e254824225bf1a12c2718a59a699f
+  data.tar.gz: 36ce81c3f1f0888924668ccef5bde169958e45a97837cc669d94a416edc573de
 SHA512:
-  metadata.gz: b412b43cd6d6c3865726770b1bd54d121e5a122fdafcd0f4f0e141edb6cd9e83ca13c47f73530025be3d16498144f97f3ddc40c02897049679bfebad8189ed56
-  data.tar.gz: '018ccec04e7e67b563e460fcbe7d1649a097087846b488985c34072004bcd2839162e4a3f3131c76718ea99a1d15633bc5c9f7ec3190cef65de203eb6c533a4b'
+  metadata.gz: ba8b4d40badcfba328280f397f8fb7ab7f42ce5257478c0482e48c4f0abf533f4b170d51f507caf6378ed6239d51460b4fe0f4623a6cfb93e0b565bbbf81a80d
+  data.tar.gz: de3c6a7f726b0b9ca1311906c1c3d05c0896fe8ba1b64d9d059cc0b7c5d82c227ae7ec17611b999b666201b97818daea30d2f996fda5f9d9fefa849d00ec9fc2

data/README.md

@@ -14,8 +14,8 @@ A collection of utilities for building GraphQL APIs.
 - [Installation](#installation)
 - [Usage](#usage)
   - [GraphQL::Extras::Controller](#graphqlextrascontroller)
-  - [GraphQL::Extras::AssociationLoader](#graphqlextrasassociationloader)
   - [GraphQL::Extras::Preload](#graphqlextraspreload)
+  - [GraphQL::Extras::PreloadSource](#graphqlextraspreloadsource)
   - [GraphQL::Extras::Types](#graphqlextrastypes)
     - [Date](#date)
     - [DateTime](#datetime)
@@ -53,21 +53,15 @@ class GraphqlController < ApplicationController
 end
 ```
 
-### GraphQL::Extras::AssociationLoader
-
-This is a subclass of [`GraphQL::Batch::Loader`](https://github.com/Shopify/graphql-batch) that performs eager loading of Active Record associations.
-
-```ruby
-loader = GraphQL::Extras::AssociationLoader.for(:blog)
-loader.load(Post.first)
-loader.load_many(Post.all)
-```
-
 ### GraphQL::Extras::Preload
 
 This allows you to preload associations before resolving fields.
 
 ```ruby
+class Schema < GraphQL::Schema
+  use GraphQL::Dataloader
+end
+
 class BaseField < GraphQL::Schema::Field
   prepend GraphQL::Extras::Preload
 end
@@ -87,6 +81,16 @@ class PostType < BaseObject
 end
 ```
 
+### GraphQL::Extras::PreloadSource
+
+This is a subclass of [`GraphQL::Dataloader::Source`](https://graphql-ruby.org/dataloader/overview.html) that performs eager loading of Active Record associations.
+
+```ruby
+loader = dataloader.with(GraphQL::Extras::PreloadSource, :blog)
+loader.load(Post.first)
+loader.load_many(Post.all)
+```
+
 ### GraphQL::Extras::Types
 
 In your base classes, you should include the `GraphQL::Extras::Types`.

data/graphql-extras.gemspec

@@ -26,7 +26,6 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "activesupport", ">= 5.2"
   spec.add_dependency "graphql", "~> 1.12"
-  spec.add_dependency "graphql-batch", "~> 0.4"
 
   spec.add_development_dependency "bundler", "~> 2.0"
   spec.add_development_dependency "rake", "~> 13.0"

data/lib/graphql/extras.rb

@@ -1,7 +1,6 @@
 require "graphql/extras/version"
 require "graphql/extras/types"
 require "graphql/extras/controller"
-require "graphql/extras/association_loader"
 require "graphql/extras/preload"
 
 module GraphQL

data/lib/graphql/extras/preload.rb

@@ -1,7 +1,17 @@
-require "graphql/extras/association_loader"
-
 module GraphQL
   module Extras
+    class PreloadSource < GraphQL::Dataloader::Source
+      def initialize(preload)
+        @preload = preload
+      end
+
+      def fetch(records)
+        preloader = ActiveRecord::Associations::Preloader.new
+        preloader.preload(records, @preload)
+        records
+      end
+    end
+
     module Preload
       # @override
       def initialize(*args, preload: nil, **opts, &block)
@@ -10,13 +20,13 @@ module GraphQL
       end
 
       # @override
-      def resolve(object, args, ctx)
-        return super unless @preload
-
-        loader = AssociationLoader.for(@preload)
-        loader.load(object.object).then do
-          super(object, args, ctx)
+      def resolve(object, args, context)
+        if @preload
+          loader = context.dataloader.with(PreloadSource, @preload)
+          loader.load(object.object)
         end
+
+        super
       end
     end
   end

data/lib/graphql/extras/version.rb

@@ -1,5 +1,5 @@
 module GraphQL
   module Extras
-    VERSION = "0.3.2"
+    VERSION = "0.4.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql-extras
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.4.0
 platform: ruby
 authors:
 - Ray Zane
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2021-02-19 00:00:00.000000000 Z
+date: 2021-03-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -38,20 +38,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.12'
-- !ruby/object:Gem::Dependency
-  name: graphql-batch
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.4'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.4'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -168,7 +154,6 @@ files:
 - bin/setup
 - graphql-extras.gemspec
 - lib/graphql/extras.rb
-- lib/graphql/extras/association_loader.rb
 - lib/graphql/extras/controller.rb
 - lib/graphql/extras/preload.rb
 - lib/graphql/extras/test.rb

data/lib/graphql/extras/association_loader.rb

@@ -1,24 +0,0 @@
-require "graphql/batch"
-
-module GraphQL
-  module Extras
-    class AssociationLoader < GraphQL::Batch::Loader
-      def initialize(preload)
-        @preload = preload
-      end
-
-      def cache_key(record)
-        record.object_id
-      end
-
-      def perform(records)
-        preloader = ActiveRecord::Associations::Preloader.new
-        preloader.preload(records, @preload)
-
-        records.each do |record|
-          fulfill(record, nil) unless fulfilled?(record)
-        end
-      end
-    end
-  end
-end