graphql-client 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 88afea7eaa70819f11b2a000886ef3924e2b0e12
-  data.tar.gz: 62a8706efe7fe20a73da2affaa3e362dce686970
+  metadata.gz: 665795b2cb201c59918533b567ea75e1d9e17c8c
+  data.tar.gz: 6c0aa59a2fb36248cefa5777a986afb9a3e56ca5
 SHA512:
-  metadata.gz: b9774d7f5229a0202924ff253b251076ed7b5f71dd3e32f0707467663868faace9a331b79878e70159058ebbdde59b477892b13c662c1e3f9492fa31e6901551
-  data.tar.gz: 0d4e18520e7b23a28012edf77a98913358ef7793e70f46ddbdf881ad63c51eafc83325ef7a388d37b752914d55b0f6e9d23dc50efbb23afc98bf1f5aebd25be0
+  metadata.gz: 3462c80267b7dd02fbaa07a5386187a285f6b4c7ebff7a122f961c59d9ecc9b6d16e0a5b1d25b37236051265552d7b5b89a10984cf45e8fbf7a8f2c054f5b79c
+  data.tar.gz: b8b8d763e2d13f62ffb24ce53a82882a58517abe61179b5aa509a3263a7366377d305da7fdbb057430a248284a6675c48ee39fab61d4872ae6be1245a7dbb874

data/lib/graphql/client.rb

@@ -210,11 +210,14 @@ module GraphQL
           definition_dependencies.merge(fragment.document.definitions)
           "...#{fragment.definition_name}"
         else
-          message = if fragment
-                      "expected #{const_name} to be a #{FragmentDefinition}, but was a #{fragment.class}"
-                    else
-                      "uninitialized constant #{const_name}"
-                    end
+          if fragment
+            message = "expected #{const_name} to be a #{FragmentDefinition}, but was a #{fragment.class}."
+            if fragment.is_a?(Module) && fragment.constants.any?
+              message += " Did you mean #{fragment}::#{fragment.constants.first}?"
+            end
+          else
+            message = "uninitialized constant #{const_name}"
+          end
 
           error = ValidationError.new(message)
           error.set_backtrace(["#{filename}:#{lineno + match.pre_match.count("\n") + 1}"] + caller)

data/lib/graphql/client/query_result.rb

@@ -14,6 +14,11 @@ module GraphQL
     #
     # Wrappers also limit field visibility to fragment definitions.
     class QueryResult
+      class NoFieldError < Error; end
+      class ImplicitlyFetchedFieldError < NoFieldError; end
+      class UnfetchedFieldError < NoFieldError; end
+      class UnimplementedFieldError < NoFieldError; end
+
       # Internal: Get QueryResult class for result of query.
       #
       # Returns subclass of QueryResult or nil.
@@ -248,7 +253,24 @@ module GraphQL
       def method_missing(*args)
         super
       rescue NoMethodError => e
-        raise NoMethodError, "undefined method `#{e.name}' for #{inspect}"
+        type = self.class.type
+        raise e unless type
+
+        unless type.fields[e.name.to_s]
+          raise UnimplementedFieldError, "undefined field `#{e.name}' on #{type} type. https://git.io/v1y3m"
+        end
+
+        if data[e.name.to_s]
+          error_class = ImplicitlyFetchedFieldError
+          message = "implicitly fetched field `#{e.name}' on #{type} type. https://git.io/v1yGL"
+        else
+          error_class = UnfetchedFieldError
+          message = "unfetched field `#{e.name}' on #{type} type. https://git.io/v1y3U"
+        end
+
+        node = self.class.source_node
+        message += "\n\n" + node.to_query_string.sub(/\}$/, "+ #{e.name}\n}") if node
+        raise error_class, message
       end
 
       def respond_to_missing?(*args)

data/lib/rubocop/cop/graphql/heredoc.rb

@@ -16,7 +16,12 @@ module RuboCop
 
         def check_str(node)
           return unless node.location.is_a?(Parser::Source::Map::Heredoc)
-          return unless node.location.expression.source == "<<-GRAPHQL"
+          return unless node.location.expression.source =~ /^<<(-|~)?GRAPHQL/
+
+          node.each_child_node(:begin) do |begin_node|
+            add_offense(begin_node, :expression, "Do not interpolate variables into GraphQL queries, " \
+              "used variables instead.")
+          end
 
           add_offense(node, :expression, "GraphQL heredocs should be quoted. <<-'GRAPHQL'")
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql-client
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - GitHub
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-12-01 00:00:00.000000000 Z
+date: 2016-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -92,6 +92,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '11.2'
+- !ruby/object:Gem::Dependency
+  name: rubocop-github
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.2'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement