graphql-anycable 1.3.3 → 1.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ba22f385767198acc338809a6b60237248dfc15ecdd2f279a31628e6dad013e8
-  data.tar.gz: 6e59e6c8119969ee8358219b080abecb05df38d6ffe5549adbc58869f214872d
+  metadata.gz: 8d1012a281016a5fdd02aa9a1decc2d3935f545fef5899c15505dfeef64c9628
+  data.tar.gz: ae8f4ff4cb25da208b31b8a257f60307bf66fe626362741ea29705c97bcab8e1
 SHA512:
-  metadata.gz: 3479edd8cf0548d649ca3a0aaaeea728a8030c22342b50cb41beacca14b2ab7391bc9fc1cd2783ca861a07c8049b4ef1256e735fc97468469372213a822c9201
-  data.tar.gz: f6595e5f63dd71d375ec8d90816ae102839a8fda29bfc3f3400af10dedbcbf0cd4fb587d1462233b1a1b733801dfa5af8f172fc1f0906c4b4ba4db6e5250eebf
+  metadata.gz: 3c37a74df3ffc723b7b2fcf7bbfc009b3d67df79275d1c027b22bec3c9f45d6b3a5896b270582c50fc0deb78e38c1f7bc4f38a03288aa941ac20ed584538a3c8
+  data.tar.gz: 7dff7ea7638ee30a09bbc889648db4e0ebf4a12ba2798f215b013f29bb92e146241b0a9e4cad167c4691fbe15141ef085966f4799d708352ed1729628c97d634

data/.github/workflows/test.yml

@@ -19,13 +19,17 @@ jobs:
       matrix:
         include:
           - ruby: "4.0"
-            graphql: '~> 2.3'
+            graphql: '~> 2.6'
             anycable: '~> 1.6'
             redis_version: latest
+          - ruby: "3.4"
+            graphql: '~> 2.5.0'
+            anycable: '~> 1.6'
+            redis_version: '7.4'
           - ruby: "3.3"
-            graphql: '~> 2.3'
+            graphql: '~> 2.3.0'
             anycable: '~> 1.5'
-            redis_version: latest
+            redis_version: '7.4'
           - ruby: "3.2"
             graphql: '~> 2.2.0'
             anycable: '~> 1.5.0'

data/CHANGELOG.md

@@ -7,6 +7,20 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## Unreleased
 
+## 1.3.4 - 2026-08-21
+
+### Fixed
+
+- Return `nil` from `read_subscription` if subscription data has gone from Redis, That was resulted in a "No query string was present" errors received on graphql subscription clients receiving a hash with an `nil` `query_string` instead of receiving `nil` directly. [@thlacroix] ([#51](https://github.com/anycable/graphql-anycable/pull/51))
+
+- Subscription events are no longer dropped when another subscription with the same fingerprint expires during execution. [@prog-supdex] ([#53](https://github.com/anycable/graphql-anycable/pull/53))
+
+- Deleting a subscription no longer goes through the deprecated `GraphQL::AnyCable.redis`; this avoids both the deprecation warning and reusing a connection after it has been returned to the pool. [@Envek] ([#53](https://github.com/anycable/graphql-anycable/pull/53))
+
+### Changed
+
+- `GraphQL::Subscriptions::AnyCableSubscriptions#read_subscription` now raises `GraphQL::AnyCable::SubscriptionExpiredError` when the subscription is no longer stored in Redis, instead of returning `nil`. [@Envek] ([#53](https://github.com/anycable/graphql-anycable/pull/53))
+
 ## 1.3.3 - 2026-08-10
 
 ### Fixed
@@ -231,6 +245,7 @@ Technical release to test publishing via GitHub Actions.
 
 Initial version: store subscriptions on redis, re-execute queries in sync. [@Envek]
 
+[@thlacroix]: https://github.com/thlacroix "Thomas Lacroix"
 [@jjb]: https://github.com/jjb "John Bachir"
 [@prog-supdex]: https://github.com/prog-supdex "Igor Platonov"
 [@ilyasgaraev]: https://github.com/ilyasgaraev "Ilyas Garaev"

data/lib/graphql/anycable/errors.rb

@@ -16,5 +16,9 @@ module GraphQL
         DEFAULT_MESSAGE
       end
     end
+
+    # This error is raised when a subscription is gone from Redis by the time it is read,
+    # so that the caller can tell it from an update GraphQL has deliberately skipped.
+    class SubscriptionExpiredError < ::RuntimeError; end
   end
 end

data/lib/graphql/anycable/version.rb

@@ -2,6 +2,6 @@
 
 module GraphQL
   module AnyCable
-    VERSION = "1.3.3"
+    VERSION = "1.3.4"
   end
 end

data/lib/graphql/subscriptions/anycable_subscriptions.rb

@@ -95,10 +95,20 @@ module GraphQL
       def execute_grouped(fingerprint, subscription_ids, event, object)
         return if subscription_ids.empty?
 
-        subscription_id = with_redis { |redis| subscription_ids.find { |sid| redis.exists?(redis_key(SUBSCRIPTION_PREFIX) + sid) } }
-        return unless subscription_id # All subscriptions has expired but haven't cleaned up yet
+        result = nil
+
+        subscription_ids.each do |subscription_id|
+          result = execute_update(subscription_id, event, object)
+
+          # Whatever GraphQL has decided here — including a nil result for NO_UPDATE or
+          # for #unsubscribe without a final update — applies to the whole group, as all
+          # of its subscriptions share the same fingerprint. So, ask only one of them.
+          break
+        rescue GraphQL::AnyCable::SubscriptionExpiredError
+          # This one is gone, but the rest of the group is still waiting for the update
+          next
+        end
 
-        result = execute_update(subscription_id, event, object)
         return unless result
 
         # Having calculated the result _once_, send the same payload to all subscribers
@@ -162,19 +172,27 @@ module GraphQL
       end
 
       # Return the query from "storage" (in redis)
+      # @raise [GraphQL::AnyCable::SubscriptionExpiredError] if it is not stored anymore
       def read_subscription(subscription_id)
-        with_redis do |redis|
+        subscription = with_redis do |redis|
           redis.mapped_hmget(
             "#{redis_key(SUBSCRIPTION_PREFIX)}#{subscription_id}",
             :query_string, :variables, :context, :operation_name
-          ).tap do |subscription|
-            next if subscription.values.all?(&:nil?) # Redis returns hash with all nils for missing key
-
-            subscription[:context] = @serializer.load(subscription[:context])
-            subscription[:variables] = JSON.parse(subscription[:variables])
-            subscription[:operation_name] = nil if subscription[:operation_name].strip == ""
-          end
+          )
         end
+
+        # Give the connection back before raising or deserializing: a connector may be
+        # backed by a pool, and neither of these needs Redis anymore.
+        #
+        # Redis returns a hash with nil values for a missing key. A subscription without
+        # a query string is unusable anyway, so treat a half-written one as missing, too.
+        raise GraphQL::AnyCable::SubscriptionExpiredError, subscription_id if subscription[:query_string].nil?
+
+        subscription[:context] = @serializer.load(subscription[:context])
+        subscription[:variables] = JSON.parse(subscription[:variables])
+        subscription[:operation_name] = nil if subscription[:operation_name].to_s.strip == ""
+
+        subscription
       end
 
       # The channel was closed, forget about it and its subscriptions
@@ -194,7 +212,9 @@ module GraphQL
         end
       end
 
-      def delete_subscription(subscription_id, redis: AnyCable.redis)
+      def delete_subscription(subscription_id, redis: nil)
+        return with_redis { |connection| delete_subscription(subscription_id, redis: connection) } unless redis
+
         events = redis.hget(redis_key(SUBSCRIPTION_PREFIX) + subscription_id, :events)
         events = events ? JSON.parse(events) : {}
         fingerprint_subscriptions = {}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphql-anycable
 version: !ruby/object:Gem::Version
-  version: 1.3.3
+  version: 1.3.4
 platform: ruby
 authors:
 - Andrey Novikov
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-08-10 00:00:00.000000000 Z
+date: 2026-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: anycable-core