graphlient 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0da18e4b9370c65fb4e6add0b644c89b55149b32
-  data.tar.gz: 39a55d067517d0be0f609ea3fcea3836cc0c4e9c
+  metadata.gz: 3243a1525db30d3bf16a4bc9fc699e07c829a3d5
+  data.tar.gz: 37d6d5fc32ce427967b06d3975b80d393af333a8
 SHA512:
-  metadata.gz: d443d7ca4023923bce79d474e59bab4e7f85fb2b4f270fd8466435997c89dfb8bb763821728b428d7e8dde0f196b4f2e4ae8e9747c805e11dbae301707b7326f
-  data.tar.gz: 3bf4e9568f17b0a26566a1d79f422395ce545a6273ca37c8d177a858734e78dcee1d3a5706678e0613998a67d63d7b309dec0be14b9edef0342759b9943d5917
+  metadata.gz: 29a39b7c44150ad3e9182b98e14ed407a688fffefb6a2fa1a62644130cb6c4c04bc694584d6cd6dab5b0b9321911d905b5a902a50aa11fcf75ac6747b1c15d7b
+  data.tar.gz: d665ba561261fa682ec71888810d9767f3f9a1a6ad4d8186832454d0220fbcfc1ad9957a9ca1af8136019c6848f20cae849e94c2a57812d73cd822d97fd15f76

data/.rubocop.yml

@@ -1,4 +1,19 @@
 Style/FrozenStringLiteralComment:
   Enabled: false
 
+Style/Documentation:
+  Enabled: false
+
+Metrics/LineLength:
+  Enabled: false
+
+Metrics/MethodLength:
+  Enabled: false
+
+Metrics/BlockLength:
+  Enabled: false
+
+Metrics/AbcSize:
+  Enabled: false
+
 inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2017-10-25 13:18:43 -0400 using RuboCop version 0.47.1.
+# on 2017-10-26 13:24:56 -0400 using RuboCop version 0.47.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -8,27 +8,10 @@
 
 # Offense count: 1
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyleAlignWith, SupportedStylesAlignWith, AutoCorrect.
-# SupportedStylesAlignWith: keyword, variable, start_of_line
-Lint/EndAlignment:
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
+Lint/UnusedMethodArgument:
   Exclude:
-    - 'lib/graphlient/client.rb'
-
-# Offense count: 11
-# Configuration parameters: CountComments, ExcludedMethods.
-Metrics/BlockLength:
-  Max: 178
-
-# Offense count: 19
-# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
-# URISchemes: http, https
-Metrics/LineLength:
-  Max: 177
-
-# Offense count: 2
-# Configuration parameters: CountComments.
-Metrics/MethodLength:
-  Max: 12
+    - 'lib/graphlient/adapters/http/http_adapter.rb'
 
 # Offense count: 1
 # Configuration parameters: EnforcedStyle, SupportedStyles.
@@ -37,18 +20,6 @@ Style/ClassAndModuleChildren:
   Exclude:
     - 'spec/graphlient/static_client_query_spec.rb'
 
-# Offense count: 6
-Style/Documentation:
-  Exclude:
-    - 'spec/**/*'
-    - 'test/**/*'
-    - 'lib/graphlient/adapters/faraday_adapter.rb'
-    - 'lib/graphlient/client.rb'
-    - 'lib/graphlient/errors/error.rb'
-    - 'lib/graphlient/errors/graphql.rb'
-    - 'lib/graphlient/extensions/query.rb'
-    - 'lib/graphlient/query.rb'
-
 # Offense count: 2
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
@@ -64,7 +35,7 @@ Style/MethodMissing:
     - 'lib/graphlient/extensions/query.rb'
     - 'lib/graphlient/query.rb'
 
-# Offense count: 2
+# Offense count: 3
 Style/MultilineBlockChain:
   Exclude:
     - 'spec/graphlient/client_query_spec.rb'

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+### 0.0.9 (10/26/2017)
+
+* [#28](https://github.com/ashkan18/graphlient/pull/28): Raise errors in `execute`, not only `query` - [@dblock](https://github.com/dblock).
+* [#29](https://github.com/ashkan18/graphlient/pull/29): Added `Graphlient::Adapters::HTTP::HTTPAdapter` that replaces Faraday with `Net::HTTP` - [@dblock](https://github.com/dblock).
+
 ### 0.0.8 (10/26/2017)
 
 * [#27](https://github.com/ashkan18/graphlient/pull/27): Always raise an exception unless a query has succeeded - [@dblock](https://github.com/dblock).

data/README.md

@@ -265,9 +265,19 @@ query.to_s
 # "\nquery{\n  invoice(id: 10){\n    line_items\n    }\n  }\n"
 ```
 
+### Swapping the HTTP Stack
+
+You can swap the default Faraday adapter for `Net::HTTP`.
+
+```ruby
+client = Graphlient::Client.new('https://test-graphql.biz/graphql',
+  http: Graphlient::Adapters::HTTP::HTTPAdapter
+)
+```
+
 ### Testing with Graphlient and RSpec
 
-Use Graphlient inside your RSpec tests in a Rails application or with `Rack::Test`, no more messy HTTP POSTs.
+Use Graphlient inside your RSpec tests in a Rails application or with `Rack::Test` against your actual application.
 
 ```ruby
 require 'spec_helper'
@@ -307,6 +317,26 @@ describe App do
 end
 ```
 
+Alternately you can `stub_request` with Webmock.
+
+```ruby
+describe App do
+  let(:url) { 'http://example.com/graphql' }
+  let(:client) { Graphlient::Client.new(url) }
+
+  before do
+    stub_request(:post, url).to_return(
+      status: 200,
+      body: DummySchema.execute(GraphQL::Introspection::INTROSPECTION_QUERY).to_json
+    )
+  end
+
+  it 'retrieves schema' do
+    expect(client.schema).to be_a GraphQL::Schema
+  end
+end
+```
+
 ## License
 
 MIT License, see [LICENSE](LICENSE)

data/lib/graphlient.rb

@@ -1,5 +1,7 @@
+require 'graphql/client'
 require 'graphlient/version'
 require 'graphlient/extensions'
 require 'graphlient/errors'
 require 'graphlient/query'
+require 'graphlient/adapters'
 require 'graphlient/client'

data/lib/graphlient/adapters.rb

@@ -0,0 +1 @@
+require_relative 'adapters/http'

data/lib/graphlient/adapters/http.rb

@@ -0,0 +1,3 @@
+require_relative 'http/adapter'
+require_relative 'http/faraday_adapter'
+require_relative 'http/http_adapter'

data/lib/graphlient/adapters/http/adapter.rb

@@ -0,0 +1,23 @@
+module Graphlient
+  module Adapters
+    module HTTP
+      class Adapter
+        attr_accessor :url, :options
+
+        def initialize(url, options = {}, &_block)
+          @url = url
+          @options = options.dup if options
+          yield self if block_given?
+        end
+
+        def headers
+          options[:headers] if options
+        end
+
+        def execute(*)
+          raise NotImplementedError
+        end
+      end
+    end
+  end
+end

data/lib/graphlient/adapters/http/faraday_adapter.rb

@@ -0,0 +1,37 @@
+require 'faraday'
+require 'faraday_middleware'
+
+module Graphlient
+  module Adapters
+    module HTTP
+      class FaradayAdapter < Adapter
+        def execute(document:, operation_name:, variables:, context:)
+          response = connection.post do |req|
+            req.headers.merge!(context[:headers] || {})
+            req.body = {
+              query: document.to_query_string,
+              operationName: operation_name,
+              variables: variables.to_json
+            }.to_json
+          end
+          response.body
+        rescue Faraday::ClientError => e
+          raise Graphlient::Errors::Server.new(e.message, e)
+        end
+
+        def connection
+          @connection ||= Faraday.new(url: url, headers: headers) do |c|
+            c.use Faraday::Response::RaiseError
+            c.request :json
+            c.response :json
+            if block_given?
+              yield c
+            else
+              c.use Faraday::Adapter::NetHttp
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/graphlient/adapters/http/http_adapter.rb

@@ -0,0 +1,39 @@
+require 'graphql/client/http'
+
+module Graphlient
+  module Adapters
+    module HTTP
+      class HTTPAdapter < Adapter
+        attr_reader :uri
+
+        def execute(document:, operation_name: nil, variables: {}, context: {})
+          request = Net::HTTP::Post.new(url)
+
+          request['Accept'] = 'application/json'
+          request['Content-Type'] = 'application/json'
+          headers&.each { |name, value| request[name] = value }
+
+          body = {}
+          body['query'] = document.to_query_string
+          body['variables'] = variables if variables.any?
+          body['operationName'] = operation_name if operation_name
+          request.body = JSON.generate(body)
+
+          response = connection.request(request)
+          raise Graphlient::Errors::Server.new("the server responded with status #{response.code}", response) unless response.is_a?(Net::HTTPOK)
+          JSON.parse(response.body)
+        end
+
+        def uri
+          @uri ||= URI(url)
+        end
+
+        def connection
+          Net::HTTP.new(uri.host, uri.port).tap do |client|
+            client.use_ssl = uri.scheme == 'https'
+          end
+        end
+      end
+    end
+  end
+end

data/lib/graphlient/client.rb

@@ -1,6 +1,3 @@
-require 'graphql/client'
-require 'graphlient/adapters/faraday_adapter'
-
 module Graphlient
   class Client
     attr_accessor :uri, :options
@@ -16,6 +13,8 @@ module Graphlient
         instance_eval(&block)
       end
       client.parse(query_str.to_s)
+    rescue GraphQL::Client::Error => e
+      raise Graphlient::Errors::Client.new(e.message, e)
     end
 
     def execute(query, variables = nil)
@@ -23,25 +22,27 @@ module Graphlient
       query_params[:context] = @options if @options
       query_params[:variables] = variables if variables
       query = client.parse(query) if query.is_a?(String)
-      client.query(query, query_params)
+      rc = client.query(query, query_params)
+      raise Graphlient::Errors::GraphQL, rc if rc.errors.any?
+      rc
     rescue GraphQL::Client::Error => e
       raise Graphlient::Errors::Client.new(e.message, e)
     end
 
     def query(query_or_variables = nil, variables = nil, &block)
-      rc = if block_given?
-             execute(parse(&block), query_or_variables)
-           else
-             execute(query_or_variables, variables)
+      if block_given?
+        execute(parse(&block), query_or_variables)
+      else
+        execute(query_or_variables, variables)
       end
-      raise Graphlient::Errors::GraphQL, rc if rc.errors.any?
-      rc
-    rescue GraphQL::Client::Error => e
-      raise Graphlient::Errors::Client.new(e.message, e)
+    end
+
+    def http_adapter_class
+      options[:http] || Adapters::HTTP::FaradayAdapter
     end
 
     def http(&block)
-      @http ||= Adapters::FaradayAdapter.new(@url, headers: @options[:headers], &block)
+      @http ||= http_adapter_class.new(@url, headers: @options[:headers], &block)
     end
 
     def schema

data/lib/graphlient/version.rb

@@ -1,3 +1,3 @@
 module Graphlient
-  VERSION = '0.0.8'.freeze
+  VERSION = '0.0.9'.freeze
 end

data/spec/graphlient/adapters/{faraday_adapter_spec.rb → http/faraday_adapter_spec.rb}

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Graphlient::Adapters::FaradayAdapter do
+describe Graphlient::Adapters::HTTP::FaradayAdapter do
   let(:app) { Object.new }
 
   context 'with a custom middleware' do
@@ -41,4 +41,20 @@ describe Graphlient::Adapters::FaradayAdapter do
       expect(client.http.headers).to eq headers
     end
   end
+
+  context 'default' do
+    let(:url) { 'http://example.com/graphql' }
+    let(:client) { Graphlient::Client.new(url) }
+
+    before do
+      stub_request(:post, url).to_return(
+        status: 200,
+        body: DummySchema.execute(GraphQL::Introspection::INTROSPECTION_QUERY).to_json
+      )
+    end
+
+    it 'retrieves schema' do
+      expect(client.schema).to be_a GraphQL::Schema
+    end
+  end
 end

data/spec/graphlient/adapters/http/http_adapter_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+describe Graphlient::Adapters::HTTP::HTTPAdapter do
+  let(:app) { Object.new }
+
+  context 'with custom url and headers' do
+    let(:url) { 'http://example.com/graphql' }
+    let(:headers) { { 'Foo' => 'bar' } }
+    let(:client) do
+      Graphlient::Client.new(url, headers: headers, http: Graphlient::Adapters::HTTP::HTTPAdapter)
+    end
+
+    it 'sets adapter' do
+      expect(client.http).to be_a Graphlient::Adapters::HTTP::HTTPAdapter
+    end
+
+    it 'sets url' do
+      expect(client.http.url).to eq url
+    end
+
+    it 'sets headers' do
+      expect(client.http.headers).to eq headers
+    end
+  end
+
+  context 'default' do
+    let(:url) { 'http://example.com/graphql' }
+    let(:client) { Graphlient::Client.new(url, http: Graphlient::Adapters::HTTP::HTTPAdapter) }
+
+    before do
+      stub_request(:post, url).to_return(
+        status: 200,
+        body: DummySchema.execute(GraphQL::Introspection::INTROSPECTION_QUERY).to_json
+      )
+    end
+
+    it 'retrieves schema' do
+      expect(client.schema).to be_a GraphQL::Schema
+    end
+  end
+end

data/spec/graphlient/client_query_spec.rb

@@ -75,6 +75,14 @@ describe Graphlient::Client do
         expect(invoices.first.id).to eq 42
         expect(invoices.first.fee_in_cents).to eq 20_000
       end
+
+      it 'fails when wrong input type' do
+        expect do
+          client.execute(query, ids: ['42'])
+        end.to raise_error Graphlient::Errors::GraphQL do |e|
+          expect(e.to_s).to eq "Variable ids of type [Int] was provided invalid value\n  0: Could not coerce value \"42\" to Int"
+        end
+      end
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: graphlient
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Ashkan Nasseri
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-26 00:00:00.000000000 Z
+date: 2017-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: graphql-client
@@ -74,7 +74,11 @@ files:
 - Rakefile
 - graphlient.gemspec
 - lib/graphlient.rb
-- lib/graphlient/adapters/faraday_adapter.rb
+- lib/graphlient/adapters.rb
+- lib/graphlient/adapters/http.rb
+- lib/graphlient/adapters/http/adapter.rb
+- lib/graphlient/adapters/http/faraday_adapter.rb
+- lib/graphlient/adapters/http/http_adapter.rb
 - lib/graphlient/client.rb
 - lib/graphlient/errors.rb
 - lib/graphlient/errors/client.rb
@@ -85,7 +89,8 @@ files:
 - lib/graphlient/extensions/query.rb
 - lib/graphlient/query.rb
 - lib/graphlient/version.rb
-- spec/graphlient/adapters/faraday_adapter_spec.rb
+- spec/graphlient/adapters/http/faraday_adapter_spec.rb
+- spec/graphlient/adapters/http/http_adapter_spec.rb
 - spec/graphlient/client_query_spec.rb
 - spec/graphlient/client_schema_spec.rb
 - spec/graphlient/extensions/query_spec.rb
@@ -119,7 +124,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.12
 signing_key: 
 specification_version: 4
 summary: Ruby Gem for consuming GraphQL endpoints

data/lib/graphlient/adapters/faraday_adapter.rb

@@ -1,43 +0,0 @@
-require 'faraday'
-require 'faraday_middleware'
-
-module Graphlient
-  module Adapters
-    class FaradayAdapter
-      attr_accessor :url, :headers
-
-      def initialize(url, headers:, &_block)
-        @url = url
-        @headers = headers.dup if headers
-        yield self if block_given?
-      end
-
-      def execute(document:, operation_name:, variables:, context:)
-        response = connection.post do |req|
-          req.headers.merge!(context[:headers] || {})
-          req.body = {
-            query: document.to_query_string,
-            operationName: operation_name,
-            variables: variables.to_json
-          }.to_json
-        end
-        response.body
-      rescue Faraday::ClientError => e
-        raise Graphlient::Errors::Server.new(e.message, e)
-      end
-
-      def connection
-        @connection ||= Faraday.new(url: url, headers: headers) do |c|
-          c.use Faraday::Response::RaiseError
-          c.request :json
-          c.response :json
-          if block_given?
-            yield c
-          else
-            c.use Faraday::Adapter::NetHttp
-          end
-        end
-      end
-    end
-  end
-end