grape-middleware-logger 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 38faa42e694ac5c8b974975c8e5f8819c073c028
-  data.tar.gz: d5da71383af6b787ad2380e7d408ea3974553c4a
+  metadata.gz: fff85131fb1c55207dcfe522acde1ad666839cc8
+  data.tar.gz: fc6f65023b7645ac2ba0b48aba20739d07b1b60a
 SHA512:
-  metadata.gz: 2ad87065915b6f9a6b932b7ac198434de5cda37b55812dadc716544c1eb346fb602d5e4be32a006516cc4cba1955e44d9b3543f1e711f905bff41452c777216e
-  data.tar.gz: cf6f37a8a9878aa7d677b401c1f7aac37cdc559fc572057d6f0fcdcd939d798358b94f10252516ddf225a37abb24dd8bc606f28c793f19757afef8cc7bbdee69
+  metadata.gz: 1b984cb11a87cfbad641f934b2c336e1305dbb18880657012c6f2447329bb95350c528db6bdbdd01c4112a5de3275fe5c31d6edd31cb82e4ac25736aee8c6e04
+  data.tar.gz: b73d0d4cc26d63b2351e0058e7075fb74b140b46d982d24f73acd4ee8176f77d388cc94cdf031fde4069e76e0c8aeddf21341aa2b51b9be3d9abfade7e9b8545

data/lib/grape/middleware/logger.rb

@@ -9,9 +9,17 @@ module Grape
       # Overrides
       #
 
+      def before
+        @start_time = Time.now
+        super
+        logger.info ''
+        logger.info %Q(Started #{env['grape.request'].request_method} "#{env['grape.request'].path}")
+        logger.info %Q(  Parameters: #{parameters})
+      end
+
       def call!(env)
         @env = env
-        _before
+        before
         error = catch(:error) { @app_response = @app.call(@env); nil }
         if error
           after_failure(error)
@@ -31,14 +39,6 @@ module Grape
       # Helpers
       #
 
-      # @todo rename to +before+ when Grape v0.12.0 is released
-      def _before
-        @start_time = Time.now
-        logger.info ''
-        logger.info %Q(Started #{env['grape.request'].request_method} "#{env['grape.request'].path}")
-        logger.info %Q(  Parameters: #{parameters})
-      end
-
       def after_failure(error)
         logger.info %Q(  Error: #{error[:message]}) if error[:message]
         after(error[:status])

data/lib/grape/middleware/logger/version.rb

@@ -1,7 +1,7 @@
 module Grape
   module Middleware
     class Logger
-      VERSION = '0.1.0'
+      VERSION = '0.1.1'
     end
   end
 end

data/spec/lib/grape/middleware/logger_spec.rb

@@ -20,13 +20,16 @@ describe Grape::Middleware::Logger do
       }
     }
   }
+  # @todo remove when Grape v0.12.0 is released
+  before(:each) { allow(subject).to receive(:before) }
+
   describe '#call!' do
     context 'when calling the app results in an error response' do
       let(:error) { { status: 400 } }
 
       it 'calls +after_failure+ and rethrows the error' do
         expect(app).to receive(:call).with(env).and_throw(:error, error)
-        expect(subject).to receive(:_before)
+        expect(subject).to receive(:before)
         expect(subject).to receive(:after_failure).with(error)
         expect(subject).to receive(:throw).with(:error, error)
         subject.call!(env)
@@ -36,21 +39,21 @@ describe Grape::Middleware::Logger do
     context 'when there is no error' do
       it 'calls +after+ with the correct status' do
         expect(app).to receive(:call).with(env).and_return(app_response)
-        expect(subject).to receive(:_before)
+        expect(subject).to receive(:before)
         expect(subject).to receive(:after).with(200)
         subject.call!(env)
       end
 
       it 'returns the @app_response' do
         expect(app).to receive(:call).with(env).and_return(app_response)
-        allow(subject).to receive(:_before)
+        allow(subject).to receive(:before)
         allow(subject).to receive(:after)
         expect(subject.call!(env)).to eq app_response
       end
     end
 
     describe 'integration' do
-      it 'properly logs requests' do
+      it 'properly logs requests', pending: 'Grape v0.12.0' do
         expect(app).to receive(:call).with(env).and_return(app_response)
         expect(subject.logger).to receive(:info).with('')
         expect(subject.logger).to receive(:info).with(%Q(Started POST "/api/1.0/users"))

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: grape-middleware-logger
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Ryan Buckley