grape-batch 2.0.1 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bbbf72e7d25fcf89c630726e596e076196efe570
-  data.tar.gz: afdfe942d8894569147cec3e7665c1f7ef03811e
+  metadata.gz: 4e44f52d84088c227271799372c1dc9cdd570b65
+  data.tar.gz: bb3eebf865d2d329e81ad97e85655b1035faf4fd
 SHA512:
-  metadata.gz: 792bfb7fa1ad3361706e79035093e3b4ec9b26764f3d1810584345e72ee37f2365a1d404a958ce96de6790bb8179cbf21dafd4bfd335e336a54a03798c1d7774
-  data.tar.gz: 49ca34252acda3520aac0c20eb8efc597422ac2a1e1e3764bb828e71d8705cedc1d9fe50198823d86d34ef21d39a0717f48220695f3fe617b64ff44f9d589a1a
+  metadata.gz: 784cc47d4012ce202e0c089d50dd85fde29388a44758c01f7066ed9ef46c651c5eade41d4089d4753075f5a6722c95486685bcf3511e41bd0d146724c70ca16b
+  data.tar.gz: 133f5ba1ed2ca8efe5252acb652fb6dc15f6f07cf72b38d6ac32ee641d388b0ac7ac7030956b0bfab8d5bc4255a5393eca2646544e6e82191b7c165d51e6cd35

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 2.1.0 (4th November 2015)
+* Removed error response format because of unexpected side effects
+
 # 2.0.1 (30th September 2015)
 * Removed obsolete gem dependencies
 * Now ensures the response is properly formatted and not empty, or returns an error

data/lib/grape/batch.rb

@@ -57,7 +57,7 @@ module Grape
           status, headers, response = @app.call(tmp_env)
 
           # format response
-          @response_klass::format(status, headers, response, tmp_env)
+          @response_klass::format(status, headers, response)
         end
       end
 

data/lib/grape/batch/response.rb

@@ -1,22 +1,10 @@
 class Grape::Batch::Response
-  def self.format(status, headers, response, env)
+  def self.format(status, headers, response)
     if response
       body = response.respond_to?(:body) ? response.body.join : response.join
-      parsing_failed = true
-
-      begin
-        result = MultiJson.decode(body)
-        parsing_failed = false
-      rescue MultiJson::ParseError
-        # Captain planet to the rescue
-      end
-    end
-
-    if parsing_failed || result.empty?
-      status = 404
-      result = { 'error' => "#{env['PATH_INFO']} not found" }
+      result = MultiJson.decode(body)
     end
 
-    (200..299).include?(status) ? { success: result } : { code: status, error: result['error'] }
+    (200..299).include?(status) ? {success: result} : {code: status, error: result['error']}
   end
 end

data/lib/grape/batch/version.rb

@@ -1,5 +1,5 @@
 module Grape
   module Batch
-    VERSION = '2.0.1'
+    VERSION = '2.1.0'
   end
 end

data/spec/requests_spec.rb

@@ -134,12 +134,6 @@ RSpec.describe Grape::Batch::Base do
         it { expect(response.body).to eq(encode([{ success: 'status 856' }])) }
       end
 
-      context 'with an unknown version' do
-        let(:request_body) { encode({ requests: [{ method: 'GET', path: '/api/v2/status', body: { id: 856 } }] }) }
-        it { expect(response.status).to eq(200) }
-        it { expect(response.body).to eq(encode([{ code: 404, error: '/api/v2/status not found' }])) }
-      end
-
       context 'with a body and nested hash' do
         let(:complex) do
           { a: { b: { c: 1 } } }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: grape-batch
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.1.0
 platform: ruby
 authors:
 - Lionel Oto
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-30 00:00:00.000000000 Z
+date: 2015-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: grape