grantinee 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 89f4f8af1525d7207329302102d430e7c85b672a1832eb8a7fa121d19d6fc2a2
-  data.tar.gz: 448874152dafa01650d28c0b8e8d68d7360c70c793aed37afc0b2a6e4e4bd16d
+  metadata.gz: bd59012e89ac1bad99cc95da8f1915b2c026fad022ab0e00740320cbcc26ce50
+  data.tar.gz: f1f48a160ecc3745bf508f1615565b1a6996e8403294da7681c63fb1bcee766f
 SHA512:
-  metadata.gz: aaff1cad9f6a2e7ca2ba5d2fdadfb896104284e1905a8d3f0f984f3f406c162ccc91ae3b9cfd52ae533e3718f123617537545b9fef5fcb00a8336fea51be34fa
-  data.tar.gz: e240c5fdb3223483dca84b61dfe3b2e8730ebb6875be4eea955c3a5de42be0c5eceb7e7376a62c4e4fbab0b3967b5547a1d507fc954a9a492e994acfbb97d6f6
+  metadata.gz: a4a527b5f2cf5992a3bed8f290f20675e12c2f1f15913ea0f0abc3b2daf73211fa1887bf42743a6de3fd5747dddfce47dafb2bf229c11c2f86f6f3f554d64425
+  data.tar.gz: c6c3af0d7e868aaf07f438901009cc1b7e5379d67e1719aeeb49aa07d6dff307a5457138d3d8a60c9dd14e17ac8b8fcc42dcd4aaf16a23ed27898681ee61f5b0

data/.rubocop.yml

@@ -1,3 +1,6 @@
+AllCops:
+  TargetRubyVersion: 2.3
+
 Layout/CaseIndentation:
   EnforcedStyle: end
 
@@ -9,13 +12,16 @@ Lint/HandleExceptions:
   Enabled: false
   
 Metrics/AbcSize:
-  Max: 17
+  Max: 20
 
 Metrics/BlockLength:
   Exclude:
     - "grantinee.gemspec"
     - "spec/**/*"
 
+Metrics/CyclomaticComplexity:
+  Enabled: false
+
 Metrics/LineLength:
   Max: 100
   Exclude:
@@ -24,6 +30,10 @@ Metrics/LineLength:
 Metrics/MethodLength:
   Max: 15
 
+Metrics/ModuleLength:
+  Exclude:
+    - "spec/**/*"
+
 Security/Eval:
   Enabled: false
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    grantinee (0.3.1)
+    grantinee (0.3.3)
 
 GEM
   remote: https://rubygems.org/

data/README.md

@@ -2,8 +2,10 @@
 
 Grantinee is a library to manage your database permissions. It supports MySQL and Postgres, allowing for granular per-table, and per-column permission setting. Tight and explicit permissions, instead of "allow all access" approach, may enhance the data security in your app, and make the GDPR compliance easier for multi-user databases (like when you have a service-oriented architecture).
 
+[![Gem Version](https://badge.fury.io/rb/grantinee.svg)](https://badge.fury.io/rb/grantinee)
 [![CircleCI](https://circleci.com/gh/blinkist/grantinee/tree/master.svg?style=svg&circle-token=be47ddf3e39aa44795797ae40c06bd42144ad888)](https://circleci.com/gh/blinkist/grantinee/tree/master)
 
+
 ## Installation
 
 Add this line to your application's Gemfile:

data/grantinee.gemspec

@@ -7,8 +7,8 @@ require "grantinee/version"
 Gem::Specification.new do |spec|
   spec.name          = "grantinee"
   spec.version       = Grantinee::VERSION
-  spec.authors       = ["Paweł Komarnicki"]
-  spec.email         = ["pawel@blinkist.com"]
+  spec.authors       = ["Paweł Komarnicki", "John Donner"]
+  spec.email         = ["pawel@blinkist.com", "john@blinkist.com"]
 
   spec.summary       = '"Your permissions, freshly baked!" | A library to manage your database permissions for MySQL and Postgres'
   spec.description   = "A Ruby library to manage your database permissions for MySQL and PostgreSQL. Supports per-table, and per-column permissions for granular access and security."

data/lib/grantinee/cli.rb

@@ -108,9 +108,19 @@ module Grantinee
 
     # Database configuration file
     def process_database_param
-      require options[:config] if options[:config]
+      unless @options[:config] || Grantinee.configuration.configured?
+        Grantinee::Engine.detect_active_record_connection!
 
-      Grantinee::Engine.detect_active_record_connection! unless Grantinee.configuration.configured?
+        unless Grantinee.configuration.configured?
+          raise "No configuration file found. Please use the -c option"\
+                " to pass a configuration file."
+        end
+      end
+
+      require options[:config]
+    rescue StandardError, LoadError => error
+      puts error
+      exit
     end
 
     # Grantinee file

data/lib/grantinee/configuration.rb

@@ -41,6 +41,8 @@ module Grantinee
         @engine = :postgres
       end
 
+      raise 'Invalid database url' unless uri.user && uri.host && uri.path
+
       @username = uri.user
       @password = uri.password
       @hostname = uri.host

data/lib/grantinee/dsl.rb

@@ -21,6 +21,8 @@ module Grantinee
       instance_eval(commands)
     end
 
+    private
+
     # Define database and mode
     def on(database, &block)
       logger.debug "Got database: #{database}"
@@ -54,8 +56,6 @@ module Grantinee
       end
     end
 
-    private
-
     def logger
       Grantinee.logger
     end

data/lib/grantinee/engine/mysql.rb

@@ -34,10 +34,10 @@ module Grantinee
       end
 
       def grant_permission!(data) # rubocop:disable Metrics/AbcSize
-        raise "Invalid permission kind" unless WHITELISTED_KINDS.include?(data[:kind])
+        raise "Invalid permission kind" unless WHITELISTED_KINDS.include?(data[:kind]&.downcase)
 
         database = sanitize_column_name(data[:database])
-        kind     = data[:kind]
+        kind     = data[:kind]&.upcase
         table    = sanitize_table_name(data[:table])
         user     = sanitize_value(data[:user])
         host     = sanitize_value(data[:host])

data/lib/grantinee/engine/postgresql.rb

@@ -24,16 +24,16 @@ module Grantinee
 
       def revoke_permissions!(data)
         database = sanitize_column_name(data[:database])
-        user     = sanitize_column_name(data[:database])
+        user     = sanitize_column_name(data[:user])
 
         query = "REVOKE ALL PRIVILEGES ON DATABASE #{database} FROM #{user};"
         run! query, data
       end
 
       def grant_permission!(data)
-        raise "Invalid permission kind" unless WHITELISTED_KINDS.include?(data[:kind])
+        raise "Invalid permission kind" unless WHITELISTED_KINDS.include?(data[:kind]&.downcase)
 
-        kind   = data[:kind]
+        kind   = data[:kind]&.upcase
         table  = sanitize_table_name(data[:table])
         user   = sanitize_column_name(data[:user])
         fields = data[:fields].map { |v| sanitize_column_name(v.to_s) }.join(', ')

data/lib/grantinee/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Grantinee
-  VERSION = '0.3.2'.freeze
+  VERSION = '0.3.3'.freeze
 end

metadata

@@ -1,10 +1,11 @@
 --- !ruby/object:Gem::Specification
 name: grantinee
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Paweł Komarnicki
+- John Donner
 autorequire: 
 bindir: exe
 cert_chain: []
@@ -98,6 +99,7 @@ description: A Ruby library to manage your database permissions for MySQL and Po
   Supports per-table, and per-column permissions for granular access and security.
 email:
 - pawel@blinkist.com
+- john@blinkist.com
 executables:
 - grantinee
 extensions: []