granite-form 0.6.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7a1314ba3c2ba30bdc16261970529bae85d79d96c49f54fb445c350e6f828532
-  data.tar.gz: a868509fd29600d0c94ec7de9e20c584b1caf29d985f5e6a7334ffeb0df6a2ac
+  metadata.gz: 62a7935cb1b74f15d4599c3118e4b60728bcf8b27dac232a3893ef84d2b5f127
+  data.tar.gz: 2c6e8d0aeca6ca09aae7a364d2966a26c1ad1a4ab7f9986d348deeaab7688bdb
 SHA512:
-  metadata.gz: 27ad9896a8c1e282a220051ff2eac56bbcaa97cf4c378bceb26779051b36a888623b33aad6be0b30c1810efdb032c182f575fb9caf4e0c9fcc2ce9591d72d957
-  data.tar.gz: c989dc6d3e3f96597780d9b84ea0137cc1345a70047f56c400c0e3ca79900fe0b92f057b8be977390cf1ef75aef05154431e9b974351fe343b1fc55c8fa5b784
+  metadata.gz: 1545d76b21d34005b22708aa3670f7c893d322b388f217f70d21180d0dfa65621f694d87025e1b8c0fd243f97139b5f2e1a0c101a536c01750f3eba741ad0327
+  data.tar.gz: 0dbf480f6d6d8ebc4401ad698d3adfe8b894a2f07f6b32b9fdff0f3bc60605d7a97da1c305877db248f4a6005aebb836fa8000f22fb3c5096231e044d0491144

data/CHANGELOG.md

@@ -2,6 +2,13 @@
 
 ## Next
 
+## v0.6.1
+
+* Introduces `mass_assignment_strict_mode` configuration option to control the behavior of mass assignment.
+  * The setting is per class and configures strict handling of unknown attributes by raising an exception.
+  * By default it is disabled, and you need to opt-in.
+  * https://github.com/toptal/granite-form/pull/32
+
 ## v0.6.0
 
 * Fix crash when mapping PostgreSQL enum to ruby variable in https://github.com/toptal/granite-form/pull/28

data/lib/granite/form/model/attributes.rb

@@ -16,10 +16,13 @@ module Granite
         extend ActiveSupport::Concern
 
         included do
-          class_attribute :_attributes, :_attribute_aliases, :_sanitize, instance_reader: false, instance_writer: false
+          class_attribute :_attributes, :_attribute_aliases, :_sanitize,
+                          :mass_assignment_strict_mode,
+                          instance_reader: false, instance_writer: false
           self._attributes = {}
           self._attribute_aliases = {}
           self._sanitize = true
+          self.mass_assignment_strict_mode = false
 
           delegate :attribute_names, :has_attribute?, to: 'self.class'
 
@@ -180,7 +183,7 @@ module Granite
               public_send("#{name}=", value)
             else
               attribute_type = sanitize_value ? 'primary' : 'undefined'
-              logger.debug("Ignoring #{attribute_type} `#{name}` attribute value for #{self} during mass-assignment")
+              report_unknown_attribute(attribute_type, name)
             end
           end
         end
@@ -208,6 +211,12 @@ module Granite
 
         private
 
+        def report_unknown_attribute(attribute_type, name)
+          raise ActiveModel::UnknownAttributeError.new(self, name.to_s) if self.class.mass_assignment_strict_mode
+
+          logger.debug("Ignoring #{attribute_type} `#{name}` attribute value for #{self} during mass-assignment")
+        end
+
         def attributes_for_inspect
           attribute_names(false).map do |name|
             prefix = self.class.primary_name == name ? '*' : ''

data/lib/granite/form/version.rb

@@ -1,5 +1,5 @@
 module Granite
   module Form
-    VERSION = '0.6.0'.freeze
+    VERSION = '0.6.1'.freeze
   end
 end

data/spec/granite/form/model/attributes_spec.rb

@@ -206,6 +206,27 @@ describe Granite::Form::Model::Attributes do
         end
       end
     end
+
+    context 'with mass_assignment_strict_mode' do
+      let(:model) do
+        stub_model do
+          self.mass_assignment_strict_mode = true
+          attribute :full_name, String
+          alias_attribute :name, :full_name
+        end
+      end
+
+      specify do
+        expect do
+          subject.assign_attributes(name: 'name', unexisting: 'value')
+        end.to raise_error(ActiveModel::UnknownAttributeError, /unknown attribute 'unexisting' for/)
+      end
+
+      specify do
+        subject.assign_attributes(name: 'name', full_name: 'full_name')
+        expect(subject.name).to eq('full_name')
+      end
+    end
   end
 
   describe '#sync_attributes' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: granite-form
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Toptal Engineering
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-05-31 00:00:00.000000000 Z
+date: 2024-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -221,13 +221,12 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 description: Making object from any hash or hash array
-email: 
+email:
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".codeclimate.yml"
-- ".github/CODEOWNERS"
 - ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".rspec"
@@ -392,7 +391,7 @@ files:
 homepage: https://github.com/toptal/granite-form
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -407,8 +406,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.9
-signing_key: 
+rubygems_version: 3.4.19
+signing_key:
 specification_version: 4
 summary: Working with hashes in AR style
 test_files:

data/.github/CODEOWNERS

@@ -1 +0,0 @@
-* @toptal/devx