govuk_taxonomy_helpers 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4a9bcf516b96e7dcec97d7c83fc3915100922700
-  data.tar.gz: ded38f9b3e0d1602a22b4d3d1e498995a65048a9
+  metadata.gz: e5c3007adf0ce60349335ca892e7e1dc794272fe
+  data.tar.gz: b33cdedec387f8fdbd42ede8a5d35c6a6cff0bcb
 SHA512:
-  metadata.gz: 2a7bbbb176477e4d4c7611c900f4df8830579cc9b2289b93cb18b3a39bf397c2cfca51e57b3ef3c274cc1140fb4548a83e5912a9e85a22f34312593e4c3b6bdd
-  data.tar.gz: 2730337dfffb046d85fb25c84c728285bdd111245e3758ff7e0188dd87d2545936cfab48e3e7c4a7f4af3363e897e84cd673e14f43ce72c80b3b785c34f52642
+  metadata.gz: 2b3604308af84d0f683812197af5a2ccb72db718a59a797dec168756c82bf90fef5ab232432674ff66f98a33be64364f848814f75f2e1d40a2e5b583fc8402e2
+  data.tar.gz: f7a29142e29897c8950d2f634d1786e9a2254b272a893f31373404fbc89741a52a2888e933bcb67fb7d7ae13982da0fc3d195f7da76d9750e30a5ecfbe7eaeff

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.1.0
+
+* When parsing publishing api responses, allow both links and details hashes to
+  be omitted.
+
 ## 0.0.1
 
 * Gem created

data/lib/govuk_taxonomy_helpers/publishing_api_response.rb

@@ -23,9 +23,11 @@ module GovukTaxonomyHelpers
     # @param content_item [Hash] Publishing API `get_content` response hash
     # @param expanded_links [Hash] Publishing API `get_expanded_links` response hash
     def initialize(content_item:, expanded_links:)
+      details = content_item["details"] || {}
+
       @linked_content_item = LinkedContentItem.new(
         title: content_item["title"],
-        internal_name: content_item["details"]["internal_name"],
+        internal_name: details["internal_name"],
         content_id: content_item["content_id"],
         base_path: content_item["base_path"]
       )
@@ -62,14 +64,17 @@ module GovukTaxonomyHelpers
     end
 
     def parse_nested_child(nested_item)
+      details = nested_item["details"] || {}
+      links = nested_item["links"] || {}
+
       nested_linked_content_item = LinkedContentItem.new(
         title: nested_item["title"],
-        internal_name: nested_item["details"]["internal_name"],
+        internal_name: details["internal_name"],
         content_id: nested_item["content_id"],
         base_path: nested_item["base_path"]
       )
 
-      child_taxons = nested_item["links"]["child_taxons"]
+      child_taxons = links["child_taxons"]
 
       if !child_taxons.nil?
         child_taxons.each do |child|
@@ -81,14 +86,17 @@ module GovukTaxonomyHelpers
     end
 
     def parse_nested_parent(nested_item)
+      details = nested_item["details"] || {}
+      links = nested_item["links"] || {}
+
       nested_linked_content_item = LinkedContentItem.new(
         title: nested_item["title"],
-        internal_name: nested_item["details"]["internal_name"],
+        internal_name: details["internal_name"],
         content_id: nested_item["content_id"],
         base_path: nested_item["base_path"]
       )
 
-      parent_taxons = nested_item["links"]["parent_taxons"]
+      parent_taxons = links["parent_taxons"]
 
       if !parent_taxons.nil?
         single_parent = parent_taxons.first

data/lib/govuk_taxonomy_helpers/version.rb

@@ -1,3 +1,3 @@
 module GovukTaxonomyHelpers
-  VERSION = "0.0.1".freeze
+  VERSION = "0.1.0".freeze
 end

data/spec/publishing_api_response_spec.rb

@@ -340,4 +340,66 @@ RSpec.describe GovukTaxonomyHelpers::PublishingApiResponse do
       )
     end
   end
+
+  context "minimal responses with missing links and details hashes" do
+    let(:minimal_taxon) do
+      grandchild_1 = {
+        "content_id" => "84aadc14-9bca-40d9-abb4-4f21f9792a05",
+        "base_path" => "/grandchild-1",
+        "title" => "Grandchild 1",
+      }
+
+      grandchild_2 = {
+        "content_id" => "94aadc14-9bca-40d9-abb4-4f21f9792a05",
+        "base_path" => "/grandchild-2",
+        "title" => "Grandchild 2",
+      }
+
+      child_1 = {
+        "content_id" => "74aadc14-9bca-40d9-abb4-4f21f9792a05",
+        "base_path" => "/child-1",
+        "title" => "Child 1",
+        "links" => {
+          "child_taxons" => [
+            grandchild_1,
+            grandchild_2
+          ]
+        }
+      }
+
+      content_item = {
+        "content_id" => "aaaaaa14-9bca-40d9-abb4-4f21f9792a05",
+        "base_path" => "/minimal-taxon",
+        "title" => "Minimal Taxon",
+      }
+
+      expanded_links = {
+        "content_id" => "64aadc14-9bca-40d9-abb4-4f21f9792a05",
+        "expanded_links" => {
+          "child_taxons" => [child_1],
+          "parent_taxons" => [
+            {
+              "content_id" => "ffaadc14-9bca-40d9-abb4-4f21f9792aff",
+              "title" => "Parent Taxon",
+              "base_path" => "/parent"
+            }
+          ]
+        }
+      }
+
+      GovukTaxonomyHelpers::LinkedContentItem.from_publishing_api(
+        content_item: content_item,
+        expanded_links: expanded_links
+      )
+    end
+
+    it "parses taxons with nil internal names" do
+      expect(minimal_taxon.title).to eq("Minimal Taxon")
+      expect(minimal_taxon.internal_name).to be_nil
+      expect(minimal_taxon.parent.title).to eq("Parent Taxon")
+      expect(minimal_taxon.parent.internal_name).to be_nil
+      expect(minimal_taxon.descendants.map(&:title)).to eq(["Child 1", "Grandchild 1", "Grandchild 2"])
+      expect(minimal_taxon.descendants.map(&:internal_name)).to all(be_nil)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govuk_taxonomy_helpers
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Government Digital Service
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-03-06 00:00:00.000000000 Z
+date: 2017-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler