govuk_schemas 6.1.1 → 6.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 64c90e4698b291270b8f17f181b16a974b8b96676dc843ed06c0f0468740154d
-  data.tar.gz: d0ce267bb1d49467f857669d22a3be4883cd97f745916d0aa5262eba2e7426cb
+  metadata.gz: 232c587a32f3faa5b2a96754859d3ec61226f8e26c84035e1dd3e169292a9d18
+  data.tar.gz: 7d7debcd13ffaedc2170121769717c1a0b47e0e6eda8f2d3ac55f13b074f5219
 SHA512:
-  metadata.gz: 494d096ab78a444af350cb9f96ee1544299af5b1eaf1483c5221d9645f6227446639c3b8e1610e7fba2c9a1b15e57a57438bdfb91bff4c91c3cba6eb4d723f67
-  data.tar.gz: 76c0edd74cdc2fc01966bb603077028465cad8d136165984791f99eca69af3adeba13664f5d9f49a21c2c30fad2a2c052559da1587bf69662c5486b2b1bb6bcf
+  metadata.gz: ca1478bb2431b30d4d37febb2010a9f22820b3118cf3ed40730afc48d2e28dcec85d7a18a75b18b08bdc45cb74bcb3204ddef22f21d2065ebb70fa039deae432
+  data.tar.gz: bf32b71b72196432e7a67caeeb8776435305fc2979b33f971edf176c7ca8c10d7143c6c344fd8c9e91100086735406494d17fe35a947b0842d69bdaf2452ba59

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 6.2.0
+
+* Remove Faker dependency [PR](https://github.com/alphagov/govuk_schemas/pull/172)
+
 ## 6.1.1
 
 * Add a new regex generator for a content block order item [PR](https://github.com/alphagov/govuk_schemas/pull/170)

data/README.md

@@ -22,6 +22,13 @@ Make sure you have `publishing-api` cloned in a sibling directory:
 bundle exec rake
 ```
 
+## Development
+
+In order to run the tests successfully you also need [publishing-api](https://github.com/alphagov/publishing-api) checked
+out into the same parent directory as govuk_schemas.
+
+The tests can then be run with `bundle exec rspec`.
+
 ## License
 
 The gem is available as open source under the terms of the [MIT License](LICENCE).

data/govuk_schemas.gemspec

@@ -18,7 +18,6 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = %w[lib]
 
-  spec.add_dependency "faker", ">= 3.4.1", "< 3.6.0"
   # This should be kept in sync with the json-schema version of publishing-api.
   spec.add_dependency "json-schema", ">= 2.8", "< 6.1"
 

data/lib/govuk_schemas/random_content_generator.rb

@@ -1,13 +1,11 @@
-require "faker"
-
 module GovukSchemas
   # @private
   class RandomContentGenerator
-    WORDS = %w[Lorem ipsum dolor sit amet consectetur adipiscing elit. Ut suscipit at mauris non bibendum. Ut ac massa est. Aenean tempor imperdiet leo vel interdum. Nam sagittis cursus sem ultricies scelerisque. Quisque porttitor risus vel risus finibus eu sollicitudin nisl aliquet. Sed sed lectus ac dolor molestie interdum. Nam molestie pellentesque purus ac vestibulum. Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas. Suspendisse non tempor eros. Mauris eu orci hendrerit volutpat lorem in tristique libero. Duis a nibh nibh.].freeze
+    WORDS = %w[Lorem ipsum dolor sit amet consectetur adipiscing elit Ut suscipit at mauris non bibendum Ut ac massa est Aenean tempor imperdiet leo vel interdum Nam sagittis cursus sem ultricies scelerisque Quisque porttitor risus vel risus finibus eu sollicitudin nisl aliquet Sed sed lectus ac dolor molestie interdum Nam molestie pellentesque purus ac vestibulum Pellentesque habitant morbi tristique senectus et netus et malesuada fames ac turpis egestas Suspendisse non tempor eros Mauris eu orci hendrerit volutpat lorem in tristique libero Duis a nibh nibh].freeze
+    DOMAIN_SUFFIXES = %w[co.uk com].freeze
 
     def initialize(random: Random.new)
       @random = random
-      Faker::Config.random = @random
     end
 
     def string_for_type(type)
@@ -17,7 +15,7 @@ module GovukSchemas
       when "uri"
         uri
       when "email"
-        Faker::Internet.email
+        [username, domain_name].join("@")
       else
         raise <<~DOC
            Unsupported JSON schema type `#{type}`
@@ -38,9 +36,9 @@ module GovukSchemas
       (arbitrary_time + @random.rand(0..500_000_000)).iso8601
     end
 
-    # TODO: make this more random with query string, optional anchor.
-    def uri
-      "#{Faker::Internet.url(path: base_path)}#{anchor}"
+    # TODO: make this more random with query string
+    def uri(domain_suffix: nil, include_anchor: true)
+      "https://#{domain_name(domain_suffix:)}#{base_path}#{include_anchor ? anchor : nil}"
     end
 
     def base_path
@@ -48,8 +46,7 @@ module GovukSchemas
     end
 
     def govuk_subdomain_url
-      host = Faker::Internet.domain_name(subdomain: true, domain: "gov.uk")
-      Faker::Internet.url(host:, path: base_path)
+      uri(domain_suffix: "gov.uk", include_anchor: false)
     end
 
     def string(minimum_chars = nil, maximum_chars = nil)
@@ -66,11 +63,11 @@ module GovukSchemas
       "##{hex}"
     end
 
-    def random_identifier(separator:)
+    def random_identifier(separator: "-")
       WORDS.sample(@random.rand(1..10), random: @random)
-        .join("-")
-        .gsub(/[^a-z0-9\-_]+/i, "-")
-        .gsub("-", separator)
+        .join(separator)
+        .gsub(/[^a-z0-9\-_]+/i, separator)
+        .downcase
     end
 
     def uuid
@@ -132,11 +129,22 @@ module GovukSchemas
 
   private
 
+    def username
+      WORDS.sample(random: @random).downcase
+    end
+
+    def domain_name(domain_suffix: nil)
+      [
+        WORDS.sample(random: @random).downcase,
+        domain_suffix || DOMAIN_SUFFIXES.sample(random: @random),
+      ].join(".")
+    end
+
     def content_block_order_item
       [
         %w[addresses contact_links email_addresses telephones].sample,
         ".",
-        Faker::Internet.slug(glue: "-"),
+        random_identifier,
       ].join
     end
 

data/lib/govuk_schemas/version.rb

@@ -1,4 +1,4 @@
 module GovukSchemas
   # @private
-  VERSION = "6.1.1".freeze
+  VERSION = "6.2.0".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: govuk_schemas
 version: !ruby/object:Gem::Version
-  version: 6.1.1
+  version: 6.2.0
 platform: ruby
 authors:
 - GOV.UK Dev
@@ -9,26 +9,6 @@ bindir: exe
 cert_chain: []
 date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: faker
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.4.1
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: 3.6.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.4.1
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: 3.6.0
 - !ruby/object:Gem::Dependency
   name: json-schema
   requirement: !ruby/object:Gem::Requirement