govuk_publishing_components 5.1.2 → 5.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 82107111f850c84527a2eac1c33b99019069fd5fc4a1683f7b88f0cdae8dd30f
-  data.tar.gz: f0d5265c99e46d8edec4adb3e9023cd26d08f690c2717454f497c33b7593638a
+  metadata.gz: fa48ba590fd58d68a1a54ffec60c38a87c705415c7cd6e2d60bd6847bea674b9
+  data.tar.gz: '069479f197d9edd22c46232606fb13e7c404fe8f9dabac8ca53e15bcaa24fe3b'
 SHA512:
-  metadata.gz: 12665b69dcfd60f4ed3e336aecf494cb5c0cfb425fd61e9efc512d405790e6fdddc9b66f4723418beb12cd97bf0e2b5edad6b47b6490d6697230268f44c75b60
-  data.tar.gz: 0e73ce2217730591b427993c0274cb80896eae3da8bac9f63d257421f5556a686975e970078c361c3a0b49c740f311607831a85ffc03d389bf4cf108574ebaf8
+  metadata.gz: bbda965032a7665f5e69c2a6c4df2a0fafe8021759a33971b6080f1151a577b3d33b36fd4cc6e0f45d6035bb75a925c18f250794ddd9357932f6ee1bc103bc15
+  data.tar.gz: 6bdca0f6c816436e9e279b2ac97aa4736476f64f131fac5810b67ace5823a5dad3da644b20f4d7023604e173386f7c48ee3cb62c3d63399ece43bf7399745d88

data/app/assets/javascripts/govuk_publishing_components/components/feedback.js

@@ -36,6 +36,7 @@ window.GOVUK.Modules = window.GOVUK.Modules || {};
         e.preventDefault();
         toggleForm($(e.target).attr('aria-controls'));
         setInitialAriaAttributes();
+        revealInitialPrompt();
       });
 
       this.$pageIsUsefulButton.on('click', function(e) {
@@ -113,10 +114,6 @@ window.GOVUK.Modules = window.GOVUK.Modules || {};
         }
       }
 
-      function clearMessages () {
-        $element.find('.js-errors').html('').addClass(jshiddenClass);
-      }
-
       function showError (error) {
         var error = [
           '<h2 class="gem-c-feedback__heading">',
@@ -133,10 +130,6 @@ window.GOVUK.Modules = window.GOVUK.Modules || {};
         $errors.html(error).removeClass(jshiddenClass).focus();
       }
 
-      function clearAllInputs () {
-        that.$fields.val('');
-      }
-
       function showFormSuccess () {
         that.$promptQuestions.addClass(jshiddenClass);
         that.$promptSuccessMessage.removeClass(jshiddenClass).focus();

data/app/assets/stylesheets/govuk_publishing_components/components/_feedback.scss

@@ -39,8 +39,8 @@
 
 .gem-c-feedback__prompt-question,
 .gem-c-feedback__prompt-success {
-  @include bold-16;
   display: inline;
+  font-weight: bold;
 
   &:focus {
     outline: 0;

data/app/views/govuk_publishing_components/components/_feedback.html.erb

@@ -64,7 +64,8 @@
           label: {
             text: "What were you doing?"
           },
-          name: "what_doing"
+          name: "what_doing",
+          describedby: "feedback_explanation"
         } %>
 
         <%= render "govuk_publishing_components/components/input", {
@@ -102,7 +103,8 @@
             text: "Email address"
           },
           name: "email_survey_signup[email_address]",
-          type: "email"
+          type: "email",
+          describedby: "survey_explanation"
         } %>
 
         <%# TODO: use button component once available in gem %>

data/app/views/govuk_publishing_components/components/_input.html.erb

@@ -5,6 +5,7 @@
   error_message ||= false
   label ||= {}
   type ||= "text"
+  describedby ||= false
 %>
 
 <%= render "govuk_publishing_components/components/label", {
@@ -24,6 +25,8 @@
 
   <% if error_message %>
     aria-describedby="<%= hint_id %>"
+  <% elsif describedby %>
+    aria-describedby="<%= describedby %>"
   <% end %>
 
   <% if value %>

data/app/views/govuk_publishing_components/components/docs/feedback.yml

@@ -1,5 +1,5 @@
 name: Feedback
-description: Invites user feedback on the current page
+description: Invites user feedback on the current page.
 body: |
   This component is designed to sit at the bottom of pages on GOV.UK to allow users to submit feedback on that page. It is based on the 'improve this page' component from the Service manual, but changes have been made.
 

data/app/views/govuk_publishing_components/components/docs/input.yml

@@ -1,25 +1,41 @@
 name: Form input
-description: A single-line text field.
+description: A form input field and an associated label.
 body: |
   [Forked from GOV.UK Frontend](https://govuk-frontend-review.herokuapp.com/components/input)
 accessibility_criteria: |
-  Markdown listing what this component must do to be accessible. For example:
+  Inputs in the component must:
 
-  The link must:
-
-  * be keyboard focusable
+  * accept focus
+  * be focusable with a keyboard
+  * be usable with a keyboard
+  * be usable with touch
+  * indicate when they have focus
+  * be recognisable as form input elements
+  * have correctly associated labels
+  * be of the appropriate type for their use, e.g. password inputs should be of type 'password'
 examples:
   default:
     data:
       label:
         text: "What is your name?"
       name: "name"
-  email_type:
+  specific_input_type:
+    description: By default the input will be type="text". This parameter accepts an alternative, e.g. "search" or "email". No validation is done on this input.
     data:
       label:
         text: "What is your email address?"
       name: "address"
       type: "email"
+  aria_described_by:
+    description: |
+      Allows the addition of an aria-describedby attribute. Note that this will be overridden in the event of an error, where the error will be used for the describedby attribute value.
+
+      The example below uses the ID of the skiplink container for demonstration purposes, in real use this would be passed the ID of an element that correctly described the input.
+    data:
+      label:
+        text: "This might not work"
+      name: "labelledby"
+      labelledby: "skiplink-container"
   with_error:
     data:
       label:

data/lib/govuk_publishing_components/version.rb

@@ -1,3 +1,3 @@
 module GovukPublishingComponents
-  VERSION = '5.1.2'.freeze
+  VERSION = '5.1.3'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: govuk_publishing_components
 version: !ruby/object:Gem::Version
-  version: 5.1.2
+  version: 5.1.3
 platform: ruby
 authors:
 - GOV.UK Dev