govuk_publishing_components 29.12.0 → 29.12.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3dd3c468990ad57344b60f3268db6600fc77389ec57fa53688699284bef86502
-  data.tar.gz: 2dc30bfb1f489e894134032e8d055e694b4ac45e5eb49e3055ceae8ac0f2b0b7
+  metadata.gz: 4334fdd441cbca8d9fac8dfa8fd49478fd01cd847eb29707872abf0dd8c523d1
+  data.tar.gz: fe3f84de2e16d964fb9e7567ce52e8509258f833cc291fee28f54be4c4b8bd8c
 SHA512:
-  metadata.gz: 1d147c794de4cd0cb8210584db07fe0e32a3036d68bded430d2c8d9b45a00b50f78a931d21b48be269f971099f8b054881f3b707694b4f52c3dfa7d00aef7ea2
-  data.tar.gz: 786de6478e56d31089cb7745914bc5e38e5e8e63043d2b862777a69a5622b19f7f678c2d43559e179eb1701b3222fd1f384d05530c7f403abcccf1f025a005ef
+  metadata.gz: e6776dd162047045dbad8f70cda8d7eae8cc8e66321d607f614daf49c410d29b40c8cf718c6c04c27756bfa05382a58fe70b94633a49cbce7e4bbd5934006c7f
+  data.tar.gz: d9411dfa23e431152880d95f455d42d6ac326cae14eddb0f905dcdef5a68e1b19b9affb3407e9c6052ed5f813131ec5cf68a8398d0899bcd150bb35bf0ad85aa

data/app/assets/javascripts/govuk_publishing_components/analytics/custom-dimensions.js

@@ -64,7 +64,7 @@
       'taxon-slugs': { dimension: 58, defaultValue: 'other' },
       'taxon-ids': { dimension: 59, defaultValue: 'other' },
       'content-has-history': { dimension: 39, defaultValue: 'false' },
-      'publishing-application': { dimension: 89 },
+      'publishing-app': { dimension: 89 },
       'brexit-audience': { dimension: 112 },
       'brexit-superbreadcrumb': { dimension: 111 },
       stepnavs: { dimension: 96 },

data/app/assets/javascripts/govuk_publishing_components/analytics-ga4/gtm-click-tracking.js

@@ -25,7 +25,12 @@ window.GOVUK.Modules = window.GOVUK.Modules || {};
           link_url: window.location.href.substring(window.location.origin.length),
           ui: JSON.parse(target.getAttribute('data-gtm-attributes')) || {}
         }
-        var ariaExpanded = this.getClosestAttribute(target, 'aria-expanded')
+
+        // Ensure it only tracks aria-expanded in an accordion element, instead of in any child of the clicked element
+        if (target.closest('.gem-c-accordion')) {
+          var ariaExpanded = this.getClosestAttribute(target, 'aria-expanded')
+        }
+
         /*
           the details component uses an 'open' attribute instead of aria-expanded, so we need to check if we're on a details component.
           since details deletes the 'open' attribute when closed, we need this boolean, otherwise every element which
@@ -35,11 +40,11 @@ window.GOVUK.Modules = window.GOVUK.Modules || {};
 
         if (ariaExpanded) {
           data.ui.text = data.ui.text || target.innerText
-          data.ui.state = (ariaExpanded === 'false') ? 'opened' : 'closed'
+          data.ui.action = (ariaExpanded === 'false') ? 'opened' : 'closed'
         } else if (detailsElement) {
           data.ui.text = data.ui.text || detailsElement.textContent
           var openAttribute = detailsElement.getAttribute('open')
-          data.ui.state = (openAttribute == null) ? 'opened' : 'closed'
+          data.ui.action = (openAttribute == null) ? 'opened' : 'closed'
         }
 
         window.dataLayer.push(data)

data/app/assets/javascripts/govuk_publishing_components/analytics-ga4/gtm-page-views.js

@@ -16,8 +16,8 @@
           },
           publishing: {
             document_type: this.getMetaContent('format'),
-            publishing_application: this.getMetaContent('publishing-application'),
-            rendering_application: this.getMetaContent('rendering-application'),
+            publishing_app: this.getMetaContent('publishing-app'),
+            rendering_app: this.getMetaContent('rendering-app'),
             schema_name: this.getMetaContent('schema-name'),
             content_id: this.getMetaContent('content-id')
           },

data/app/views/govuk_publishing_components/components/_date_input.html.erb

@@ -6,7 +6,7 @@
     { :name => "month", :width => 2 },
     { :name => "year", :width => 4 }
   ]
-
+  autocomplete_date_of_birth ||= nil
   legend_text ||= nil
   hint ||= nil
   error_message ||= nil
@@ -64,7 +64,7 @@
             id: item[:id],
             type: "number",
             data: item[:data],
-            autocomplete: item[:autocomplete]
+            autocomplete: autocomplete_date_of_birth ? "bday-#{item[:name]}" : nil
           } %>
         <% end %>
       <% end %>

data/app/views/govuk_publishing_components/components/docs/date_input.yml

@@ -26,6 +26,13 @@ examples:
       component as follows: `custom-name[day]`, `custom-name[month]`, `custom-name[year]`
     data:
       name: "dob"
+  with_autocomplete_for_date_of_birth_fields:
+    description: |
+      Use the `autocomplete_date_of_birth` option when you're asking for the user's date of birth. This supports browsers or tools that can autofill the information on a user's behalf if they've entered it previously.
+
+      Note that the option should only be passed to the component if the date of birth asked for is the date of birth of the person filling the form in and not asked for on behalf of someone else.
+    data:
+      autocomplete_date_of_birth: true
   with_legend:
     data:
       legend_text: "What is your date of birth?"

data/lib/govuk_publishing_components/presenters/meta_tags.rb

@@ -27,9 +27,12 @@ module GovukPublishingComponents
 
     private
 
+      # other meta tags are inserted by slimmer here:
+      # https://github.com/alphagov/slimmer/blob/82144be372aa4afc1f8ff30917c96c2ee3a47ed8/lib/slimmer/processors/metadata_inserter.rb#L15
       def add_core_tags(meta_tags)
         meta_tags["govuk:format"] = content_item[:document_type] if content_item[:document_type]
-        meta_tags["govuk:publishing-application"] = content_item[:publishing_app] if content_item[:publishing_app]
+        meta_tags["govuk:publishing-app"] = content_item[:publishing_app] if content_item[:publishing_app]
+        meta_tags["govuk:rendering-app"] = content_item[:rendering_app] if content_item[:rendering_app]
         meta_tags["govuk:schema-name"] = content_item[:schema_name] if content_item[:schema_name]
         meta_tags["govuk:content-id"] = content_item[:content_id] if content_item[:content_id]
         meta_tags["govuk:navigation-page-type"] = content_item[:navigation_page_type] if content_item[:navigation_page_type]
@@ -43,8 +46,8 @@ module GovukPublishingComponents
         meta_tags["govuk:updated-at"] = content_item[:updated_at] if content_item[:updated_at]
         meta_tags["govuk:public-updated-at"] = content_item[:public_updated_at] if content_item[:public_updated_at]
         primary_publisher = content_item.dig(:links, :primary_publishing_organisation)
-        primary_publisher = primary_publisher.first[:title] if primary_publisher
-        meta_tags["govuk:primary-publishing-organisation"] = primary_publisher if primary_publisher
+        primary_publisher = primary_publisher.first[:title] unless primary_publisher.blank?
+        meta_tags["govuk:primary-publishing-organisation"] = primary_publisher unless primary_publisher.blank?
 
         meta_tags
       end

data/lib/govuk_publishing_components/version.rb

@@ -1,3 +1,3 @@
 module GovukPublishingComponents
-  VERSION = "29.12.0".freeze
+  VERSION = "29.12.1".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govuk_publishing_components
 version: !ruby/object:Gem::Version
-  version: 29.12.0
+  version: 29.12.1
 platform: ruby
 authors:
 - GOV.UK Dev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-06-21 00:00:00.000000000 Z
+date: 2022-07-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: govuk_app_config
@@ -1919,7 +1919,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.16
+rubygems_version: 3.3.17
 signing_key: 
 specification_version: 4
 summary: A gem to document components in GOV.UK frontend applications