govuk_publishing_components 21.13.0 → 21.13.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6f789d318fa52196b8bdd6fb96916895e930b4dfaa1b4d347e790c88a1544b23
-  data.tar.gz: 024765e4eddecd938233e986488697ad2c6bdb65a2c323d994a5962e41fe1bf5
+  metadata.gz: a5bcfe7943bc46cdae4ae9c7fd8278c442c3362f799e30fe08c933c1f7ae1c69
+  data.tar.gz: 271c01108ddb33cc7eeff626006d8d46f4ee835f77860cfef1a558648d3b4a30
 SHA512:
-  metadata.gz: 4d049a4ffe5820827413c4a0e93e1026440f38505c039354f026f480bb727c7021b427fee1f5e43e1cc3381d0ce80fcc1b832a81442b6718572004c698c68a0b
-  data.tar.gz: d2557868656cf64c7f010b724672033176213f111e82a783fc690697c5f7231c3af27d61244ae8f747ccfe56d96179d008591e73aed5203af7a8aff91676ac92
+  metadata.gz: 2a0217b070c0900247e5ec24ead3549f35715ab451e009d0fd8d1c40d0d22c4949acee256e6d306590c3d8c07771da41193563bbc7b69ef095d65f43a6d10e15
+  data.tar.gz: f841658b480950ee87b0afb40fb16323dd243b430653d8b5ceceec22207883aa0887e700f035e2c4e943664c91f0455efc2c9e379e1156672a1f490eb1e306ff

data/app/assets/stylesheets/govuk_publishing_components/components/_feedback.scss

@@ -197,3 +197,9 @@
   // scss-lint:enable PlaceholderInExtend
   margin: 0;
 }
+
+.gem-c-feedback__option-list {
+  list-style-type: none;
+  margin: 0;
+  padding: 0;
+}

data/app/controllers/govuk_publishing_components/application_controller.rb

@@ -5,15 +5,17 @@ module GovukPublishingComponents
     before_action :set_x_frame_options_header
     before_action :set_disable_slimmer_header
 
-    content_security_policy do |p|
-      # don't do anything if the app doesn't have a content security policy
-      next unless p.directives.any?
+    if defined? content_security_policy
+      content_security_policy do |p|
+        # don't do anything if the app doesn't have a content security policy
+        next unless p.directives.any?
 
-      # Unfortunately the axe core script uses a dependency that uses eval
-      # see: https://github.com/dequelabs/axe-core/issues/1175
-      # Thus all components shown by govuk_publishing_components need this
-      # enabled
-      p.script_src(*p.script_src, :unsafe_eval)
+        # Unfortunately the axe core script uses a dependency that uses eval
+        # see: https://github.com/dequelabs/axe-core/issues/1175
+        # Thus all components shown by govuk_publishing_components need this
+        # enabled
+        p.script_src(*p.script_src, :unsafe_eval)
+      end
     end
 
   private

data/app/views/govuk_publishing_components/components/docs/accordion.yml

@@ -215,7 +215,7 @@ examples:
   different_heading_level:
     description: This will alter the level of the heading, not the appearance of the heading.
     data:
-      heading_level: 5
+      heading_level: 3
       items:
         - heading:
             text: "Writing well for the web"

data/app/views/govuk_publishing_components/components/docs/breadcrumbs.yml

@@ -8,6 +8,8 @@ shared_accessibility_criteria:
 accessibility_criteria:
   The breadcrumb links must have a text contrast ratio higher than 4.5:1 against the background colour to meet WCAG AA
   (this especially applies when [using the inverse flag](/component-guide/breadcrumbs/inverse)).
+accessibility_excluded_rules:
+  - skip-link # This component is creating a reference to #content which is part of the layout
 display_html: true
 examples:
   default:

data/app/views/govuk_publishing_components/components/docs/contents_list.yml

@@ -24,6 +24,8 @@ accessibility_criteria: |
   Links with formatted numbers must separate the number and text with a space for correct screen reader pronunciation. This changes pronunciation from "1 dot Item" to "1 Item".
 shared_accessibility_criteria:
   - link
+accessibility_excluded_rules:
+  - skip-link # The examples for this component are using references to sections on the page that do not exist in examples
 examples:
   default:
     data:

data/app/views/govuk_publishing_components/components/docs/contextual_sidebar.yml

@@ -57,31 +57,29 @@ examples:
         title: "A content item"
         links:
           part_of_step_navs:
-            - title: "Choosing a micropig or micropug: step by step"
+            - title: "Learn to drive a car: step by step"
               base_path: "/micropigs-vs-micropugs"
               details:
                 step_by_step_nav:
                   title: 'Stay in the UK after it leaves the EU (''settled status''): step by step'
                   steps:
-                  - title: Check if you need to apply to the EU Settlement Scheme
+                  - title: Check you're allowed to drive
                     contents:
                     - type: paragraph
-                      text: 'You may need to apply to the EU Settlement Scheme to continue living
-                        in the UK. '
+                      text: Most people can start learning to drive when they’re 17.
                     - type: list
                       contents:
-                      - text: Check if you need to apply
-                        href: "/settled-status-eu-citizens-families/eligibility"
+                      - text: Check what age you can drive
+                        href: "/vehicles-can-drive"
                     optional: false
-                  - title: Find out what status you’ll get
+                  - title: Driving lessons and practice
                     contents:
                     - type: paragraph
-                      text: You’ll get settled or pre-settled status depending on how long you’ve
-                        been living in the UK. This might affect when you choose to apply.
+                      text: You need a provisional driving licence to take lessons or practice.
                     - type: list
                       contents:
-                      - text: Find out what you’ll get
-                        href: "/settled-status-eu-citizens-families/what-settled-and-presettled-status-means"
+                      - text: The Highway Code
+                        href: "/guidance/the-highway-code"
                     optional: false
   with_brexit_cta_and_related_links:
     data:

data/app/views/govuk_publishing_components/components/docs/error_summary.yml

@@ -5,6 +5,8 @@ accessibility_criteria: |
   - list of errors should be clickable and focus the inputs with errors
 shared_accessibility_criteria:
   - link
+accessibility_excluded_rules:
+  - skip-link # This component is creating references to to sections on the page that do not exist in examples
 examples:
   default:
     data:

data/app/views/govuk_publishing_components/components/docs/govspeak.yml

@@ -17,6 +17,8 @@ accessibility_criteria: |
   - text should have a text contrast ratio higher than 4.5:1 against the background colour to meet WCAG AA
 shared_accessibility_criteria:
   - link
+accessibility_excluded_rules:
+  - landmark-complementary-is-top-level # Statistic headlines are generating an aside element which can not be a top level in the examples
 examples:
   basic_content:
     data:

data/app/views/govuk_publishing_components/components/docs/inverse_header.yml

@@ -9,6 +9,8 @@ accessibility_criteria: |
   * be used in conjunction with content that renders a text contrast ratio higher than 4.5:1
   against the header colour to meet WCAG AA.
 
+accessibility_excluded_rules:
+  - skip-link # Examples of this component contain breadcrumbs, creating a reference to #content which is part of the layout
 examples:
   default:
     data:

data/app/views/govuk_publishing_components/components/docs/layout_footer.yml

@@ -36,6 +36,8 @@ accessibility_criteria: |
     Assumption made is that is most predictable for users of assistive technologies.
     The spec indicates that `contentinfo` is useful for "Examples of information included in this region of the page are copyrights and links to privacy statements.", which may indicate that it might be better placed around the 'meta' section of this component.
     Should be challenged if user research indicates this is an issue.
+accessibility_excluded_rules:
+  - landmark-contentinfo-is-top-level # The footer element can not be top level in the examples
 examples:
   default:
     data: {}

data/app/views/govuk_publishing_components/components/docs/layout_header.yml

@@ -5,6 +5,8 @@ body: |
   staging or production).
 govuk_frontend_components:
   - header
+accessibility_excluded_rules:
+  - landmark-banner-is-top-level # The header element can not be top level in the examples
 examples:
   default:
     data:
@@ -27,12 +29,12 @@ examples:
       environment: production
       navigation_items:
       - text: Navigation item 1
-        href: "#1"
+        href: "item-1"
         active: true
       - text: Navigation item 2
-        href: "#2"
+        href: "item-2"
       - text: Hidden on desktop
-        href: "#3"
+        href: "item-3"
         show_only_in_collapsed_menu: true
   full_width:
     description: |

data/app/views/govuk_publishing_components/components/docs/metadata.yml

@@ -9,6 +9,8 @@ accessibility_criteria: |
 
 shared_accessibility_criteria:
   - link
+accessibility_excluded_rules:
+  - skip-link # This component is creating a reference to sections of the page that are not part of the examples.
 examples:
   from_only:
     data:

data/app/views/govuk_publishing_components/components/docs/radio.yml

@@ -31,8 +31,7 @@ accessibility_criteria: |
   - Left Arrow and Up Arrow: move focus to the previous radio button in the group, uncheck the previously focused button, and check the newly focused button. If focus is on the first button, focus moves to the last button.
 
 accessibility_excluded_rules:
-- radiogroup # Since this is in isolation we don't want to wrap a fieldset here.
-- aria-expanded # We use aria expanded to reflect the state of a conditionally revealed radio content even if this attribute is not officially supported on this element.
+  - aria-expanded # We use aria expanded to reflect the state of a conditionally revealed radio content even if this attribute is not officially supported on this element.
 govuk_frontend_components:
   - radios
 examples:

data/app/views/govuk_publishing_components/components/docs/skip_link.yml

@@ -9,6 +9,8 @@ accessibility_criteria: |
   - indicate when they have focus
   - becomes visible when pressing tab
   - is the first items that screen readers hear and that keyboard users tab to
+accessibility_excluded_rules:
+  - skip-link # This component is creating a reference to #content which is part of the layout
 examples:
   default:
     data:

data/app/views/govuk_publishing_components/components/feedback/_yes_no_banner.html.erb

@@ -5,59 +5,63 @@
 <div class="gem-c-feedback__prompt gem-c-feedback__js-show js-prompt" tabindex="-1">
   <div class="gem-c-feedback__js-prompt-questions js-prompt-questions">
     <h2 class="gem-c-feedback__prompt-question">Is this page useful?</h2>
-
-    <%= link_to contact_govuk_path, {
-      class: 'gem-c-feedback__prompt-link',
-      data: {
-        'track-category' => 'yesNoFeedbackForm',
-        'track-action' => 'ffMaybeClick'
-      },
-      'aria-expanded': false,
-      role: 'button',
-      style: 'display: none;',
-      hidden: 'hidden',
-      'aria-hidden': 'true',
-    } do %>
-      Maybe
-    <% end %>
-
-    <%= link_to contact_govuk_path, {
-      class: 'gem-c-feedback__prompt-link gem-c-feedback__prompt-link--useful js-page-is-useful',
-      data: {
-        'track-category' => 'yesNoFeedbackForm',
-        'track-action' => 'ffYesClick'
-      },
-      'aria-expanded': false,
-      role: 'button',
-    } do %>
-      Yes <span class="visually-hidden">this page is useful</span>
-    <% end %>
-
-    <%= link_to contact_govuk_path, {
-      class: 'gem-c-feedback__prompt-link js-toggle-form js-page-is-not-useful',
-      data: {
-        'track-category' => 'yesNoFeedbackForm',
-        'track-action' => 'ffNoClick'
-      },
-      'aria-controls': 'page-is-not-useful',
-      'aria-expanded': false,
-      role: 'button',
-    } do %>
-      No <span class="visually-hidden">this page is not useful</span>
-    <% end %>
-
     <%= link_to contact_govuk_path, {
-      class: 'gem-c-feedback__prompt-link gem-c-feedback__prompt-link--wrong js-toggle-form js-something-is-wrong',
-      data: {
-        'track-category' => 'Onsite Feedback',
-        'track-action' => 'GOV.UK Open Form'
-      },
-      'aria-controls': 'something-is-wrong',
-      'aria-expanded': false,
-      role: 'button',
-    } do %>
-      Is there anything wrong with this page?
+        class: 'gem-c-feedback__prompt-link',
+        data: {
+          'track-category' => 'yesNoFeedbackForm',
+          'track-action' => 'ffMaybeClick'
+        },
+        'aria-expanded': false,
+        role: 'button',
+        style: 'display: none;',
+        hidden: 'hidden',
+        'aria-hidden': 'true',
+      } do %>
+        Maybe
     <% end %>
+    <ul class="gem-c-feedback__option-list">
+      <li class="gem-c-feedback__option-list-item">
+        <%= link_to contact_govuk_path, {
+          class: 'gem-c-feedback__prompt-link gem-c-feedback__prompt-link--useful js-page-is-useful',
+          data: {
+            'track-category' => 'yesNoFeedbackForm',
+            'track-action' => 'ffYesClick'
+          },
+          'aria-expanded': false,
+          role: 'button',
+        } do %>
+          Yes <span class="visually-hidden">this page is useful</span>
+        <% end %>
+      </li>
+      <li class="gem-c-feedback__option-list-item">
+        <%= link_to contact_govuk_path, {
+          class: 'gem-c-feedback__prompt-link js-toggle-form js-page-is-not-useful',
+          data: {
+            'track-category' => 'yesNoFeedbackForm',
+            'track-action' => 'ffNoClick'
+          },
+          'aria-controls': 'page-is-not-useful',
+          'aria-expanded': false,
+          role: 'button',
+        } do %>
+          No <span class="visually-hidden">this page is not useful</span>
+        <% end %>
+      </li>
+      <li class="gem-c-feedback__option-list-item">
+        <%= link_to contact_govuk_path, {
+          class: 'gem-c-feedback__prompt-link gem-c-feedback__prompt-link--wrong js-toggle-form js-something-is-wrong',
+          data: {
+            'track-category' => 'Onsite Feedback',
+            'track-action' => 'GOV.UK Open Form'
+          },
+          'aria-controls': 'something-is-wrong',
+          'aria-expanded': false,
+          role: 'button',
+        } do %>
+          Is there anything wrong with this page?
+        <% end %>
+      </li>
+    </ul>
   </div>
 
   <div class="gem-c-feedback__prompt-success js-prompt-success js-hidden" tabindex="-1">

data/lib/govuk_publishing_components/version.rb

@@ -1,3 +1,3 @@
 module GovukPublishingComponents
-  VERSION = '21.13.0'.freeze
+  VERSION = '21.13.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govuk_publishing_components
 version: !ruby/object:Gem::Version
-  version: 21.13.0
+  version: 21.13.1
 platform: ruby
 authors:
 - GOV.UK Dev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-11-20 00:00:00.000000000 Z
+date: 2019-11-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gds-api-adapters