govuk_frontend_toolkit 4.7.0 → 4.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: eaa5f7117e30f5312a36798eb20156bfe780d2a9
-  data.tar.gz: 1325ad166e0234a847bde510e26f8f0eb69fc774
+  metadata.gz: 1bf84ca5f409edb14c30de9f164e2a882020cfe6
+  data.tar.gz: e5bb03235b7a6cd7a694094e99e8f1abf61ec2ad
 SHA512:
-  metadata.gz: d46e13e3da38fe2c8a70d0ff7bf14a0c3e8b8933a8652a1165a0deb0b3fe8d20a0279f8f93afc31d6beec86e0fc06a998aff298d8109e52b0e96f2cb2c3e95cd
-  data.tar.gz: 1aaa3cd5fafc3450c5ac8f6425822e8faf7798168458fb0b6019ea0f034841afe9309f023ac02671ec89de7a06342509add753ec36110587d62ac237b93d0bad
+  metadata.gz: e529cdabcb19a17969515e8e259b61ff061987c1bfe7c30f8b68212bd563a5b44cd13f278828f656aa01fbf1a5d6f8ba5933c25c1cf2bb2abd6329c2c0d07bc7
+  data.tar.gz: 374dd5938b13d38ca5ca6fbab70ed02818f9754062e2ff9d4f56712f4414face85a355e0db1df625d3c14696f89b739eff8d296aa56527f956d017d6cc7e9cfd

data/app/assets/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 4.8.0
+
+- Pass cohort name to analytics when using multivariate test (PR #251)
+
 # 4.7.0
 
 - Add 'mailto' tracking to GOV.UK Analytics (PR #244)

data/app/assets/VERSION.txt

@@ -1 +1 @@
-4.7.0
+4.8.0

data/app/assets/docs/javascript.md

@@ -248,7 +248,7 @@ var test = new GOVUK.MultivariateTest({
 });
 ```
 
-`customDimensionIndex` is the index of the custom variable in Google Analytics. GA only gives 50 integer slots to each account, and it is important that a unique integer is assigned to each test. Current contact for assigning a custom var slot for GOV.UK is: Ashraf Chohan <ashraf.chohan@digital.cabinet-office.gov.uk>
+`customDimensionIndex` is the index of the custom variable in Google Analytics. GA only gives 50 integer slots to each account, and it is important that a unique integer is assigned to each test. Current contact for assigning a custom var slot for GOV.UK is: Tim Leighton-Boyce <tim.leighton-boyce@digital.cabinet-office.gov.uk>
 
 ## Primary Links
 

data/app/assets/javascripts/govuk/multivariate-test.js

@@ -77,9 +77,7 @@
     if (this.customDimensionIndex) {
       GOVUK.analytics.setDimension(
         this.customDimensionIndex,
-        this.cookieName(),
-        cohort,
-        2 // session level
+        this.cookieName() + "__" + cohort
       );
     }
   };

data/app/assets/spec/unit/multivariate-test.spec.js

@@ -47,7 +47,7 @@ describe("MultivariateTest", function() {
       expect(fooSpy).toHaveBeenCalled();
     });
 
-    it("should set a custom var if one is defined", function() {
+    it("should set a custom var with the name and cohort if one is defined", function() {
       GOVUK.cookie.and.returnValue('foo');
       var test = new GOVUK.MultivariateTest({
         name: 'stuff',
@@ -59,10 +59,19 @@ describe("MultivariateTest", function() {
       });
       expect(GOVUK.analytics.setDimension).toHaveBeenCalledWith(
         2,
-        'multivariatetest_cohort_stuff',
-        'foo',
-        2
+        'multivariatetest_cohort_stuff__foo'
       );
+    });
+
+    it("should trigger an event to track that the test has been run", function() {
+      GOVUK.cookie.and.returnValue('foo');
+      var test = new GOVUK.MultivariateTest({
+        name: 'stuff',
+        cohorts: {
+          foo: {},
+          bar: {}
+        },
+      });
       expect(GOVUK.analytics.trackEvent).toHaveBeenCalledWith(
         'multivariatetest_cohort_stuff',
         'run',

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: govuk_frontend_toolkit
 version: !ruby/object:Gem::Version
-  version: 4.7.0
+  version: 4.8.0
 platform: ruby
 authors:
 - Bradley Wright
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-04 00:00:00.000000000 Z
+date: 2016-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails